* [PATCH v2] cxgb3: remove VLA usage
@ 2018-03-07 18:03 Gustavo A. R. Silva
2018-03-07 20:56 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-03-07 18:03 UTC (permalink / raw)
To: David Miller, Santosh Raspatur; +Cc: netdev, linux-kernel, Gustavo A. R. Silva
Remove VLA usage and change the 'len' argument to a u8 and use a 256
byte buffer on the stack. Notice that these lengths are limited by the
encoding field in the VPD structure, which is a u8 [1].
[1] https://marc.info/?l=linux-netdev&m=152044354814024&w=2
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
Changes in v2:
- Update the code as suggested by David Miller.
- Update changelog based on David's comments.
- Update subject.
drivers/net/ethernet/chelsio/cxgb3/t3_hw.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c b/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c
index a89721f..080918a 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c
+++ b/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c
@@ -681,18 +681,18 @@ int t3_seeprom_wp(struct adapter *adapter, int enable)
return t3_seeprom_write(adapter, EEPROM_STAT_ADDR, enable ? 0xc : 0);
}
-static int vpdstrtouint(char *s, int len, unsigned int base, unsigned int *val)
+static int vpdstrtouint(char *s, u8 len, unsigned int base, unsigned int *val)
{
- char tok[len + 1];
+ char tok[256];
memcpy(tok, s, len);
tok[len] = 0;
return kstrtouint(strim(tok), base, val);
}
-static int vpdstrtou16(char *s, int len, unsigned int base, u16 *val)
+static int vpdstrtou16(char *s, u8 len, unsigned int base, u16 *val)
{
- char tok[len + 1];
+ char tok[256];
memcpy(tok, s, len);
tok[len] = 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] cxgb3: remove VLA usage
2018-03-07 18:03 [PATCH v2] cxgb3: remove VLA usage Gustavo A. R. Silva
@ 2018-03-07 20:56 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-03-07 20:56 UTC (permalink / raw)
To: gustavo; +Cc: santosh, netdev, linux-kernel, garsilva
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Wed, 7 Mar 2018 12:03:33 -0600
> Remove VLA usage and change the 'len' argument to a u8 and use a 256
> byte buffer on the stack. Notice that these lengths are limited by the
> encoding field in the VPD structure, which is a u8 [1].
>
> [1] https://marc.info/?l=linux-netdev&m=152044354814024&w=2
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> Changes in v2:
> - Update the code as suggested by David Miller.
> - Update changelog based on David's comments.
> - Update subject.
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-07 20:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-07 18:03 [PATCH v2] cxgb3: remove VLA usage Gustavo A. R. Silva
2018-03-07 20:56 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.