From: Jonathan Cameron <jic23@kernel.org> To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> Cc: devel@driverdev.osuosl.org, Lars-Peter Clausen <lars@metafoo.de>, linux-iio@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Hartmut Knaack <knaack.h@gmx.de>, daniel.baluta@nxp.com Subject: Re: [PATCH v2 2/3] staging:iio:meter: Remove unused macro IIO_DEV_ATTR_CH_OFF Date: Wed, 7 Mar 2018 20:09:32 +0000 [thread overview] Message-ID: <20180307200932.040bf33b@archlinux> (raw) In-Reply-To: <d22093b4c22f6df9c6efc2e7f711417726719fee.1520382753.git.rodrigosiqueiramelo@gmail.com> On Tue, 6 Mar 2018 21:44:07 -0300 Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> wrote: > This patch removes the macro IIO_DEV_ATTR_CH_OFF. The macro > IIO_DEV_ATTR_CH_OFF is not required, due to the replace of it by the > direct use of IIO_DEVICE_ATTR in files staging/iio/meter/ade7759.c and > staging/iio/meter/ade7753.c. > > Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> Doh! I should have read to the next patch. Personally I wouldn't have split this in to, but it is a small thing so doesn't matter. Applied to the togreg branch of iio.git (having reverted my tweak to the previous patch) and pushed out as testing. Thanks, Jonathan > --- > drivers/staging/iio/meter/meter.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/iio/meter/meter.h b/drivers/staging/iio/meter/meter.h > index edf26302fa57..5ed59bf30a25 100644 > --- a/drivers/staging/iio/meter/meter.h > +++ b/drivers/staging/iio/meter/meter.h > @@ -348,9 +348,6 @@ > #define IIO_DEV_ATTR_VPERIOD(_mode, _show, _store, _addr) \ > IIO_DEVICE_ATTR(vperiod, _mode, _show, _store, _addr) > > -#define IIO_DEV_ATTR_CH_OFF(_num, _mode, _show, _store, _addr) \ > - IIO_DEVICE_ATTR(choff_##_num, _mode, _show, _store, _addr) > - > /* active energy register, AENERGY, is more than half full */ > #define IIO_EVENT_ATTR_AENERGY_HALF_FULL(_evlist, _show, _store, _mask) \ > IIO_EVENT_ATTR_SH(aenergy_half_full, _evlist, _show, _store, _mask) _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> Cc: Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, daniel.baluta@nxp.com, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] staging:iio:meter: Remove unused macro IIO_DEV_ATTR_CH_OFF Date: Wed, 7 Mar 2018 20:09:32 +0000 [thread overview] Message-ID: <20180307200932.040bf33b@archlinux> (raw) In-Reply-To: <d22093b4c22f6df9c6efc2e7f711417726719fee.1520382753.git.rodrigosiqueiramelo@gmail.com> On Tue, 6 Mar 2018 21:44:07 -0300 Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> wrote: > This patch removes the macro IIO_DEV_ATTR_CH_OFF. The macro > IIO_DEV_ATTR_CH_OFF is not required, due to the replace of it by the > direct use of IIO_DEVICE_ATTR in files staging/iio/meter/ade7759.c and > staging/iio/meter/ade7753.c. > > Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> Doh! I should have read to the next patch. Personally I wouldn't have split this in to, but it is a small thing so doesn't matter. Applied to the togreg branch of iio.git (having reverted my tweak to the previous patch) and pushed out as testing. Thanks, Jonathan > --- > drivers/staging/iio/meter/meter.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/iio/meter/meter.h b/drivers/staging/iio/meter/meter.h > index edf26302fa57..5ed59bf30a25 100644 > --- a/drivers/staging/iio/meter/meter.h > +++ b/drivers/staging/iio/meter/meter.h > @@ -348,9 +348,6 @@ > #define IIO_DEV_ATTR_VPERIOD(_mode, _show, _store, _addr) \ > IIO_DEVICE_ATTR(vperiod, _mode, _show, _store, _addr) > > -#define IIO_DEV_ATTR_CH_OFF(_num, _mode, _show, _store, _addr) \ > - IIO_DEVICE_ATTR(choff_##_num, _mode, _show, _store, _addr) > - > /* active energy register, AENERGY, is more than half full */ > #define IIO_EVENT_ATTR_AENERGY_HALF_FULL(_evlist, _show, _store, _mask) \ > IIO_EVENT_ATTR_SH(aenergy_half_full, _evlist, _show, _store, _mask)
next prev parent reply other threads:[~2018-03-07 20:09 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-07 0:43 [PATCH v2 0/3] staging:iio:meter: Checkpatch cleanup for meter Rodrigo Siqueira 2018-03-07 0:43 ` Rodrigo Siqueira 2018-03-07 0:43 ` [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR Rodrigo Siqueira 2018-03-07 0:43 ` Rodrigo Siqueira 2018-03-07 20:07 ` Jonathan Cameron 2018-03-07 20:07 ` Jonathan Cameron 2018-03-09 0:37 ` Rodrigo Siqueira 2018-03-09 0:37 ` Rodrigo Siqueira 2018-03-10 15:10 ` Jonathan Cameron 2018-03-15 6:10 ` John Syne 2018-03-15 6:12 ` John Syne 2018-03-15 6:12 ` John Syne 2018-03-17 20:30 ` Jonathan Cameron 2018-03-17 20:30 ` Jonathan Cameron 2018-03-18 6:11 ` John Syne 2018-03-18 6:11 ` John Syne 2018-03-18 12:23 ` meter ABI: (was Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR) Jonathan Cameron 2018-03-20 5:57 ` John Syne 2018-03-20 5:57 ` John Syne 2018-03-24 15:02 ` Jonathan Cameron 2018-03-24 15:02 ` Jonathan Cameron 2018-03-24 22:45 ` John Syne 2018-03-24 22:45 ` John Syne 2018-03-25 16:29 ` Jonathan Cameron 2018-03-25 16:29 ` Jonathan Cameron 2018-03-25 20:36 ` John Syne 2018-03-25 20:36 ` John Syne 2018-03-30 9:13 ` Jonathan Cameron 2018-03-30 9:13 ` Jonathan Cameron 2018-03-20 6:28 ` John Syne 2018-03-20 6:28 ` John Syne 2018-03-24 15:18 ` Jonathan Cameron 2018-03-24 15:18 ` Jonathan Cameron 2018-03-24 23:06 ` John Syne 2018-03-25 16:44 ` Jonathan Cameron 2018-03-25 16:44 ` Jonathan Cameron 2018-03-25 20:43 ` John Syne 2018-03-25 20:44 ` John Syne 2018-03-25 20:44 ` John Syne 2018-03-24 23:18 ` John Syne 2018-03-25 7:10 ` John Syne 2018-03-25 7:10 ` John Syne 2018-03-25 7:13 ` John Syne 2018-03-25 7:13 ` John Syne 2018-03-25 8:26 ` John Syne 2018-03-25 8:29 ` John Syne 2018-03-25 8:29 ` John Syne 2018-03-25 16:54 ` Jonathan Cameron 2018-03-25 16:54 ` Jonathan Cameron 2018-03-25 20:53 ` John Syne 2018-03-25 20:53 ` John Syne 2018-03-30 9:16 ` Jonathan Cameron 2018-03-07 0:44 ` [PATCH v2 2/3] staging:iio:meter: Remove unused macro IIO_DEV_ATTR_CH_OFF Rodrigo Siqueira 2018-03-07 0:44 ` Rodrigo Siqueira 2018-03-07 20:09 ` Jonathan Cameron [this message] 2018-03-07 20:09 ` Jonathan Cameron 2018-03-07 0:44 ` [PATCH v2 3/3] staging:iio:meter: Aligns open parenthesis Rodrigo Siqueira 2018-03-07 0:44 ` Rodrigo Siqueira 2018-03-07 20:12 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180307200932.040bf33b@archlinux \ --to=jic23@kernel.org \ --cc=daniel.baluta@nxp.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmeerw@pmeerw.net \ --cc=rodrigosiqueiramelo@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.