All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] Fix up HFP memory dialling documentation
@ 2018-03-07 21:18 Philippe De Swert
  2018-03-07 21:18 ` [PATCH 1/1] doc: Fix documentation for HFP memory dialling Philippe De Swert
  0 siblings, 1 reply; 3+ messages in thread
From: Philippe De Swert @ 2018-03-07 21:18 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

Hi,

I noticed that unfortunately a small error crept into the documentation as I
forgot to update it to the lastest changes. Thus here is a patch to fix the 
issue.

Regards,

Philippe

Philippe De Swert (1):
  doc: Fix documentation for HFP memory dialling

 doc/voicecallmanager-api.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.11.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] doc: Fix documentation for HFP memory dialling
  2018-03-07 21:18 [PATCH 0/1] Fix up HFP memory dialling documentation Philippe De Swert
@ 2018-03-07 21:18 ` Philippe De Swert
  2018-03-07 21:20   ` Marcel Holtmann
  0 siblings, 1 reply; 3+ messages in thread
From: Philippe De Swert @ 2018-03-07 21:18 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

Signed-off-by: Philippe De Swert <philippedeswert@gmail.com>
---
 doc/voicecallmanager-api.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/voicecallmanager-api.txt b/doc/voicecallmanager-api.txt
index 5c4ce11b..96492ced 100644
--- a/doc/voicecallmanager-api.txt
+++ b/doc/voicecallmanager-api.txt
@@ -69,10 +69,10 @@ Methods		dict GetProperties()
 					 [service].Error.NotImplemented
 					 [service].Error.Failed
 
-		object DialMemory(string memory position, string hide_callerid)
+		object DialMemory(unsigned int memory position)
 
 			Initiates a new outgoing call to the number in the given memory
-			position/favourite. For callerid see the Dial method.
+			position/favourite.
 
 			Possible Errors: [service].Error.InProgress
 					 [service].Error.InvalidArguments
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] doc: Fix documentation for HFP memory dialling
  2018-03-07 21:18 ` [PATCH 1/1] doc: Fix documentation for HFP memory dialling Philippe De Swert
@ 2018-03-07 21:20   ` Marcel Holtmann
  0 siblings, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2018-03-07 21:20 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 718 bytes --]

Hi Philippe,

> Signed-off-by: Philippe De Swert <philippedeswert@gmail.com>

No signed-off-by please.

> ---
> doc/voicecallmanager-api.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/voicecallmanager-api.txt b/doc/voicecallmanager-api.txt
> index 5c4ce11b..96492ced 100644
> --- a/doc/voicecallmanager-api.txt
> +++ b/doc/voicecallmanager-api.txt
> @@ -69,10 +69,10 @@ Methods		dict GetProperties()
> 					 [service].Error.NotImplemented
> 					 [service].Error.Failed
> 
> -		object DialMemory(string memory position, string hide_callerid)
> +		object DialMemory(unsigned int memory position)

And there is no unsigned int in D-Bus.

Regards

Marcel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-07 21:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-07 21:18 [PATCH 0/1] Fix up HFP memory dialling documentation Philippe De Swert
2018-03-07 21:18 ` [PATCH 1/1] doc: Fix documentation for HFP memory dialling Philippe De Swert
2018-03-07 21:20   ` Marcel Holtmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.