All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/cnl: Add Wa_2201832410
@ 2018-03-06  1:08 Rodrigo Vivi
  2018-03-06  1:36 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 16+ messages in thread
From: Rodrigo Vivi @ 2018-03-06  1:08 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

"Clock gating bug in GWL may not clear barrier state when an EOT
is received, causing a hang the next time that barrier is used."

HSDES: 2201832410

Cc: Rafael Antognolli <rafael.antognolli@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h | 3 +++
 drivers/gpu/drm/i915/intel_pm.c | 5 +++++
 2 files changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index a060726fed7e..42baf90edb6f 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -3953,6 +3953,9 @@ enum {
 #define  SARBUNIT_CLKGATE_DIS		(1 << 5)
 #define  RCCUNIT_CLKGATE_DIS		(1 << 7)
 
+#define SUBSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9524)
+#define  GWUNIT_CLKGATE_DIS		(1 << 16)
+
 #define UNSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9434)
 #define  VFUNIT_CLKGATE_DIS		(1 << 20)
 
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 3e60279f18b1..be01012bb65f 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -8522,6 +8522,11 @@ static void cnl_init_clock_gating(struct drm_i915_private *dev_priv)
 		val |= SARBUNIT_CLKGATE_DIS;
 	I915_WRITE(SLICE_UNIT_LEVEL_CLKGATE, val);
 
+	/* Wa_2201832410:cnl */
+	val = I915_READ(SUBSLICE_UNIT_LEVEL_CLKGATE);
+	val |= GWUNIT_CLKGATE_DIS;
+	I915_WRITE(SUBSLICE_UNIT_LEVEL_CLKGATE, val);
+
 	/* WaDisableVFclkgate:cnl */
 	val = I915_READ(UNSLICE_UNIT_LEVEL_CLKGATE);
 	val |= VFUNIT_CLKGATE_DIS;
-- 
2.13.6

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/cnl: Add Wa_2201832410
  2018-03-06  1:08 [PATCH] drm/i915/cnl: Add Wa_2201832410 Rodrigo Vivi
@ 2018-03-06  1:36 ` Patchwork
  2018-03-06  7:26 ` ✗ Fi.CI.IGT: warning " Patchwork
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2018-03-06  1:36 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/cnl: Add Wa_2201832410
URL   : https://patchwork.freedesktop.org/series/39408/
State : success

== Summary ==

Series 39408v1 drm/i915/cnl: Add Wa_2201832410
https://patchwork.freedesktop.org/api/1.0/series/39408/revisions/1/mbox/

---- Known issues:

Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                fail       -> PASS       (fi-gdg-551) fdo#102575
Test kms_chamelium:
        Subgroup dp-edid-read:
                fail       -> PASS       (fi-kbl-7500u) fdo#102505

fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#102505 https://bugs.freedesktop.org/show_bug.cgi?id=102505

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:422s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:425s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:371s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:495s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:277s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:492s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:493s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:479s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:470s
fi-cfl-8700k     total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:404s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:571s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:414s
fi-gdg-551       total:288  pass:180  dwarn:0   dfail:0   fail:0   skip:108 time:288s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:516s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:396s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:408s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:464s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:423s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:465s
fi-kbl-7560u     total:108  pass:104  dwarn:0   dfail:0   fail:0   skip:3  
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:455s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:507s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:584s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:437s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:521s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:529s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:498s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:487s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:421s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:429s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:513s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:391s

e0164934bc08a991c3c2d2e3671a9e3e46b8448e drm-tip: 2018y-03m-05d-23h-48m-01s UTC integration manifest
7393f94a4776 drm/i915/cnl: Add Wa_2201832410

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8237/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* ✗ Fi.CI.IGT: warning for drm/i915/cnl: Add Wa_2201832410
  2018-03-06  1:08 [PATCH] drm/i915/cnl: Add Wa_2201832410 Rodrigo Vivi
  2018-03-06  1:36 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-03-06  7:26 ` Patchwork
  2018-03-06 22:53 ` ✓ Fi.CI.BAT: success " Patchwork
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2018-03-06  7:26 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/cnl: Add Wa_2201832410
URL   : https://patchwork.freedesktop.org/series/39408/
State : warning

== Summary ==

---- Possible new issues:

Test kms_chv_cursor_fail:
        Subgroup pipe-a-64x64-right-edge:
                dmesg-warn -> PASS       (shard-hsw)
Test kms_rotation_crc:
        Subgroup bad-pixel-format:
                pass       -> DMESG-WARN (shard-apl)

---- Known issues:

Test kms_chv_cursor_fail:
        Subgroup pipe-b-64x64-left-edge:
                pass       -> DMESG-WARN (shard-snb) fdo#105185 +1
Test kms_cursor_legacy:
        Subgroup 2x-long-flip-vs-cursor-atomic:
                fail       -> PASS       (shard-hsw) fdo#104873
Test kms_flip:
        Subgroup 2x-modeset-vs-vblank-race:
                fail       -> PASS       (shard-hsw) fdo#103060 +2
Test kms_setmode:
        Subgroup basic:
                pass       -> FAIL       (shard-hsw) fdo#99912
Test kms_sysfs_edid_timing:
                pass       -> WARN       (shard-apl) fdo#100047

fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#104873 https://bugs.freedesktop.org/show_bug.cgi?id=104873
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047

shard-apl        total:3468 pass:1825 dwarn:2   dfail:0   fail:7   skip:1633 time:12286s
shard-hsw        total:3468 pass:1773 dwarn:1   dfail:0   fail:2   skip:1691 time:11890s
shard-snb        total:3468 pass:1362 dwarn:3   dfail:0   fail:2   skip:2101 time:7068s
Blacklisted hosts:
shard-kbl        total:3390 pass:1908 dwarn:1   dfail:0   fail:6   skip:1474 time:9094s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8237/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/cnl: Add Wa_2201832410
  2018-03-06  1:08 [PATCH] drm/i915/cnl: Add Wa_2201832410 Rodrigo Vivi
  2018-03-06  1:36 ` ✓ Fi.CI.BAT: success for " Patchwork
  2018-03-06  7:26 ` ✗ Fi.CI.IGT: warning " Patchwork
@ 2018-03-06 22:53 ` Patchwork
  2018-03-07  3:36 ` ✗ Fi.CI.IGT: failure " Patchwork
  2018-03-07 21:40 ` ✗ Fi.CI.BAT: " Patchwork
  4 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2018-03-06 22:53 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/cnl: Add Wa_2201832410
URL   : https://patchwork.freedesktop.org/series/39408/
State : success

== Summary ==

Series 39408v1 drm/i915/cnl: Add Wa_2201832410
https://patchwork.freedesktop.org/api/1.0/series/39408/revisions/1/mbox/

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:427s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:425s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:371s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:499s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:277s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:488s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:488s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:484s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:464s
fi-cfl-8700k     total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:406s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:564s
fi-cfl-u         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:503s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:415s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:290s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:516s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:401s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:414s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:465s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:425s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:467s
fi-kbl-7560u     total:108  pass:104  dwarn:0   dfail:0   fail:0   skip:3  
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:462s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:505s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:583s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:434s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:518s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:533s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:498s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:482s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:422s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:428s
fi-snb-2520m     total:245  pass:211  dwarn:0   dfail:0   fail:0   skip:33 
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:394s

72d7aac2959d8b0dcdbe6d5e7f072a07fbe2d377 drm-tip: 2018y-03m-06d-19h-09m-24s UTC integration manifest
ea5a831b5406 drm/i915/cnl: Add Wa_2201832410

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8253/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915/cnl: Add Wa_2201832410
  2018-03-06  1:08 [PATCH] drm/i915/cnl: Add Wa_2201832410 Rodrigo Vivi
                   ` (2 preceding siblings ...)
  2018-03-06 22:53 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-03-07  3:36 ` Patchwork
  2018-03-07 21:40 ` ✗ Fi.CI.BAT: " Patchwork
  4 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2018-03-07  3:36 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/cnl: Add Wa_2201832410
URL   : https://patchwork.freedesktop.org/series/39408/
State : failure

== Summary ==

---- Possible new issues:

Test gem_exec_create:
        Subgroup madvise:
                pass       -> INCOMPLETE (shard-snb)
Test kms_busy:
        Subgroup extended-modeset-hang-newfb-render-b:
                dmesg-warn -> PASS       (shard-hsw)
Test kms_chv_cursor_fail:
        Subgroup pipe-c-64x64-right-edge:
                incomplete -> PASS       (shard-hsw)

---- Known issues:

Test gem_eio:
        Subgroup in-flight:
                pass       -> INCOMPLETE (shard-apl) fdo#105341
Test gem_softpin:
        Subgroup noreloc-s3:
                incomplete -> PASS       (shard-hsw) fdo#103540
Test kms_chv_cursor_fail:
        Subgroup pipe-b-256x256-bottom-edge:
                dmesg-warn -> PASS       (shard-snb) fdo#105185 +3
Test kms_flip:
        Subgroup 2x-flip-vs-expired-vblank-interruptible:
                pass       -> FAIL       (shard-hsw) fdo#102887
        Subgroup 2x-wf_vblank-ts-check:
                pass       -> FAIL       (shard-hsw) fdo#100368
        Subgroup modeset-vs-vblank-race-interruptible:
                pass       -> FAIL       (shard-hsw) fdo#103060
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-primscrn-spr-indfb-draw-blt:
                skip       -> PASS       (shard-snb) fdo#101623
Test perf:
        Subgroup blocking:
                pass       -> FAIL       (shard-hsw) fdo#102252

fdo#105341 https://bugs.freedesktop.org/show_bug.cgi?id=105341
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252

shard-apl        total:3308 pass:1742 dwarn:1   dfail:0   fail:7   skip:1556 time:11381s
shard-hsw        total:3467 pass:1768 dwarn:1   dfail:0   fail:6   skip:1691 time:11883s
shard-snb        total:3380 pass:1334 dwarn:3   dfail:0   fail:2   skip:2040 time:6829s
Blacklisted hosts:
shard-kbl        total:3450 pass:1935 dwarn:6   dfail:0   fail:7   skip:1501 time:9337s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8253/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/cnl: Add Wa_2201832410
  2018-03-06  1:08 [PATCH] drm/i915/cnl: Add Wa_2201832410 Rodrigo Vivi
                   ` (3 preceding siblings ...)
  2018-03-07  3:36 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-03-07 21:40 ` Patchwork
  2018-03-07 22:09   ` [PATCH] " Rodrigo Vivi
                     ` (3 more replies)
  4 siblings, 4 replies; 16+ messages in thread
From: Patchwork @ 2018-03-07 21:40 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/cnl: Add Wa_2201832410
URL   : https://patchwork.freedesktop.org/series/39408/
State : failure

== Summary ==

Applying: drm/i915/cnl: Add Wa_2201832410
error: sha1 information is lacking or useless (drivers/gpu/drm/i915/i915_reg.h).
error: could not build fake ancestor
Patch failed at 0001 drm/i915/cnl: Add Wa_2201832410
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8253/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [PATCH] drm/i915/cnl: Add Wa_2201832410
  2018-03-07 21:40 ` ✗ Fi.CI.BAT: " Patchwork
@ 2018-03-07 22:09   ` Rodrigo Vivi
  2018-03-07 22:48     ` Rafael Antognolli
  2018-04-11 13:53     ` Mika Kuoppala
  2018-03-07 22:59   ` ✗ Fi.CI.BAT: failure for drm/i915/cnl: Add Wa_2201832410 (rev2) Patchwork
                     ` (2 subsequent siblings)
  3 siblings, 2 replies; 16+ messages in thread
From: Rodrigo Vivi @ 2018-03-07 22:09 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

"Clock gating bug in GWL may not clear barrier state when an EOT
is received, causing a hang the next time that barrier is used."

HSDES: 2201832410

Cc: Rafael Antognolli <rafael.antognolli@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h | 3 +++
 drivers/gpu/drm/i915/intel_pm.c | 5 +++++
 2 files changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 4787d9bf58b9..e6a8c0ee7df1 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -3965,6 +3965,9 @@ enum {
 #define  SARBUNIT_CLKGATE_DIS		(1 << 5)
 #define  RCCUNIT_CLKGATE_DIS		(1 << 7)
 
+#define SUBSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9524)
+#define  GWUNIT_CLKGATE_DIS		(1 << 16)
+
 #define UNSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9434)
 #define  VFUNIT_CLKGATE_DIS		(1 << 20)
 
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 6cab20ce167a..b8da4dcdd584 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -8522,6 +8522,11 @@ static void cnl_init_clock_gating(struct drm_i915_private *dev_priv)
 		val |= SARBUNIT_CLKGATE_DIS;
 	I915_WRITE(SLICE_UNIT_LEVEL_CLKGATE, val);
 
+	/* Wa_2201832410:cnl */
+	val = I915_READ(SUBSLICE_UNIT_LEVEL_CLKGATE);
+	val |= GWUNIT_CLKGATE_DIS;
+	I915_WRITE(SUBSLICE_UNIT_LEVEL_CLKGATE, val);
+
 	/* WaDisableVFclkgate:cnl */
 	/* WaVFUnitClockGatingDisable:cnl */
 	val = I915_READ(UNSLICE_UNIT_LEVEL_CLKGATE);
-- 
2.13.6

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915/cnl: Add Wa_2201832410
  2018-03-07 22:09   ` [PATCH] " Rodrigo Vivi
@ 2018-03-07 22:48     ` Rafael Antognolli
  2018-03-08  0:00       ` Rodrigo Vivi
  2018-04-11 13:53     ` Mika Kuoppala
  1 sibling, 1 reply; 16+ messages in thread
From: Rafael Antognolli @ 2018-03-07 22:48 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: intel-gfx

Matches bspec.

Reviewed-by: Rafael Antognolli <rafael.antognolli@intel.com>

On Wed, Mar 07, 2018 at 02:09:12PM -0800, Rodrigo Vivi wrote:
> "Clock gating bug in GWL may not clear barrier state when an EOT
> is received, causing a hang the next time that barrier is used."
> 
> HSDES: 2201832410
> 
> Cc: Rafael Antognolli <rafael.antognolli@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_reg.h | 3 +++
>  drivers/gpu/drm/i915/intel_pm.c | 5 +++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 4787d9bf58b9..e6a8c0ee7df1 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -3965,6 +3965,9 @@ enum {
>  #define  SARBUNIT_CLKGATE_DIS		(1 << 5)
>  #define  RCCUNIT_CLKGATE_DIS		(1 << 7)
>  
> +#define SUBSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9524)
> +#define  GWUNIT_CLKGATE_DIS		(1 << 16)
> +
>  #define UNSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9434)
>  #define  VFUNIT_CLKGATE_DIS		(1 << 20)
>  
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 6cab20ce167a..b8da4dcdd584 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -8522,6 +8522,11 @@ static void cnl_init_clock_gating(struct drm_i915_private *dev_priv)
>  		val |= SARBUNIT_CLKGATE_DIS;
>  	I915_WRITE(SLICE_UNIT_LEVEL_CLKGATE, val);
>  
> +	/* Wa_2201832410:cnl */
> +	val = I915_READ(SUBSLICE_UNIT_LEVEL_CLKGATE);
> +	val |= GWUNIT_CLKGATE_DIS;
> +	I915_WRITE(SUBSLICE_UNIT_LEVEL_CLKGATE, val);
> +
>  	/* WaDisableVFclkgate:cnl */
>  	/* WaVFUnitClockGatingDisable:cnl */
>  	val = I915_READ(UNSLICE_UNIT_LEVEL_CLKGATE);
> -- 
> 2.13.6
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/cnl: Add Wa_2201832410 (rev2)
  2018-03-07 21:40 ` ✗ Fi.CI.BAT: " Patchwork
  2018-03-07 22:09   ` [PATCH] " Rodrigo Vivi
@ 2018-03-07 22:59   ` Patchwork
  2018-03-07 23:08     ` Rodrigo Vivi
  2018-03-07 23:42   ` ✓ Fi.CI.BAT: success " Patchwork
  2018-03-08  0:26   ` ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 1 reply; 16+ messages in thread
From: Patchwork @ 2018-03-07 22:59 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/cnl: Add Wa_2201832410 (rev2)
URL   : https://patchwork.freedesktop.org/series/39408/
State : failure

== Summary ==

Series 39408v2 drm/i915/cnl: Add Wa_2201832410
https://patchwork.freedesktop.org/api/1.0/series/39408/revisions/2/mbox/

---- Possible new issues:

Test gem_exec_suspend:
        Subgroup basic-s4-devices:
                pass       -> INCOMPLETE (fi-glk-1)

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:424s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:429s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:371s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:496s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:277s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:486s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:492s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:479s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:468s
fi-cfl-8700k     total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:404s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:579s
fi-cfl-u         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:504s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:414s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:289s
fi-glk-1         total:109  pass:96   dwarn:0   dfail:0   fail:0   skip:12 
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:397s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:408s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:464s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:424s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:469s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:458s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:506s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:583s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:431s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:524s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:532s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:495s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:480s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:422s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:432s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:519s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:396s

0ada78bfa33814b53fc0ce9549a384261bbfffc3 drm-tip: 2018y-03m-07d-22h-14m-49s UTC integration manifest
571e850d4a9e drm/i915/cnl: Add Wa_2201832410

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8265/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for drm/i915/cnl: Add Wa_2201832410 (rev2)
  2018-03-07 22:59   ` ✗ Fi.CI.BAT: failure for drm/i915/cnl: Add Wa_2201832410 (rev2) Patchwork
@ 2018-03-07 23:08     ` Rodrigo Vivi
  0 siblings, 0 replies; 16+ messages in thread
From: Rodrigo Vivi @ 2018-03-07 23:08 UTC (permalink / raw)
  To: intel-gfx

On Wed, Mar 07, 2018 at 10:59:12PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915/cnl: Add Wa_2201832410 (rev2)
> URL   : https://patchwork.freedesktop.org/series/39408/
> State : failure
> 
> == Summary ==
> 
> Series 39408v2 drm/i915/cnl: Add Wa_2201832410
> https://patchwork.freedesktop.org/api/1.0/series/39408/revisions/2/mbox/
> 
> ---- Possible new issues:
> 
> Test gem_exec_suspend:
>         Subgroup basic-s4-devices:
>                 pass       -> INCOMPLETE (fi-glk-1)

yet another false positive... going to the 3rd attempt :/

> 
> fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:424s
> fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:429s
> fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:371s
> fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:496s
> fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:277s
> fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:486s
> fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:492s
> fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:479s
> fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:468s
> fi-cfl-8700k     total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:404s
> fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:579s
> fi-cfl-u         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:504s
> fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:414s
> fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:289s
> fi-glk-1         total:109  pass:96   dwarn:0   dfail:0   fail:0   skip:12 
> fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:397s
> fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:408s
> fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:464s
> fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:424s
> fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:469s
> fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:458s
> fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:506s
> fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:583s
> fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:431s
> fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:524s
> fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:532s
> fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:495s
> fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:480s
> fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:422s
> fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:432s
> fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:519s
> fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:396s
> 
> 0ada78bfa33814b53fc0ce9549a384261bbfffc3 drm-tip: 2018y-03m-07d-22h-14m-49s UTC integration manifest
> 571e850d4a9e drm/i915/cnl: Add Wa_2201832410
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8265/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/cnl: Add Wa_2201832410 (rev2)
  2018-03-07 21:40 ` ✗ Fi.CI.BAT: " Patchwork
  2018-03-07 22:09   ` [PATCH] " Rodrigo Vivi
  2018-03-07 22:59   ` ✗ Fi.CI.BAT: failure for drm/i915/cnl: Add Wa_2201832410 (rev2) Patchwork
@ 2018-03-07 23:42   ` Patchwork
  2018-03-08  0:26   ` ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2018-03-07 23:42 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/cnl: Add Wa_2201832410 (rev2)
URL   : https://patchwork.freedesktop.org/series/39408/
State : success

== Summary ==

Series 39408v2 drm/i915/cnl: Add Wa_2201832410
https://patchwork.freedesktop.org/api/1.0/series/39408/revisions/2/mbox/

---- Known issues:

Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                pass       -> INCOMPLETE (fi-snb-2520m) fdo#103713

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:420s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:424s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:375s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:498s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:278s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:488s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:490s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:480s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:463s
fi-cfl-8700k     total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:405s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:570s
fi-cfl-u         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:509s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:414s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:292s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:517s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:395s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:407s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:462s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:418s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:466s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:462s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:508s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:592s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:432s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:520s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:533s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:492s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:500s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:423s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:426s
fi-snb-2520m     total:245  pass:211  dwarn:0   dfail:0   fail:0   skip:33 
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:388s

0ada78bfa33814b53fc0ce9549a384261bbfffc3 drm-tip: 2018y-03m-07d-22h-14m-49s UTC integration manifest
dccad0adc34f drm/i915/cnl: Add Wa_2201832410

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8266/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915/cnl: Add Wa_2201832410
  2018-03-07 22:48     ` Rafael Antognolli
@ 2018-03-08  0:00       ` Rodrigo Vivi
  2018-03-08 10:30         ` Jani Nikula
  0 siblings, 1 reply; 16+ messages in thread
From: Rodrigo Vivi @ 2018-03-08  0:00 UTC (permalink / raw)
  To: Rafael Antognolli; +Cc: intel-gfx

On Wed, Mar 07, 2018 at 02:48:05PM -0800, Rafael Antognolli wrote:
> Matches bspec.
> 
> Reviewed-by: Rafael Antognolli <rafael.antognolli@intel.com>

pushed, thanks

> 
> On Wed, Mar 07, 2018 at 02:09:12PM -0800, Rodrigo Vivi wrote:
> > "Clock gating bug in GWL may not clear barrier state when an EOT
> > is received, causing a hang the next time that barrier is used."
> > 
> > HSDES: 2201832410
> > 
> > Cc: Rafael Antognolli <rafael.antognolli@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_reg.h | 3 +++
> >  drivers/gpu/drm/i915/intel_pm.c | 5 +++++
> >  2 files changed, 8 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index 4787d9bf58b9..e6a8c0ee7df1 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -3965,6 +3965,9 @@ enum {
> >  #define  SARBUNIT_CLKGATE_DIS		(1 << 5)
> >  #define  RCCUNIT_CLKGATE_DIS		(1 << 7)
> >  
> > +#define SUBSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9524)
> > +#define  GWUNIT_CLKGATE_DIS		(1 << 16)
> > +
> >  #define UNSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9434)
> >  #define  VFUNIT_CLKGATE_DIS		(1 << 20)
> >  
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 6cab20ce167a..b8da4dcdd584 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -8522,6 +8522,11 @@ static void cnl_init_clock_gating(struct drm_i915_private *dev_priv)
> >  		val |= SARBUNIT_CLKGATE_DIS;
> >  	I915_WRITE(SLICE_UNIT_LEVEL_CLKGATE, val);
> >  
> > +	/* Wa_2201832410:cnl */
> > +	val = I915_READ(SUBSLICE_UNIT_LEVEL_CLKGATE);
> > +	val |= GWUNIT_CLKGATE_DIS;
> > +	I915_WRITE(SUBSLICE_UNIT_LEVEL_CLKGATE, val);
> > +
> >  	/* WaDisableVFclkgate:cnl */
> >  	/* WaVFUnitClockGatingDisable:cnl */
> >  	val = I915_READ(UNSLICE_UNIT_LEVEL_CLKGATE);
> > -- 
> > 2.13.6
> > 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/cnl: Add Wa_2201832410 (rev2)
  2018-03-07 21:40 ` ✗ Fi.CI.BAT: " Patchwork
                     ` (2 preceding siblings ...)
  2018-03-07 23:42   ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-03-08  0:26   ` Patchwork
  3 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2018-03-08  0:26 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/cnl: Add Wa_2201832410 (rev2)
URL   : https://patchwork.freedesktop.org/series/39408/
State : success

== Summary ==

---- Possible new issues:

Test kms_vblank:
        Subgroup pipe-b-ts-continuation-suspend:
                incomplete -> PASS       (shard-hsw)

---- Known issues:

Test kms_chv_cursor_fail:
        Subgroup pipe-b-256x256-top-edge:
                pass       -> DMESG-WARN (shard-snb) fdo#105185 +3

fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185

shard-apl        total:3381 pass:1778 dwarn:3   dfail:0   fail:7   skip:1591 time:11871s
shard-hsw        total:3467 pass:1772 dwarn:1   dfail:0   fail:2   skip:1691 time:11862s
shard-snb        total:3467 pass:1362 dwarn:2   dfail:0   fail:2   skip:2101 time:7014s
Blacklisted hosts:
shard-kbl        total:3394 pass:1898 dwarn:11  dfail:0   fail:8   skip:1476 time:9117s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8266/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915/cnl: Add Wa_2201832410
  2018-03-08  0:00       ` Rodrigo Vivi
@ 2018-03-08 10:30         ` Jani Nikula
  2018-03-08 15:23           ` Rodrigo Vivi
  0 siblings, 1 reply; 16+ messages in thread
From: Jani Nikula @ 2018-03-08 10:30 UTC (permalink / raw)
  To: Rodrigo Vivi, Rafael Antognolli; +Cc: intel-gfx

On Wed, 07 Mar 2018, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Wed, Mar 07, 2018 at 02:48:05PM -0800, Rafael Antognolli wrote:
>> Matches bspec.
>> 
>> Reviewed-by: Rafael Antognolli <rafael.antognolli@intel.com>
>
> pushed, thanks

Okay, too late now, but I think "Add Wa_2201832410" as a commit title is
insufficient. Even a few words around it about the change would be
appreciated.

Thanks,
Jani.


>
>> 
>> On Wed, Mar 07, 2018 at 02:09:12PM -0800, Rodrigo Vivi wrote:
>> > "Clock gating bug in GWL may not clear barrier state when an EOT
>> > is received, causing a hang the next time that barrier is used."
>> > 
>> > HSDES: 2201832410
>> > 
>> > Cc: Rafael Antognolli <rafael.antognolli@intel.com>
>> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> > ---
>> >  drivers/gpu/drm/i915/i915_reg.h | 3 +++
>> >  drivers/gpu/drm/i915/intel_pm.c | 5 +++++
>> >  2 files changed, 8 insertions(+)
>> > 
>> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>> > index 4787d9bf58b9..e6a8c0ee7df1 100644
>> > --- a/drivers/gpu/drm/i915/i915_reg.h
>> > +++ b/drivers/gpu/drm/i915/i915_reg.h
>> > @@ -3965,6 +3965,9 @@ enum {
>> >  #define  SARBUNIT_CLKGATE_DIS		(1 << 5)
>> >  #define  RCCUNIT_CLKGATE_DIS		(1 << 7)
>> >  
>> > +#define SUBSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9524)
>> > +#define  GWUNIT_CLKGATE_DIS		(1 << 16)
>> > +
>> >  #define UNSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9434)
>> >  #define  VFUNIT_CLKGATE_DIS		(1 << 20)
>> >  
>> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>> > index 6cab20ce167a..b8da4dcdd584 100644
>> > --- a/drivers/gpu/drm/i915/intel_pm.c
>> > +++ b/drivers/gpu/drm/i915/intel_pm.c
>> > @@ -8522,6 +8522,11 @@ static void cnl_init_clock_gating(struct drm_i915_private *dev_priv)
>> >  		val |= SARBUNIT_CLKGATE_DIS;
>> >  	I915_WRITE(SLICE_UNIT_LEVEL_CLKGATE, val);
>> >  
>> > +	/* Wa_2201832410:cnl */
>> > +	val = I915_READ(SUBSLICE_UNIT_LEVEL_CLKGATE);
>> > +	val |= GWUNIT_CLKGATE_DIS;
>> > +	I915_WRITE(SUBSLICE_UNIT_LEVEL_CLKGATE, val);
>> > +
>> >  	/* WaDisableVFclkgate:cnl */
>> >  	/* WaVFUnitClockGatingDisable:cnl */
>> >  	val = I915_READ(UNSLICE_UNIT_LEVEL_CLKGATE);
>> > -- 
>> > 2.13.6
>> > 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915/cnl: Add Wa_2201832410
  2018-03-08 10:30         ` Jani Nikula
@ 2018-03-08 15:23           ` Rodrigo Vivi
  0 siblings, 0 replies; 16+ messages in thread
From: Rodrigo Vivi @ 2018-03-08 15:23 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

On Thu, Mar 08, 2018 at 12:30:07PM +0200, Jani Nikula wrote:
> On Wed, 07 Mar 2018, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> > On Wed, Mar 07, 2018 at 02:48:05PM -0800, Rafael Antognolli wrote:
> >> Matches bspec.
> >> 
> >> Reviewed-by: Rafael Antognolli <rafael.antognolli@intel.com>
> >
> > pushed, thanks
> 
> Okay, too late now, but I think "Add Wa_2201832410" as a commit title is
> insufficient. Even a few words around it about the change would be
> appreciated.

yeap... good point.

usually wa names had some WaSomeInformationOnName and I got used to only
use that as subject... This round of Wa came only with HSD number on it.
But we should be able to add few useful information on subject indeed.

Noted for next Wa_<#hsdesnumber>....

thanks for the feedback.

> 
> Thanks,
> Jani.
> 
> 
> >
> >> 
> >> On Wed, Mar 07, 2018 at 02:09:12PM -0800, Rodrigo Vivi wrote:
> >> > "Clock gating bug in GWL may not clear barrier state when an EOT
> >> > is received, causing a hang the next time that barrier is used."
> >> > 
> >> > HSDES: 2201832410
> >> > 
> >> > Cc: Rafael Antognolli <rafael.antognolli@intel.com>
> >> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >> > ---
> >> >  drivers/gpu/drm/i915/i915_reg.h | 3 +++
> >> >  drivers/gpu/drm/i915/intel_pm.c | 5 +++++
> >> >  2 files changed, 8 insertions(+)
> >> > 
> >> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> >> > index 4787d9bf58b9..e6a8c0ee7df1 100644
> >> > --- a/drivers/gpu/drm/i915/i915_reg.h
> >> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> >> > @@ -3965,6 +3965,9 @@ enum {
> >> >  #define  SARBUNIT_CLKGATE_DIS		(1 << 5)
> >> >  #define  RCCUNIT_CLKGATE_DIS		(1 << 7)
> >> >  
> >> > +#define SUBSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9524)
> >> > +#define  GWUNIT_CLKGATE_DIS		(1 << 16)
> >> > +
> >> >  #define UNSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9434)
> >> >  #define  VFUNIT_CLKGATE_DIS		(1 << 20)
> >> >  
> >> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> >> > index 6cab20ce167a..b8da4dcdd584 100644
> >> > --- a/drivers/gpu/drm/i915/intel_pm.c
> >> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> >> > @@ -8522,6 +8522,11 @@ static void cnl_init_clock_gating(struct drm_i915_private *dev_priv)
> >> >  		val |= SARBUNIT_CLKGATE_DIS;
> >> >  	I915_WRITE(SLICE_UNIT_LEVEL_CLKGATE, val);
> >> >  
> >> > +	/* Wa_2201832410:cnl */
> >> > +	val = I915_READ(SUBSLICE_UNIT_LEVEL_CLKGATE);
> >> > +	val |= GWUNIT_CLKGATE_DIS;
> >> > +	I915_WRITE(SUBSLICE_UNIT_LEVEL_CLKGATE, val);
> >> > +
> >> >  	/* WaDisableVFclkgate:cnl */
> >> >  	/* WaVFUnitClockGatingDisable:cnl */
> >> >  	val = I915_READ(UNSLICE_UNIT_LEVEL_CLKGATE);
> >> > -- 
> >> > 2.13.6
> >> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915/cnl: Add Wa_2201832410
  2018-03-07 22:09   ` [PATCH] " Rodrigo Vivi
  2018-03-07 22:48     ` Rafael Antognolli
@ 2018-04-11 13:53     ` Mika Kuoppala
  1 sibling, 0 replies; 16+ messages in thread
From: Mika Kuoppala @ 2018-04-11 13:53 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

Rodrigo Vivi <rodrigo.vivi@intel.com> writes:

> "Clock gating bug in GWL may not clear barrier state when an EOT
> is received, causing a hang the next time that barrier is used."
>
> HSDES: 2201832410
>

A bit late here but do we have a preference of going like
the above or,

References: HSDES#2201832410

?
-Mika


> Cc: Rafael Antognolli <rafael.antognolli@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_reg.h | 3 +++
>  drivers/gpu/drm/i915/intel_pm.c | 5 +++++
>  2 files changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 4787d9bf58b9..e6a8c0ee7df1 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -3965,6 +3965,9 @@ enum {
>  #define  SARBUNIT_CLKGATE_DIS		(1 << 5)
>  #define  RCCUNIT_CLKGATE_DIS		(1 << 7)
>  
> +#define SUBSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9524)
> +#define  GWUNIT_CLKGATE_DIS		(1 << 16)
> +
>  #define UNSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9434)
>  #define  VFUNIT_CLKGATE_DIS		(1 << 20)
>  
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 6cab20ce167a..b8da4dcdd584 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -8522,6 +8522,11 @@ static void cnl_init_clock_gating(struct drm_i915_private *dev_priv)
>  		val |= SARBUNIT_CLKGATE_DIS;
>  	I915_WRITE(SLICE_UNIT_LEVEL_CLKGATE, val);
>  
> +	/* Wa_2201832410:cnl */
> +	val = I915_READ(SUBSLICE_UNIT_LEVEL_CLKGATE);
> +	val |= GWUNIT_CLKGATE_DIS;
> +	I915_WRITE(SUBSLICE_UNIT_LEVEL_CLKGATE, val);
> +
>  	/* WaDisableVFclkgate:cnl */
>  	/* WaVFUnitClockGatingDisable:cnl */
>  	val = I915_READ(UNSLICE_UNIT_LEVEL_CLKGATE);
> -- 
> 2.13.6
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2018-04-11 13:53 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-06  1:08 [PATCH] drm/i915/cnl: Add Wa_2201832410 Rodrigo Vivi
2018-03-06  1:36 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-06  7:26 ` ✗ Fi.CI.IGT: warning " Patchwork
2018-03-06 22:53 ` ✓ Fi.CI.BAT: success " Patchwork
2018-03-07  3:36 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-03-07 21:40 ` ✗ Fi.CI.BAT: " Patchwork
2018-03-07 22:09   ` [PATCH] " Rodrigo Vivi
2018-03-07 22:48     ` Rafael Antognolli
2018-03-08  0:00       ` Rodrigo Vivi
2018-03-08 10:30         ` Jani Nikula
2018-03-08 15:23           ` Rodrigo Vivi
2018-04-11 13:53     ` Mika Kuoppala
2018-03-07 22:59   ` ✗ Fi.CI.BAT: failure for drm/i915/cnl: Add Wa_2201832410 (rev2) Patchwork
2018-03-07 23:08     ` Rodrigo Vivi
2018-03-07 23:42   ` ✓ Fi.CI.BAT: success " Patchwork
2018-03-08  0:26   ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.