* [Buildroot] [PATCH v2 1/1] fbgrab: add patch fixing pixel format report
@ 2018-03-08 7:22 Timo Ketola
2018-03-08 8:07 ` Peter Korsgaard
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Timo Ketola @ 2018-03-08 7:22 UTC (permalink / raw)
To: buildroot
When verbosive, fbgrab reports pixel format. Green and blue offset and
msb_right fields are accidentally swapped there. This commit adds a patch
which straightens them up.
Upstream-Status: Submitted [Gunnar Monell <gmo@linux.nu>]
Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>
---
No changes in the payload. Only added Upstream-status (Adrian) and
adjusted subject line (Thomas).
---
package/fbgrab/0100-fix-pixfmt-report.patch | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
create mode 100644 package/fbgrab/0100-fix-pixfmt-report.patch
diff --git a/package/fbgrab/0100-fix-pixfmt-report.patch b/package/fbgrab/0100-fix-pixfmt-report.patch
new file mode 100644
index 0000000..18bcf96
--- /dev/null
+++ b/package/fbgrab/0100-fix-pixfmt-report.patch
@@ -0,0 +1,22 @@
+Fix pixel format report
+
+When fbgrab tells about the framebuffer pixel format, blue and green
+are accidentally swapped in 'length' and 'msb_right' columns. Let's
+order everything as RGB.
+
+Signed-off-by timo.ketola at exertus.fi
+
+diff -u a/fbgrab.c b/fbgrab.c
+--- a/fbgrab.c 2018-03-07 11:42:04.739250433 +0200
++++ b/fbgrab.c 2018-03-07 11:43:26.128043877 +0200
+@@ -169,8 +169,8 @@
+ fprintf(stderr, "bits_per_pixel: %i\n", fb_varinfo_p->bits_per_pixel);
+ fprintf(stderr, "grayscale: %s\n", fb_varinfo_p->grayscale ? "true" : "false");
+ fprintf(stderr, "red: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->red.offset, fb_varinfo_p->red.length, fb_varinfo_p->red.msb_right);
+- fprintf(stderr, "blue: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->blue.offset, fb_varinfo_p->green.length, fb_varinfo_p->green.msb_right);
+- fprintf(stderr, "green: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->green.offset, fb_varinfo_p->blue.length, fb_varinfo_p->blue.msb_right);
++ fprintf(stderr, "green: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->green.offset, fb_varinfo_p->green.length, fb_varinfo_p->green.msb_right);
++ fprintf(stderr, "blue: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->blue.offset, fb_varinfo_p->blue.length, fb_varinfo_p->blue.msb_right);
+ fprintf(stderr, "alpha: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->transp.offset, fb_varinfo_p->transp.length, fb_varinfo_p->transp.msb_right);
+ fprintf(stderr, "pixel format: %s\n", fb_varinfo_p->nonstd == 0 ? "standard" : "non-standard");
+ }
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH v2 1/1] fbgrab: add patch fixing pixel format report
2018-03-08 7:22 [Buildroot] [PATCH v2 1/1] fbgrab: add patch fixing pixel format report Timo Ketola
@ 2018-03-08 8:07 ` Peter Korsgaard
2018-03-08 8:30 ` Thomas Petazzoni
2018-03-30 21:22 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2018-03-08 8:07 UTC (permalink / raw)
To: buildroot
>>>>> "Timo" == Timo Ketola <timo.ketola@exertus.fi> writes:
> When verbosive, fbgrab reports pixel format. Green and blue offset and
> msb_right fields are accidentally swapped there. This commit adds a patch
> which straightens them up.
> Upstream-Status: Submitted [Gunnar Monell <gmo@linux.nu>]
> Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>
> ---
> No changes in the payload. Only added Upstream-status (Adrian) and
> adjusted subject line (Thomas).
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/1] fbgrab: add patch fixing pixel format report
2018-03-08 7:22 [Buildroot] [PATCH v2 1/1] fbgrab: add patch fixing pixel format report Timo Ketola
2018-03-08 8:07 ` Peter Korsgaard
@ 2018-03-08 8:30 ` Thomas Petazzoni
2018-03-08 9:15 ` Timo Ketola
2018-03-30 21:22 ` Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2018-03-08 8:30 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 8 Mar 2018 09:22:05 +0200, Timo Ketola wrote:
> When verbosive, fbgrab reports pixel format. Green and blue offset and
> msb_right fields are accidentally swapped there. This commit adds a patch
> which straightens them up.
>
> Upstream-Status: Submitted [Gunnar Monell <gmo@linux.nu>]
We normally put the Upstream-Status in the patch itself, i.e
>
> Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>
> ---
> No changes in the payload. Only added Upstream-status (Adrian) and
> adjusted subject line (Thomas).
> ---
> package/fbgrab/0100-fix-pixfmt-report.patch | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
> create mode 100644 package/fbgrab/0100-fix-pixfmt-report.patch
>
> diff --git a/package/fbgrab/0100-fix-pixfmt-report.patch b/package/fbgrab/0100-fix-pixfmt-report.patch
> new file mode 100644
> index 0000000..18bcf96
> --- /dev/null
> +++ b/package/fbgrab/0100-fix-pixfmt-report.patch
> @@ -0,0 +1,22 @@
> +Fix pixel format report
> +
> +When fbgrab tells about the framebuffer pixel format, blue and green
> +are accidentally swapped in 'length' and 'msb_right' columns. Let's
> +order everything as RGB.
... here.
> +
> +Signed-off-by timo.ketola at exertus.fi
This Signed-off-by line doesn't follow the usual format, it should have
been:
Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>
(But your patch has been applied already anyway).
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/1] fbgrab: add patch fixing pixel format report
2018-03-08 8:30 ` Thomas Petazzoni
@ 2018-03-08 9:15 ` Timo Ketola
2018-03-08 9:57 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Timo Ketola @ 2018-03-08 9:15 UTC (permalink / raw)
To: buildroot
On 08.03.2018 10:30, Thomas Petazzoni wrote:
> On Thu, 8 Mar 2018 09:22:05 +0200, Timo Ketola wrote:
>> Upstream-Status: Submitted [Gunnar Monell <gmo@linux.nu>]
>
> We normally put the Upstream-Status in the patch itself...
Ah, makes sense of course.
>> +Signed-off-by timo.ketola at exertus.fi
>
> This Signed-off-by line doesn't follow the usual format...
Arg, I hand edited the patch from diff output.
> (But your patch has been applied already anyway).
Should I fix them anyway?
--
Timo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/1] fbgrab: add patch fixing pixel format report
2018-03-08 9:15 ` Timo Ketola
@ 2018-03-08 9:57 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2018-03-08 9:57 UTC (permalink / raw)
To: buildroot
>>>>> "Timo" == Timo Ketola <timo.ketola@exertus.fi> writes:
Hi,
>> We normally put the Upstream-Status in the patch itself...
> Ah, makes sense of course.
>>> +Signed-off-by timo.ketola at exertus.fi
>>
>> This Signed-off-by line doesn't follow the usual format...
> Arg, I hand edited the patch from diff output.
>> (But your patch has been applied already anyway).
> Should I fix them anyway?
yes, please send a followup patch - Thanks!
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/1] fbgrab: add patch fixing pixel format report
2018-03-08 7:22 [Buildroot] [PATCH v2 1/1] fbgrab: add patch fixing pixel format report Timo Ketola
2018-03-08 8:07 ` Peter Korsgaard
2018-03-08 8:30 ` Thomas Petazzoni
@ 2018-03-30 21:22 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2018-03-30 21:22 UTC (permalink / raw)
To: buildroot
>>>>> "Timo" == Timo Ketola <timo.ketola@exertus.fi> writes:
> When verbosive, fbgrab reports pixel format. Green and blue offset and
> msb_right fields are accidentally swapped there. This commit adds a patch
> which straightens them up.
> Upstream-Status: Submitted [Gunnar Monell <gmo@linux.nu>]
> Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>
> ---
> No changes in the payload. Only added Upstream-status (Adrian) and
> adjusted subject line (Thomas).
Committed to 2018.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-30 21:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-08 7:22 [Buildroot] [PATCH v2 1/1] fbgrab: add patch fixing pixel format report Timo Ketola
2018-03-08 8:07 ` Peter Korsgaard
2018-03-08 8:30 ` Thomas Petazzoni
2018-03-08 9:15 ` Timo Ketola
2018-03-08 9:57 ` Peter Korsgaard
2018-03-30 21:22 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.