[linux-next:master 6181/6533] net/rds/message.c:336:5: sparse: symbol 'rds_message_zcopy_from_user' was not declared. Should it be static?

[linux-next:master 6181/6533] net/rds/message.c:336:5: sparse: symbol 'rds_message_zcopy_from_user' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   c6f1a8c953479b390458e36fb838d96199a5f466
commit: d40a126b16ea851f858f97b0e214d97c8355cecb [6181/6533] rds: refactor zcopy code into rds_message_zcopy_from_user
reproduce:
        # apt-get install sparse
        git checkout d40a126b16ea851f858f97b0e214d97c8355cecb
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> net/rds/message.c:336:5: sparse: symbol 'rds_message_zcopy_from_user' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH linux-next] rds: rds_message_zcopy_from_user() can be static

[kbuild test robot]

Fixes: d40a126b16ea ("rds: refactor zcopy code into rds_message_zcopy_from_user")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 message.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rds/message.c b/net/rds/message.c
index c36edbb9..6d87910b 100644
--- a/net/rds/message.c
+++ b/net/rds/message.c
@@ -333,7 +333,7 @@ struct rds_message *rds_message_map_pages(unsigned long *page_addrs, unsigned in
 	return rm;
 }
 
-int rds_message_zcopy_from_user(struct rds_message *rm, struct iov_iter *from)
+static int rds_message_zcopy_from_user(struct rds_message *rm, struct iov_iter *from)
 {
 	unsigned long sg_off;
 	struct scatterlist *sg;

Re: [RFC PATCH linux-next] rds: rds_message_zcopy_from_user() can be static

[Sowmini Varadhan]

On (03/08/18 18:56), kbuild test robot wrote:
> 
> Fixes: d40a126b16ea ("rds: refactor zcopy code into rds_message_zcopy_from_user")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>

(do I need to separately submit a non-RFC patch for this?)

Re: [RFC PATCH linux-next] rds: rds_message_zcopy_from_user() can be static

[David Miller]

From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Date: Thu, 8 Mar 2018 06:25:52 -0500

> On (03/08/18 18:56), kbuild test robot wrote:
>> 
>> Fixes: d40a126b16ea ("rds: refactor zcopy code into rds_message_zcopy_from_user")
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
> 
> (do I need to separately submit a non-RFC patch for this?)

You don't have to resubmit in a situation like this.

Applied, thanks everyone.