* [PATCH v4 0/4] Set name of regmap_config
@ 2018-03-09 1:51 ` Jeffy Chen
0 siblings, 0 replies; 14+ messages in thread
From: Jeffy Chen @ 2018-03-09 1:51 UTC (permalink / raw)
To: linux-kernel, broonie, alexandre.belloni
Cc: Jeffy Chen, linux-rtc, Sylvain Lemieux, Arnd Bergmann,
Michael Turquette, Heiko Stuebner, Alessandro Zummo,
Stephen Boyd, Gabriel Fernandez, linux-clk, linux-rockchip,
Russell King, Lee Jones, Nicolas Ferre, Jerome Brunet,
Vladimir Zapolskiy, Arvind Yadav, linux-arm-kernel
After 9b947a13e7f6 ("regmap: use debugfs even when no device"), we are
allowing regmap to create debugfs without a valid device. Some of them
would end up using "dummy*" as debugfs name.
This series try to set names in some regmap_config to avoid that.
Changes in v4:
Not to use rtc dev to init regmap, the gpbr is not directly related to
the rtc.
Changes in v3:
Modify commit message.
Jeffy Chen (4):
mfd: syscon: Set name of regmap_config
rtc: at91sam9: Set name of regmap_config
clk: lpc32xx: Set name of regmap_config
ARM: rockchip: Set name of regmap_config
arch/arm/mach-rockchip/platsmp.c | 1 +
drivers/clk/nxp/clk-lpc32xx.c | 1 +
drivers/mfd/syscon.c | 1 +
drivers/rtc/rtc-at91sam9.c | 1 +
4 files changed, 4 insertions(+)
--
2.11.0
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v4 0/4] Set name of regmap_config
@ 2018-03-09 1:51 ` Jeffy Chen
0 siblings, 0 replies; 14+ messages in thread
From: Jeffy Chen @ 2018-03-09 1:51 UTC (permalink / raw)
To: linux-arm-kernel
After 9b947a13e7f6 ("regmap: use debugfs even when no device"), we are
allowing regmap to create debugfs without a valid device. Some of them
would end up using "dummy*" as debugfs name.
This series try to set names in some regmap_config to avoid that.
Changes in v4:
Not to use rtc dev to init regmap, the gpbr is not directly related to
the rtc.
Changes in v3:
Modify commit message.
Jeffy Chen (4):
mfd: syscon: Set name of regmap_config
rtc: at91sam9: Set name of regmap_config
clk: lpc32xx: Set name of regmap_config
ARM: rockchip: Set name of regmap_config
arch/arm/mach-rockchip/platsmp.c | 1 +
drivers/clk/nxp/clk-lpc32xx.c | 1 +
drivers/mfd/syscon.c | 1 +
drivers/rtc/rtc-at91sam9.c | 1 +
4 files changed, 4 insertions(+)
--
2.11.0
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v4 1/4] mfd: syscon: Set name of regmap_config
2018-03-09 1:51 ` Jeffy Chen
(?)
@ 2018-03-09 1:51 ` Jeffy Chen
2018-03-09 8:15 ` Lee Jones
-1 siblings, 1 reply; 14+ messages in thread
From: Jeffy Chen @ 2018-03-09 1:51 UTC (permalink / raw)
To: linux-kernel, broonie, alexandre.belloni
Cc: Jeffy Chen, Arnd Bergmann, Lee Jones
We are now allowing to register debugfs without a valid device, and not
having a valid name will end up using "dummy*" to create debugfs dir.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
Changes in v4: None
Changes in v3:
Modify commit message.
drivers/mfd/syscon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
index fc9ba0ea4e44..b6d05cd934e6 100644
--- a/drivers/mfd/syscon.c
+++ b/drivers/mfd/syscon.c
@@ -110,6 +110,7 @@ static struct syscon *of_syscon_register(struct device_node *np)
syscon_config.reg_stride = reg_io_width;
syscon_config.val_bits = reg_io_width * 8;
syscon_config.max_register = resource_size(&res) - reg_io_width;
+ syscon_config.name = of_node_full_name(np);
regmap = regmap_init_mmio(NULL, base, &syscon_config);
if (IS_ERR(regmap)) {
--
2.11.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v4 2/4] rtc: at91sam9: Set name of regmap_config
2018-03-09 1:51 ` Jeffy Chen
@ 2018-03-09 1:51 ` Jeffy Chen
-1 siblings, 0 replies; 14+ messages in thread
From: Jeffy Chen @ 2018-03-09 1:51 UTC (permalink / raw)
To: linux-kernel, broonie, alexandre.belloni
Cc: Jeffy Chen, linux-rtc, Alessandro Zummo, Nicolas Ferre, linux-arm-kernel
We are now allowing to register debugfs without a valid device, and not
having a valid name will end up using "dummy*" to create debugfs dir.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
Changes in v4:
Not to use rtc dev to init regmap, the gpbr is not directly related to
the rtc.
Changes in v3: None
drivers/rtc/rtc-at91sam9.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c
index 7418a763ce52..ee71e647fd43 100644
--- a/drivers/rtc/rtc-at91sam9.c
+++ b/drivers/rtc/rtc-at91sam9.c
@@ -349,6 +349,7 @@ static const struct rtc_class_ops at91_rtc_ops = {
};
static const struct regmap_config gpbr_regmap_config = {
+ .name = "gpbr",
.reg_bits = 32,
.val_bits = 32,
.reg_stride = 4,
--
2.11.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v4 2/4] rtc: at91sam9: Set name of regmap_config
@ 2018-03-09 1:51 ` Jeffy Chen
0 siblings, 0 replies; 14+ messages in thread
From: Jeffy Chen @ 2018-03-09 1:51 UTC (permalink / raw)
To: linux-arm-kernel
We are now allowing to register debugfs without a valid device, and not
having a valid name will end up using "dummy*" to create debugfs dir.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
Changes in v4:
Not to use rtc dev to init regmap, the gpbr is not directly related to
the rtc.
Changes in v3: None
drivers/rtc/rtc-at91sam9.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c
index 7418a763ce52..ee71e647fd43 100644
--- a/drivers/rtc/rtc-at91sam9.c
+++ b/drivers/rtc/rtc-at91sam9.c
@@ -349,6 +349,7 @@ static const struct rtc_class_ops at91_rtc_ops = {
};
static const struct regmap_config gpbr_regmap_config = {
+ .name = "gpbr",
.reg_bits = 32,
.val_bits = 32,
.reg_stride = 4,
--
2.11.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v4 3/4] clk: lpc32xx: Set name of regmap_config
2018-03-09 1:51 ` Jeffy Chen
@ 2018-03-09 1:51 ` Jeffy Chen
-1 siblings, 0 replies; 14+ messages in thread
From: Jeffy Chen @ 2018-03-09 1:51 UTC (permalink / raw)
To: linux-kernel, broonie, alexandre.belloni
Cc: Jeffy Chen, Sylvain Lemieux, Michael Turquette, Stephen Boyd,
Gabriel Fernandez, linux-clk, linux-arm-kernel, Jerome Brunet,
Vladimir Zapolskiy, Arvind Yadav
We are now allowing to register debugfs without a valid device, and not
having a valid name will end up using "dummy*" to create debugfs dir.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
Changes in v4: None
Changes in v3: None
drivers/clk/nxp/clk-lpc32xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c
index f5d815f577e0..a2a0a7f3bc57 100644
--- a/drivers/clk/nxp/clk-lpc32xx.c
+++ b/drivers/clk/nxp/clk-lpc32xx.c
@@ -67,6 +67,7 @@
#define LPC32XX_USB_CLK_STS 0xF8
static struct regmap_config lpc32xx_scb_regmap_config = {
+ .name = "lpc32xx-scb",
.reg_bits = 32,
.val_bits = 32,
.reg_stride = 4,
--
2.11.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v4 3/4] clk: lpc32xx: Set name of regmap_config
@ 2018-03-09 1:51 ` Jeffy Chen
0 siblings, 0 replies; 14+ messages in thread
From: Jeffy Chen @ 2018-03-09 1:51 UTC (permalink / raw)
To: linux-arm-kernel
We are now allowing to register debugfs without a valid device, and not
having a valid name will end up using "dummy*" to create debugfs dir.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
Changes in v4: None
Changes in v3: None
drivers/clk/nxp/clk-lpc32xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c
index f5d815f577e0..a2a0a7f3bc57 100644
--- a/drivers/clk/nxp/clk-lpc32xx.c
+++ b/drivers/clk/nxp/clk-lpc32xx.c
@@ -67,6 +67,7 @@
#define LPC32XX_USB_CLK_STS 0xF8
static struct regmap_config lpc32xx_scb_regmap_config = {
+ .name = "lpc32xx-scb",
.reg_bits = 32,
.val_bits = 32,
.reg_stride = 4,
--
2.11.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v4 4/4] ARM: rockchip: Set name of regmap_config
2018-03-09 1:51 ` Jeffy Chen
@ 2018-03-09 1:51 ` Jeffy Chen
-1 siblings, 0 replies; 14+ messages in thread
From: Jeffy Chen @ 2018-03-09 1:51 UTC (permalink / raw)
To: linux-kernel, broonie, alexandre.belloni
Cc: Jeffy Chen, linux-arm-kernel, linux-rockchip, Russell King,
Heiko Stuebner
We are now allowing to register debugfs without a valid device, and not
having a valid name will end up using "dummy*" to create debugfs dir.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
Changes in v4: None
Changes in v3: None
arch/arm/mach-rockchip/platsmp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c
index ecec340ca345..51984a40b097 100644
--- a/arch/arm/mach-rockchip/platsmp.c
+++ b/arch/arm/mach-rockchip/platsmp.c
@@ -208,6 +208,7 @@ static int __init rockchip_smp_prepare_sram(struct device_node *node)
}
static const struct regmap_config rockchip_pmu_regmap_config = {
+ .name = "rockchip-pmu",
.reg_bits = 32,
.val_bits = 32,
.reg_stride = 4,
--
2.11.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v4 4/4] ARM: rockchip: Set name of regmap_config
@ 2018-03-09 1:51 ` Jeffy Chen
0 siblings, 0 replies; 14+ messages in thread
From: Jeffy Chen @ 2018-03-09 1:51 UTC (permalink / raw)
To: linux-arm-kernel
We are now allowing to register debugfs without a valid device, and not
having a valid name will end up using "dummy*" to create debugfs dir.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
Changes in v4: None
Changes in v3: None
arch/arm/mach-rockchip/platsmp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c
index ecec340ca345..51984a40b097 100644
--- a/arch/arm/mach-rockchip/platsmp.c
+++ b/arch/arm/mach-rockchip/platsmp.c
@@ -208,6 +208,7 @@ static int __init rockchip_smp_prepare_sram(struct device_node *node)
}
static const struct regmap_config rockchip_pmu_regmap_config = {
+ .name = "rockchip-pmu",
.reg_bits = 32,
.val_bits = 32,
.reg_stride = 4,
--
2.11.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v4 1/4] mfd: syscon: Set name of regmap_config
2018-03-09 1:51 ` [PATCH v4 1/4] mfd: syscon: " Jeffy Chen
@ 2018-03-09 8:15 ` Lee Jones
0 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2018-03-09 8:15 UTC (permalink / raw)
To: Jeffy Chen; +Cc: linux-kernel, broonie, alexandre.belloni, Arnd Bergmann
On Fri, 09 Mar 2018, Jeffy Chen wrote:
> We are now allowing to register debugfs without a valid device, and not
> having a valid name will end up using "dummy*" to create debugfs dir.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
>
> Changes in v4: None
> Changes in v3:
> Modify commit message.
>
> drivers/mfd/syscon.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index fc9ba0ea4e44..b6d05cd934e6 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -110,6 +110,7 @@ static struct syscon *of_syscon_register(struct device_node *np)
> syscon_config.reg_stride = reg_io_width;
> syscon_config.val_bits = reg_io_width * 8;
> syscon_config.max_register = resource_size(&res) - reg_io_width;
> + syscon_config.name = of_node_full_name(np);
It's difficult to review, since we cannot see what's happening with
the rest of the patch set. Would you mind re-sending the whole set to
all parties please?
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v4 0/4] Set name of regmap_config
2018-03-09 1:51 ` Jeffy Chen
@ 2018-03-09 8:16 ` Lee Jones
-1 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2018-03-09 8:16 UTC (permalink / raw)
To: Jeffy Chen
Cc: linux-kernel, broonie, alexandre.belloni, linux-rtc,
Sylvain Lemieux, Arnd Bergmann, Michael Turquette,
Heiko Stuebner, Alessandro Zummo, Stephen Boyd,
Gabriel Fernandez, linux-clk, linux-rockchip, Russell King,
Nicolas Ferre, Jerome Brunet, Vladimir Zapolskiy, Arvind Yadav,
linux-arm-kernel
On Fri, 09 Mar 2018, Jeffy Chen wrote:
>
> After 9b947a13e7f6 ("regmap: use debugfs even when no device"), we are
> allowing regmap to create debugfs without a valid device. Some of them
> would end up using "dummy*" as debugfs name.
>
> This series try to set names in some regmap_config to avoid that.
>
>
> Changes in v4:
> Not to use rtc dev to init regmap, the gpbr is not directly related to
> the rtc.
>
> Changes in v3:
> Modify commit message.
>
> Jeffy Chen (4):
> mfd: syscon: Set name of regmap_config
> rtc: at91sam9: Set name of regmap_config
> clk: lpc32xx: Set name of regmap_config
> ARM: rockchip: Set name of regmap_config
>
> arch/arm/mach-rockchip/platsmp.c | 1 +
> drivers/clk/nxp/clk-lpc32xx.c | 1 +
> drivers/mfd/syscon.c | 1 +
It's difficult to review, since we cannot see what's happening with
the rest of the patch set. Would you mind re-sending the whole set to
all parties please?
> drivers/rtc/rtc-at91sam9.c | 1 +
> 4 files changed, 4 insertions(+)
>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v4 0/4] Set name of regmap_config
@ 2018-03-09 8:16 ` Lee Jones
0 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2018-03-09 8:16 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 09 Mar 2018, Jeffy Chen wrote:
>
> After 9b947a13e7f6 ("regmap: use debugfs even when no device"), we are
> allowing regmap to create debugfs without a valid device. Some of them
> would end up using "dummy*" as debugfs name.
>
> This series try to set names in some regmap_config to avoid that.
>
>
> Changes in v4:
> Not to use rtc dev to init regmap, the gpbr is not directly related to
> the rtc.
>
> Changes in v3:
> Modify commit message.
>
> Jeffy Chen (4):
> mfd: syscon: Set name of regmap_config
> rtc: at91sam9: Set name of regmap_config
> clk: lpc32xx: Set name of regmap_config
> ARM: rockchip: Set name of regmap_config
>
> arch/arm/mach-rockchip/platsmp.c | 1 +
> drivers/clk/nxp/clk-lpc32xx.c | 1 +
> drivers/mfd/syscon.c | 1 +
It's difficult to review, since we cannot see what's happening with
the rest of the patch set. Would you mind re-sending the whole set to
all parties please?
> drivers/rtc/rtc-at91sam9.c | 1 +
> 4 files changed, 4 insertions(+)
>
--
Lee Jones [???]
Linaro Services Technical Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v4 0/4] Set name of regmap_config
2018-03-09 8:16 ` Lee Jones
@ 2018-03-09 8:45 ` JeffyChen
-1 siblings, 0 replies; 14+ messages in thread
From: JeffyChen @ 2018-03-09 8:45 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, broonie, alexandre.belloni, linux-rtc,
Sylvain Lemieux, Arnd Bergmann, Michael Turquette,
Heiko Stuebner, Alessandro Zummo, Stephen Boyd,
Gabriel Fernandez, linux-clk, linux-rockchip, Russell King,
Nicolas Ferre, Jerome Brunet, Vladimir Zapolskiy, Arvind Yadav,
linux-arm-kernel
Hi Lee,
Thanks for your reply.
On 03/09/2018 04:16 PM, Lee Jones wrote:
>> >
>> >Jeffy Chen (4):
>> > mfd: syscon: Set name of regmap_config
>> > rtc: at91sam9: Set name of regmap_config
>> > clk: lpc32xx: Set name of regmap_config
>> > ARM: rockchip: Set name of regmap_config
>> >
>> > arch/arm/mach-rockchip/platsmp.c | 1 +
>> > drivers/clk/nxp/clk-lpc32xx.c | 1 +
>> > drivers/mfd/syscon.c | 1 +
> It's difficult to review, since we cannot see what's happening with
> the rest of the patch set. Would you mind re-sending the whole set to
> all parties please?
sure, i can do that :)
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v4 0/4] Set name of regmap_config
@ 2018-03-09 8:45 ` JeffyChen
0 siblings, 0 replies; 14+ messages in thread
From: JeffyChen @ 2018-03-09 8:45 UTC (permalink / raw)
To: linux-arm-kernel
Hi Lee,
Thanks for your reply.
On 03/09/2018 04:16 PM, Lee Jones wrote:
>> >
>> >Jeffy Chen (4):
>> > mfd: syscon: Set name of regmap_config
>> > rtc: at91sam9: Set name of regmap_config
>> > clk: lpc32xx: Set name of regmap_config
>> > ARM: rockchip: Set name of regmap_config
>> >
>> > arch/arm/mach-rockchip/platsmp.c | 1 +
>> > drivers/clk/nxp/clk-lpc32xx.c | 1 +
>> > drivers/mfd/syscon.c | 1 +
> It's difficult to review, since we cannot see what's happening with
> the rest of the patch set. Would you mind re-sending the whole set to
> all parties please?
sure, i can do that :)
>
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2018-03-09 8:46 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-09 1:51 [PATCH v4 0/4] Set name of regmap_config Jeffy Chen
2018-03-09 1:51 ` Jeffy Chen
2018-03-09 1:51 ` [PATCH v4 1/4] mfd: syscon: " Jeffy Chen
2018-03-09 8:15 ` Lee Jones
2018-03-09 1:51 ` [PATCH v4 2/4] rtc: at91sam9: " Jeffy Chen
2018-03-09 1:51 ` Jeffy Chen
2018-03-09 1:51 ` [PATCH v4 3/4] clk: lpc32xx: " Jeffy Chen
2018-03-09 1:51 ` Jeffy Chen
2018-03-09 1:51 ` [PATCH v4 4/4] ARM: rockchip: " Jeffy Chen
2018-03-09 1:51 ` Jeffy Chen
2018-03-09 8:16 ` [PATCH v4 0/4] " Lee Jones
2018-03-09 8:16 ` Lee Jones
2018-03-09 8:45 ` JeffyChen
2018-03-09 8:45 ` JeffyChen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.