All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Bai Ping <ping.bai@nxp.com>
Cc: sboyd@kernel.org, robh+dt@kernel.org, kernel@pengutronix.de,
	fabio.estevam@nxp.com, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	aisheng.dong@nxp.com, jacky.baip@gmail.com
Subject: Re: [PATCH v4 4/4] driver: clk: imx: add clock driver for imx6sll
Date: Fri, 9 Mar 2018 10:45:14 +0800	[thread overview]
Message-ID: <20180309024513.GE3217@dragon> (raw)
In-Reply-To: <1520502445-22576-4-git-send-email-ping.bai@nxp.com>

On Thu, Mar 08, 2018 at 05:47:25PM +0800, Bai Ping wrote:
> diff --git a/drivers/clk/imx/clk-imx6sll.c b/drivers/clk/imx/clk-imx6sll.c
> new file mode 100644
> index 0000000..e938db5
> --- /dev/null
> +++ b/drivers/clk/imx/clk-imx6sll.c
> @@ -0,0 +1,344 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2016 Freescale Semiconductor, Inc.
> + * Copyright 2017-2018 NXP.
> + */
> +
> +#include <dt-bindings/clock/imx6sll-clock.h>
> +#include <linux/clk.h>
> +#include <linux/clkdev.h>
> +#include <linux/err.h>
> +#include <linux/init.h>
> +#include <linux/io.h>
> +#include <linux/of.h>
> +#include <linux/of_address.h>
> +#include <linux/of_irq.h>
> +#include <linux/types.h>
> +
> +#include "clk.h"
> +
> +#define CCM_ANALOG_PLL_BYPASS		(0x1 << 16)
> +#define BM_CCM_CCDR_MMDC_CH0_MASK	(0x2 << 16)
> +#define CCDR				0x4

We agreed to remove this define, right?

Shawn

> +#define xPLL_CLR(offset)		(offset + 0x8)

WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/4] driver: clk: imx: add clock driver for imx6sll
Date: Fri, 9 Mar 2018 10:45:14 +0800	[thread overview]
Message-ID: <20180309024513.GE3217@dragon> (raw)
In-Reply-To: <1520502445-22576-4-git-send-email-ping.bai@nxp.com>

On Thu, Mar 08, 2018 at 05:47:25PM +0800, Bai Ping wrote:
> diff --git a/drivers/clk/imx/clk-imx6sll.c b/drivers/clk/imx/clk-imx6sll.c
> new file mode 100644
> index 0000000..e938db5
> --- /dev/null
> +++ b/drivers/clk/imx/clk-imx6sll.c
> @@ -0,0 +1,344 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2016 Freescale Semiconductor, Inc.
> + * Copyright 2017-2018 NXP.
> + */
> +
> +#include <dt-bindings/clock/imx6sll-clock.h>
> +#include <linux/clk.h>
> +#include <linux/clkdev.h>
> +#include <linux/err.h>
> +#include <linux/init.h>
> +#include <linux/io.h>
> +#include <linux/of.h>
> +#include <linux/of_address.h>
> +#include <linux/of_irq.h>
> +#include <linux/types.h>
> +
> +#include "clk.h"
> +
> +#define CCM_ANALOG_PLL_BYPASS		(0x1 << 16)
> +#define BM_CCM_CCDR_MMDC_CH0_MASK	(0x2 << 16)
> +#define CCDR				0x4

We agreed to remove this define, right?

Shawn

> +#define xPLL_CLR(offset)		(offset + 0x8)

  reply	other threads:[~2018-03-09  2:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08  9:47 [PATCH v4 1/4] driver: clk: imx: Add CLK_IS_CRITICAL flag for busy divider and busy mux Bai Ping
2018-03-08  9:47 ` Bai Ping
2018-03-08  9:47 ` [PATCH v4 2/4] driver: clk: imx: add new gate/gate2 wrapper funtion Bai Ping
2018-03-08  9:47   ` Bai Ping
2018-03-08  9:47 ` [PATCH v4 3/4] Document: dt: binding: imx: update clock doc for imx6sll Bai Ping
2018-03-08  9:47   ` Bai Ping
2018-03-08  9:47 ` [PATCH v4 4/4] driver: clk: imx: add clock driver " Bai Ping
2018-03-08  9:47   ` Bai Ping
2018-03-09  2:45   ` Shawn Guo [this message]
2018-03-09  2:45     ` Shawn Guo
2018-03-09  5:01     ` Jacky Bai
2018-03-09  5:01       ` Jacky Bai
2018-03-09  2:31 ` [PATCH v4 1/4] driver: clk: imx: Add CLK_IS_CRITICAL flag for busy divider and busy mux Shawn Guo
2018-03-09  2:31   ` Shawn Guo
2018-03-09  5:00   ` Jacky Bai
2018-03-09  5:00     ` Jacky Bai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180309024513.GE3217@dragon \
    --to=shawnguo@kernel.org \
    --cc=aisheng.dong@nxp.com \
    --cc=fabio.estevam@nxp.com \
    --cc=jacky.baip@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.