* [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint
@ 2018-02-09 14:15 Wanpeng Li
2018-02-09 14:31 ` Eduardo Habkost
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Wanpeng Li @ 2018-02-09 14:15 UTC (permalink / raw)
To: linux-kernel, kvm
Cc: Paolo Bonzini, Radim Krčmář,
Peter Zijlstra, Eduardo Habkost
From: Wanpeng Li <wanpengli@tencent.com>
Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit
to determine if they run on dedicated vCPUs, allowing optimizations such
as usage of qspinlocks.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Radim Krčmář <rkrcmar@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
---
v1 -> v2:
* add a new feature word
target/i386/cpu.c | 14 ++++++++++++++
target/i386/cpu.h | 3 +++
target/i386/kvm.c | 4 ++++
3 files changed, 21 insertions(+)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index d70954b..e2974ad 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -358,6 +358,20 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
.cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EAX,
.tcg_features = TCG_KVM_FEATURES,
},
+ [FEAT_KVM_HINTS] = {
+ .feat_names = {
+ "hint-dedicated", NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL,
+ },
+ .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EDX,
+ .tcg_features = TCG_KVM_FEATURES,
+ },
[FEAT_HYPERV_EAX] = {
.feat_names = {
NULL /* hv_msr_vp_runtime_access */, NULL /* hv_msr_time_refcount_access */,
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index f91e37d..9f73692 100644
--- a/target/i386/cpu.h
+++ b/target/i386/cpu.h
@@ -475,6 +475,7 @@ typedef enum FeatureWord {
FEAT_8000_0008_EBX, /* CPUID[8000_0008].EBX */
FEAT_C000_0001_EDX, /* CPUID[C000_0001].EDX */
FEAT_KVM, /* CPUID[4000_0001].EAX (KVM_CPUID_FEATURES) */
+ FEAT_KVM_HINTS, /* CPUID[4000_0001].EDX */
FEAT_HYPERV_EAX, /* CPUID[4000_0003].EAX */
FEAT_HYPERV_EBX, /* CPUID[4000_0003].EBX */
FEAT_HYPERV_EDX, /* CPUID[4000_0003].EDX */
@@ -670,6 +671,8 @@ typedef uint32_t FeatureWordArray[FEATURE_WORDS];
#define CPUID_7_0_EDX_AVX512_4FMAPS (1U << 3) /* AVX512 Multiply Accumulation Single Precision */
#define CPUID_7_0_EDX_SPEC_CTRL (1U << 26) /* Speculation Control */
+#define KVM_HINTS_DEDICATED (1U << 0)
+
#define CPUID_8000_0008_EBX_IBPB (1U << 12) /* Indirect Branch Prediction Barrier */
#define CPUID_XSAVE_XSAVEOPT (1U << 0)
diff --git a/target/i386/kvm.c b/target/i386/kvm.c
index ad4b159..44ee524 100644
--- a/target/i386/kvm.c
+++ b/target/i386/kvm.c
@@ -383,6 +383,9 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function,
if (!kvm_irqchip_in_kernel()) {
ret &= ~(1U << KVM_FEATURE_PV_UNHALT);
}
+ } else if (function == KVM_CPUID_FEATURES && reg == R_EDX) {
+ ret |= KVM_HINTS_DEDICATED;
+ found = 1;
}
/* fallback for older kernels */
@@ -801,6 +804,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
c = &cpuid_data.entries[cpuid_i++];
c->function = KVM_CPUID_FEATURES | kvm_base;
c->eax = env->features[FEAT_KVM];
+ c->edx = env->features[FEAT_KVM_HINTS];
}
cpu_x86_cpuid(env, 0, 0, &limit, &unused, &unused, &unused);
--
2.7.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint
2018-02-09 14:15 [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint Wanpeng Li
@ 2018-02-09 14:31 ` Eduardo Habkost
2018-02-09 14:52 ` [Qemu-devel] " Wanpeng Li
2018-02-28 12:31 ` [Qemu-devel] " Wanpeng Li
2018-03-09 14:16 ` Eduardo Habkost
2 siblings, 1 reply; 14+ messages in thread
From: Eduardo Habkost @ 2018-02-09 14:31 UTC (permalink / raw)
To: Wanpeng Li
Cc: linux-kernel, kvm, Paolo Bonzini, Radim Krčmář,
Peter Zijlstra
On Fri, Feb 09, 2018 at 06:15:25AM -0800, Wanpeng Li wrote:
> From: Wanpeng Li <wanpengli@tencent.com>
>
> Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit
> to determine if they run on dedicated vCPUs, allowing optimizations such
> as usage of qspinlocks.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
[...]
> + [FEAT_KVM_HINTS] = {
> + .feat_names = {
> + "hint-dedicated", NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + },
> + .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EDX,
> + .tcg_features = TCG_KVM_FEATURES,
> + },
Do you have a pointer to the KVM patch that adds this bit to
Documentation/virtual/kvm/cpuid.txt? I would like to wait until
the KVM CPUID docs are updated before applying the patch to QEMU.
--
Eduardo
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint
2018-02-09 14:31 ` Eduardo Habkost
@ 2018-02-09 14:52 ` Wanpeng Li
0 siblings, 0 replies; 14+ messages in thread
From: Wanpeng Li @ 2018-02-09 14:52 UTC (permalink / raw)
To: Eduardo Habkost
Cc: kvm, Paolo Bonzini, Radim Krčmář,
qemu-devel@nongnu.org Developers
2018-02-09 22:31 GMT+08:00 Eduardo Habkost <ehabkost@redhat.com>:
> On Fri, Feb 09, 2018 at 06:15:25AM -0800, Wanpeng Li wrote:
>> From: Wanpeng Li <wanpengli@tencent.com>
>>
>> Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit
>> to determine if they run on dedicated vCPUs, allowing optimizations such
>> as usage of qspinlocks.
>>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Radim Krčmář <rkrcmar@redhat.com>
>> Cc: Eduardo Habkost <ehabkost@redhat.com>
>> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> [...]
>> + [FEAT_KVM_HINTS] = {
>> + .feat_names = {
>> + "hint-dedicated", NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + },
>> + .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EDX,
>> + .tcg_features = TCG_KVM_FEATURES,
>> + },
>
> Do you have a pointer to the KVM patch that adds this bit to
> Documentation/virtual/kvm/cpuid.txt? I would like to wait until
> the KVM CPUID docs are updated before applying the patch to QEMU.
Yeah, please refer to https://lkml.org/lkml/2018/2/9/476
Regards,
Wanpeng Li
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint
@ 2018-02-09 14:52 ` Wanpeng Li
0 siblings, 0 replies; 14+ messages in thread
From: Wanpeng Li @ 2018-02-09 14:52 UTC (permalink / raw)
To: Eduardo Habkost
Cc: kvm, Paolo Bonzini, Radim Krčmář,
qemu-devel@nongnu.org Developers
2018-02-09 22:31 GMT+08:00 Eduardo Habkost <ehabkost@redhat.com>:
> On Fri, Feb 09, 2018 at 06:15:25AM -0800, Wanpeng Li wrote:
>> From: Wanpeng Li <wanpengli@tencent.com>
>>
>> Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit
>> to determine if they run on dedicated vCPUs, allowing optimizations such
>> as usage of qspinlocks.
>>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Radim Krčmář <rkrcmar@redhat.com>
>> Cc: Eduardo Habkost <ehabkost@redhat.com>
>> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> [...]
>> + [FEAT_KVM_HINTS] = {
>> + .feat_names = {
>> + "hint-dedicated", NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + },
>> + .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EDX,
>> + .tcg_features = TCG_KVM_FEATURES,
>> + },
>
> Do you have a pointer to the KVM patch that adds this bit to
> Documentation/virtual/kvm/cpuid.txt? I would like to wait until
> the KVM CPUID docs are updated before applying the patch to QEMU.
Yeah, please refer to https://lkml.org/lkml/2018/2/9/476
Regards,
Wanpeng Li
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint
2018-02-09 14:15 [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint Wanpeng Li
@ 2018-02-28 12:31 ` Wanpeng Li
2018-02-28 12:31 ` [Qemu-devel] " Wanpeng Li
2018-03-09 14:16 ` Eduardo Habkost
2 siblings, 0 replies; 14+ messages in thread
From: Wanpeng Li @ 2018-02-28 12:31 UTC (permalink / raw)
To: kvm, qemu-devel@nongnu.org Developers
Cc: Paolo Bonzini, Eduardo Habkost, Radim Krčmář
Ping,
2018-02-09 22:15 GMT+08:00 Wanpeng Li <kernellwp@gmail.com>:
> From: Wanpeng Li <wanpengli@tencent.com>
>
> Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit
> to determine if they run on dedicated vCPUs, allowing optimizations such
> as usage of qspinlocks.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> ---
> v1 -> v2:
> * add a new feature word
>
> target/i386/cpu.c | 14 ++++++++++++++
> target/i386/cpu.h | 3 +++
> target/i386/kvm.c | 4 ++++
> 3 files changed, 21 insertions(+)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index d70954b..e2974ad 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -358,6 +358,20 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
> .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EAX,
> .tcg_features = TCG_KVM_FEATURES,
> },
> + [FEAT_KVM_HINTS] = {
> + .feat_names = {
> + "hint-dedicated", NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + },
> + .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EDX,
> + .tcg_features = TCG_KVM_FEATURES,
> + },
> [FEAT_HYPERV_EAX] = {
> .feat_names = {
> NULL /* hv_msr_vp_runtime_access */, NULL /* hv_msr_time_refcount_access */,
> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
> index f91e37d..9f73692 100644
> --- a/target/i386/cpu.h
> +++ b/target/i386/cpu.h
> @@ -475,6 +475,7 @@ typedef enum FeatureWord {
> FEAT_8000_0008_EBX, /* CPUID[8000_0008].EBX */
> FEAT_C000_0001_EDX, /* CPUID[C000_0001].EDX */
> FEAT_KVM, /* CPUID[4000_0001].EAX (KVM_CPUID_FEATURES) */
> + FEAT_KVM_HINTS, /* CPUID[4000_0001].EDX */
> FEAT_HYPERV_EAX, /* CPUID[4000_0003].EAX */
> FEAT_HYPERV_EBX, /* CPUID[4000_0003].EBX */
> FEAT_HYPERV_EDX, /* CPUID[4000_0003].EDX */
> @@ -670,6 +671,8 @@ typedef uint32_t FeatureWordArray[FEATURE_WORDS];
> #define CPUID_7_0_EDX_AVX512_4FMAPS (1U << 3) /* AVX512 Multiply Accumulation Single Precision */
> #define CPUID_7_0_EDX_SPEC_CTRL (1U << 26) /* Speculation Control */
>
> +#define KVM_HINTS_DEDICATED (1U << 0)
> +
> #define CPUID_8000_0008_EBX_IBPB (1U << 12) /* Indirect Branch Prediction Barrier */
>
> #define CPUID_XSAVE_XSAVEOPT (1U << 0)
> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
> index ad4b159..44ee524 100644
> --- a/target/i386/kvm.c
> +++ b/target/i386/kvm.c
> @@ -383,6 +383,9 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function,
> if (!kvm_irqchip_in_kernel()) {
> ret &= ~(1U << KVM_FEATURE_PV_UNHALT);
> }
> + } else if (function == KVM_CPUID_FEATURES && reg == R_EDX) {
> + ret |= KVM_HINTS_DEDICATED;
> + found = 1;
> }
>
> /* fallback for older kernels */
> @@ -801,6 +804,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
> c = &cpuid_data.entries[cpuid_i++];
> c->function = KVM_CPUID_FEATURES | kvm_base;
> c->eax = env->features[FEAT_KVM];
> + c->edx = env->features[FEAT_KVM_HINTS];
> }
>
> cpu_x86_cpuid(env, 0, 0, &limit, &unused, &unused, &unused);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint
@ 2018-02-28 12:31 ` Wanpeng Li
0 siblings, 0 replies; 14+ messages in thread
From: Wanpeng Li @ 2018-02-28 12:31 UTC (permalink / raw)
To: kvm, qemu-devel@nongnu.org Developers
Cc: Paolo Bonzini, Radim Krčmář, Eduardo Habkost
Ping,
2018-02-09 22:15 GMT+08:00 Wanpeng Li <kernellwp@gmail.com>:
> From: Wanpeng Li <wanpengli@tencent.com>
>
> Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit
> to determine if they run on dedicated vCPUs, allowing optimizations such
> as usage of qspinlocks.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> ---
> v1 -> v2:
> * add a new feature word
>
> target/i386/cpu.c | 14 ++++++++++++++
> target/i386/cpu.h | 3 +++
> target/i386/kvm.c | 4 ++++
> 3 files changed, 21 insertions(+)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index d70954b..e2974ad 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -358,6 +358,20 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
> .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EAX,
> .tcg_features = TCG_KVM_FEATURES,
> },
> + [FEAT_KVM_HINTS] = {
> + .feat_names = {
> + "hint-dedicated", NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + },
> + .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EDX,
> + .tcg_features = TCG_KVM_FEATURES,
> + },
> [FEAT_HYPERV_EAX] = {
> .feat_names = {
> NULL /* hv_msr_vp_runtime_access */, NULL /* hv_msr_time_refcount_access */,
> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
> index f91e37d..9f73692 100644
> --- a/target/i386/cpu.h
> +++ b/target/i386/cpu.h
> @@ -475,6 +475,7 @@ typedef enum FeatureWord {
> FEAT_8000_0008_EBX, /* CPUID[8000_0008].EBX */
> FEAT_C000_0001_EDX, /* CPUID[C000_0001].EDX */
> FEAT_KVM, /* CPUID[4000_0001].EAX (KVM_CPUID_FEATURES) */
> + FEAT_KVM_HINTS, /* CPUID[4000_0001].EDX */
> FEAT_HYPERV_EAX, /* CPUID[4000_0003].EAX */
> FEAT_HYPERV_EBX, /* CPUID[4000_0003].EBX */
> FEAT_HYPERV_EDX, /* CPUID[4000_0003].EDX */
> @@ -670,6 +671,8 @@ typedef uint32_t FeatureWordArray[FEATURE_WORDS];
> #define CPUID_7_0_EDX_AVX512_4FMAPS (1U << 3) /* AVX512 Multiply Accumulation Single Precision */
> #define CPUID_7_0_EDX_SPEC_CTRL (1U << 26) /* Speculation Control */
>
> +#define KVM_HINTS_DEDICATED (1U << 0)
> +
> #define CPUID_8000_0008_EBX_IBPB (1U << 12) /* Indirect Branch Prediction Barrier */
>
> #define CPUID_XSAVE_XSAVEOPT (1U << 0)
> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
> index ad4b159..44ee524 100644
> --- a/target/i386/kvm.c
> +++ b/target/i386/kvm.c
> @@ -383,6 +383,9 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function,
> if (!kvm_irqchip_in_kernel()) {
> ret &= ~(1U << KVM_FEATURE_PV_UNHALT);
> }
> + } else if (function == KVM_CPUID_FEATURES && reg == R_EDX) {
> + ret |= KVM_HINTS_DEDICATED;
> + found = 1;
> }
>
> /* fallback for older kernels */
> @@ -801,6 +804,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
> c = &cpuid_data.entries[cpuid_i++];
> c->function = KVM_CPUID_FEATURES | kvm_base;
> c->eax = env->features[FEAT_KVM];
> + c->edx = env->features[FEAT_KVM_HINTS];
> }
>
> cpu_x86_cpuid(env, 0, 0, &limit, &unused, &unused, &unused);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint
2018-02-28 12:31 ` [Qemu-devel] " Wanpeng Li
@ 2018-02-28 15:05 ` Paolo Bonzini
-1 siblings, 0 replies; 14+ messages in thread
From: Paolo Bonzini @ 2018-02-28 15:05 UTC (permalink / raw)
To: Wanpeng Li, kvm, qemu-devel@nongnu.org Developers
Cc: Eduardo Habkost, Radim Krčmář
On 28/02/2018 13:31, Wanpeng Li wrote:
> Ping,
> 2018-02-09 22:15 GMT+08:00 Wanpeng Li <kernellwp@gmail.com>:
>> From: Wanpeng Li <wanpengli@tencent.com>
>>
>> Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit
>> to determine if they run on dedicated vCPUs, allowing optimizations such
>> as usage of qspinlocks.
Eduardo is still on vacation; the patch is okay but the KVM parts are
still in kvm/queue, so I'm just waiting for him (Radim owns the KVM tree
right now). Feel free to post any patch on top of it. You can add
Based-on: <1518185725-69559-1-git-send-email-wanpengli@tencent.com>
when you post anything needing KVM_HINTS_DEDICATED, that way patchew can
apply your series and test it correctly.
Thanks,
Paolo
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Radim Krčmář <rkrcmar@redhat.com>
>> Cc: Eduardo Habkost <ehabkost@redhat.com>
>> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
>> ---
>> v1 -> v2:
>> * add a new feature word
>>
>> target/i386/cpu.c | 14 ++++++++++++++
>> target/i386/cpu.h | 3 +++
>> target/i386/kvm.c | 4 ++++
>> 3 files changed, 21 insertions(+)
>>
>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> index d70954b..e2974ad 100644
>> --- a/target/i386/cpu.c
>> +++ b/target/i386/cpu.c
>> @@ -358,6 +358,20 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
>> .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EAX,
>> .tcg_features = TCG_KVM_FEATURES,
>> },
>> + [FEAT_KVM_HINTS] = {
>> + .feat_names = {
>> + "hint-dedicated", NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + },
>> + .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EDX,
>> + .tcg_features = TCG_KVM_FEATURES,
>> + },
>> [FEAT_HYPERV_EAX] = {
>> .feat_names = {
>> NULL /* hv_msr_vp_runtime_access */, NULL /* hv_msr_time_refcount_access */,
>> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
>> index f91e37d..9f73692 100644
>> --- a/target/i386/cpu.h
>> +++ b/target/i386/cpu.h
>> @@ -475,6 +475,7 @@ typedef enum FeatureWord {
>> FEAT_8000_0008_EBX, /* CPUID[8000_0008].EBX */
>> FEAT_C000_0001_EDX, /* CPUID[C000_0001].EDX */
>> FEAT_KVM, /* CPUID[4000_0001].EAX (KVM_CPUID_FEATURES) */
>> + FEAT_KVM_HINTS, /* CPUID[4000_0001].EDX */
>> FEAT_HYPERV_EAX, /* CPUID[4000_0003].EAX */
>> FEAT_HYPERV_EBX, /* CPUID[4000_0003].EBX */
>> FEAT_HYPERV_EDX, /* CPUID[4000_0003].EDX */
>> @@ -670,6 +671,8 @@ typedef uint32_t FeatureWordArray[FEATURE_WORDS];
>> #define CPUID_7_0_EDX_AVX512_4FMAPS (1U << 3) /* AVX512 Multiply Accumulation Single Precision */
>> #define CPUID_7_0_EDX_SPEC_CTRL (1U << 26) /* Speculation Control */
>>
>> +#define KVM_HINTS_DEDICATED (1U << 0)
>> +
>> #define CPUID_8000_0008_EBX_IBPB (1U << 12) /* Indirect Branch Prediction Barrier */
>>
>> #define CPUID_XSAVE_XSAVEOPT (1U << 0)
>> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
>> index ad4b159..44ee524 100644
>> --- a/target/i386/kvm.c
>> +++ b/target/i386/kvm.c
>> @@ -383,6 +383,9 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function,
>> if (!kvm_irqchip_in_kernel()) {
>> ret &= ~(1U << KVM_FEATURE_PV_UNHALT);
>> }
>> + } else if (function == KVM_CPUID_FEATURES && reg == R_EDX) {
>> + ret |= KVM_HINTS_DEDICATED;
>> + found = 1;
>> }
>>
>> /* fallback for older kernels */
>> @@ -801,6 +804,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
>> c = &cpuid_data.entries[cpuid_i++];
>> c->function = KVM_CPUID_FEATURES | kvm_base;
>> c->eax = env->features[FEAT_KVM];
>> + c->edx = env->features[FEAT_KVM_HINTS];
>> }
>>
>> cpu_x86_cpuid(env, 0, 0, &limit, &unused, &unused, &unused);
>> --
>> 2.7.4
>>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint
@ 2018-02-28 15:05 ` Paolo Bonzini
0 siblings, 0 replies; 14+ messages in thread
From: Paolo Bonzini @ 2018-02-28 15:05 UTC (permalink / raw)
To: Wanpeng Li, kvm, qemu-devel@nongnu.org Developers
Cc: Radim Krčmář, Eduardo Habkost
On 28/02/2018 13:31, Wanpeng Li wrote:
> Ping,
> 2018-02-09 22:15 GMT+08:00 Wanpeng Li <kernellwp@gmail.com>:
>> From: Wanpeng Li <wanpengli@tencent.com>
>>
>> Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit
>> to determine if they run on dedicated vCPUs, allowing optimizations such
>> as usage of qspinlocks.
Eduardo is still on vacation; the patch is okay but the KVM parts are
still in kvm/queue, so I'm just waiting for him (Radim owns the KVM tree
right now). Feel free to post any patch on top of it. You can add
Based-on: <1518185725-69559-1-git-send-email-wanpengli@tencent.com>
when you post anything needing KVM_HINTS_DEDICATED, that way patchew can
apply your series and test it correctly.
Thanks,
Paolo
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Radim Krčmář <rkrcmar@redhat.com>
>> Cc: Eduardo Habkost <ehabkost@redhat.com>
>> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
>> ---
>> v1 -> v2:
>> * add a new feature word
>>
>> target/i386/cpu.c | 14 ++++++++++++++
>> target/i386/cpu.h | 3 +++
>> target/i386/kvm.c | 4 ++++
>> 3 files changed, 21 insertions(+)
>>
>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> index d70954b..e2974ad 100644
>> --- a/target/i386/cpu.c
>> +++ b/target/i386/cpu.c
>> @@ -358,6 +358,20 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
>> .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EAX,
>> .tcg_features = TCG_KVM_FEATURES,
>> },
>> + [FEAT_KVM_HINTS] = {
>> + .feat_names = {
>> + "hint-dedicated", NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + },
>> + .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EDX,
>> + .tcg_features = TCG_KVM_FEATURES,
>> + },
>> [FEAT_HYPERV_EAX] = {
>> .feat_names = {
>> NULL /* hv_msr_vp_runtime_access */, NULL /* hv_msr_time_refcount_access */,
>> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
>> index f91e37d..9f73692 100644
>> --- a/target/i386/cpu.h
>> +++ b/target/i386/cpu.h
>> @@ -475,6 +475,7 @@ typedef enum FeatureWord {
>> FEAT_8000_0008_EBX, /* CPUID[8000_0008].EBX */
>> FEAT_C000_0001_EDX, /* CPUID[C000_0001].EDX */
>> FEAT_KVM, /* CPUID[4000_0001].EAX (KVM_CPUID_FEATURES) */
>> + FEAT_KVM_HINTS, /* CPUID[4000_0001].EDX */
>> FEAT_HYPERV_EAX, /* CPUID[4000_0003].EAX */
>> FEAT_HYPERV_EBX, /* CPUID[4000_0003].EBX */
>> FEAT_HYPERV_EDX, /* CPUID[4000_0003].EDX */
>> @@ -670,6 +671,8 @@ typedef uint32_t FeatureWordArray[FEATURE_WORDS];
>> #define CPUID_7_0_EDX_AVX512_4FMAPS (1U << 3) /* AVX512 Multiply Accumulation Single Precision */
>> #define CPUID_7_0_EDX_SPEC_CTRL (1U << 26) /* Speculation Control */
>>
>> +#define KVM_HINTS_DEDICATED (1U << 0)
>> +
>> #define CPUID_8000_0008_EBX_IBPB (1U << 12) /* Indirect Branch Prediction Barrier */
>>
>> #define CPUID_XSAVE_XSAVEOPT (1U << 0)
>> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
>> index ad4b159..44ee524 100644
>> --- a/target/i386/kvm.c
>> +++ b/target/i386/kvm.c
>> @@ -383,6 +383,9 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function,
>> if (!kvm_irqchip_in_kernel()) {
>> ret &= ~(1U << KVM_FEATURE_PV_UNHALT);
>> }
>> + } else if (function == KVM_CPUID_FEATURES && reg == R_EDX) {
>> + ret |= KVM_HINTS_DEDICATED;
>> + found = 1;
>> }
>>
>> /* fallback for older kernels */
>> @@ -801,6 +804,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
>> c = &cpuid_data.entries[cpuid_i++];
>> c->function = KVM_CPUID_FEATURES | kvm_base;
>> c->eax = env->features[FEAT_KVM];
>> + c->edx = env->features[FEAT_KVM_HINTS];
>> }
>>
>> cpu_x86_cpuid(env, 0, 0, &limit, &unused, &unused, &unused);
>> --
>> 2.7.4
>>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint
2018-02-09 14:15 [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint Wanpeng Li
2018-02-09 14:31 ` Eduardo Habkost
2018-02-28 12:31 ` [Qemu-devel] " Wanpeng Li
@ 2018-03-09 14:16 ` Eduardo Habkost
2018-03-10 1:43 ` [Qemu-devel] " Wanpeng Li
2018-04-10 9:13 ` Wanpeng Li
2 siblings, 2 replies; 14+ messages in thread
From: Eduardo Habkost @ 2018-03-09 14:16 UTC (permalink / raw)
To: Wanpeng Li
Cc: linux-kernel, kvm, Paolo Bonzini, Radim Krčmář,
Peter Zijlstra
On Fri, Feb 09, 2018 at 06:15:25AM -0800, Wanpeng Li wrote:
> From: Wanpeng Li <wanpengli@tencent.com>
>
> Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit
> to determine if they run on dedicated vCPUs, allowing optimizations such
> as usage of qspinlocks.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> ---
> v1 -> v2:
> * add a new feature word
>
> target/i386/cpu.c | 14 ++++++++++++++
> target/i386/cpu.h | 3 +++
> target/i386/kvm.c | 4 ++++
> 3 files changed, 21 insertions(+)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index d70954b..e2974ad 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -358,6 +358,20 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
> .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EAX,
> .tcg_features = TCG_KVM_FEATURES,
> },
> + [FEAT_KVM_HINTS] = {
> + .feat_names = {
> + "hint-dedicated", NULL, NULL, NULL,
I suggest naming it "kvm-hint-dedicated", to indicate it's
KVM-specific.
If there are no objections, I can rename it while applying.
With the rename:
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL,
> + },
> + .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EDX,
> + .tcg_features = TCG_KVM_FEATURES,
> + },
> [FEAT_HYPERV_EAX] = {
> .feat_names = {
> NULL /* hv_msr_vp_runtime_access */, NULL /* hv_msr_time_refcount_access */,
> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
> index f91e37d..9f73692 100644
> --- a/target/i386/cpu.h
> +++ b/target/i386/cpu.h
> @@ -475,6 +475,7 @@ typedef enum FeatureWord {
> FEAT_8000_0008_EBX, /* CPUID[8000_0008].EBX */
> FEAT_C000_0001_EDX, /* CPUID[C000_0001].EDX */
> FEAT_KVM, /* CPUID[4000_0001].EAX (KVM_CPUID_FEATURES) */
> + FEAT_KVM_HINTS, /* CPUID[4000_0001].EDX */
> FEAT_HYPERV_EAX, /* CPUID[4000_0003].EAX */
> FEAT_HYPERV_EBX, /* CPUID[4000_0003].EBX */
> FEAT_HYPERV_EDX, /* CPUID[4000_0003].EDX */
> @@ -670,6 +671,8 @@ typedef uint32_t FeatureWordArray[FEATURE_WORDS];
> #define CPUID_7_0_EDX_AVX512_4FMAPS (1U << 3) /* AVX512 Multiply Accumulation Single Precision */
> #define CPUID_7_0_EDX_SPEC_CTRL (1U << 26) /* Speculation Control */
>
> +#define KVM_HINTS_DEDICATED (1U << 0)
> +
> #define CPUID_8000_0008_EBX_IBPB (1U << 12) /* Indirect Branch Prediction Barrier */
>
> #define CPUID_XSAVE_XSAVEOPT (1U << 0)
> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
> index ad4b159..44ee524 100644
> --- a/target/i386/kvm.c
> +++ b/target/i386/kvm.c
> @@ -383,6 +383,9 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function,
> if (!kvm_irqchip_in_kernel()) {
> ret &= ~(1U << KVM_FEATURE_PV_UNHALT);
> }
> + } else if (function == KVM_CPUID_FEATURES && reg == R_EDX) {
> + ret |= KVM_HINTS_DEDICATED;
> + found = 1;
> }
>
> /* fallback for older kernels */
> @@ -801,6 +804,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
> c = &cpuid_data.entries[cpuid_i++];
> c->function = KVM_CPUID_FEATURES | kvm_base;
> c->eax = env->features[FEAT_KVM];
> + c->edx = env->features[FEAT_KVM_HINTS];
> }
>
> cpu_x86_cpuid(env, 0, 0, &limit, &unused, &unused, &unused);
> --
> 2.7.4
>
--
Eduardo
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint
2018-03-09 14:16 ` Eduardo Habkost
@ 2018-03-10 1:43 ` Wanpeng Li
2018-04-10 9:13 ` Wanpeng Li
1 sibling, 0 replies; 14+ messages in thread
From: Wanpeng Li @ 2018-03-10 1:43 UTC (permalink / raw)
To: Eduardo Habkost
Cc: Peter Zijlstra, Paolo Bonzini, qemu-devel, kvm,
Radim Krčmář
2018-03-09 22:16 GMT+08:00 Eduardo Habkost <ehabkost@redhat.com>:
> On Fri, Feb 09, 2018 at 06:15:25AM -0800, Wanpeng Li wrote:
>> From: Wanpeng Li <wanpengli@tencent.com>
>>
>> Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit
>> to determine if they run on dedicated vCPUs, allowing optimizations such
>> as usage of qspinlocks.
>>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Radim Krčmář <rkrcmar@redhat.com>
>> Cc: Eduardo Habkost <ehabkost@redhat.com>
>> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
>> ---
>> v1 -> v2:
>> * add a new feature word
>>
>> target/i386/cpu.c | 14 ++++++++++++++
>> target/i386/cpu.h | 3 +++
>> target/i386/kvm.c | 4 ++++
>> 3 files changed, 21 insertions(+)
>>
>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> index d70954b..e2974ad 100644
>> --- a/target/i386/cpu.c
>> +++ b/target/i386/cpu.c
>> @@ -358,6 +358,20 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
>> .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EAX,
>> .tcg_features = TCG_KVM_FEATURES,
>> },
>> + [FEAT_KVM_HINTS] = {
>> + .feat_names = {
>> + "hint-dedicated", NULL, NULL, NULL,
>
> I suggest naming it "kvm-hint-dedicated", to indicate it's
> KVM-specific.
>
> If there are no objections, I can rename it while applying.
Looks good to me, thanks Eduardo.
Regards,
Wanpeng Li
>
> With the rename:
>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>
>
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + },
>> + .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EDX,
>> + .tcg_features = TCG_KVM_FEATURES,
>> + },
>> [FEAT_HYPERV_EAX] = {
>> .feat_names = {
>> NULL /* hv_msr_vp_runtime_access */, NULL /* hv_msr_time_refcount_access */,
>> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
>> index f91e37d..9f73692 100644
>> --- a/target/i386/cpu.h
>> +++ b/target/i386/cpu.h
>> @@ -475,6 +475,7 @@ typedef enum FeatureWord {
>> FEAT_8000_0008_EBX, /* CPUID[8000_0008].EBX */
>> FEAT_C000_0001_EDX, /* CPUID[C000_0001].EDX */
>> FEAT_KVM, /* CPUID[4000_0001].EAX (KVM_CPUID_FEATURES) */
>> + FEAT_KVM_HINTS, /* CPUID[4000_0001].EDX */
>> FEAT_HYPERV_EAX, /* CPUID[4000_0003].EAX */
>> FEAT_HYPERV_EBX, /* CPUID[4000_0003].EBX */
>> FEAT_HYPERV_EDX, /* CPUID[4000_0003].EDX */
>> @@ -670,6 +671,8 @@ typedef uint32_t FeatureWordArray[FEATURE_WORDS];
>> #define CPUID_7_0_EDX_AVX512_4FMAPS (1U << 3) /* AVX512 Multiply Accumulation Single Precision */
>> #define CPUID_7_0_EDX_SPEC_CTRL (1U << 26) /* Speculation Control */
>>
>> +#define KVM_HINTS_DEDICATED (1U << 0)
>> +
>> #define CPUID_8000_0008_EBX_IBPB (1U << 12) /* Indirect Branch Prediction Barrier */
>>
>> #define CPUID_XSAVE_XSAVEOPT (1U << 0)
>> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
>> index ad4b159..44ee524 100644
>> --- a/target/i386/kvm.c
>> +++ b/target/i386/kvm.c
>> @@ -383,6 +383,9 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function,
>> if (!kvm_irqchip_in_kernel()) {
>> ret &= ~(1U << KVM_FEATURE_PV_UNHALT);
>> }
>> + } else if (function == KVM_CPUID_FEATURES && reg == R_EDX) {
>> + ret |= KVM_HINTS_DEDICATED;
>> + found = 1;
>> }
>>
>> /* fallback for older kernels */
>> @@ -801,6 +804,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
>> c = &cpuid_data.entries[cpuid_i++];
>> c->function = KVM_CPUID_FEATURES | kvm_base;
>> c->eax = env->features[FEAT_KVM];
>> + c->edx = env->features[FEAT_KVM_HINTS];
>> }
>>
>> cpu_x86_cpuid(env, 0, 0, &limit, &unused, &unused, &unused);
>> --
>> 2.7.4
>>
>
> --
> Eduardo
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint
@ 2018-03-10 1:43 ` Wanpeng Li
0 siblings, 0 replies; 14+ messages in thread
From: Wanpeng Li @ 2018-03-10 1:43 UTC (permalink / raw)
To: Eduardo Habkost
Cc: kvm, Paolo Bonzini, Radim Krčmář,
Peter Zijlstra, qemu-devel
2018-03-09 22:16 GMT+08:00 Eduardo Habkost <ehabkost@redhat.com>:
> On Fri, Feb 09, 2018 at 06:15:25AM -0800, Wanpeng Li wrote:
>> From: Wanpeng Li <wanpengli@tencent.com>
>>
>> Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit
>> to determine if they run on dedicated vCPUs, allowing optimizations such
>> as usage of qspinlocks.
>>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Radim Krčmář <rkrcmar@redhat.com>
>> Cc: Eduardo Habkost <ehabkost@redhat.com>
>> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
>> ---
>> v1 -> v2:
>> * add a new feature word
>>
>> target/i386/cpu.c | 14 ++++++++++++++
>> target/i386/cpu.h | 3 +++
>> target/i386/kvm.c | 4 ++++
>> 3 files changed, 21 insertions(+)
>>
>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> index d70954b..e2974ad 100644
>> --- a/target/i386/cpu.c
>> +++ b/target/i386/cpu.c
>> @@ -358,6 +358,20 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
>> .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EAX,
>> .tcg_features = TCG_KVM_FEATURES,
>> },
>> + [FEAT_KVM_HINTS] = {
>> + .feat_names = {
>> + "hint-dedicated", NULL, NULL, NULL,
>
> I suggest naming it "kvm-hint-dedicated", to indicate it's
> KVM-specific.
>
> If there are no objections, I can rename it while applying.
Looks good to me, thanks Eduardo.
Regards,
Wanpeng Li
>
> With the rename:
>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>
>
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + },
>> + .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EDX,
>> + .tcg_features = TCG_KVM_FEATURES,
>> + },
>> [FEAT_HYPERV_EAX] = {
>> .feat_names = {
>> NULL /* hv_msr_vp_runtime_access */, NULL /* hv_msr_time_refcount_access */,
>> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
>> index f91e37d..9f73692 100644
>> --- a/target/i386/cpu.h
>> +++ b/target/i386/cpu.h
>> @@ -475,6 +475,7 @@ typedef enum FeatureWord {
>> FEAT_8000_0008_EBX, /* CPUID[8000_0008].EBX */
>> FEAT_C000_0001_EDX, /* CPUID[C000_0001].EDX */
>> FEAT_KVM, /* CPUID[4000_0001].EAX (KVM_CPUID_FEATURES) */
>> + FEAT_KVM_HINTS, /* CPUID[4000_0001].EDX */
>> FEAT_HYPERV_EAX, /* CPUID[4000_0003].EAX */
>> FEAT_HYPERV_EBX, /* CPUID[4000_0003].EBX */
>> FEAT_HYPERV_EDX, /* CPUID[4000_0003].EDX */
>> @@ -670,6 +671,8 @@ typedef uint32_t FeatureWordArray[FEATURE_WORDS];
>> #define CPUID_7_0_EDX_AVX512_4FMAPS (1U << 3) /* AVX512 Multiply Accumulation Single Precision */
>> #define CPUID_7_0_EDX_SPEC_CTRL (1U << 26) /* Speculation Control */
>>
>> +#define KVM_HINTS_DEDICATED (1U << 0)
>> +
>> #define CPUID_8000_0008_EBX_IBPB (1U << 12) /* Indirect Branch Prediction Barrier */
>>
>> #define CPUID_XSAVE_XSAVEOPT (1U << 0)
>> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
>> index ad4b159..44ee524 100644
>> --- a/target/i386/kvm.c
>> +++ b/target/i386/kvm.c
>> @@ -383,6 +383,9 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function,
>> if (!kvm_irqchip_in_kernel()) {
>> ret &= ~(1U << KVM_FEATURE_PV_UNHALT);
>> }
>> + } else if (function == KVM_CPUID_FEATURES && reg == R_EDX) {
>> + ret |= KVM_HINTS_DEDICATED;
>> + found = 1;
>> }
>>
>> /* fallback for older kernels */
>> @@ -801,6 +804,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
>> c = &cpuid_data.entries[cpuid_i++];
>> c->function = KVM_CPUID_FEATURES | kvm_base;
>> c->eax = env->features[FEAT_KVM];
>> + c->edx = env->features[FEAT_KVM_HINTS];
>> }
>>
>> cpu_x86_cpuid(env, 0, 0, &limit, &unused, &unused, &unused);
>> --
>> 2.7.4
>>
>
> --
> Eduardo
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint
2018-03-09 14:16 ` Eduardo Habkost
2018-03-10 1:43 ` [Qemu-devel] " Wanpeng Li
@ 2018-04-10 9:13 ` Wanpeng Li
2018-04-10 11:57 ` Eduardo Habkost
1 sibling, 1 reply; 14+ messages in thread
From: Wanpeng Li @ 2018-04-10 9:13 UTC (permalink / raw)
To: Eduardo Habkost
Cc: LKML, kvm, Paolo Bonzini, Radim Krčmář, Peter Zijlstra
Hi Eduardo,
2018-03-09 22:16 GMT+08:00 Eduardo Habkost <ehabkost@redhat.com>:
> On Fri, Feb 09, 2018 at 06:15:25AM -0800, Wanpeng Li wrote:
>> From: Wanpeng Li <wanpengli@tencent.com>
>>
>> Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit
>> to determine if they run on dedicated vCPUs, allowing optimizations such
>> as usage of qspinlocks.
>>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Radim Krčmář <rkrcmar@redhat.com>
>> Cc: Eduardo Habkost <ehabkost@redhat.com>
>> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
>> ---
>> v1 -> v2:
>> * add a new feature word
>>
>> target/i386/cpu.c | 14 ++++++++++++++
>> target/i386/cpu.h | 3 +++
>> target/i386/kvm.c | 4 ++++
>> 3 files changed, 21 insertions(+)
>>
>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> index d70954b..e2974ad 100644
>> --- a/target/i386/cpu.c
>> +++ b/target/i386/cpu.c
>> @@ -358,6 +358,20 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
>> .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EAX,
>> .tcg_features = TCG_KVM_FEATURES,
>> },
>> + [FEAT_KVM_HINTS] = {
>> + .feat_names = {
>> + "hint-dedicated", NULL, NULL, NULL,
>
> I suggest naming it "kvm-hint-dedicated", to indicate it's
> KVM-specific.
I found this feature is enabled by default w/o kvm-hint-dedicated
parameter, any idea how to make it disabled by default?
Regards,
Wanpeng Li
>
> If there are no objections, I can rename it while applying.
>
> With the rename:
>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>
>
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL,
>> + },
>> + .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EDX,
>> + .tcg_features = TCG_KVM_FEATURES,
>> + },
>> [FEAT_HYPERV_EAX] = {
>> .feat_names = {
>> NULL /* hv_msr_vp_runtime_access */, NULL /* hv_msr_time_refcount_access */,
>> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
>> index f91e37d..9f73692 100644
>> --- a/target/i386/cpu.h
>> +++ b/target/i386/cpu.h
>> @@ -475,6 +475,7 @@ typedef enum FeatureWord {
>> FEAT_8000_0008_EBX, /* CPUID[8000_0008].EBX */
>> FEAT_C000_0001_EDX, /* CPUID[C000_0001].EDX */
>> FEAT_KVM, /* CPUID[4000_0001].EAX (KVM_CPUID_FEATURES) */
>> + FEAT_KVM_HINTS, /* CPUID[4000_0001].EDX */
>> FEAT_HYPERV_EAX, /* CPUID[4000_0003].EAX */
>> FEAT_HYPERV_EBX, /* CPUID[4000_0003].EBX */
>> FEAT_HYPERV_EDX, /* CPUID[4000_0003].EDX */
>> @@ -670,6 +671,8 @@ typedef uint32_t FeatureWordArray[FEATURE_WORDS];
>> #define CPUID_7_0_EDX_AVX512_4FMAPS (1U << 3) /* AVX512 Multiply Accumulation Single Precision */
>> #define CPUID_7_0_EDX_SPEC_CTRL (1U << 26) /* Speculation Control */
>>
>> +#define KVM_HINTS_DEDICATED (1U << 0)
>> +
>> #define CPUID_8000_0008_EBX_IBPB (1U << 12) /* Indirect Branch Prediction Barrier */
>>
>> #define CPUID_XSAVE_XSAVEOPT (1U << 0)
>> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
>> index ad4b159..44ee524 100644
>> --- a/target/i386/kvm.c
>> +++ b/target/i386/kvm.c
>> @@ -383,6 +383,9 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function,
>> if (!kvm_irqchip_in_kernel()) {
>> ret &= ~(1U << KVM_FEATURE_PV_UNHALT);
>> }
>> + } else if (function == KVM_CPUID_FEATURES && reg == R_EDX) {
>> + ret |= KVM_HINTS_DEDICATED;
>> + found = 1;
>> }
>>
>> /* fallback for older kernels */
>> @@ -801,6 +804,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
>> c = &cpuid_data.entries[cpuid_i++];
>> c->function = KVM_CPUID_FEATURES | kvm_base;
>> c->eax = env->features[FEAT_KVM];
>> + c->edx = env->features[FEAT_KVM_HINTS];
>> }
>>
>> cpu_x86_cpuid(env, 0, 0, &limit, &unused, &unused, &unused);
>> --
>> 2.7.4
>>
>
> --
> Eduardo
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint
2018-04-10 9:13 ` Wanpeng Li
@ 2018-04-10 11:57 ` Eduardo Habkost
2018-04-10 12:04 ` Paolo Bonzini
0 siblings, 1 reply; 14+ messages in thread
From: Eduardo Habkost @ 2018-04-10 11:57 UTC (permalink / raw)
To: Wanpeng Li
Cc: LKML, kvm, Paolo Bonzini, Radim Krčmář, Peter Zijlstra
On Tue, Apr 10, 2018 at 05:13:21PM +0800, Wanpeng Li wrote:
> Hi Eduardo,
> 2018-03-09 22:16 GMT+08:00 Eduardo Habkost <ehabkost@redhat.com>:
> > On Fri, Feb 09, 2018 at 06:15:25AM -0800, Wanpeng Li wrote:
> >> From: Wanpeng Li <wanpengli@tencent.com>
> >>
> >> Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit
> >> to determine if they run on dedicated vCPUs, allowing optimizations such
> >> as usage of qspinlocks.
> >>
> >> Cc: Paolo Bonzini <pbonzini@redhat.com>
> >> Cc: Radim Krčmář <rkrcmar@redhat.com>
> >> Cc: Eduardo Habkost <ehabkost@redhat.com>
> >> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> >> ---
> >> v1 -> v2:
> >> * add a new feature word
> >>
> >> target/i386/cpu.c | 14 ++++++++++++++
> >> target/i386/cpu.h | 3 +++
> >> target/i386/kvm.c | 4 ++++
> >> 3 files changed, 21 insertions(+)
> >>
> >> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> >> index d70954b..e2974ad 100644
> >> --- a/target/i386/cpu.c
> >> +++ b/target/i386/cpu.c
> >> @@ -358,6 +358,20 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
> >> .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EAX,
> >> .tcg_features = TCG_KVM_FEATURES,
> >> },
> >> + [FEAT_KVM_HINTS] = {
> >> + .feat_names = {
> >> + "hint-dedicated", NULL, NULL, NULL,
> >
> > I suggest naming it "kvm-hint-dedicated", to indicate it's
> > KVM-specific.
>
> I found this feature is enabled by default w/o kvm-hint-dedicated
> parameter, any idea how to make it disabled by default?
You mean on "-cpu host", right?
The assumption in most of the code is that anything enabled on
GET_SUPPORTED_CPUID should be enabled on "-cpu host". This
shouldn't be the case for FEAT_KVM_HINTS.
Untested fix below.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target/i386/cpu.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 1a6b082b6f..a20fe26573 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -295,6 +295,8 @@ typedef struct FeatureWordInfo {
uint32_t tcg_features; /* Feature flags supported by TCG */
uint32_t unmigratable_flags; /* Feature flags known to be unmigratable */
uint32_t migratable_flags; /* Feature flags known to be migratable */
+ /* Features that shouldn't be auto-enabled by "-cpu host" */
+ uint32_t no_autoenable_flags;
} FeatureWordInfo;
static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
@@ -400,6 +402,11 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
},
.cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EDX,
.tcg_features = TCG_KVM_FEATURES,
+ /*
+ * KVM hints aren't auto-enabled by -cpu host, they need to be
+ * explicitly enabled in the command-line.
+ */
+ .no_autoenable_flags = ~0U,
},
[FEAT_HYPERV_EAX] = {
.feat_names = {
@@ -4062,7 +4069,8 @@ static void x86_cpu_expand_features(X86CPU *cpu, Error **errp)
*/
env->features[w] |=
x86_cpu_get_supported_feature_word(w, cpu->migratable) &
- ~env->user_features[w];
+ ~env->user_features[w] & \
+ ~feature_word_info[w].no_autoenable_flags;
}
}
--
2.14.3
--
Eduardo
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint
2018-04-10 11:57 ` Eduardo Habkost
@ 2018-04-10 12:04 ` Paolo Bonzini
0 siblings, 0 replies; 14+ messages in thread
From: Paolo Bonzini @ 2018-04-10 12:04 UTC (permalink / raw)
To: Eduardo Habkost, Wanpeng Li
Cc: LKML, kvm, Radim Krčmář, Peter Zijlstra
On 10/04/2018 13:57, Eduardo Habkost wrote:
> On Tue, Apr 10, 2018 at 05:13:21PM +0800, Wanpeng Li wrote:
>> Hi Eduardo,
>> 2018-03-09 22:16 GMT+08:00 Eduardo Habkost <ehabkost@redhat.com>:
>>> On Fri, Feb 09, 2018 at 06:15:25AM -0800, Wanpeng Li wrote:
>>>> From: Wanpeng Li <wanpengli@tencent.com>
>>>>
>>>> Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit
>>>> to determine if they run on dedicated vCPUs, allowing optimizations such
>>>> as usage of qspinlocks.
>>>>
>>>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>>> Cc: Radim Krčmář <rkrcmar@redhat.com>
>>>> Cc: Eduardo Habkost <ehabkost@redhat.com>
>>>> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
>>>> ---
>>>> v1 -> v2:
>>>> * add a new feature word
>>>>
>>>> target/i386/cpu.c | 14 ++++++++++++++
>>>> target/i386/cpu.h | 3 +++
>>>> target/i386/kvm.c | 4 ++++
>>>> 3 files changed, 21 insertions(+)
>>>>
>>>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>>>> index d70954b..e2974ad 100644
>>>> --- a/target/i386/cpu.c
>>>> +++ b/target/i386/cpu.c
>>>> @@ -358,6 +358,20 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
>>>> .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EAX,
>>>> .tcg_features = TCG_KVM_FEATURES,
>>>> },
>>>> + [FEAT_KVM_HINTS] = {
>>>> + .feat_names = {
>>>> + "hint-dedicated", NULL, NULL, NULL,
>>>
>>> I suggest naming it "kvm-hint-dedicated", to indicate it's
>>> KVM-specific.
>>
>> I found this feature is enabled by default w/o kvm-hint-dedicated
>> parameter, any idea how to make it disabled by default?
>
> You mean on "-cpu host", right?
>
> The assumption in most of the code is that anything enabled on
> GET_SUPPORTED_CPUID should be enabled on "-cpu host". This
> shouldn't be the case for FEAT_KVM_HINTS.
>
> Untested fix below.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> target/i386/cpu.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 1a6b082b6f..a20fe26573 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -295,6 +295,8 @@ typedef struct FeatureWordInfo {
> uint32_t tcg_features; /* Feature flags supported by TCG */
> uint32_t unmigratable_flags; /* Feature flags known to be unmigratable */
> uint32_t migratable_flags; /* Feature flags known to be migratable */
> + /* Features that shouldn't be auto-enabled by "-cpu host" */
> + uint32_t no_autoenable_flags;
> } FeatureWordInfo;
>
> static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
> @@ -400,6 +402,11 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
> },
> .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EDX,
> .tcg_features = TCG_KVM_FEATURES,
> + /*
> + * KVM hints aren't auto-enabled by -cpu host, they need to be
> + * explicitly enabled in the command-line.
> + */
> + .no_autoenable_flags = ~0U,
> },
> [FEAT_HYPERV_EAX] = {
> .feat_names = {
> @@ -4062,7 +4069,8 @@ static void x86_cpu_expand_features(X86CPU *cpu, Error **errp)
> */
> env->features[w] |=
> x86_cpu_get_supported_feature_word(w, cpu->migratable) &
> - ~env->user_features[w];
> + ~env->user_features[w] & \
> + ~feature_word_info[w].no_autoenable_flags;
> }
> }
>
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2018-04-10 12:04 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-09 14:15 [PATCH v2] target-i386: add KVM_HINTS_DEDICATED performance hint Wanpeng Li
2018-02-09 14:31 ` Eduardo Habkost
2018-02-09 14:52 ` Wanpeng Li
2018-02-09 14:52 ` [Qemu-devel] " Wanpeng Li
2018-02-28 12:31 ` Wanpeng Li
2018-02-28 12:31 ` [Qemu-devel] " Wanpeng Li
2018-02-28 15:05 ` Paolo Bonzini
2018-02-28 15:05 ` [Qemu-devel] " Paolo Bonzini
2018-03-09 14:16 ` Eduardo Habkost
2018-03-10 1:43 ` Wanpeng Li
2018-03-10 1:43 ` [Qemu-devel] " Wanpeng Li
2018-04-10 9:13 ` Wanpeng Li
2018-04-10 11:57 ` Eduardo Habkost
2018-04-10 12:04 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.