From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Wei Liu" <wei.liu2@citrix.com>,
"George Dunlap" <george.dunlap@eu.citrix.com>,
"Tim Deegan" <tim@xen.org>, Xen-devel <xen-devel@lists.xen.org>,
"Julien Grall" <julien.grall@arm.com>,
"Jan Beulich" <JBeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 7/7] xen/mm: Clean up share_xen_page_with_guest() API
Date: Fri, 9 Mar 2018 14:53:35 +0000 [thread overview]
Message-ID: <20180309145335.4d4zfq2ehgoldiya@citrix.com> (raw)
In-Reply-To: <1520601522-2886-8-git-send-email-andrew.cooper3@citrix.com>
On Fri, Mar 09, 2018 at 01:18:42PM +0000, Andrew Cooper wrote:
> The share_xen_page_with_guest() functions are used by common code, and are
> implemented the same by each arch. Move the declarations into the common mm.h
> rather than duplicating them in each arch/mm.h
>
> Turn an int readonly into a boolean enum, to retain ro/rw context at the
> callsites, but use shorter labels which avoids a large number of split lines.
>
> Implement share_xen_page_with_privileged_guests() as a static inline wrapper
> around share_xen_page_with_guest() to avoid having a call into a separate
> translation unit whose only purpose is to shuffle function arguments.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-09 14:53 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 13:18 [PATCH 0/7] xen: More assorted improvements to domain creation Andrew Cooper
2018-03-09 13:18 ` [PATCH 1/7] xen/domain: Drop DOMCRF_dummy Andrew Cooper
2018-03-09 14:12 ` Wei Liu
2018-03-09 16:46 ` Jan Beulich
2018-03-11 20:01 ` Julien Grall
2018-03-09 13:18 ` [PATCH 2/7] xen/domain: Drop all DOMCRF_* constants Andrew Cooper
2018-03-09 14:12 ` Wei Liu
2018-03-09 14:14 ` Andrew Cooper
2018-03-09 14:16 ` Wei Liu
2018-03-09 16:48 ` Jan Beulich
2018-03-11 20:02 ` Julien Grall
2018-03-09 13:18 ` [PATCH 3/7] RFC arm/domain: Reject invalid combinations of domain creation flags Andrew Cooper
2018-03-11 19:59 ` Julien Grall
2018-03-12 16:32 ` Wei Liu
2018-03-13 14:42 ` Julien Grall
2018-03-15 20:02 ` Andrew Cooper
2018-03-09 13:18 ` [PATCH 4/7] x86/domain: Remove unused parameters from {hvm, pv}_domain_initialise() Andrew Cooper
2018-03-09 14:13 ` Wei Liu
2018-03-09 16:49 ` Jan Beulich
2018-03-13 12:05 ` Roger Pau Monné
2018-03-15 20:09 ` Andrew Cooper
2018-03-16 10:58 ` Jan Beulich
2018-03-09 13:18 ` [PATCH 5/7] x86/domain: Optimise the order of actions in arch_domain_create() Andrew Cooper
2018-03-09 14:43 ` Wei Liu
2018-03-09 16:54 ` Jan Beulich
2018-03-15 20:15 ` Andrew Cooper
2018-03-16 7:40 ` Jan Beulich
2018-03-13 12:18 ` Roger Pau Monné
2018-03-09 13:18 ` [PATCH 6/7] xen/domain: Pass the full domctl_createdomain struct to create_domain() Andrew Cooper
2018-03-09 14:50 ` Wei Liu
2018-03-09 17:00 ` Jan Beulich
2018-03-09 17:06 ` Andrew Cooper
2018-03-12 12:57 ` Jan Beulich
2018-03-11 20:08 ` Julien Grall
2018-03-09 13:18 ` [PATCH 7/7] xen/mm: Clean up share_xen_page_with_guest() API Andrew Cooper
2018-03-09 14:53 ` Wei Liu [this message]
2018-03-11 20:29 ` Julien Grall
2018-03-13 12:28 ` Roger Pau Monné
2018-03-13 14:39 ` Jan Beulich
2018-03-15 20:25 ` Andrew Cooper
2018-03-16 7:43 ` Jan Beulich
2018-03-16 8:58 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309145335.4d4zfq2ehgoldiya@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.