From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xen.org>, WeiLiu <wei.liu2@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 4/7] x86/domain: Remove unused parameters from {hvm, pv}_domain_initialise()
Date: Fri, 16 Mar 2018 04:58:12 -0600 [thread overview]
Message-ID: <5AABB15402000078001B2ABB@prv-mh.provo.novell.com> (raw)
In-Reply-To: <19b24ce8-67ae-7cbd-a867-1f11799941d9@citrix.com>
>>> On 15.03.18 at 21:09, <andrew.cooper3@citrix.com> wrote:
> On 13/03/18 12:05, Roger Pau Monné wrote:
>> Maybe this could be:
>>
>> if ( is_idle_domain(d) )
>> ...
>> else
>> {
>> rc = is_hvm_domain(d) ? hvm_domain_initialise(d)
>> : pv_domain_initialise(d);
>> if ( rc )
>> goto fail;
>> }
>>
>> But that's maybe out of the scope of this patch.
>
> I'd actually like to reconsider our use of this design pattern.
>
> As far as I can tell from some XTF examples, it forces the use of a
> function pointer rather than an "if call else call" which in turn
> forcibly out-of-lines static inline stubs, and prevents LTO from merging
> a cross TU call into its sole caller.
Where's the function pointer coming from? I could see that happening
with
rc = (is_hvm_domain(d) ? hvm_domain_initialise
: pv_domain_initialise)(d);
which I think Roger has been using variants of in a few other
patches of his (and which I've been debating with myself whether
to comment on while reviewing those patches).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-16 10:58 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 13:18 [PATCH 0/7] xen: More assorted improvements to domain creation Andrew Cooper
2018-03-09 13:18 ` [PATCH 1/7] xen/domain: Drop DOMCRF_dummy Andrew Cooper
2018-03-09 14:12 ` Wei Liu
2018-03-09 16:46 ` Jan Beulich
2018-03-11 20:01 ` Julien Grall
2018-03-09 13:18 ` [PATCH 2/7] xen/domain: Drop all DOMCRF_* constants Andrew Cooper
2018-03-09 14:12 ` Wei Liu
2018-03-09 14:14 ` Andrew Cooper
2018-03-09 14:16 ` Wei Liu
2018-03-09 16:48 ` Jan Beulich
2018-03-11 20:02 ` Julien Grall
2018-03-09 13:18 ` [PATCH 3/7] RFC arm/domain: Reject invalid combinations of domain creation flags Andrew Cooper
2018-03-11 19:59 ` Julien Grall
2018-03-12 16:32 ` Wei Liu
2018-03-13 14:42 ` Julien Grall
2018-03-15 20:02 ` Andrew Cooper
2018-03-09 13:18 ` [PATCH 4/7] x86/domain: Remove unused parameters from {hvm, pv}_domain_initialise() Andrew Cooper
2018-03-09 14:13 ` Wei Liu
2018-03-09 16:49 ` Jan Beulich
2018-03-13 12:05 ` Roger Pau Monné
2018-03-15 20:09 ` Andrew Cooper
2018-03-16 10:58 ` Jan Beulich [this message]
2018-03-09 13:18 ` [PATCH 5/7] x86/domain: Optimise the order of actions in arch_domain_create() Andrew Cooper
2018-03-09 14:43 ` Wei Liu
2018-03-09 16:54 ` Jan Beulich
2018-03-15 20:15 ` Andrew Cooper
2018-03-16 7:40 ` Jan Beulich
2018-03-13 12:18 ` Roger Pau Monné
2018-03-09 13:18 ` [PATCH 6/7] xen/domain: Pass the full domctl_createdomain struct to create_domain() Andrew Cooper
2018-03-09 14:50 ` Wei Liu
2018-03-09 17:00 ` Jan Beulich
2018-03-09 17:06 ` Andrew Cooper
2018-03-12 12:57 ` Jan Beulich
2018-03-11 20:08 ` Julien Grall
2018-03-09 13:18 ` [PATCH 7/7] xen/mm: Clean up share_xen_page_with_guest() API Andrew Cooper
2018-03-09 14:53 ` Wei Liu
2018-03-11 20:29 ` Julien Grall
2018-03-13 12:28 ` Roger Pau Monné
2018-03-13 14:39 ` Jan Beulich
2018-03-15 20:25 ` Andrew Cooper
2018-03-16 7:43 ` Jan Beulich
2018-03-16 8:58 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AABB15402000078001B2ABB@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.