From: Maxime Ripard <maxime.ripard@bootlin.com>
To: megous@megous.com
Cc: dev@linux-sunxi.org, Jernej Skrabec <jernej.skrabec@siol.net>,
David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
"open list:DRM DRIVERS FOR ALLWINNER A10"
<dri-devel@lists.freedesktop.org>,
"moderated list:ARM/Allwinner sunXi SoC support"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/sun4i: Fix exclusivity of the TCON clocks
Date: Mon, 12 Mar 2018 10:44:34 +0100 [thread overview]
Message-ID: <20180312094434.uucwvqy6pykxpbl7@flea> (raw)
In-Reply-To: <20180310110511.14697-1-megous@megous.com>
[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]
On Sat, Mar 10, 2018 at 12:05:11PM +0100, megous@megous.com wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> Currently the exclusivity is enabled when the rate is set by
> the mode setting functions. These functions are called by
> mode_set_nofb callback of drm_crc_helper. Then exclusivity
> is disabled when tcon is disabled by atomic_disable
> callback.
>
> What happens is that mode_set_nofb can be called once when
> mode chnages, and afterwards the system can call atomic_enable
> and atomic_disable multiple times without further calls to
> mode_set_nofb.
>
> This happens:
>
> mode_set_nofb - clk exclusivity is enabled
> atomic_enable
> atomic_disable - clk exclusivity is disabled
> atomic_enable
> atomic_disable - clk exclusivity is already disabled, leading to WARN
> in clk_rate_exclusive_put
>
> Solution is to enable exclusivity in sun4i_tcon_channel_set_status.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Applied, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@bootlin.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/sun4i: Fix exclusivity of the TCON clocks
Date: Mon, 12 Mar 2018 10:44:34 +0100 [thread overview]
Message-ID: <20180312094434.uucwvqy6pykxpbl7@flea> (raw)
In-Reply-To: <20180310110511.14697-1-megous@megous.com>
On Sat, Mar 10, 2018 at 12:05:11PM +0100, megous at megous.com wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> Currently the exclusivity is enabled when the rate is set by
> the mode setting functions. These functions are called by
> mode_set_nofb callback of drm_crc_helper. Then exclusivity
> is disabled when tcon is disabled by atomic_disable
> callback.
>
> What happens is that mode_set_nofb can be called once when
> mode chnages, and afterwards the system can call atomic_enable
> and atomic_disable multiple times without further calls to
> mode_set_nofb.
>
> This happens:
>
> mode_set_nofb - clk exclusivity is enabled
> atomic_enable
> atomic_disable - clk exclusivity is disabled
> atomic_enable
> atomic_disable - clk exclusivity is already disabled, leading to WARN
> in clk_rate_exclusive_put
>
> Solution is to enable exclusivity in sun4i_tcon_channel_set_status.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Applied, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180312/ea213dee/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: megous@megous.com
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
dev@linux-sunxi.org, open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVERS FOR ALLWINNER A10"
<dri-devel@lists.freedesktop.org>,
David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
"moderated list:ARM/Allwinner sunXi SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] drm/sun4i: Fix exclusivity of the TCON clocks
Date: Mon, 12 Mar 2018 10:44:34 +0100 [thread overview]
Message-ID: <20180312094434.uucwvqy6pykxpbl7@flea> (raw)
In-Reply-To: <20180310110511.14697-1-megous@megous.com>
[-- Attachment #1.1: Type: text/plain, Size: 1183 bytes --]
On Sat, Mar 10, 2018 at 12:05:11PM +0100, megous@megous.com wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> Currently the exclusivity is enabled when the rate is set by
> the mode setting functions. These functions are called by
> mode_set_nofb callback of drm_crc_helper. Then exclusivity
> is disabled when tcon is disabled by atomic_disable
> callback.
>
> What happens is that mode_set_nofb can be called once when
> mode chnages, and afterwards the system can call atomic_enable
> and atomic_disable multiple times without further calls to
> mode_set_nofb.
>
> This happens:
>
> mode_set_nofb - clk exclusivity is enabled
> atomic_enable
> atomic_disable - clk exclusivity is disabled
> atomic_enable
> atomic_disable - clk exclusivity is already disabled, leading to WARN
> in clk_rate_exclusive_put
>
> Solution is to enable exclusivity in sun4i_tcon_channel_set_status.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Applied, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-03-12 9:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 11:05 [PATCH] drm/sun4i: Fix exclusivity of the TCON clocks megous
2018-03-10 11:05 ` megous via linux-sunxi
2018-03-10 11:05 ` megous at megous.com
2018-03-12 9:44 ` Maxime Ripard [this message]
2018-03-12 9:44 ` Maxime Ripard
2018-03-12 9:44 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312094434.uucwvqy6pykxpbl7@flea \
--to=maxime.ripard@bootlin.com \
--cc=airlied@linux.ie \
--cc=dev@linux-sunxi.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=megous@megous.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.