* [PATCH] rxrpc: remove redundant initialization of variable 'len'
@ 2018-03-12 17:25 Colin King
2018-03-16 13:49 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2018-03-12 17:25 UTC (permalink / raw)
To: David Howells, David S . Miller, linux-afs, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable 'len' is being initialized with a value that is never
read and it is re-assigned later, hence the initialization is redundant
and can be removed.
Cleans up clang warning:
net/rxrpc/recvmsg.c:275:15: warning: Value stored to 'len' during its
initialization is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/rxrpc/recvmsg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rxrpc/recvmsg.c b/net/rxrpc/recvmsg.c
index 9d45d8b56744..7bff716e911e 100644
--- a/net/rxrpc/recvmsg.c
+++ b/net/rxrpc/recvmsg.c
@@ -272,7 +272,7 @@ static int rxrpc_locate_data(struct rxrpc_call *call, struct sk_buff *skb,
unsigned int *_offset, unsigned int *_len)
{
unsigned int offset = sizeof(struct rxrpc_wire_header);
- unsigned int len = *_len;
+ unsigned int len;
int ret;
u8 annotation = *_annotation;
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rxrpc: remove redundant initialization of variable 'len'
2018-03-12 17:25 [PATCH] rxrpc: remove redundant initialization of variable 'len' Colin King
@ 2018-03-16 13:49 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2018-03-16 13:49 UTC (permalink / raw)
To: colin.king; +Cc: dhowells, linux-afs, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Mon, 12 Mar 2018 17:25:38 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable 'len' is being initialized with a value that is never
> read and it is re-assigned later, hence the initialization is redundant
> and can be removed.
>
> Cleans up clang warning:
> net/rxrpc/recvmsg.c:275:15: warning: Value stored to 'len' during its
> initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Hehe, if the diff provided just 2 more lines of context at the bottom
we'd be able to see the overriding assignment :-)
> @@ -272,7 +272,7 @@ static int rxrpc_locate_data(struct rxrpc_call *call, struct sk_buff *skb,
> unsigned int *_offset, unsigned int *_len)
> {
> unsigned int offset = sizeof(struct rxrpc_wire_header);
> - unsigned int len = *_len;
> + unsigned int len;
> int ret;
> u8 annotation = *_annotation;
>
> --
> 2.15.1
>
Applied, thanks Colin.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rxrpc: remove redundant initialization of variable 'len'
@ 2018-03-16 13:49 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2018-03-16 13:49 UTC (permalink / raw)
To: colin.king; +Cc: dhowells, linux-afs, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Mon, 12 Mar 2018 17:25:38 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable 'len' is being initialized with a value that is never
> read and it is re-assigned later, hence the initialization is redundant
> and can be removed.
>
> Cleans up clang warning:
> net/rxrpc/recvmsg.c:275:15: warning: Value stored to 'len' during its
> initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Hehe, if the diff provided just 2 more lines of context at the bottom
we'd be able to see the overriding assignment :-)
> @@ -272,7 +272,7 @@ static int rxrpc_locate_data(struct rxrpc_call *call, struct sk_buff *skb,
> unsigned int *_offset, unsigned int *_len)
> {
> unsigned int offset = sizeof(struct rxrpc_wire_header);
> - unsigned int len = *_len;
> + unsigned int len;
> int ret;
> u8 annotation = *_annotation;
>
> --
> 2.15.1
>
Applied, thanks Colin.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-16 13:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-12 17:25 [PATCH] rxrpc: remove redundant initialization of variable 'len' Colin King
2018-03-16 13:49 ` David Miller
2018-03-16 13:49 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.