* [igt-dev] [PATCH igt] lib/audio: Replace sqrt(a*a + b*b) with hypot(a, b)
@ 2018-03-12 15:43 Chris Wilson
2018-03-12 15:47 ` Chris Wilson
2018-03-12 23:34 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2018-03-12 15:43 UTC (permalink / raw)
To: igt-dev
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
lib/igt_audio.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/igt_audio.c b/lib/igt_audio.c
index 2321d1c6..229ce6c6 100644
--- a/lib/igt_audio.c
+++ b/lib/igt_audio.c
@@ -266,9 +266,7 @@ bool audio_signal_detect(struct audio_signal *signal, int channels,
max = 0;
for (i = 0; i < frames / 2; i++) {
- amplitude[i] = sqrt(data[i] * data[i] +
- data[frames - i] *
- data[frames - i]);
+ amplitude[i] = hypot(data[i], data[frames - i]);
if (amplitude[i] > max)
max = amplitude[i];
}
--
2.16.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [igt-dev] [PATCH igt] lib/audio: Replace sqrt(a*a + b*b) with hypot(a, b)
2018-03-12 15:43 [igt-dev] [PATCH igt] lib/audio: Replace sqrt(a*a + b*b) with hypot(a, b) Chris Wilson
@ 2018-03-12 15:47 ` Chris Wilson
2018-03-12 23:34 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Chris Wilson @ 2018-03-12 15:47 UTC (permalink / raw)
To: igt-dev
Quoting Chris Wilson (2018-03-12 15:43:50)
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> lib/igt_audio.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/igt_audio.c b/lib/igt_audio.c
> index 2321d1c6..229ce6c6 100644
> --- a/lib/igt_audio.c
> +++ b/lib/igt_audio.c
> @@ -266,9 +266,7 @@ bool audio_signal_detect(struct audio_signal *signal, int channels,
> max = 0;
>
> for (i = 0; i < frames / 2; i++) {
> - amplitude[i] = sqrt(data[i] * data[i] +
> - data[frames - i] *
> - data[frames - i]);
> + amplitude[i] = hypot(data[i], data[frames - i]);
> if (amplitude[i] > max)
> max = amplitude[i];
Although the sqrt is overkill as the code would be just as happy using
amplitude squared. Ok, the code is quite weird, I'm not going to read
any more...
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for lib/audio: Replace sqrt(a*a + b*b) with hypot(a, b)
2018-03-12 15:43 [igt-dev] [PATCH igt] lib/audio: Replace sqrt(a*a + b*b) with hypot(a, b) Chris Wilson
2018-03-12 15:47 ` Chris Wilson
@ 2018-03-12 23:34 ` Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2018-03-12 23:34 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: lib/audio: Replace sqrt(a*a + b*b) with hypot(a, b)
URL : https://patchwork.freedesktop.org/series/39798/
State : failure
== Summary ==
IGT patchset tested on top of latest successful build
89b915f5aa465d5c3498b170b1572fae20460491 tests/pm_rpm: Don't try to create an X-tiled ARGB8888 framebuffer
with latest DRM-Tip kernel build CI_DRM_3915
da600bbe2441 drm-tip: 2018y-03m-12d-22h-06m-53s UTC integration manifest
No testlist changes.
---- Possible new issues:
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-c-frame-sequence:
pass -> FAIL (fi-skl-guc)
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:435s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:385s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:534s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:299s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:506s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:513s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:511s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:497s
fi-cfl-8700k total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:409s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:587s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:425s
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:314s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:536s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:403s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:428s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:471s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:429s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:481s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:468s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:515s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:643s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:441s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:532s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:545s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:495s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:498s
fi-skl-guc total:288 pass:259 dwarn:0 dfail:0 fail:1 skip:28 time:429s
fi-snb-2520m total:245 pass:211 dwarn:0 dfail:0 fail:0 skip:33
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:400s
Blacklisted hosts:
fi-cfl-u total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:513s
fi-cnl-drrs total:288 pass:257 dwarn:3 dfail:0 fail:0 skip:28 time:523s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1111/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-12 23:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-12 15:43 [igt-dev] [PATCH igt] lib/audio: Replace sqrt(a*a + b*b) with hypot(a, b) Chris Wilson
2018-03-12 15:47 ` Chris Wilson
2018-03-12 23:34 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.