[PATCH v2] auxdisplay: arm-charlcd: Fix struct charlcd doc line

[PATCH v2] auxdisplay: arm-charlcd: Fix struct charlcd doc line

[Miguel Ojeda]

There was a missing first line and a missing member,
which gave a warning under W=1:

    CC      drivers/auxdisplay/arm-charlcd.o
  drivers/auxdisplay/arm-charlcd.c:57: warning: Cannot understand
   * @dev: a pointer back to containing device on line 57 - I thought
  it was a doc line

Cc: Linus Walleij <triad@df.lth.se>
Cc: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
---
 drivers/auxdisplay/arm-charlcd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/auxdisplay/arm-charlcd.c b/drivers/auxdisplay/arm-charlcd.c
index b3176ee92b90..dde180995582 100644
--- a/drivers/auxdisplay/arm-charlcd.c
+++ b/drivers/auxdisplay/arm-charlcd.c
@@ -54,12 +54,14 @@
 #define HD_BUSY_FLAG			0x80U
 
 /**
+ * struct charlcd - Private data structure
  * @dev: a pointer back to containing device
  * @phybase: the offset to the controller in physical memory
  * @physize: the size of the physical page
  * @virtbase: the offset to the controller in virtual memory
  * @irq: reserved interrupt number
  * @complete: completion structure for the last LCD command
+ * @init_work: delayed work structure to initialize the display on boot
  */
 struct charlcd {
 	struct device *dev;
-- 
2.14.1

Re: [PATCH v2] auxdisplay: arm-charlcd: Fix struct charlcd doc line

[Linus Walleij]

On Tue, Mar 13, 2018 at 12:59 AM, Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:

> There was a missing first line and a missing member,
> which gave a warning under W=1:
>
>     CC      drivers/auxdisplay/arm-charlcd.o
>   drivers/auxdisplay/arm-charlcd.c:57: warning: Cannot understand
>    * @dev: a pointer back to containing device on line 57 - I thought
>   it was a doc line
>
> Cc: Linus Walleij <triad@df.lth.se>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH v2] auxdisplay: arm-charlcd: Fix struct charlcd doc line

[Miguel Ojeda]

On Tue, Mar 27, 2018 at 1:24 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Mar 13, 2018 at 12:59 AM, Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
>
>> There was a missing first line and a missing member,
>> which gave a warning under W=1:
>>
>>     CC      drivers/auxdisplay/arm-charlcd.o
>>   drivers/auxdisplay/arm-charlcd.c:57: warning: Cannot understand
>>    * @dev: a pointer back to containing device on line 57 - I thought
>>   it was a doc line
>>
>> Cc: Linus Walleij <triad@df.lth.se>
>> Cc: Randy Dunlap <rdunlap@infradead.org>
>> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Thanks Linus.

Cheers,
Miguel