[PATCH] libxl/pvh: force PVH guests to use the xenstore shutdown

[PATCH] libxl/pvh: force PVH guests to use the xenstore shutdown

[Roger Pau Monne]

There's no other way to shutdown a PVH guest at the moment.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
 tools/libxl/libxl_domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/libxl_domain.c b/tools/libxl/libxl_domain.c
index 814f8128a1..aaa22ef576 100644
--- a/tools/libxl/libxl_domain.c
+++ b/tools/libxl/libxl_domain.c
@@ -599,7 +599,7 @@ int libxl__domain_pvcontrol_available(libxl__gc *gc, uint32_t domid)
     if (domtype == LIBXL_DOMAIN_TYPE_INVALID)
         return ERROR_FAIL;
 
-    if (domtype == LIBXL_DOMAIN_TYPE_PV)
+    if (domtype != LIBXL_DOMAIN_TYPE_HVM)
         return 1;
 
     ret = xc_hvm_param_get(ctx->xch, domid, HVM_PARAM_CALLBACK_IRQ, &pvdriver);
-- 
2.14.3 (Apple Git-98)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] libxl/pvh: force PVH guests to use the xenstore shutdown

[Ian Jackson]

Roger Pau Monne writes ("[PATCH] libxl/pvh: force PVH guests to use the xenstore shutdown"):
> There's no other way to shutdown a PVH guest at the moment.

This commit message is rather confusing.

Do you mean, instead:

  PVH guests are all required to support the xenstore-based shutdown
  signalling, since there is no other way for a PVH guest to be
  requested to shut down.

  For HVM guests we check whether the guest has installed a PV-on-HVM
  interrupt callback; that does not make sense for PVH guests.

  So for PVH guests, take the PV path: assume that all PVH guests have
  suitable xenstore drivers.

?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] libxl/pvh: force PVH guests to use the xenstore shutdown

[Roger Pau Monné]

On Tue, Dec 19, 2017 at 02:36:06PM +0000, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH] libxl/pvh: force PVH guests to use the xenstore shutdown"):
> > There's no other way to shutdown a PVH guest at the moment.
> 
> This commit message is rather confusing.
> 
> Do you mean, instead:
> 
>   PVH guests are all required to support the xenstore-based shutdown
>   signalling, since there is no other way for a PVH guest to be
>   requested to shut down.
> 
>   For HVM guests we check whether the guest has installed a PV-on-HVM
>   interrupt callback; that does not make sense for PVH guests.
> 
>   So for PVH guests, take the PV path: assume that all PVH guests have
>   suitable xenstore drivers.
> 
> ?

Yes, that's exactly what I meant but failed to express. Feel free to
replace the commit message with yours.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] libxl/pvh: force PVH guests to use the xenstore shutdown

[Ian Jackson]

Roger Pau Monné writes ("Re: [PATCH] libxl/pvh: force PVH guests to use the xenstore shutdown"):
> Yes, that's exactly what I meant but failed to express. Feel free to
> replace the commit message with yours.

OK, thanks :-).  I have

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

and pushed it.

I think this is a candidate for backporting as far as 4.9 ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] libxl/pvh: force PVH guests to use the xenstore shutdown

[Roger Pau Monné]

On Tue, Dec 19, 2017 at 02:48:47PM +0000, Ian Jackson wrote:
> Roger Pau Monné writes ("Re: [PATCH] libxl/pvh: force PVH guests to use the xenstore shutdown"):
> > Yes, that's exactly what I meant but failed to express. Feel free to
> > replace the commit message with yours.
> 
> OK, thanks :-).  I have
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> and pushed it.
> 
> I think this is a candidate for backporting as far as 4.9 ?

Yes, 4.10 only though (that's when the PVH guest type was introduced)
in it's current form. 4.9 will require some rework (like checking qemu
pid).

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] libxl/pvh: force PVH guests to use the xenstore shutdown

[Ian Jackson]

Roger Pau Monné writes ("Re: [PATCH] libxl/pvh: force PVH guests to use the xenstore shutdown"):
> On Tue, Dec 19, 2017 at 02:48:47PM +0000, Ian Jackson wrote:
> > I think this is a candidate for backporting as far as 4.9 ?
> 
> Yes, 4.10 only though (that's when the PVH guest type was introduced)
> in it's current form. 4.9 will require some rework (like checking qemu
> pid).

I have applied it to 4.10.  Do you intend to prepare that backport for
4.9 ?  I'm not sure what rework is required.

Also, we are intending to release a 4.8 stable with the PVH
backport, so perhaps it needs to be in there too.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] libxl/pvh: force PVH guests to use the xenstore shutdown

[Roger Pau Monné]

On Tue, Mar 06, 2018 at 03:56:58PM +0000, Ian Jackson wrote:
> Roger Pau Monné writes ("Re: [PATCH] libxl/pvh: force PVH guests to use the xenstore shutdown"):
> > On Tue, Dec 19, 2017 at 02:48:47PM +0000, Ian Jackson wrote:
> > > I think this is a candidate for backporting as far as 4.9 ?
> > 
> > Yes, 4.10 only though (that's when the PVH guest type was introduced)
> > in it's current form. 4.9 will require some rework (like checking qemu
> > pid).
> 
> I have applied it to 4.10.  Do you intend to prepare that backport for
> 4.9 ?  I'm not sure what rework is required.
> 
> Also, we are intending to release a 4.8 stable with the PVH
> backport, so perhaps it needs to be in there too.

Yes, it needs to be in the 4.8 branch if the type=pvh work is merged.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel