All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] memory-failure: fix section mismatch
@ 2018-03-04  7:16 ` Nick Desaulniers
  0 siblings, 0 replies; 4+ messages in thread
From: Nick Desaulniers @ 2018-03-04  7:16 UTC (permalink / raw)
  Cc: Nick Desaulniers, Andrew Morton, Dan Williams, Michal Hocko,
	Kirill A. Shutemov, Jan Kara, Jérôme Glisse,
	Hugh Dickins, Matthew Wilcox, linux-mm, linux-kernel

Clang complains when a variable is declared extern twice, but with two
different sections. num_poisoned_pages is marked extern and __read_mostly
in include/linux/swapops.h, but only extern in include/linux/mm.h. Some
c source files must include both, and thus see the conflicting
declarations.

Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
---
 include/linux/mm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index ad06d42adb1a..bd4bd59f02c1 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2582,7 +2582,7 @@ extern int get_hwpoison_page(struct page *page);
 extern int sysctl_memory_failure_early_kill;
 extern int sysctl_memory_failure_recovery;
 extern void shake_page(struct page *p, int access);
-extern atomic_long_t num_poisoned_pages;
+extern atomic_long_t num_poisoned_pages __read_mostly;
 extern int soft_offline_page(struct page *page, int flags);
 
 
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] memory-failure: fix section mismatch
@ 2018-03-04  7:16 ` Nick Desaulniers
  0 siblings, 0 replies; 4+ messages in thread
From: Nick Desaulniers @ 2018-03-04  7:16 UTC (permalink / raw)
  Cc: Nick Desaulniers, Andrew Morton, Dan Williams, Michal Hocko,
	Kirill A. Shutemov, Jan Kara, Jérôme Glisse,
	Hugh Dickins, Matthew Wilcox, linux-mm, linux-kernel

Clang complains when a variable is declared extern twice, but with two
different sections. num_poisoned_pages is marked extern and __read_mostly
in include/linux/swapops.h, but only extern in include/linux/mm.h. Some
c source files must include both, and thus see the conflicting
declarations.

Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
---
 include/linux/mm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index ad06d42adb1a..bd4bd59f02c1 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2582,7 +2582,7 @@ extern int get_hwpoison_page(struct page *page);
 extern int sysctl_memory_failure_early_kill;
 extern int sysctl_memory_failure_recovery;
 extern void shake_page(struct page *p, int access);
-extern atomic_long_t num_poisoned_pages;
+extern atomic_long_t num_poisoned_pages __read_mostly;
 extern int soft_offline_page(struct page *page, int flags);
 
 
-- 
2.14.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] memory-failure: fix section mismatch
  2018-03-04  7:16 ` Nick Desaulniers
  (?)
@ 2018-03-13 14:45 ` Michal Hocko
  -1 siblings, 0 replies; 4+ messages in thread
From: Michal Hocko @ 2018-03-13 14:45 UTC (permalink / raw)
  To: Nick Desaulniers
  Cc: Andrew Morton, Dan Williams, Kirill A. Shutemov, Jan Kara,
	Jérôme Glisse, Hugh Dickins, Matthew Wilcox, linux-mm,
	linux-kernel

On Sat 03-03-18 23:16:11, Nick Desaulniers wrote:
> Clang complains when a variable is declared extern twice, but with two
> different sections. num_poisoned_pages is marked extern and __read_mostly
> in include/linux/swapops.h, but only extern in include/linux/mm.h. Some
> c source files must include both, and thus see the conflicting
> declarations.

Why do we need declarations in both places? This sounds like a mess to
me.

> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
> ---
>  include/linux/mm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index ad06d42adb1a..bd4bd59f02c1 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -2582,7 +2582,7 @@ extern int get_hwpoison_page(struct page *page);
>  extern int sysctl_memory_failure_early_kill;
>  extern int sysctl_memory_failure_recovery;
>  extern void shake_page(struct page *p, int access);
> -extern atomic_long_t num_poisoned_pages;
> +extern atomic_long_t num_poisoned_pages __read_mostly;
>  extern int soft_offline_page(struct page *page, int flags);
>  
>  
> -- 
> 2.14.1
> 

-- 
Michal Hocko
SUSE Labs

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] memory-failure: fix section mismatch
  2018-03-04  7:16 ` Nick Desaulniers
  (?)
  (?)
@ 2018-03-16 23:04 ` Matthias Kaehlcke
  -1 siblings, 0 replies; 4+ messages in thread
From: Matthias Kaehlcke @ 2018-03-16 23:04 UTC (permalink / raw)
  To: Nick Desaulniers
  Cc: Andrew Morton, Dan Williams, Michal Hocko, Kirill A. Shutemov,
	Jan Kara, Jérôme Glisse, Hugh Dickins, Matthew Wilcox,
	linux-mm, linux-kernel

El Sat, Mar 03, 2018 at 11:16:11PM -0800 Nick Desaulniers ha dit:

> Clang complains when a variable is declared extern twice, but with two
> different sections. num_poisoned_pages is marked extern and __read_mostly
> in include/linux/swapops.h, but only extern in include/linux/mm.h. Some
> c source files must include both, and thus see the conflicting
> declarations.
> 
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
> ---
>  include/linux/mm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index ad06d42adb1a..bd4bd59f02c1 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -2582,7 +2582,7 @@ extern int get_hwpoison_page(struct page *page);
>  extern int sysctl_memory_failure_early_kill;
>  extern int sysctl_memory_failure_recovery;
>  extern void shake_page(struct page *p, int access);
> -extern atomic_long_t num_poisoned_pages;
> +extern atomic_long_t num_poisoned_pages __read_mostly;
>  extern int soft_offline_page(struct page *page, int flags);

An equivalent patch was posted by Guenter Roeck and has been picked up
by Andrew: https://patchwork.kernel.org/patch/10243919/

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-16 23:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-04  7:16 [PATCH] memory-failure: fix section mismatch Nick Desaulniers
2018-03-04  7:16 ` Nick Desaulniers
2018-03-13 14:45 ` Michal Hocko
2018-03-16 23:04 ` Matthias Kaehlcke

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.