[renesas-drivers:master 4329/4669] drivers/media/platform/vsp1/vsp1_dl.c:378:3: sparse: symbol 'vsp1_extended_commands' was not declared. Should it be static?

[renesas-drivers:master 4329/4669] drivers/media/platform/vsp1/vsp1_dl.c:378:3: sparse: symbol 'vsp1_extended_commands' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git master
head:   b67ea3b553661cb76397afbf73701c3ea14b19de
commit: 02dcefdd58c734623b9caf2513316380feb9f993 [4329/4669] media: vsp1: Provide support for extended command pools
reproduce:
        # apt-get install sparse
        git checkout 02dcefdd58c734623b9caf2513316380feb9f993
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/media/platform/vsp1/vsp1_dl.c:378:3: sparse: symbol 'vsp1_extended_commands' was not declared. Should it be static?
>> drivers/media/platform/vsp1/vsp1_dl.c:395:25: sparse: symbol 'vsp1_dl_cmd_pool_create' was not declared. Should it be static?
>> drivers/media/platform/vsp1/vsp1_dl.c:453:24: sparse: symbol 'vsp1_dl_ext_cmd_get' was not declared. Should it be static?
>> drivers/media/platform/vsp1/vsp1_dl.c:471:6: sparse: symbol 'vsp1_dl_ext_cmd_put' was not declared. Should it be static?
>> drivers/media/platform/vsp1/vsp1_dl.c:486:6: sparse: symbol 'vsp1_dl_ext_cmd_pool_destroy' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH renesas-drivers] media: vsp1: vsp1_dl_cmd_pool_create can be static

[kbuild test robot]

Fixes: 02dcefdd58c7 ("media: vsp1: Provide support for extended command pools")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 vsp1_dl.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/vsp1/vsp1_dl.c b/drivers/media/platform/vsp1/vsp1_dl.c
index 6d17b8b..7b99d47 100644
--- a/drivers/media/platform/vsp1/vsp1_dl.c
+++ b/drivers/media/platform/vsp1/vsp1_dl.c
@@ -392,7 +392,7 @@ struct vsp1_extended_command_info {
  *
  * Return a pointer to a pool on success or NULL if memory can't be allocated.
  */
-struct vsp1_dl_cmd_pool *
+static struct vsp1_dl_cmd_pool *
 vsp1_dl_cmd_pool_create(struct vsp1_device *vsp1, enum vsp1_extcmd_type type,
 			unsigned int num_cmds)
 {
@@ -450,7 +450,7 @@ vsp1_dl_cmd_pool_create(struct vsp1_device *vsp1, enum vsp1_extcmd_type type,
 	return pool;
 }
 
-struct vsp1_dl_ext_cmd *vsp1_dl_ext_cmd_get(struct vsp1_dl_cmd_pool *pool)
+static struct vsp1_dl_ext_cmd *vsp1_dl_ext_cmd_get(struct vsp1_dl_cmd_pool *pool)
 {
 	struct vsp1_dl_ext_cmd *cmd = NULL;
 	unsigned long flags;
@@ -468,7 +468,7 @@ struct vsp1_dl_ext_cmd *vsp1_dl_ext_cmd_get(struct vsp1_dl_cmd_pool *pool)
 	return cmd;
 }
 
-void vsp1_dl_ext_cmd_put(struct vsp1_dl_ext_cmd *cmd)
+static void vsp1_dl_ext_cmd_put(struct vsp1_dl_ext_cmd *cmd)
 {
 	unsigned long flags;
 
@@ -483,7 +483,7 @@ void vsp1_dl_ext_cmd_put(struct vsp1_dl_ext_cmd *cmd)
 	spin_unlock_irqrestore(&cmd->pool->lock, flags);
 }
 
-void vsp1_dl_ext_cmd_pool_destroy(struct vsp1_dl_cmd_pool *pool)
+static void vsp1_dl_ext_cmd_pool_destroy(struct vsp1_dl_cmd_pool *pool)
 {
 	if (!pool)
 		return;