* [PATCH] drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+
@ 2018-03-13 4:09 Dhinakaran Pandiyan
2018-03-13 4:46 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Dhinakaran Pandiyan @ 2018-03-13 4:09 UTC (permalink / raw)
To: intel-gfx; +Cc: Dhinakaran Pandiyan
What was called SRD_DEBUG(0x6F860) on HSW and BDW was renamed to PSR_MASK
SKL onwards, add a note next to the macro definition.
There is also a different PSR_DEBUG on SKL+ to add to the confusion.
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 23c0f9bdf591..e8a4b61397ba 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -4186,13 +4186,13 @@ enum {
#define EDP_PSR_PERF_CNT _MMIO(dev_priv->psr_mmio_base + 0x44)
#define EDP_PSR_PERF_CNT_MASK 0xffffff
-#define EDP_PSR_DEBUG _MMIO(dev_priv->psr_mmio_base + 0x60)
+#define EDP_PSR_DEBUG _MMIO(dev_priv->psr_mmio_base + 0x60) /* PSR_MASK on SKL+ */
#define EDP_PSR_DEBUG_MASK_MAX_SLEEP (1<<28)
#define EDP_PSR_DEBUG_MASK_LPSP (1<<27)
#define EDP_PSR_DEBUG_MASK_MEMUP (1<<26)
#define EDP_PSR_DEBUG_MASK_HPD (1<<25)
#define EDP_PSR_DEBUG_MASK_DISP_REG_WRITE (1<<16)
-#define EDP_PSR_DEBUG_EXIT_ON_PIXEL_UNDERRUN (1<<15)
+#define EDP_PSR_DEBUG_EXIT_ON_PIXEL_UNDERRUN (1<<15) /* SKL+ */
#define EDP_PSR2_CTL _MMIO(0x6f900)
#define EDP_PSR2_ENABLE (1<<31)
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+
2018-03-13 4:09 [PATCH] drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+ Dhinakaran Pandiyan
@ 2018-03-13 4:46 ` Patchwork
2018-03-13 8:00 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-03-13 22:25 ` [PATCH] " Rodrigo Vivi
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-03-13 4:46 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+
URL : https://patchwork.freedesktop.org/series/39826/
State : success
== Summary ==
Series 39826v1 drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+
https://patchwork.freedesktop.org/api/1.0/series/39826/revisions/1/mbox/
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:432s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:383s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:530s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:298s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:506s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:514s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:508s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:499s
fi-cfl-8700k total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:411s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:578s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:429s
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:316s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:536s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:404s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:420s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:471s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:425s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:471s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:468s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:514s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:637s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:446s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:528s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:540s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:501s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:491s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:427s
fi-snb-2520m total:245 pass:211 dwarn:0 dfail:0 fail:0 skip:33
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:408s
Blacklisted hosts:
fi-cfl-u total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:510s
fi-cnl-drrs total:288 pass:257 dwarn:3 dfail:0 fail:0 skip:28 time:516s
fi-glk-j5005 failed to collect. IGT log at Patchwork_8320/fi-glk-j5005/run0.log
da600bbe24412edd1c46591fd21ef81518e49c5d drm-tip: 2018y-03m-12d-22h-06m-53s UTC integration manifest
8042cf656d8d drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8320/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+
2018-03-13 4:09 [PATCH] drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+ Dhinakaran Pandiyan
2018-03-13 4:46 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-03-13 8:00 ` Patchwork
2018-03-13 22:25 ` [PATCH] " Rodrigo Vivi
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-03-13 8:00 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+
URL : https://patchwork.freedesktop.org/series/39826/
State : failure
== Summary ==
---- Possible new issues:
Test drv_suspend:
Subgroup forcewake:
pass -> SKIP (shard-snb)
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-indfb-fliptrack:
pass -> FAIL (shard-apl)
---- Known issues:
Test gem_eio:
Subgroup in-flight-contexts:
incomplete -> PASS (shard-apl) fdo#105341
Test kms_atomic_transition:
Subgroup 1x-modeset-transitions-nonblocking-fencing:
fail -> PASS (shard-apl) fdo#103207
fdo#105341 https://bugs.freedesktop.org/show_bug.cgi?id=105341
fdo#103207 https://bugs.freedesktop.org/show_bug.cgi?id=103207
shard-apl total:3473 pass:1829 dwarn:1 dfail:0 fail:8 skip:1634 time:12981s
shard-hsw total:3473 pass:1777 dwarn:1 dfail:0 fail:2 skip:1692 time:11909s
shard-snb total:3473 pass:1363 dwarn:1 dfail:0 fail:3 skip:2106 time:7188s
Blacklisted hosts:
shard-kbl total:3393 pass:1918 dwarn:1 dfail:0 fail:9 skip:1464 time:9556s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8320/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+
2018-03-13 4:09 [PATCH] drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+ Dhinakaran Pandiyan
2018-03-13 4:46 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-13 8:00 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-03-13 22:25 ` Rodrigo Vivi
2018-03-13 22:36 ` Rodrigo Vivi
2 siblings, 1 reply; 5+ messages in thread
From: Rodrigo Vivi @ 2018-03-13 22:25 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
On Mon, Mar 12, 2018 at 09:09:54PM -0700, Dhinakaran Pandiyan wrote:
> What was called SRD_DEBUG(0x6F860) on HSW and BDW was renamed to PSR_MASK
> SKL onwards, add a note next to the macro definition.
> There is also a different PSR_DEBUG on SKL+ to add to the confusion.
>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 23c0f9bdf591..e8a4b61397ba 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -4186,13 +4186,13 @@ enum {
> #define EDP_PSR_PERF_CNT _MMIO(dev_priv->psr_mmio_base + 0x44)
> #define EDP_PSR_PERF_CNT_MASK 0xffffff
>
> -#define EDP_PSR_DEBUG _MMIO(dev_priv->psr_mmio_base + 0x60)
> +#define EDP_PSR_DEBUG _MMIO(dev_priv->psr_mmio_base + 0x60) /* PSR_MASK on SKL+ */
> #define EDP_PSR_DEBUG_MASK_MAX_SLEEP (1<<28)
> #define EDP_PSR_DEBUG_MASK_LPSP (1<<27)
> #define EDP_PSR_DEBUG_MASK_MEMUP (1<<26)
> #define EDP_PSR_DEBUG_MASK_HPD (1<<25)
> #define EDP_PSR_DEBUG_MASK_DISP_REG_WRITE (1<<16)
> -#define EDP_PSR_DEBUG_EXIT_ON_PIXEL_UNDERRUN (1<<15)
> +#define EDP_PSR_DEBUG_EXIT_ON_PIXEL_UNDERRUN (1<<15) /* SKL+ */
>
> #define EDP_PSR2_CTL _MMIO(0x6f900)
> #define EDP_PSR2_ENABLE (1<<31)
> --
> 2.14.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+
2018-03-13 22:25 ` [PATCH] " Rodrigo Vivi
@ 2018-03-13 22:36 ` Rodrigo Vivi
0 siblings, 0 replies; 5+ messages in thread
From: Rodrigo Vivi @ 2018-03-13 22:36 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
On Tue, Mar 13, 2018 at 03:25:51PM -0700, Rodrigo Vivi wrote:
> On Mon, Mar 12, 2018 at 09:09:54PM -0700, Dhinakaran Pandiyan wrote:
> > What was called SRD_DEBUG(0x6F860) on HSW and BDW was renamed to PSR_MASK
> > SKL onwards, add a note next to the macro definition.
> > There is also a different PSR_DEBUG on SKL+ to add to the confusion.
> >
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>
> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
and pushed. thanks.
>
> > ---
> > drivers/gpu/drm/i915/i915_reg.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index 23c0f9bdf591..e8a4b61397ba 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -4186,13 +4186,13 @@ enum {
> > #define EDP_PSR_PERF_CNT _MMIO(dev_priv->psr_mmio_base + 0x44)
> > #define EDP_PSR_PERF_CNT_MASK 0xffffff
> >
> > -#define EDP_PSR_DEBUG _MMIO(dev_priv->psr_mmio_base + 0x60)
> > +#define EDP_PSR_DEBUG _MMIO(dev_priv->psr_mmio_base + 0x60) /* PSR_MASK on SKL+ */
> > #define EDP_PSR_DEBUG_MASK_MAX_SLEEP (1<<28)
> > #define EDP_PSR_DEBUG_MASK_LPSP (1<<27)
> > #define EDP_PSR_DEBUG_MASK_MEMUP (1<<26)
> > #define EDP_PSR_DEBUG_MASK_HPD (1<<25)
> > #define EDP_PSR_DEBUG_MASK_DISP_REG_WRITE (1<<16)
> > -#define EDP_PSR_DEBUG_EXIT_ON_PIXEL_UNDERRUN (1<<15)
> > +#define EDP_PSR_DEBUG_EXIT_ON_PIXEL_UNDERRUN (1<<15) /* SKL+ */
> >
> > #define EDP_PSR2_CTL _MMIO(0x6f900)
> > #define EDP_PSR2_ENABLE (1<<31)
> > --
> > 2.14.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-13 22:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-13 4:09 [PATCH] drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+ Dhinakaran Pandiyan
2018-03-13 4:46 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-13 8:00 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-03-13 22:25 ` [PATCH] " Rodrigo Vivi
2018-03-13 22:36 ` Rodrigo Vivi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.