[igt-dev] [PATCH i-g-t] tests/kms_panel_fitting: Make test pass on gen9's pipe C

[igt-dev] [PATCH i-g-t] tests/kms_panel_fitting: Make test pass on gen9's pipe C

[Maarten Lankhorst]

The legacy test fails because it tries scaling on pipe C,
because the single scaler is already used for CRTC scaling.
On other pipes and newer gens we have 2 scalers, so special
case pipe C here.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105456
---
 tests/kms_panel_fitting.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
index 1f087ecc82a0..5dce101003c5 100644
--- a/tests/kms_panel_fitting.c
+++ b/tests/kms_panel_fitting.c
@@ -133,6 +133,14 @@ static void test_panel_fitting(data_t *d)
 		igt_plane_set_size(d->plane2, mode->hdisplay-200, mode->vdisplay-200);
 		igt_display_commit2(display, COMMIT_UNIVERSAL);
 
+		/*
+		 * gen9 pipe C has only 1 scaler shared with the crtc, which
+		 * means pipe scaling can't work simultaneously with panel
+		 * fitting.
+		 */
+		if (intel_gen(intel_get_drm_devid(display->drm_fd)) == 9 && pipe == PIPE_C)
+			igt_plane_set_size(d->plane2, d->fb2.width-200, d->fb2.height-200);
+
 		/* enable panel fitting along with sprite scaling */
 		mode->hdisplay = 1024;
 		mode->vdisplay = 768;
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_panel_fitting: Make test pass on gen9's pipe C

[Chris Wilson]

Quoting Maarten Lankhorst (2018-03-14 10:54:11)
> The legacy test fails because it tries scaling on pipe C,
> because the single scaler is already used for CRTC scaling.
> On other pipes and newer gens we have 2 scalers, so special
> case pipe C here.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105456
> ---
>  tests/kms_panel_fitting.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> index 1f087ecc82a0..5dce101003c5 100644
> --- a/tests/kms_panel_fitting.c
> +++ b/tests/kms_panel_fitting.c
> @@ -133,6 +133,14 @@ static void test_panel_fitting(data_t *d)
>                 igt_plane_set_size(d->plane2, mode->hdisplay-200, mode->vdisplay-200);
>                 igt_display_commit2(display, COMMIT_UNIVERSAL);
>  
> +               /*
> +                * gen9 pipe C has only 1 scaler shared with the crtc, which
> +                * means pipe scaling can't work simultaneously with panel
> +                * fitting.

+ Since this is the legacy path, userspace has to know about the HW
limitations, whereas atomic can ask.

> +                */
> +               if (intel_gen(intel_get_drm_devid(display->drm_fd)) == 9 && pipe == PIPE_C)
> +                       igt_plane_set_size(d->plane2, d->fb2.width-200, d->fb2.height-200);
> +
>                 /* enable panel fitting along with sprite scaling */
>                 mode->hdisplay = 1024;
>                 mode->vdisplay = 768;
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_panel_fitting: Make test pass on gen9's pipe C

[Patchwork]

== Series Details ==

Series: tests/kms_panel_fitting: Make test pass on gen9's pipe C
URL   : https://patchwork.freedesktop.org/series/39952/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
518ccf1d1b452b9d26ddcf54249fb6e91f451f90 tests/kms_frontbuffer_tracking: Respect mode when collecting CRCs.

with latest DRM-Tip kernel build CI_DRM_3925
311e6b74462a drm-tip: 2018y-03m-14d-10h-51m-46s UTC integration manifest

No testlist changes.

---- Known issues:

Test gem_exec_suspend:
        Subgroup basic-s3:
                pass       -> DMESG-WARN (fi-skl-6700k2) fdo#104108

fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108

fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:436s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:382s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:540s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:514s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:509s
fi-cfl-8700k     total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:415s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:584s
fi-cfl-u         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:509s
fi-cnl-y3        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:601s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:428s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:325s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:535s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:405s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:424s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:475s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:428s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:474s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:467s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:517s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:663s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:440s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:529s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:543s
fi-skl-6700k2    total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:507s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:505s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:428s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:435s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:405s
Blacklisted hosts:
fi-cnl-drrs      total:288  pass:257  dwarn:3   dfail:0   fail:0   skip:28  time:524s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1127/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_panel_fitting: Make test pass on gen9's pipe C

[Patchwork]

== Series Details ==

Series: tests/kms_panel_fitting: Make test pass on gen9's pipe C
URL   : https://patchwork.freedesktop.org/series/39952/
State : success

== Summary ==

---- Known issues:

Test gem_eio:
        Subgroup in-flight-contexts:
                pass       -> INCOMPLETE (shard-apl) fdo#105341
Test kms_flip:
        Subgroup 2x-plain-flip-fb-recreate-interruptible:
                fail       -> PASS       (shard-hsw) fdo#100368
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
                pass       -> FAIL       (shard-apl) fdo#101623
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                pass       -> SKIP       (shard-snb) fdo#103375

fdo#105341 https://bugs.freedesktop.org/show_bug.cgi?id=105341
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375

shard-apl        total:3352 pass:1771 dwarn:1   dfail:0   fail:8   skip:1570 time:12610s
shard-hsw        total:3444 pass:1770 dwarn:1   dfail:0   fail:1   skip:1671 time:11938s
shard-snb        total:3444 pass:1359 dwarn:1   dfail:0   fail:2   skip:2082 time:7235s
Blacklisted hosts:
shard-kbl        total:3352 pass:1891 dwarn:1   dfail:0   fail:9   skip:1450 time:9474s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1127/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_panel_fitting: Make test pass on gen9's pipe C

[Maarten Lankhorst]

Op 14-03-18 om 12:04 schreef Chris Wilson:
> Quoting Maarten Lankhorst (2018-03-14 10:54:11)
>> The legacy test fails because it tries scaling on pipe C,
>> because the single scaler is already used for CRTC scaling.
>> On other pipes and newer gens we have 2 scalers, so special
>> case pipe C here.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105456
>> ---
>>  tests/kms_panel_fitting.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
>> index 1f087ecc82a0..5dce101003c5 100644
>> --- a/tests/kms_panel_fitting.c
>> +++ b/tests/kms_panel_fitting.c
>> @@ -133,6 +133,14 @@ static void test_panel_fitting(data_t *d)
>>                 igt_plane_set_size(d->plane2, mode->hdisplay-200, mode->vdisplay-200);
>>                 igt_display_commit2(display, COMMIT_UNIVERSAL);
>>  
>> +               /*
>> +                * gen9 pipe C has only 1 scaler shared with the crtc, which
>> +                * means pipe scaling can't work simultaneously with panel
>> +                * fitting.
> + Since this is the legacy path, userspace has to know about the HW
> limitations, whereas atomic can ask.
Considering this test was about making sure both can be used at the same time, I thought it was better not to ask. :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev