All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: ks7010: remove unnecessary brackets in single statement block
@ 2018-03-11  7:22 Sergio Paracuellos
  2018-03-14 11:45 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Sergio Paracuellos @ 2018-03-11  7:22 UTC (permalink / raw)
  To: gregkh; +Cc: wsa, driverdev-devel

This patch fix the following sparse warning:
    braces {} are not necessary for single statement blocks

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 drivers/staging/ks7010/ks_hostif.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 05f7be4..c05102d 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -1385,9 +1385,8 @@ static __le16 ks_wlan_cap(struct ks_wlan_private *priv)
 {
 	u16 capability = 0x0000;
 
-	if (priv->reg.preamble == SHORT_PREAMBLE) {
+	if (priv->reg.preamble == SHORT_PREAMBLE)
 		capability |= WLAN_CAPABILITY_SHORT_PREAMBLE;
-	}
 
 	capability &= ~(WLAN_CAPABILITY_PBCC);	/* pbcc not support */
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: ks7010: remove unnecessary brackets in single statement block
  2018-03-11  7:22 [PATCH] staging: ks7010: remove unnecessary brackets in single statement block Sergio Paracuellos
@ 2018-03-14 11:45 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-03-14 11:45 UTC (permalink / raw)
  To: Sergio Paracuellos; +Cc: driverdev-devel, wsa

On Sun, Mar 11, 2018 at 08:22:55AM +0100, Sergio Paracuellos wrote:
> This patch fix the following sparse warning:
>     braces {} are not necessary for single statement blocks

sparse gives you this warning?  Are you sure it's not checkpatch that
does this?

Please fix up and resend.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-03-14 11:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-11  7:22 [PATCH] staging: ks7010: remove unnecessary brackets in single statement block Sergio Paracuellos
2018-03-14 11:45 ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.