All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Russell King <linux@armlinux.org.uk>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
Subject: Re: [PATCH v7] ARM: shmobile: Add watchdog support
Date: Wed, 14 Mar 2018 13:43:30 +0100	[thread overview]
Message-ID: <20180314124330.75xbinatpekhm576@verge.net.au> (raw)
In-Reply-To: <1521026033-8494-1-git-send-email-fabrizio.castro@bp.renesas.com>

On Wed, Mar 14, 2018 at 11:13:53AM +0000, Fabrizio Castro wrote:
> On R-Car Gen2 and RZ/G1 platforms, we use the SBAR registers to make non
> boot CPUs run a routine designed to bring up SMP and deal with hot plug.
> The value contained in the SBAR registers is not initialized by a WDT
> triggered reset, which means that after a WDT triggered reset we jump
> to the SMP bring up routine, preventing the system from executing the
> bootrom code.
> 
> The purpose of this patch is to jump to the bootrom code in case of a
> WDT triggered reset, and keep the SMP functionality untouched.
> In order to tell if the code had been called due to the WDT overflowing
> we are testing WOVF from register RWTCSRA.
> 
> The new function shmobile_boot_vector_gen2 isn't replacing
> shmobile_boot_vector for backward compatibility reasons. The kernel
> will install the best option (either shmobile_boot_vector or
> shmobile_boot_vector_gen2) to ICRAM1 after parsing the device tree,
> according to the amount of memory available.
> 
> Since shmobile_boot_vector has become bigger, "reg" property of nodes
> compatible with "renesas,smp-sram" now need to be set to a value
> greater or equal to "<0 0x60>".
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v6->v7:
> * restored ifdef within arch/arm/mach-shmobile/headsmp.S

Thanks. I believe that this is the same as the hand modified
version of v5 that I applied yesterday.

WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7] ARM: shmobile: Add watchdog support
Date: Wed, 14 Mar 2018 13:43:30 +0100	[thread overview]
Message-ID: <20180314124330.75xbinatpekhm576@verge.net.au> (raw)
In-Reply-To: <1521026033-8494-1-git-send-email-fabrizio.castro@bp.renesas.com>

On Wed, Mar 14, 2018 at 11:13:53AM +0000, Fabrizio Castro wrote:
> On R-Car Gen2 and RZ/G1 platforms, we use the SBAR registers to make non
> boot CPUs run a routine designed to bring up SMP and deal with hot plug.
> The value contained in the SBAR registers is not initialized by a WDT
> triggered reset, which means that after a WDT triggered reset we jump
> to the SMP bring up routine, preventing the system from executing the
> bootrom code.
> 
> The purpose of this patch is to jump to the bootrom code in case of a
> WDT triggered reset, and keep the SMP functionality untouched.
> In order to tell if the code had been called due to the WDT overflowing
> we are testing WOVF from register RWTCSRA.
> 
> The new function shmobile_boot_vector_gen2 isn't replacing
> shmobile_boot_vector for backward compatibility reasons. The kernel
> will install the best option (either shmobile_boot_vector or
> shmobile_boot_vector_gen2) to ICRAM1 after parsing the device tree,
> according to the amount of memory available.
> 
> Since shmobile_boot_vector has become bigger, "reg" property of nodes
> compatible with "renesas,smp-sram" now need to be set to a value
> greater or equal to "<0 0x60>".
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v6->v7:
> * restored ifdef within arch/arm/mach-shmobile/headsmp.S

Thanks. I believe that this is the same as the hand modified
version of v5 that I applied yesterday.

  reply	other threads:[~2018-03-14 12:43 UTC|newest]

Thread overview: 177+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 17:44 [PATCH v5 00/26] Fix watchdog on Renesas R-Car Gen2 and RZ/G1 Fabrizio Castro
2018-02-12 17:44 ` Fabrizio Castro
2018-02-12 17:44 ` Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 01/26] ARM: shmobile: Add watchdog support Fabrizio Castro
2018-02-12 17:44   ` Fabrizio Castro
2018-02-28 12:57   ` Geert Uytterhoeven
2018-02-28 12:57     ` Geert Uytterhoeven
2018-02-28 12:57     ` Geert Uytterhoeven
2018-02-28 17:37     ` Fabrizio Castro
2018-02-28 17:37       ` Fabrizio Castro
2018-02-28 17:37       ` Fabrizio Castro
2018-02-28 17:37       ` Fabrizio Castro
2018-02-28 17:40     ` [PATCH v6 " Fabrizio Castro
2018-02-28 17:40       ` Fabrizio Castro
2018-02-28 17:40       ` Fabrizio Castro
2018-03-01  9:44       ` Simon Horman
2018-03-01  9:44         ` Simon Horman
2018-03-01  9:44         ` Simon Horman
2018-03-13 13:43       ` Geert Uytterhoeven
2018-03-13 13:43         ` Geert Uytterhoeven
2018-03-13 13:43         ` Geert Uytterhoeven
2018-03-14 11:02         ` Fabrizio Castro
2018-03-14 11:02           ` Fabrizio Castro
2018-03-14 11:02           ` Fabrizio Castro
2018-03-14 11:02           ` Fabrizio Castro
2018-03-14 11:13         ` [PATCH v7] " Fabrizio Castro
2018-03-14 11:13           ` Fabrizio Castro
2018-03-14 12:43           ` Simon Horman [this message]
2018-03-14 12:43             ` Simon Horman
2018-03-14 13:26             ` Fabrizio Castro
2018-03-14 13:26               ` Fabrizio Castro
2018-03-16 11:49               ` Simon Horman
2018-03-16 11:49                 ` Simon Horman
2018-02-12 17:44 ` [PATCH v5 02/26] ARM: dts: r8a7743: Adjust SMP routine size Fabrizio Castro
2018-02-12 17:44   ` Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 03/26] ARM: dts: r8a7745: " Fabrizio Castro
2018-02-12 17:44   ` Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 04/26] ARM: dts: r8a7790: " Fabrizio Castro
2018-02-12 17:44   ` Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 07/26] ARM: dts: r8a7793: " Fabrizio Castro
2018-02-12 17:44   ` Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 14/26] ARM: shmobile: defconfig: Enable RENESAS_WDT_GEN Fabrizio Castro
2018-02-12 17:44   ` Fabrizio Castro
     [not found]   ` <1518457475-4480-15-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2018-02-13 13:08     ` Fabrizio Castro
2018-02-13 13:08       ` Fabrizio Castro
2018-02-13 13:08       ` Fabrizio Castro
2018-02-13 13:08       ` Fabrizio Castro
     [not found]       ` <TY1PR06MB0895970E6725F954D1A97E4CC0F60-/PRLmSCtZ16EeHdvShrxA20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-02-15 16:20         ` Simon Horman
2018-02-15 16:20           ` Simon Horman
2018-02-15 16:20           ` Simon Horman
2018-05-02  9:38   ` Simon Horman
2018-05-02  9:38     ` Simon Horman
2018-05-02  9:38     ` Simon Horman
2018-02-12 17:44 ` [PATCH v5 15/26] clk: renesas: r8a7743: Add rwdt clock Fabrizio Castro
2018-02-12 17:44   ` Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 16/26] clk: renesas: r8a7745: " Fabrizio Castro
2018-02-12 17:44   ` Fabrizio Castro
     [not found] ` <1518457475-4480-1-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2018-02-12 17:44   ` [PATCH v5 05/26] ARM: dts: r8a7791: Adjust SMP routine size Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44   ` [PATCH v5 06/26] ARM: dts: r8a7792: " Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44   ` [PATCH v5 08/26] ARM: dts: r8a7794: " Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44   ` [PATCH v5 09/26] soc: renesas: rcar-rst: Enable watchdog as reset trigger for Gen2 Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-13  8:19     ` Simon Horman
2018-02-13  8:19       ` Simon Horman
2018-02-13  8:19       ` Simon Horman
2018-02-13 12:57       ` Fabrizio Castro
2018-02-13 12:57         ` Fabrizio Castro
2018-02-13 12:57         ` Fabrizio Castro
2018-02-13 12:57         ` Fabrizio Castro
2018-02-13 13:02       ` [PATCH v6 " Fabrizio Castro
2018-02-13 13:02         ` Fabrizio Castro
2018-02-13 13:02         ` Fabrizio Castro
2018-02-15 16:20         ` Simon Horman
2018-02-15 16:20           ` Simon Horman
2018-02-15 16:20           ` Simon Horman
2018-02-12 17:44   ` [PATCH v5 10/26] ARM: shmobile: rcar-gen2: Add watchdog support Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
     [not found]     ` <1518457475-4480-11-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2018-02-13  8:21       ` Simon Horman
2018-02-13  8:21         ` Simon Horman
2018-02-13  8:21         ` Simon Horman
2018-02-12 17:44   ` [PATCH v5 11/26] dt-bindings: watchdog: renesas-wdt: Add R-Car Gen2 support Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44   ` [PATCH v5 12/26] watchdog: renesas_wdt: " Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
     [not found]     ` <1518457475-4480-13-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2018-02-12 19:24       ` Guenter Roeck
2018-02-12 19:24         ` Guenter Roeck
2018-02-12 19:24         ` Guenter Roeck
2018-02-12 20:58       ` Wolfram Sang
2018-02-12 20:58         ` Wolfram Sang
2018-02-12 20:58         ` Wolfram Sang
2018-02-21 15:43     ` [PATCH] watchdog: renesas_wdt: Blacklist early R-Car Gen2 SoCs Geert Uytterhoeven
2018-02-21 16:22       ` Simon Horman
2018-02-28 17:48       ` Fabrizio Castro
2018-02-28 19:24     ` [PATCH v5 12/26] watchdog: renesas_wdt: Add R-Car Gen2 support Geert Uytterhoeven
2018-02-28 19:24       ` Geert Uytterhoeven
2018-02-28 19:24       ` Geert Uytterhoeven
2018-03-01 15:34       ` Fabrizio Castro
2018-03-01 15:34         ` Fabrizio Castro
2018-03-01 15:34         ` Fabrizio Castro
2018-03-01 15:34         ` Fabrizio Castro
2018-02-12 17:44   ` [PATCH v5 13/26] watchdog: renesas_wdt: Add restart handler Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 20:59     ` Wolfram Sang
2018-02-12 20:59       ` Wolfram Sang
2018-02-12 20:59       ` Wolfram Sang
2018-02-12 17:44   ` [PATCH v5 17/26] clk: renesas: r8a7790: Add rwdt clock Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44   ` [PATCH v5 18/26] clk: renesas: r8a7791/r8a7793: " Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44   ` [PATCH v5 22/26] ARM: dts: r8a7790: Add watchdog support to SoC dtsi Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44   ` [PATCH v5 25/26] ARM: dts: iwg20m: Add watchdog support to SoM dtsi Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44     ` Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 19/26] clk: renesas: r8a7794: Add rwdt clock Fabrizio Castro
2018-02-12 17:44   ` Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 20/26] ARM: dts: r8a7743: Add watchdog support to SoC dtsi Fabrizio Castro
2018-02-12 17:44   ` Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 21/26] ARM: dts: r8a7745: " Fabrizio Castro
2018-02-12 17:44   ` Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 23/26] ARM: dts: r8a7791: " Fabrizio Castro
2018-02-12 17:44   ` Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 24/26] ARM: dts: r8a7794: " Fabrizio Castro
2018-02-12 17:44   ` Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 26/26] ARM: dts: iwg22m: Add watchdog support to SoM dtsi Fabrizio Castro
2018-02-12 17:44   ` Fabrizio Castro
2018-02-13  8:05 ` [PATCH v5 00/26] Fix watchdog on Renesas R-Car Gen2 and RZ/G1 Simon Horman
2018-02-13  8:05   ` Simon Horman
2018-02-13  8:05   ` Simon Horman
2018-02-20 12:51 ` Geert Uytterhoeven
2018-02-20 12:51   ` Geert Uytterhoeven
2018-02-20 12:51   ` Geert Uytterhoeven
2018-02-21 16:13   ` Simon Horman
2018-02-21 16:13     ` Simon Horman
2018-02-21 16:13     ` Simon Horman
2018-02-21 16:30     ` Geert Uytterhoeven
2018-02-21 16:30       ` Geert Uytterhoeven
2018-02-21 16:30       ` Geert Uytterhoeven
2018-02-21 18:32       ` Simon Horman
2018-02-21 18:32         ` Simon Horman
2018-02-21 18:32         ` Simon Horman
2018-02-22  8:38         ` Geert Uytterhoeven
2018-02-22  8:38           ` Geert Uytterhoeven
2018-02-22  8:38           ` Geert Uytterhoeven
2018-02-23  8:14           ` Simon Horman
2018-02-23  8:14             ` Simon Horman
2018-02-23  8:14             ` Simon Horman
2018-03-01 10:20             ` Geert Uytterhoeven
2018-03-01 10:20               ` Geert Uytterhoeven
2018-03-01 10:20               ` Geert Uytterhoeven
2018-03-13 20:05               ` Simon Horman
2018-03-13 20:05                 ` Simon Horman
2018-03-13 20:05                 ` Simon Horman
2018-03-14  8:17                 ` Geert Uytterhoeven
2018-03-14  8:17                   ` Geert Uytterhoeven
2018-03-14  8:17                   ` Geert Uytterhoeven
2018-03-14  8:17                   ` Geert Uytterhoeven
2018-04-18 13:37                 ` Geert Uytterhoeven
2018-04-18 13:37                   ` Geert Uytterhoeven
2018-04-18 13:37                   ` Geert Uytterhoeven
2018-04-24  9:09                   ` Simon Horman
2018-04-24  9:09                     ` Simon Horman
2018-04-24  9:09                     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314124330.75xbinatpekhm576@verge.net.au \
    --to=horms@verge.net.au \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=ramesh.shanmugasundaram@bp.renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.