From: Christoph Hellwig <hch@lst.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Christoph Hellwig <hch@lst.de>,
x86@kernel.org, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
David Woodhouse <dwmw2@infradead.org>,
Muli Ben-Yehuda <mulix@mulix.org>, Jon Mason <jdmason@kudzu.us>,
Joerg Roedel <joro@8bytes.org>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/14] x86: use generic swiotlb_ops
Date: Thu, 15 Mar 2018 12:54:26 +0100 [thread overview]
Message-ID: <20180315115426.GB16210@lst.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1803150956300.1525@nanos.tec.linutronix.de>
On Thu, Mar 15, 2018 at 10:00:57AM +0100, Thomas Gleixner wrote:
> On Wed, 14 Mar 2018, Christoph Hellwig wrote:
> > #if defined(CONFIG_INTEL_IOMMU) || defined(CONFIG_AMD_IOMMU)
> > void *iommu; /* hook for IOMMU specific extension */
> > #endif
> > +#ifdef CONFIG_STA2X11
> > + bool is_sta2x11 : 1;
>
> Huch? Please use either bool or an unsigned int based bitfield. A boolean
> bitfield doesn't make sense.
bool bitfields are perfectly valid in C99 and used in various places in
the kernel. But if you want either bool or an unsigned bitfield let me
know and I'll switch it over.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: Tom Lendacky <thomas.lendacky-5C7GfCeVMHo@public.gmane.org>,
Konrad Rzeszutek Wilk
<konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Muli Ben-Yehuda <mulix-BzGcCpaT2IbYtjvyW6yDsg@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH 04/14] x86: use generic swiotlb_ops
Date: Thu, 15 Mar 2018 12:54:26 +0100 [thread overview]
Message-ID: <20180315115426.GB16210@lst.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1803150956300.1525-ecDvlHI5BZPZikZi3RtOZ1XZhhPuCNm+@public.gmane.org>
On Thu, Mar 15, 2018 at 10:00:57AM +0100, Thomas Gleixner wrote:
> On Wed, 14 Mar 2018, Christoph Hellwig wrote:
> > #if defined(CONFIG_INTEL_IOMMU) || defined(CONFIG_AMD_IOMMU)
> > void *iommu; /* hook for IOMMU specific extension */
> > #endif
> > +#ifdef CONFIG_STA2X11
> > + bool is_sta2x11 : 1;
>
> Huch? Please use either bool or an unsigned int based bitfield. A boolean
> bitfield doesn't make sense.
bool bitfields are perfectly valid in C99 and used in various places in
the kernel. But if you want either bool or an unsigned bitfield let me
know and I'll switch it over.
next prev parent reply other threads:[~2018-03-15 11:54 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 17:51 use generic dma-direct and swiotlb code for x86 V2 Christoph Hellwig
2018-03-14 17:51 ` Christoph Hellwig
2018-03-14 17:52 ` [PATCH 01/14] x86: remove X86_PPRO_FENCE Christoph Hellwig
2018-03-14 17:52 ` Christoph Hellwig
2018-03-14 17:52 ` [PATCH 02/14] x86: remove dma_alloc_coherent_mask Christoph Hellwig
2018-03-14 17:52 ` Christoph Hellwig
2018-03-14 17:52 ` [PATCH 03/14] x86: use dma-direct Christoph Hellwig
2018-03-14 17:52 ` Christoph Hellwig
2018-03-15 8:56 ` Thomas Gleixner
2018-03-15 8:56 ` Thomas Gleixner
2018-03-15 11:53 ` Christoph Hellwig
2018-03-15 12:53 ` Thomas Gleixner
2018-03-15 13:40 ` Christoph Hellwig
2018-03-15 13:40 ` Christoph Hellwig
2018-03-15 13:45 ` Thomas Gleixner
2018-03-15 13:45 ` Thomas Gleixner
2018-03-14 17:52 ` [PATCH 04/14] x86: use generic swiotlb_ops Christoph Hellwig
2018-03-14 17:52 ` Christoph Hellwig
2018-03-15 9:00 ` Thomas Gleixner
2018-03-15 9:00 ` Thomas Gleixner
2018-03-15 11:54 ` Christoph Hellwig [this message]
2018-03-15 11:54 ` Christoph Hellwig
2018-03-15 12:52 ` Thomas Gleixner
2018-03-15 12:52 ` Thomas Gleixner
2018-03-15 13:35 ` Christoph Hellwig
2018-03-15 13:35 ` Christoph Hellwig
2018-03-15 13:48 ` Thomas Gleixner
2018-03-15 13:48 ` Thomas Gleixner
2018-03-14 17:52 ` [PATCH 05/14] x86/amd_gart: look at coherent_dma_mask instead of GFP_DMA Christoph Hellwig
2018-03-14 17:52 ` Christoph Hellwig
2018-03-15 17:47 ` Konrad Rzeszutek Wilk
2018-03-15 17:47 ` Konrad Rzeszutek Wilk
2018-03-14 17:52 ` [PATCH 06/14] x86/amd_gart: use dma_direct_{alloc,free} Christoph Hellwig
2018-03-14 17:52 ` Christoph Hellwig
2018-03-14 17:52 ` [PATCH 07/14] iommu/amd_iommu: " Christoph Hellwig
2018-03-14 17:52 ` Christoph Hellwig
2018-03-15 15:30 ` Joerg Roedel
2018-03-15 15:30 ` Joerg Roedel
2018-03-14 17:52 ` [PATCH 08/14] iommu/intel-iommu: cleanup intel_{alloc,free}_coherent Christoph Hellwig
2018-03-14 17:52 ` Christoph Hellwig
2018-03-14 17:52 ` [PATCH 09/14] x86: remove dma_alloc_coherent_gfp_flags Christoph Hellwig
2018-03-14 17:52 ` Christoph Hellwig
2018-03-14 17:52 ` [PATCH 10/14] set_memory.h: provide set_memory_{en,de}crypted stubs Christoph Hellwig
2018-03-14 17:52 ` Christoph Hellwig
2018-03-15 17:50 ` Konrad Rzeszutek Wilk
2018-03-15 17:50 ` Konrad Rzeszutek Wilk
2018-03-14 17:52 ` [PATCH 11/14] swiotlb: remove swiotlb_set_mem_attributes Christoph Hellwig
2018-03-14 17:52 ` Christoph Hellwig
2018-03-15 17:51 ` Konrad Rzeszutek Wilk
2018-03-15 17:51 ` Konrad Rzeszutek Wilk
2018-03-15 17:54 ` Konrad Rzeszutek Wilk
2018-03-15 17:54 ` Konrad Rzeszutek Wilk
2018-03-14 17:52 ` [PATCH 12/14] dma-direct: handle the memory encryption bit in common code Christoph Hellwig
2018-03-14 17:52 ` Christoph Hellwig
2018-03-14 17:52 ` [PATCH 13/14] dma-direct: handle force decryption for dma coherent buffers " Christoph Hellwig
2018-03-14 17:52 ` Christoph Hellwig
2018-03-14 17:52 ` [PATCH 14/14] swiotlb: remove swiotlb_{alloc,free}_coherent Christoph Hellwig
2018-03-14 17:52 ` Christoph Hellwig
2018-03-19 10:38 use generic dma-direct and swiotlb code for x86 V3 Christoph Hellwig
2018-03-19 10:38 ` [PATCH 04/14] x86: use generic swiotlb_ops Christoph Hellwig
2018-03-19 10:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315115426.GB16210@lst.de \
--to=hch@lst.de \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jdmason@kudzu.us \
--cc=joro@8bytes.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mulix@mulix.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.