All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: "A . s . Dong" <aisheng.dong@nxp.com>,
	devicetree@vger.kernel.org,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	patchwork-lst@pengutronix.de, Rob Herring <robh+dt@kernel.org>,
	linux-imx@nxp.com, kernel@pengutronix.de,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/4] clk: imx: add clock driver for i.MX8MQ CCM
Date: Thu, 15 Mar 2018 22:33:04 +0100	[thread overview]
Message-ID: <20180315213304.ejvgpkhxtblr6xb3@pengutronix.de> (raw)
In-Reply-To: <20180201175412.9480-4-l.stach@pengutronix.de>

On Thu, Feb 01, 2018 at 06:54:12PM +0100, Lucas Stach wrote:
> Add driver for the Clock Control Module found on i.MX8MQ.
> 
> This is largely based on the downstream driver from Anson Huang and
> Bai Ping at NXP, with only some small adaptions to mainline from me.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

A general thought: The i.MX8M finally has a consistent clock tree. We
have for example 70 Peripheral clock slices consisting of a mux, a gate
and two dividers, all 70 looking the same.
For these it might make sense to create a more complex clock type
providing mux, gate and set rate functionality in one clock. This would
drastically reduce the number of clocks we have to handle.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	"A . s . Dong" <aisheng.dong@nxp.com>,
	devicetree@vger.kernel.org, patchwork-lst@pengutronix.de,
	Rob Herring <robh+dt@kernel.org>,
	linux-imx@nxp.com, kernel@pengutronix.de,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/4] clk: imx: add clock driver for i.MX8MQ CCM
Date: Thu, 15 Mar 2018 22:33:04 +0100	[thread overview]
Message-ID: <20180315213304.ejvgpkhxtblr6xb3@pengutronix.de> (raw)
In-Reply-To: <20180201175412.9480-4-l.stach@pengutronix.de>

On Thu, Feb 01, 2018 at 06:54:12PM +0100, Lucas Stach wrote:
> Add driver for the Clock Control Module found on i.MX8MQ.
> 
> This is largely based on the downstream driver from Anson Huang and
> Bai Ping at NXP, with only some small adaptions to mainline from me.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

A general thought: The i.MX8M finally has a consistent clock tree. We
have for example 70 Peripheral clock slices consisting of a mux, a gate
and two dividers, all 70 looking the same.
For these it might make sense to create a more complex clock type
providing mux, gate and set rate functionality in one clock. This would
drastically reduce the number of clocks we have to handle.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] clk: imx: add clock driver for i.MX8MQ CCM
Date: Thu, 15 Mar 2018 22:33:04 +0100	[thread overview]
Message-ID: <20180315213304.ejvgpkhxtblr6xb3@pengutronix.de> (raw)
In-Reply-To: <20180201175412.9480-4-l.stach@pengutronix.de>

On Thu, Feb 01, 2018 at 06:54:12PM +0100, Lucas Stach wrote:
> Add driver for the Clock Control Module found on i.MX8MQ.
> 
> This is largely based on the downstream driver from Anson Huang and
> Bai Ping at NXP, with only some small adaptions to mainline from me.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

A general thought: The i.MX8M finally has a consistent clock tree. We
have for example 70 Peripheral clock slices consisting of a mux, a gate
and two dividers, all 70 looking the same.
For these it might make sense to create a more complex clock type
providing mux, gate and set rate functionality in one clock. This would
drastically reduce the number of clocks we have to handle.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2018-03-15 21:33 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-01 17:54 [PATCH v2 1/4] dt-bindings: add binding for i.MX8MQ CCM Lucas Stach
2018-02-01 17:54 ` Lucas Stach
2018-02-01 17:54 ` Lucas Stach
2018-02-01 17:54 ` [PATCH v2 2/4] clk: imx: add fractional PLL output clock Lucas Stach
2018-02-01 17:54   ` Lucas Stach
2018-02-23  6:55   ` Shawn Guo
2018-02-23  6:55     ` Shawn Guo
2018-02-23  6:55     ` Shawn Guo
2018-02-28 10:14   ` Dong Aisheng
2018-02-28 10:14     ` Dong Aisheng
2018-02-28 10:14     ` Dong Aisheng
2018-02-01 17:54 ` [PATCH v2 4/4] clk: imx: add clock driver for i.MX8MQ CCM Lucas Stach
2018-02-01 17:54   ` Lucas Stach
2018-02-23  9:20   ` Shawn Guo
2018-02-23  9:20     ` Shawn Guo
2018-02-23  9:20     ` Shawn Guo
2018-02-24  3:54   ` Shawn Guo
2018-02-24  3:54     ` Shawn Guo
2018-02-24  3:54     ` Shawn Guo
2018-02-28 12:23   ` Dong Aisheng
2018-02-28 12:23     ` Dong Aisheng
2018-02-28 12:23     ` Dong Aisheng
2018-03-15 21:33   ` Sascha Hauer [this message]
2018-03-15 21:33     ` Sascha Hauer
2018-03-15 21:33     ` Sascha Hauer
2018-03-16 10:10     ` Lucas Stach
2018-03-16 10:10       ` Lucas Stach
2018-03-16 10:10       ` Lucas Stach
2018-03-16 10:29       ` A.s. Dong
2018-03-16 10:29         ` A.s. Dong
2018-03-16 10:29         ` A.s. Dong
     [not found] ` <20180201175412.9480-1-l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2018-02-01 17:54   ` [PATCH v2 3/4] clk: imx: add SCCG PLL type Lucas Stach
2018-02-01 17:54     ` Lucas Stach
2018-02-01 17:54     ` Lucas Stach
2018-02-23  8:46     ` Shawn Guo
2018-02-23  8:46       ` Shawn Guo
2018-02-23  8:46       ` Shawn Guo
2018-02-28 12:03     ` Dong Aisheng
2018-02-28 12:03       ` Dong Aisheng
2018-02-28 12:03       ` Dong Aisheng
2018-02-12 13:35   ` [PATCH v2 1/4] dt-bindings: add binding for i.MX8MQ CCM Shawn Guo
2018-02-12 13:35     ` Shawn Guo
2018-02-12 13:35     ` Shawn Guo
2018-02-22  3:55 ` Shawn Guo
2018-02-22  3:55   ` Shawn Guo
2018-02-22  3:55   ` Shawn Guo
2018-02-22 14:12   ` Shawn Guo
2018-02-22 14:12     ` Shawn Guo
2018-02-23  9:29     ` Shawn Guo
2018-02-23  9:29       ` Shawn Guo
2018-02-23  4:05 ` Shawn Guo
2018-02-23  4:05   ` Shawn Guo
2018-02-23  4:05   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180315213304.ejvgpkhxtblr6xb3@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=mturquette@baylibre.com \
    --cc=patchwork-lst@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.