Re: [PATCH v3 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
	Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf
Date: Fri, 16 Mar 2018 12:21:29 +0000	[thread overview]
Message-ID: <20180316122129.GA2458@linux.intel.com> (raw)
In-Reply-To: <1520290344.10396.357.camel@linux.vnet.ibm.com>

On Mon, Mar 05, 2018 at 05:52:24PM -0500, Mimi Zohar wrote:
> Hi Jarrko,
> 
> On Mon, 2018-03-05 at 18:56 +0200, Jarkko Sakkinen wrote:
> > In order to make struct tpm_buf the first class object for constructing TPM
> > commands, migrate tpm2_probe() to use it.
> > 
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> With this patch, the Pi doesn't find the TPM.  I'm seeing the
> following line in dmesg.
> 
> [    1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256

Thank you for reporting this Mimi. Does it have TPM1/TPM2?

/Jarkko

WARNING: multiple messages have this Message-ID (diff)

From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
	Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf
Date: Fri, 16 Mar 2018 14:21:29 +0200	[thread overview]
Message-ID: <20180316122129.GA2458@linux.intel.com> (raw)
In-Reply-To: <1520290344.10396.357.camel@linux.vnet.ibm.com>

On Mon, Mar 05, 2018 at 05:52:24PM -0500, Mimi Zohar wrote:
> Hi Jarrko,
> 
> On Mon, 2018-03-05 at 18:56 +0200, Jarkko Sakkinen wrote:
> > In order to make struct tpm_buf the first class object for constructing TPM
> > commands, migrate tpm2_probe() to use it.
> > 
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> With this patch, the Pi doesn't find the TPM.  I'm seeing the
> following line in dmesg.
> 
> [    1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256

Thank you for reporting this Mimi. Does it have TPM1/TPM2?

/Jarkko

WARNING: multiple messages have this Message-ID (diff)

From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v3 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf
Date: Fri, 16 Mar 2018 14:21:29 +0200	[thread overview]
Message-ID: <20180316122129.GA2458@linux.intel.com> (raw)
In-Reply-To: <1520290344.10396.357.camel@linux.vnet.ibm.com>

On Mon, Mar 05, 2018 at 05:52:24PM -0500, Mimi Zohar wrote:
> Hi Jarrko,
> 
> On Mon, 2018-03-05 at 18:56 +0200, Jarkko Sakkinen wrote:
> > In order to make struct tpm_buf the first class object for constructing TPM
> > commands, migrate tpm2_probe() to use it.
> > 
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> With this patch, the Pi doesn't find the TPM. ?I'm seeing the
> following line in dmesg.
> 
> [????1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256

Thank you for reporting this Mimi. Does it have TPM1/TPM2?

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)

From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
	Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf
Date: Fri, 16 Mar 2018 14:21:29 +0200	[thread overview]
Message-ID: <20180316122129.GA2458@linux.intel.com> (raw)
In-Reply-To: <1520290344.10396.357.camel@linux.vnet.ibm.com>

On Mon, Mar 05, 2018 at 05:52:24PM -0500, Mimi Zohar wrote:
> Hi Jarrko,
> 
> On Mon, 2018-03-05 at 18:56 +0200, Jarkko Sakkinen wrote:
> > In order to make struct tpm_buf the first class object for constructing TPM
> > commands, migrate tpm2_probe() to use it.
> > 
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> With this patch, the Pi doesn't find the TPM.  I'm seeing the
> following line in dmesg.
> 
> [    1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256

Thank you for reporting this Mimi. Does it have TPM1/TPM2?

/Jarkko

next prev parent reply	other threads:[~2018-03-16 12:21 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-05 16:56 [PATCH v3 0/5] Migrate all TPM 2.0 commands to use struct tpm_buf Jarkko Sakkinen
2018-03-05 16:56 ` Jarkko Sakkinen
2018-03-05 16:56 ` Jarkko Sakkinen
2018-03-05 16:56 ` [PATCH v3 1/5] tpm: fix intermittent failure with self tests Jarkko Sakkinen
2018-03-05 16:56   ` Jarkko Sakkinen
2018-03-05 16:56   ` Jarkko Sakkinen
2018-03-12 11:13   ` Jarkko Sakkinen
2018-03-12 11:13     ` Jarkko Sakkinen
2018-03-12 11:13     ` Jarkko Sakkinen
2018-03-17  1:20   ` James Bottomley
2018-03-17  1:20     ` James Bottomley
2018-03-17  1:20     ` James Bottomley
2018-03-17  1:20     ` James Bottomley
2018-03-19 21:06     ` Jarkko Sakkinen
2018-03-19 21:06       ` Jarkko Sakkinen
2018-03-19 21:06       ` Jarkko Sakkinen
2018-03-19 21:06       ` Jarkko Sakkinen
2018-03-19 21:06       ` Jarkko Sakkinen
2018-03-05 16:56 ` [PATCH v3 2/5] tpm: migrate tpm2_shutdown() to use struct tpm_buf Jarkko Sakkinen
2018-03-05 16:56   ` Jarkko Sakkinen
2018-03-05 16:56   ` Jarkko Sakkinen
2018-03-05 16:56 ` [PATCH v3 3/5] tpm: migrate tpm2_probe() " Jarkko Sakkinen
2018-03-05 16:56   ` Jarkko Sakkinen
2018-03-05 16:56   ` Jarkko Sakkinen
2018-03-05 22:52   ` Mimi Zohar
2018-03-05 22:52     ` Mimi Zohar
2018-03-05 22:52     ` Mimi Zohar
2018-03-05 22:52     ` Mimi Zohar
2018-03-16 12:21     ` Jarkko Sakkinen [this message]
2018-03-16 12:21       ` Jarkko Sakkinen
2018-03-16 12:21       ` Jarkko Sakkinen
2018-03-16 12:21       ` Jarkko Sakkinen
2018-03-16 12:36       ` Mimi Zohar
2018-03-16 12:36         ` Mimi Zohar
2018-03-16 12:36         ` Mimi Zohar
2018-03-16 12:36         ` Mimi Zohar
2018-03-19 14:42         ` Jarkko Sakkinen
2018-03-19 14:42           ` Jarkko Sakkinen
2018-03-19 14:42           ` Jarkko Sakkinen
2018-03-19 14:42           ` Jarkko Sakkinen
2018-03-06 11:37   ` Jarkko Sakkinen
2018-03-06 11:37     ` Jarkko Sakkinen
2018-03-06 11:37     ` Jarkko Sakkinen
2018-03-06 11:37     ` Jarkko Sakkinen
2018-03-06 15:44     ` Jason Gunthorpe
2018-03-06 15:44       ` Jason Gunthorpe
2018-03-06 15:44       ` Jason Gunthorpe
2018-03-08 21:47   ` J Freyensee
2018-03-08 21:47     ` J Freyensee
2018-03-08 21:47     ` J Freyensee
2018-03-10 13:11     ` Jarkko Sakkinen
2018-03-10 13:11       ` Jarkko Sakkinen
2018-03-10 13:11       ` Jarkko Sakkinen
2018-03-10 13:11       ` Jarkko Sakkinen
2018-03-05 16:56 ` [PATCH v3 4/5] tpm: migrate tpm2_get_tpm_pt() " Jarkko Sakkinen
2018-03-05 16:56   ` Jarkko Sakkinen
2018-03-05 16:56   ` Jarkko Sakkinen
2018-03-05 16:56 ` [PATCH v3 5/5] tpm: migrate tpm2_get_random() " Jarkko Sakkinen
2018-03-05 16:56   ` Jarkko Sakkinen
2018-03-05 16:56   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180316122129.GA2458@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jgg@ziepe.ca \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.