All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support
@ 2018-03-16 18:02 Martin Bark
  2018-03-16 18:02 ` [Buildroot] [PATCH v3 1/7] package/rpi-firmware: bump version Martin Bark
                   ` (7 more replies)
  0 siblings, 8 replies; 17+ messages in thread
From: Martin Bark @ 2018-03-16 18:02 UTC (permalink / raw)
  To: buildroot

All,

This is a patch set to add rpi3 b+ support.  It includes:

- bump all the rpi configs to the latest 4.14.26 kernel
- update the rpi-firmware to latest version
- add the rpi3 b+ dtb files.
- add the new wifi and bt firmware for the rpi3 b+

I can confirm the basics of wired & wireless networks and serial all work on the rpi3 and rpi3 b+.  The bluetooth device comes up on the rpi3 b+ but i have not tried anything more that scanning.

Note there is no definitive place to download the all the necessary wifi and bt firmware files.  The closest reliable source i have found is the LibreELEC github repo where they have copied the wifi and bt firmware from raspbian into one place.  I have updated to using this repo.  The only issue is it lacks the license files.  I have sent a pull request to add the missing license, once it has been accepted I will update the wifi and bt firmware packages.

Thanks

Martin

Martin Bark (7):
  package/rpi-firmware: bump version
  configs/raspberrypi*: bump kernel version
  board/raspberrypi: add support for rpi3 b+
  package/rpi-firmware: improve installation of dtb files
  package/rpi-bt-firmware: change to LibreELEC github repo
  package/rpi-wifi-firmware: change to LibreELEC github repo
  DEVELOPERS: add myself for rpi packages

 DEVELOPERS                                       |  5 +++++
 board/raspberrypi/genimage-raspberrypi3.cfg      |  1 +
 board/raspberrypi/readme.txt                     |  3 ++-
 configs/raspberrypi0_defconfig                   |  6 +++---
 configs/raspberrypi2_defconfig                   |  6 +++---
 configs/raspberrypi3_64_defconfig                |  6 +++---
 configs/raspberrypi3_defconfig                   |  8 ++++----
 configs/raspberrypi3_qt5we_defconfig             |  8 ++++----
 configs/raspberrypi_defconfig                    |  6 +++---
 package/rpi-bt-firmware/Config.in                |  5 +++--
 package/rpi-bt-firmware/rpi-bt-firmware.hash     |  2 +-
 package/rpi-bt-firmware/rpi-bt-firmware.mk       | 13 +++++++------
 package/rpi-firmware/rpi-firmware.hash           |  2 +-
 package/rpi-firmware/rpi-firmware.mk             |  9 ++++-----
 package/rpi-wifi-firmware/Config.in              |  5 +++--
 package/rpi-wifi-firmware/rpi-wifi-firmware.hash |  2 +-
 package/rpi-wifi-firmware/rpi-wifi-firmware.mk   | 17 +++++++----------
 17 files changed, 55 insertions(+), 49 deletions(-)

--
2.16.2

^ permalink raw reply	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 1/7] package/rpi-firmware: bump version
  2018-03-16 18:02 [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support Martin Bark
@ 2018-03-16 18:02 ` Martin Bark
  2018-03-16 18:02 ` [Buildroot] [PATCH v3 2/7] configs/raspberrypi*: bump kernel version Martin Bark
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 17+ messages in thread
From: Martin Bark @ 2018-03-16 18:02 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Martin Bark <martin@barkynet.com>

----
Changes v1 -> v2:
 - none

Changes v2 -> v3:
 - none
---
 package/rpi-firmware/rpi-firmware.hash | 2 +-
 package/rpi-firmware/rpi-firmware.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/rpi-firmware/rpi-firmware.hash b/package/rpi-firmware/rpi-firmware.hash
index 833a7fbe37..0e09ff50b4 100644
--- a/package/rpi-firmware/rpi-firmware.hash
+++ b/package/rpi-firmware/rpi-firmware.hash
@@ -1,2 +1,2 @@
 # Locally computed
-sha256 0451e1a843bf02df81126a1625d9a15dfdf19dcb2f9e95b0613a63e59fd31ca8 rpi-firmware-2067241bc7cdf238fdeab7f5a3c22faa57dd5617.tar.gz
+sha256 8fe5ebe14cc900f67242cab0c1c9f8e29bd10369ccbdfc7d004c294a96bad975 rpi-firmware-086a8488de0f485e8879ac14ff505ff1d922eeed.tar.gz
diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
index 22eaaa2886..1ebdd96718 100644
--- a/package/rpi-firmware/rpi-firmware.mk
+++ b/package/rpi-firmware/rpi-firmware.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RPI_FIRMWARE_VERSION = 2067241bc7cdf238fdeab7f5a3c22faa57dd5617
+RPI_FIRMWARE_VERSION = 086a8488de0f485e8879ac14ff505ff1d922eeed
 RPI_FIRMWARE_SITE = $(call github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
 RPI_FIRMWARE_LICENSE = BSD-3-Clause
 RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 2/7] configs/raspberrypi*: bump kernel version
  2018-03-16 18:02 [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support Martin Bark
  2018-03-16 18:02 ` [Buildroot] [PATCH v3 1/7] package/rpi-firmware: bump version Martin Bark
@ 2018-03-16 18:02 ` Martin Bark
  2018-03-16 18:02 ` [Buildroot] [PATCH v3 3/7] board/raspberrypi: add support for rpi3 b+ Martin Bark
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 17+ messages in thread
From: Martin Bark @ 2018-03-16 18:02 UTC (permalink / raw)
  To: buildroot

Now based on 4.14.26 (from 4.9.79)

Signed-off-by: Martin Bark <martin@barkynet.com>

----
Changes v1 -> v2:
 - Updated to use 4.14.26 kernel

Changes v2 -> v3:
 - none
---
 configs/raspberrypi0_defconfig       | 6 +++---
 configs/raspberrypi2_defconfig       | 6 +++---
 configs/raspberrypi3_64_defconfig    | 6 +++---
 configs/raspberrypi3_defconfig       | 6 +++---
 configs/raspberrypi3_qt5we_defconfig | 6 +++---
 configs/raspberrypi_defconfig        | 6 +++---
 6 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/configs/raspberrypi0_defconfig b/configs/raspberrypi0_defconfig
index 0fb8a99465..a2661be59a 100644
--- a/configs/raspberrypi0_defconfig
+++ b/configs/raspberrypi0_defconfig
@@ -2,15 +2,15 @@ BR2_arm=y
 BR2_arm1176jzf_s=y
 BR2_ARM_EABIHF=y
 
-# Linux headers same as kernel, a 4.9 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_9=y
+# Linux headers same as kernel, a 4.14 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
 
 BR2_TOOLCHAIN_BUILDROOT_CXX=y
 
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="33ee56d5927ceff630fbc87e3f5caa409b6ae114"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="ad350a581a442f790b54abb81364295e937fe26b"
 BR2_LINUX_KERNEL_DEFCONFIG="bcmrpi"
 
 # Build the DTBs for A/B from the kernel sources: the zero is the same
diff --git a/configs/raspberrypi2_defconfig b/configs/raspberrypi2_defconfig
index 962a58cefb..2b4498c41f 100644
--- a/configs/raspberrypi2_defconfig
+++ b/configs/raspberrypi2_defconfig
@@ -7,13 +7,13 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
 
 BR2_SYSTEM_DHCP="eth0"
 
-# Linux headers same as kernel, a 4.9 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_9=y
+# Linux headers same as kernel, a 4.14 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
 
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="33ee56d5927ceff630fbc87e3f5caa409b6ae114"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="ad350a581a442f790b54abb81364295e937fe26b"
 BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
 
 # Build the DTB from the kernel sources
diff --git a/configs/raspberrypi3_64_defconfig b/configs/raspberrypi3_64_defconfig
index 6a35ac36a1..d7cce387fb 100644
--- a/configs/raspberrypi3_64_defconfig
+++ b/configs/raspberrypi3_64_defconfig
@@ -6,13 +6,13 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
 
 BR2_SYSTEM_DHCP="eth0"
 
-# Linux headers same as kernel, a 4.9 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_9=y
+# Linux headers same as kernel, a 4.14 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
 
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="33ee56d5927ceff630fbc87e3f5caa409b6ae114"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="ad350a581a442f790b54abb81364295e937fe26b"
 BR2_LINUX_KERNEL_DEFCONFIG="bcmrpi3"
 
 # Build the DTB from the kernel sources
diff --git a/configs/raspberrypi3_defconfig b/configs/raspberrypi3_defconfig
index 9304f0cb74..a8217cfd12 100644
--- a/configs/raspberrypi3_defconfig
+++ b/configs/raspberrypi3_defconfig
@@ -6,13 +6,13 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
 
 BR2_SYSTEM_DHCP="eth0"
 
-# Linux headers same as kernel, a 4.9 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_9=y
+# Linux headers same as kernel, a 4.14 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
 
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="33ee56d5927ceff630fbc87e3f5caa409b6ae114"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="ad350a581a442f790b54abb81364295e937fe26b"
 BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
 
 # Build the DTB from the kernel sources
diff --git a/configs/raspberrypi3_qt5we_defconfig b/configs/raspberrypi3_qt5we_defconfig
index d4ada47588..b8458c6742 100644
--- a/configs/raspberrypi3_qt5we_defconfig
+++ b/configs/raspberrypi3_qt5we_defconfig
@@ -7,13 +7,13 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
 
 BR2_SYSTEM_DHCP="eth0"
 
-# Linux headers same as kernel, a 4.9 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_9=y
+# Linux headers same as kernel, a 4.14 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
 
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="33ee56d5927ceff630fbc87e3f5caa409b6ae114"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="ad350a581a442f790b54abb81364295e937fe26b"
 BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
 
 # Build the DTB from the kernel sources
diff --git a/configs/raspberrypi_defconfig b/configs/raspberrypi_defconfig
index daca8362e6..17829ef56d 100644
--- a/configs/raspberrypi_defconfig
+++ b/configs/raspberrypi_defconfig
@@ -4,15 +4,15 @@ BR2_ARM_EABIHF=y
 
 BR2_SYSTEM_DHCP="eth0"
 
-# Linux headers same as kernel, a 4.9 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_9=y
+# Linux headers same as kernel, a 4.14 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
 
 BR2_TOOLCHAIN_BUILDROOT_CXX=y
 
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="33ee56d5927ceff630fbc87e3f5caa409b6ae114"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="ad350a581a442f790b54abb81364295e937fe26b"
 BR2_LINUX_KERNEL_DEFCONFIG="bcmrpi"
 
 # Build the DTBs for A/B, A+/B+ and compute module from the kernel sources
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 3/7] board/raspberrypi: add support for rpi3 b+
  2018-03-16 18:02 [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support Martin Bark
  2018-03-16 18:02 ` [Buildroot] [PATCH v3 1/7] package/rpi-firmware: bump version Martin Bark
  2018-03-16 18:02 ` [Buildroot] [PATCH v3 2/7] configs/raspberrypi*: bump kernel version Martin Bark
@ 2018-03-16 18:02 ` Martin Bark
  2018-03-16 18:02 ` [Buildroot] [PATCH v3 4/7] package/rpi-firmware: improve installation of dtb files Martin Bark
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 17+ messages in thread
From: Martin Bark @ 2018-03-16 18:02 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Martin Bark <martin@barkynet.com>

----
Changes v1 -> v2:
 - none

Changes v2 -> v3:
 - none
---
 board/raspberrypi/genimage-raspberrypi3.cfg | 1 +
 board/raspberrypi/readme.txt                | 3 ++-
 configs/raspberrypi3_defconfig              | 2 +-
 configs/raspberrypi3_qt5we_defconfig        | 2 +-
 4 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/board/raspberrypi/genimage-raspberrypi3.cfg b/board/raspberrypi/genimage-raspberrypi3.cfg
index 98ff709035..0a547241f4 100644
--- a/board/raspberrypi/genimage-raspberrypi3.cfg
+++ b/board/raspberrypi/genimage-raspberrypi3.cfg
@@ -2,6 +2,7 @@ image boot.vfat {
   vfat {
     files = {
       "bcm2710-rpi-3-b.dtb",
+      "bcm2710-rpi-3-b-plus.dtb",
       "bcm2710-rpi-cm3.dtb",
       "rpi-firmware/bootcode.bin",
       "rpi-firmware/cmdline.txt",
diff --git a/board/raspberrypi/readme.txt b/board/raspberrypi/readme.txt
index 948269347b..9f91581054 100644
--- a/board/raspberrypi/readme.txt
+++ b/board/raspberrypi/readme.txt
@@ -30,7 +30,7 @@ For model 2 B:
 
   $ make raspberrypi2_defconfig
 
-For model 3 B:
+For model 3 B and B+:
 
   $ make raspberrypi3_defconfig
 
@@ -56,6 +56,7 @@ After building, you should obtain this tree:
     +-- bcm2708-rpi-b-plus.dtb      [1]
     +-- bcm2709-rpi-2-b.dtb         [1]
     +-- bcm2710-rpi-3-b.dtb         [1]
+    +-- bcm2710-rpi-3-b-plus.dtb    [1]
     +-- boot.vfat
     +-- rootfs.ext4
     +-- rpi-firmware/
diff --git a/configs/raspberrypi3_defconfig b/configs/raspberrypi3_defconfig
index a8217cfd12..062dbbd43a 100644
--- a/configs/raspberrypi3_defconfig
+++ b/configs/raspberrypi3_defconfig
@@ -17,7 +17,7 @@ BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
 
 # Build the DTB from the kernel sources
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="bcm2710-rpi-3-b bcm2710-rpi-cm3"
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="bcm2710-rpi-3-b bcm2710-rpi-3-b-plus bcm2710-rpi-cm3"
 
 BR2_PACKAGE_RPI_FIRMWARE=y
 
diff --git a/configs/raspberrypi3_qt5we_defconfig b/configs/raspberrypi3_qt5we_defconfig
index b8458c6742..5e91390630 100644
--- a/configs/raspberrypi3_qt5we_defconfig
+++ b/configs/raspberrypi3_qt5we_defconfig
@@ -18,7 +18,7 @@ BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
 
 # Build the DTB from the kernel sources
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="bcm2710-rpi-3-b bcm2710-rpi-cm3"
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="bcm2710-rpi-3-b bcm2710-rpi-3-b-plus bcm2710-rpi-cm3"
 
 # Build Qt5 WebEngine
 BR2_PACKAGE_LIBERATION=y
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 4/7] package/rpi-firmware: improve installation of dtb files
  2018-03-16 18:02 [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support Martin Bark
                   ` (2 preceding siblings ...)
  2018-03-16 18:02 ` [Buildroot] [PATCH v3 3/7] board/raspberrypi: add support for rpi3 b+ Martin Bark
@ 2018-03-16 18:02 ` Martin Bark
  2018-03-16 18:02 ` [Buildroot] [PATCH v3 5/7] package/rpi-bt-firmware: change to LibreELEC github repo Martin Bark
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 17+ messages in thread
From: Martin Bark @ 2018-03-16 18:02 UTC (permalink / raw)
  To: buildroot

Don't list specific dtb files, instead install all dtb files in the same
way as dtbo files are currently done.

Signed-off-by: Martin Bark <martin@barkynet.com>

----
Changes v1 -> v2:
 - none

Changes v2 -> v3:
 - none
---
 package/rpi-firmware/rpi-firmware.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
index 1ebdd96718..9cc3d4a207 100644
--- a/package/rpi-firmware/rpi-firmware.mk
+++ b/package/rpi-firmware/rpi-firmware.mk
@@ -12,10 +12,9 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
 
 ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
 define RPI_FIRMWARE_INSTALL_DTB
-	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
-	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb
-	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2709-rpi-2-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2709-rpi-2-b.dtb
-	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2710-rpi-3-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2710-rpi-3-b.dtb
+	for dtb in  $(@D)/boot/*.dtb; do \
+		$(INSTALL) -D -m 0644 $${dtb} $(BINARIES_DIR)/rpi-firmware/$${dtb##*/} || exit 1; \
+	done
 endef
 endif
 
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 5/7] package/rpi-bt-firmware: change to LibreELEC github repo
  2018-03-16 18:02 [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support Martin Bark
                   ` (3 preceding siblings ...)
  2018-03-16 18:02 ` [Buildroot] [PATCH v3 4/7] package/rpi-firmware: improve installation of dtb files Martin Bark
@ 2018-03-16 18:02 ` Martin Bark
  2018-03-16 18:02 ` [Buildroot] [PATCH v3 6/7] package/rpi-wifi-firmware: " Martin Bark
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 17+ messages in thread
From: Martin Bark @ 2018-03-16 18:02 UTC (permalink / raw)
  To: buildroot

Include BCM4345C0.hcd for the rpi3 b+

Signed-off-by: Martin Bark <martin@barkynet.com>

---
Changed v2 -> v3
 - new in v3
---
 package/rpi-bt-firmware/Config.in            |  5 +++--
 package/rpi-bt-firmware/rpi-bt-firmware.hash |  2 +-
 package/rpi-bt-firmware/rpi-bt-firmware.mk   | 13 +++++++------
 3 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/package/rpi-bt-firmware/Config.in b/package/rpi-bt-firmware/Config.in
index dfc1cee06c..45643d6a52 100644
--- a/package/rpi-bt-firmware/Config.in
+++ b/package/rpi-bt-firmware/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_RPI_BT_FIRMWARE
 	depends on BR2_arm || BR2_aarch64
 	help
 	  Raspberry Pi 3 and Zero W Broadcom BCM43438 Bluetooth module
-	  firmware.
+	  firmware. Raspberry Pi 3 Model B+ Broadcom BCM4345C0
+	  Bluetooth module firmware.
 
-	  https://aur.archlinux.org/packages/pi-bluetooth
+	  https://github.com/LibreELEC/brcmfmac_sdio-firmware-rpi
diff --git a/package/rpi-bt-firmware/rpi-bt-firmware.hash b/package/rpi-bt-firmware/rpi-bt-firmware.hash
index f1d06e8ca8..922e0666d4 100644
--- a/package/rpi-bt-firmware/rpi-bt-firmware.hash
+++ b/package/rpi-bt-firmware/rpi-bt-firmware.hash
@@ -1,2 +1,2 @@
 # Locally computed
-sha256 5d9c9364277414ffd67b4a266cdf88e92f28eb937e5a413750e87b7a94161bef  rpi-bt-firmware-a439f892bf549ddfefa9ba7ad1999cc515f233bf.tar.gz
+sha256 2a6e8f492878ca1de5347f17ab239006db61215c48276fa6ea6e578f3cc5b58d  rpi-bt-firmware-f0dc870f707118fa000f6ee47ec05e7eaa57b917.tar.gz
diff --git a/package/rpi-bt-firmware/rpi-bt-firmware.mk b/package/rpi-bt-firmware/rpi-bt-firmware.mk
index 255da19262..ed76586fd6 100644
--- a/package/rpi-bt-firmware/rpi-bt-firmware.mk
+++ b/package/rpi-bt-firmware/rpi-bt-firmware.mk
@@ -4,18 +4,19 @@
 #
 ################################################################################
 
-RPI_BT_FIRMWARE_VERSION = a439f892bf549ddfefa9ba7ad1999cc515f233bf
-RPI_BT_FIRMWARE_SITE = https://aur.archlinux.org/pi-bluetooth.git
-RPI_BT_FIRMWARE_SITE_METHOD = git
+RPI_BT_FIRMWARE_VERSION = f0dc870f707118fa000f6ee47ec05e7eaa57b917
+RPI_BT_FIRMWARE_SITE = $(call github,LibreELEC,brcmfmac_sdio-firmware-rpi,$(RPI_BT_FIRMWARE_VERSION))
 RPI_BT_FIRMWARE_LICENSE = PROPRIETARY
-RPI_BT_FIRMWARE_LICENSE_FILES = LICENCE.broadcom_bcm43xx
+
+RPI_BT_FIRMWARE_FILES = brcm/BCM43430A1.hcd BCM4345C0.hcd
 
 # The BlueZ hciattach utility looks for firmware in /etc/firmware. Add a
 # compatibility symlink.
 define RPI_BT_FIRMWARE_INSTALL_TARGET_CMDS
 	ln -sf ../lib/firmware $(TARGET_DIR)/etc/firmware
-	$(INSTALL) -D -m 0644 $(@D)/BCM43430A1.hcd \
-		$(TARGET_DIR)/lib/firmware/BCM43430A1.hcd
+	for file in $(RPI_BT_FIRMWARE_FILES); do \
+		$(INSTALL) -D -m 0644 $(@D)/firmware/$${file} $(TARGET_DIR)/lib/firmware/$${file##*/}; \
+	done
 endef
 
 $(eval $(generic-package))
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 6/7] package/rpi-wifi-firmware: change to LibreELEC github repo
  2018-03-16 18:02 [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support Martin Bark
                   ` (4 preceding siblings ...)
  2018-03-16 18:02 ` [Buildroot] [PATCH v3 5/7] package/rpi-bt-firmware: change to LibreELEC github repo Martin Bark
@ 2018-03-16 18:02 ` Martin Bark
  2018-03-16 18:02 ` [Buildroot] [PATCH v3 7/7] DEVELOPERS: add myself for rpi packages Martin Bark
  2018-03-16 19:41 ` [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support Thomas Petazzoni
  7 siblings, 0 replies; 17+ messages in thread
From: Martin Bark @ 2018-03-16 18:02 UTC (permalink / raw)
  To: buildroot

Include brcmfmac43455-sdio.txt for the rpi3 b+

Signed-off-by: Martin Bark <martin@barkynet.com>
Cc: Jens Maus <mail@jens-maus.de>

---
Changes v2 -> v3
 - New in v3 (suggested by Jens Maus)
---
 package/rpi-wifi-firmware/Config.in              |  5 +++--
 package/rpi-wifi-firmware/rpi-wifi-firmware.hash |  2 +-
 package/rpi-wifi-firmware/rpi-wifi-firmware.mk   | 17 +++++++----------
 3 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/package/rpi-wifi-firmware/Config.in b/package/rpi-wifi-firmware/Config.in
index 2c87c75842..c2d6e675e2 100644
--- a/package/rpi-wifi-firmware/Config.in
+++ b/package/rpi-wifi-firmware/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_RPI_WIFI_FIRMWARE
 	select BR2_PACKAGE_LINUX_FIRMWARE_BRCM_BCM43XXX # runtime
 	help
 	  Raspberry Pi 3 and Zero W Broadcom BCM43430 wifi module
-	  NVRAM data.
+	  NVRAM data. Raspberry Pi 3 Model B+ Broadcom BCM43455
+	  wifi module NVRAM data.
 
-	  https://github.com/RPi-Distro/firmware-nonfree/
+	  https://github.com/LibreELEC/brcmfmac_sdio-firmware-rpi
diff --git a/package/rpi-wifi-firmware/rpi-wifi-firmware.hash b/package/rpi-wifi-firmware/rpi-wifi-firmware.hash
index c20506536f..c3ea553c7d 100644
--- a/package/rpi-wifi-firmware/rpi-wifi-firmware.hash
+++ b/package/rpi-wifi-firmware/rpi-wifi-firmware.hash
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256  872fde4f9942d9aba805880d6eaddfe050305626fd58ad955bfe77c04f6b75a5  brcmfmac43430-sdio.txt
+sha256 2a6e8f492878ca1de5347f17ab239006db61215c48276fa6ea6e578f3cc5b58d  rpi-wifi-firmware-f0dc870f707118fa000f6ee47ec05e7eaa57b917.tar.gz
diff --git a/package/rpi-wifi-firmware/rpi-wifi-firmware.mk b/package/rpi-wifi-firmware/rpi-wifi-firmware.mk
index 6c855a8e14..77d4945414 100644
--- a/package/rpi-wifi-firmware/rpi-wifi-firmware.mk
+++ b/package/rpi-wifi-firmware/rpi-wifi-firmware.mk
@@ -4,20 +4,17 @@
 #
 ################################################################################
 
-RPI_WIFI_FIRMWARE_VERSION = 54bab3d6a6d43239c71d26464e6e10e5067ffea7
-# brcmfmac43430-sdio.bin comes from linux-firmware
-RPI_WIFI_FIRMWARE_SOURCE = brcmfmac43430-sdio.txt
-# git repo contains a lot of unrelated files
-RPI_WIFI_FIRMWARE_SITE = https://raw.githubusercontent.com/RPi-Distro/firmware-nonfree/$(RPI_WIFI_FIRMWARE_VERSION)/brcm80211/brcm
+RPI_WIFI_FIRMWARE_VERSION = f0dc870f707118fa000f6ee47ec05e7eaa57b917
+RPI_WIFI_FIRMWARE_SITE = $(call github,LibreELEC,brcmfmac_sdio-firmware-rpi,$(RPI_WIFI_FIRMWARE_VERSION))
 RPI_WIFI_FIRMWARE_LICENSE = PROPRIETARY
 
-define RPI_WIFI_FIRMWARE_EXTRACT_CMDS
-	cp $(DL_DIR)/$($(PKG)_SOURCE) $(@D)/
-endef
+# brcmfmac43430-sdio.bin and brcmfmac43455-sdio.bin come from linux-firmware
+RPI_WIFI_FIRMWARE_FILES = brcmfmac43430-sdio.txt brcmfmac43455-sdio.txt
 
 define RPI_WIFI_FIRMWARE_INSTALL_TARGET_CMDS
-	$(INSTALL) -D -m 0644 $(@D)/$(RPI_WIFI_FIRMWARE_SOURCE) \
-		$(TARGET_DIR)/lib/firmware/brcm/$(RPI_WIFI_FIRMWARE_SOURCE)
+	for file in $(RPI_WIFI_FIRMWARE_FILES); do \
+		$(INSTALL) -D -m 0644 $(@D)/firmware/brcm/$${file} $(TARGET_DIR)/lib/firmware/brcm/$${file}; \
+	done
 endef
 
 $(eval $(generic-package))
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 7/7] DEVELOPERS: add myself for rpi packages
  2018-03-16 18:02 [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support Martin Bark
                   ` (5 preceding siblings ...)
  2018-03-16 18:02 ` [Buildroot] [PATCH v3 6/7] package/rpi-wifi-firmware: " Martin Bark
@ 2018-03-16 18:02 ` Martin Bark
  2018-03-16 19:41 ` [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support Thomas Petazzoni
  7 siblings, 0 replies; 17+ messages in thread
From: Martin Bark @ 2018-03-16 18:02 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Martin Bark <martin@barkynet.com>

---
Changed v2 -> v3
 - new in v3
---
 DEVELOPERS | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/DEVELOPERS b/DEVELOPERS
index 3df820e712..76c783c03a 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1131,9 +1131,14 @@ F:	package/harfbuzz/
 F:	package/libsecret/
 
 N:	Martin Bark <martin@barkynet.com>
+F:	board/raspberrypi/
+F:	configs/raspberrypi3_defconfig
 F:	package/ca-certificates/
 F:	package/connman/
 F:	package/nodejs/
+F:	package/rpi-bt-firmware/
+F:	package/rpi-firmware/
+F:	package/rpi-wifi-firmware/
 F:	package/tzdata/
 F:	package/zic/
 
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support
  2018-03-16 18:02 [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support Martin Bark
                   ` (6 preceding siblings ...)
  2018-03-16 18:02 ` [Buildroot] [PATCH v3 7/7] DEVELOPERS: add myself for rpi packages Martin Bark
@ 2018-03-16 19:41 ` Thomas Petazzoni
  2018-03-16 21:06   ` Martin Bark
  7 siblings, 1 reply; 17+ messages in thread
From: Thomas Petazzoni @ 2018-03-16 19:41 UTC (permalink / raw)
  To: buildroot

Hello Martin,

On Fri, 16 Mar 2018 18:02:25 +0000, Martin Bark wrote:

> Martin Bark (7):
>   package/rpi-firmware: bump version
>   configs/raspberrypi*: bump kernel version
>   board/raspberrypi: add support for rpi3 b+
>   package/rpi-firmware: improve installation of dtb files
>   package/rpi-bt-firmware: change to LibreELEC github repo
>   package/rpi-wifi-firmware: change to LibreELEC github repo
>   DEVELOPERS: add myself for rpi packages

Since you're looking at RPi stuff, could you have a look at
http://patchwork.ozlabs.org/patch/779105/, which is sitting in
patchwork since quite a while ?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support
  2018-03-16 19:41 ` [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support Thomas Petazzoni
@ 2018-03-16 21:06   ` Martin Bark
  2018-03-16 22:35     ` Thomas Petazzoni
  2018-03-18 19:07     ` Yann E. MORIN
  0 siblings, 2 replies; 17+ messages in thread
From: Martin Bark @ 2018-03-16 21:06 UTC (permalink / raw)
  To: buildroot

Thomas,

On 16 March 2018 at 19:41, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
> Hello Martin,
>
> On Fri, 16 Mar 2018 18:02:25 +0000, Martin Bark wrote:
>
>> Martin Bark (7):
>>   package/rpi-firmware: bump version
>>   configs/raspberrypi*: bump kernel version
>>   board/raspberrypi: add support for rpi3 b+
>>   package/rpi-firmware: improve installation of dtb files
>>   package/rpi-bt-firmware: change to LibreELEC github repo
>>   package/rpi-wifi-firmware: change to LibreELEC github repo
>>   DEVELOPERS: add myself for rpi packages
>
> Since you're looking at RPi stuff, could you have a look at
> http://patchwork.ozlabs.org/patch/779105/, which is sitting in
> patchwork since quite a while ?

Yes i can look at this.

The only reason for this seems to be the use of the pi3-miniuart-bt
overlay.  Personally i never use this overlay, I set enable_uart=1 in
config.txt (the same as raspi-config does).  Is there a reason
buildroot favours the pi3-miniuart-bt overlay?

If we switched to using enable_uart=1 there would be no reason to
include the overlays and no reason for this separate rpi0w defconifg.

Thanks

Martin

>
> Thanks a lot!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> http://bootlin.com

^ permalink raw reply	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support
  2018-03-16 21:06   ` Martin Bark
@ 2018-03-16 22:35     ` Thomas Petazzoni
  2018-03-19 17:14       ` Peter Seiderer
  2018-03-18 19:07     ` Yann E. MORIN
  1 sibling, 1 reply; 17+ messages in thread
From: Thomas Petazzoni @ 2018-03-16 22:35 UTC (permalink / raw)
  To: buildroot

Hello,

On Fri, 16 Mar 2018 21:06:52 +0000, Martin Bark wrote:

> The only reason for this seems to be the use of the pi3-miniuart-bt
> overlay.  Personally i never use this overlay, I set enable_uart=1 in
> config.txt (the same as raspi-config does).  Is there a reason
> buildroot favours the pi3-miniuart-bt overlay?

I am not familiar with those configuration details of the RPi platform,
but I remember they have been discussed in the past. Perhaps you can
check the commit log for some details about them.

Especially this commit log:

commit 1e03cc2290f98fc7434254d2abd9afd504de8360
Author: Peter Seiderer <ps.report@gmx.net>
Date:   Mon May 2 22:25:44 2016 +0200

    raspberrypi3: fix serial console (load pi3-miniuart-bt overlay)
    
    - enable BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS in raspberrypi3_defconfig
    - add copy of rpi-firmware/overlays directory to boot partition in genimage-raspberrypi3.cfg
    - enhance post-image.sh script to add 'dtoverlay=pi3-miniuart-bt' on request
    - add BR2_ROOTFS_POST_SCRIPT_ARGS="--add-pi3-miniuart-bt-overlay" in raspberrypi3_defconfig
    
    Signed-off-by: Peter Seiderer <ps.report@gmx.net>
    Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support
  2018-03-16 21:06   ` Martin Bark
  2018-03-16 22:35     ` Thomas Petazzoni
@ 2018-03-18 19:07     ` Yann E. MORIN
  2018-03-19  9:38       ` Martin Bark
  1 sibling, 1 reply; 17+ messages in thread
From: Yann E. MORIN @ 2018-03-18 19:07 UTC (permalink / raw)
  To: buildroot

Martin, All,

On 2018-03-16 21:06 +0000, Martin Bark spake thusly:
> On 16 March 2018 at 19:41, Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> > Hello Martin,
> >
> > On Fri, 16 Mar 2018 18:02:25 +0000, Martin Bark wrote:
> >
> >> Martin Bark (7):
> >>   package/rpi-firmware: bump version
> >>   configs/raspberrypi*: bump kernel version
> >>   board/raspberrypi: add support for rpi3 b+
> >>   package/rpi-firmware: improve installation of dtb files
> >>   package/rpi-bt-firmware: change to LibreELEC github repo
> >>   package/rpi-wifi-firmware: change to LibreELEC github repo
> >>   DEVELOPERS: add myself for rpi packages
> >
> > Since you're looking at RPi stuff, could you have a look at
> > http://patchwork.ozlabs.org/patch/779105/, which is sitting in
> > patchwork since quite a while ?
> 
> Yes i can look at this.
> 
> The only reason for this seems to be the use of the pi3-miniuart-bt
> overlay.  Personally i never use this overlay, I set enable_uart=1 in
> config.txt (the same as raspi-config does).  Is there a reason
> buildroot favours the pi3-miniuart-bt overlay?
> 
> If we switched to using enable_uart=1 there would be no reason to
> include the overlays and no reason for this separate rpi0w defconifg.

I am all iun favour of simplifying and fixing things! Please send a
patch! ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support
  2018-03-18 19:07     ` Yann E. MORIN
@ 2018-03-19  9:38       ` Martin Bark
  0 siblings, 0 replies; 17+ messages in thread
From: Martin Bark @ 2018-03-19  9:38 UTC (permalink / raw)
  To: buildroot

On 18 March 2018 at 19:07, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Martin, All,
>
> On 2018-03-16 21:06 +0000, Martin Bark spake thusly:
>> On 16 March 2018 at 19:41, Thomas Petazzoni
>> <thomas.petazzoni@bootlin.com> wrote:
>> > Hello Martin,
>> >
>> > On Fri, 16 Mar 2018 18:02:25 +0000, Martin Bark wrote:
>> >
>> >> Martin Bark (7):
>> >>   package/rpi-firmware: bump version
>> >>   configs/raspberrypi*: bump kernel version
>> >>   board/raspberrypi: add support for rpi3 b+
>> >>   package/rpi-firmware: improve installation of dtb files
>> >>   package/rpi-bt-firmware: change to LibreELEC github repo
>> >>   package/rpi-wifi-firmware: change to LibreELEC github repo
>> >>   DEVELOPERS: add myself for rpi packages
>> >
>> > Since you're looking at RPi stuff, could you have a look at
>> > http://patchwork.ozlabs.org/patch/779105/, which is sitting in
>> > patchwork since quite a while ?
>>
>> Yes i can look at this.
>>
>> The only reason for this seems to be the use of the pi3-miniuart-bt
>> overlay.  Personally i never use this overlay, I set enable_uart=1 in
>> config.txt (the same as raspi-config does).  Is there a reason
>> buildroot favours the pi3-miniuart-bt overlay?
>>
>> If we switched to using enable_uart=1 there would be no reason to
>> include the overlays and no reason for this separate rpi0w defconifg.
>
> I am all iun favour of simplifying and fixing things! Please send a
> patch! ;-)

Yes i will do

Thanks

Martin

>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support
  2018-03-16 22:35     ` Thomas Petazzoni
@ 2018-03-19 17:14       ` Peter Seiderer
  2018-03-19 18:18         ` Martin Bark
  0 siblings, 1 reply; 17+ messages in thread
From: Peter Seiderer @ 2018-03-19 17:14 UTC (permalink / raw)
  To: buildroot

Hello Martin,

On Fri, 16 Mar 2018 23:35:48 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> Hello,
> 
> On Fri, 16 Mar 2018 21:06:52 +0000, Martin Bark wrote:
> 
> > The only reason for this seems to be the use of the pi3-miniuart-bt
> > overlay.  Personally i never use this overlay, I set enable_uart=1 in
> > config.txt (the same as raspi-config does).  Is there a reason
> > buildroot favours the pi3-miniuart-bt overlay?  
> 
> I am not familiar with those configuration details of the RPi platform,
> but I remember they have been discussed in the past. Perhaps you can
> check the commit log for some details about them.
> 
> Especially this commit log:
> 
> commit 1e03cc2290f98fc7434254d2abd9afd504de8360
> Author: Peter Seiderer <ps.report@gmx.net>
> Date:   Mon May 2 22:25:44 2016 +0200
> 
>     raspberrypi3: fix serial console (load pi3-miniuart-bt overlay)
>     
>     - enable BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS in raspberrypi3_defconfig
>     - add copy of rpi-firmware/overlays directory to boot partition in genimage-raspberrypi3.cfg
>     - enhance post-image.sh script to add 'dtoverlay=pi3-miniuart-bt' on request
>     - add BR2_ROOTFS_POST_SCRIPT_ARGS="--add-pi3-miniuart-bt-overlay" in raspberrypi3_defconfig
>     
>     Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>     Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 

And the full discussion about the different solutions, see [1]...

I am still in prefer the overlay solutions ;-)

Regards,
Peter
 

[1] https://patchwork.ozlabs.org/patch/617683/
> Best regards,
> 
> Thomas

^ permalink raw reply	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support
  2018-03-19 17:14       ` Peter Seiderer
@ 2018-03-19 18:18         ` Martin Bark
  2018-03-20 12:52           ` Jens Maus
  0 siblings, 1 reply; 17+ messages in thread
From: Martin Bark @ 2018-03-19 18:18 UTC (permalink / raw)
  To: buildroot

Hi,

On 19 March 2018 at 17:14, Peter Seiderer <ps.report@gmx.net> wrote:
> Hello Martin,
>
> On Fri, 16 Mar 2018 23:35:48 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
>
>> Hello,
>>
>> On Fri, 16 Mar 2018 21:06:52 +0000, Martin Bark wrote:
>>
>> > The only reason for this seems to be the use of the pi3-miniuart-bt
>> > overlay.  Personally i never use this overlay, I set enable_uart=1 in
>> > config.txt (the same as raspi-config does).  Is there a reason
>> > buildroot favours the pi3-miniuart-bt overlay?
>>
>> I am not familiar with those configuration details of the RPi platform,
>> but I remember they have been discussed in the past. Perhaps you can
>> check the commit log for some details about them.
>>
>> Especially this commit log:
>>
>> commit 1e03cc2290f98fc7434254d2abd9afd504de8360
>> Author: Peter Seiderer <ps.report@gmx.net>
>> Date:   Mon May 2 22:25:44 2016 +0200
>>
>>     raspberrypi3: fix serial console (load pi3-miniuart-bt overlay)
>>
>>     - enable BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS in raspberrypi3_defconfig
>>     - add copy of rpi-firmware/overlays directory to boot partition in genimage-raspberrypi3.cfg
>>     - enhance post-image.sh script to add 'dtoverlay=pi3-miniuart-bt' on request
>>     - add BR2_ROOTFS_POST_SCRIPT_ARGS="--add-pi3-miniuart-bt-overlay" in raspberrypi3_defconfig
>>
>>     Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>>     Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>>
>
> And the full discussion about the different solutions, see [1]...
>
> I am still in prefer the overlay solutions ;-)
>
> Regards,
> Peter
>
>
> [1] https://patchwork.ozlabs.org/patch/617683/

Ok i remember this conversation now.

As a matter of interest has anyone actually tried using bluetooth with
the pi3-miniuart-bt overlay?  I have not.  According to [1]
pi3-miniuart-bt overlay requires core_freq=250 to work (which makes
sense) and buildroot does not set this.  I'm not sure the current way
pi3-miniuart-bt overlay is setup even works.

Thanks

Martin

[1] https://github.com/raspberrypi/linux/blob/rpi-4.14.y/arch/arm/boot/dts/overlays/README

>> Best regards,
>>
>> Thomas
>

^ permalink raw reply	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support
  2018-03-19 18:18         ` Martin Bark
@ 2018-03-20 12:52           ` Jens Maus
  2018-03-22 19:45             ` Martin Bark
  0 siblings, 1 reply; 17+ messages in thread
From: Jens Maus @ 2018-03-20 12:52 UTC (permalink / raw)
  To: buildroot

FYI: In one of my buildroot-based projects I am actually using the pi3-miniart-bt + core_freq setting at the same time to free the standard UART for a GPIO HAT that requires the UART. See here:

https://github.com/jens-maus/RaspberryMatic/blob/master/buildroot-external/board/raspberrypi3/config.txt#L27-L30

Best Regards,

Jens

> Am 19.03.2018 um 19:18 schrieb Martin Bark <martin@barkynet.com>:
> 
> Hi,
> 
> On 19 March 2018 at 17:14, Peter Seiderer <ps.report@gmx.net> wrote:
>> Hello Martin,
>> 
>> On Fri, 16 Mar 2018 23:35:48 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
>> 
>>> Hello,
>>> 
>>> On Fri, 16 Mar 2018 21:06:52 +0000, Martin Bark wrote:
>>> 
>>>> The only reason for this seems to be the use of the pi3-miniuart-bt
>>>> overlay.  Personally i never use this overlay, I set enable_uart=1 in
>>>> config.txt (the same as raspi-config does).  Is there a reason
>>>> buildroot favours the pi3-miniuart-bt overlay?
>>> 
>>> I am not familiar with those configuration details of the RPi platform,
>>> but I remember they have been discussed in the past. Perhaps you can
>>> check the commit log for some details about them.
>>> 
>>> Especially this commit log:
>>> 
>>> commit 1e03cc2290f98fc7434254d2abd9afd504de8360
>>> Author: Peter Seiderer <ps.report@gmx.net>
>>> Date:   Mon May 2 22:25:44 2016 +0200
>>> 
>>>    raspberrypi3: fix serial console (load pi3-miniuart-bt overlay)
>>> 
>>>    - enable BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS in raspberrypi3_defconfig
>>>    - add copy of rpi-firmware/overlays directory to boot partition in genimage-raspberrypi3.cfg
>>>    - enhance post-image.sh script to add 'dtoverlay=pi3-miniuart-bt' on request
>>>    - add BR2_ROOTFS_POST_SCRIPT_ARGS="--add-pi3-miniuart-bt-overlay" in raspberrypi3_defconfig
>>> 
>>>    Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>>>    Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>>> 
>> 
>> And the full discussion about the different solutions, see [1]...
>> 
>> I am still in prefer the overlay solutions ;-)
>> 
>> Regards,
>> Peter
>> 
>> 
>> [1] https://patchwork.ozlabs.org/patch/617683/
> 
> Ok i remember this conversation now.
> 
> As a matter of interest has anyone actually tried using bluetooth with
> the pi3-miniuart-bt overlay?  I have not.  According to [1]
> pi3-miniuart-bt overlay requires core_freq=250 to work (which makes
> sense) and buildroot does not set this.  I'm not sure the current way
> pi3-miniuart-bt overlay is setup even works.
> 
> Thanks
> 
> Martin
> 
> [1] https://github.com/raspberrypi/linux/blob/rpi-4.14.y/arch/arm/boot/dts/overlays/README
> 
>>> Best regards,
>>> 
>>> Thomas
>> 

-- 
Jens Maus, Dresden/Germany
http://jens-maus.de/

*** Content is authentic only with digital signature  ***

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3745 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180320/c14e3cba/attachment.p7s>

^ permalink raw reply	[flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support
  2018-03-20 12:52           ` Jens Maus
@ 2018-03-22 19:45             ` Martin Bark
  0 siblings, 0 replies; 17+ messages in thread
From: Martin Bark @ 2018-03-22 19:45 UTC (permalink / raw)
  To: buildroot

Jens,

On 20 March 2018 at 12:52, Jens Maus <mail@jens-maus.de> wrote:
> FYI: In one of my buildroot-based projects I am actually using the pi3-miniart-bt + core_freq setting at the same time to free the standard UART for a GPIO HAT that requires the UART. See here:
>
> https://github.com/jens-maus/RaspberryMatic/blob/master/buildroot-external/board/raspberrypi3/config.txt#L27-L30

Yes exactly, you need the core_freq=250 for pi3-miniart-bt to work but
buildroot does not set this.  Using pi3-miniart-bt to free up ttyAMA0
for other uses, as you do, is a good reason to use it.

Given enable_uart=1 sets core_freq=250 (see [1]) and using
pi3-miniart-bt also needs core_freq=250, i can't see the point it
using pi3-miniart-bt to just enable serial logins.

Thanks

Martin

[1] https://www.raspberrypi.org/documentation/configuration/uart.md

>
> Best Regards,
>
> Jens
>
>> Am 19.03.2018 um 19:18 schrieb Martin Bark <martin@barkynet.com>:
>>
>> Hi,
>>
>> On 19 March 2018 at 17:14, Peter Seiderer <ps.report@gmx.net> wrote:
>>> Hello Martin,
>>>
>>> On Fri, 16 Mar 2018 23:35:48 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
>>>
>>>> Hello,
>>>>
>>>> On Fri, 16 Mar 2018 21:06:52 +0000, Martin Bark wrote:
>>>>
>>>>> The only reason for this seems to be the use of the pi3-miniuart-bt
>>>>> overlay.  Personally i never use this overlay, I set enable_uart=1 in
>>>>> config.txt (the same as raspi-config does).  Is there a reason
>>>>> buildroot favours the pi3-miniuart-bt overlay?
>>>>
>>>> I am not familiar with those configuration details of the RPi platform,
>>>> but I remember they have been discussed in the past. Perhaps you can
>>>> check the commit log for some details about them.
>>>>
>>>> Especially this commit log:
>>>>
>>>> commit 1e03cc2290f98fc7434254d2abd9afd504de8360
>>>> Author: Peter Seiderer <ps.report@gmx.net>
>>>> Date:   Mon May 2 22:25:44 2016 +0200
>>>>
>>>>    raspberrypi3: fix serial console (load pi3-miniuart-bt overlay)
>>>>
>>>>    - enable BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS in raspberrypi3_defconfig
>>>>    - add copy of rpi-firmware/overlays directory to boot partition in genimage-raspberrypi3.cfg
>>>>    - enhance post-image.sh script to add 'dtoverlay=pi3-miniuart-bt' on request
>>>>    - add BR2_ROOTFS_POST_SCRIPT_ARGS="--add-pi3-miniuart-bt-overlay" in raspberrypi3_defconfig
>>>>
>>>>    Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>>>>    Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>>>>
>>>
>>> And the full discussion about the different solutions, see [1]...
>>>
>>> I am still in prefer the overlay solutions ;-)
>>>
>>> Regards,
>>> Peter
>>>
>>>
>>> [1] https://patchwork.ozlabs.org/patch/617683/
>>
>> Ok i remember this conversation now.
>>
>> As a matter of interest has anyone actually tried using bluetooth with
>> the pi3-miniuart-bt overlay?  I have not.  According to [1]
>> pi3-miniuart-bt overlay requires core_freq=250 to work (which makes
>> sense) and buildroot does not set this.  I'm not sure the current way
>> pi3-miniuart-bt overlay is setup even works.
>>
>> Thanks
>>
>> Martin
>>
>> [1] https://github.com/raspberrypi/linux/blob/rpi-4.14.y/arch/arm/boot/dts/overlays/README
>>
>>>> Best regards,
>>>>
>>>> Thomas
>>>
>
> --
> Jens Maus, Dresden/Germany
> http://jens-maus.de/
>
> *** Content is authentic only with digital signature  ***
>

^ permalink raw reply	[flat|nested] 17+ messages in thread
end of thread, other threads:[~2018-03-22 19:45 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-16 18:02 [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support Martin Bark
2018-03-16 18:02 ` [Buildroot] [PATCH v3 1/7] package/rpi-firmware: bump version Martin Bark
2018-03-16 18:02 ` [Buildroot] [PATCH v3 2/7] configs/raspberrypi*: bump kernel version Martin Bark
2018-03-16 18:02 ` [Buildroot] [PATCH v3 3/7] board/raspberrypi: add support for rpi3 b+ Martin Bark
2018-03-16 18:02 ` [Buildroot] [PATCH v3 4/7] package/rpi-firmware: improve installation of dtb files Martin Bark
2018-03-16 18:02 ` [Buildroot] [PATCH v3 5/7] package/rpi-bt-firmware: change to LibreELEC github repo Martin Bark
2018-03-16 18:02 ` [Buildroot] [PATCH v3 6/7] package/rpi-wifi-firmware: " Martin Bark
2018-03-16 18:02 ` [Buildroot] [PATCH v3 7/7] DEVELOPERS: add myself for rpi packages Martin Bark
2018-03-16 19:41 ` [Buildroot] [PATCH v3 0/7] Add rpi3 b+ support Thomas Petazzoni
2018-03-16 21:06   ` Martin Bark
2018-03-16 22:35     ` Thomas Petazzoni
2018-03-19 17:14       ` Peter Seiderer
2018-03-19 18:18         ` Martin Bark
2018-03-20 12:52           ` Jens Maus
2018-03-22 19:45             ` Martin Bark
2018-03-18 19:07     ` Yann E. MORIN
2018-03-19  9:38       ` Martin Bark

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.