build warning in drivers/macintosh/rack-meter.c

build warning in drivers/macintosh/rack-meter.c

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

Hi all,

These warnings have beeen around for a while now;

drivers/macintosh/rack-meter.c:157:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
  memset(rdma->buf1, 0, ARRAY_SIZE(rdma->buf1));
  ^~~~~~
drivers/macintosh/rack-meter.c:158:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
  memset(rdma->buf2, 0, ARRAY_SIZE(rdma->buf2));
  ^~~~~~

Introduced by commit

  4f7bef7a9f69 ("drivers: macintosh: rack-meter: fix bogus memsets")

I guess updating to a newer compiler has started generating these.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: build warning in drivers/macintosh/rack-meter.c

[Aaro Koskinen]

Hi,

On Fri, Mar 16, 2018 at 04:46:14PM +1100, Stephen Rothwell wrote:
> These warnings have beeen around for a while now;
> 
> drivers/macintosh/rack-meter.c:157:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
>   memset(rdma->buf1, 0, ARRAY_SIZE(rdma->buf1));
>   ^~~~~~
> drivers/macintosh/rack-meter.c:158:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
>   memset(rdma->buf2, 0, ARRAY_SIZE(rdma->buf2));
>   ^~~~~~
> 
> Introduced by commit
> 
>   4f7bef7a9f69 ("drivers: macintosh: rack-meter: fix bogus memsets")
> 
> I guess updating to a newer compiler has started generating these.

Eh, that's really embarrassing. Obviously it should be sizeof(). I can send
a fix for this and test on Xserve.

A.

Re: build warning in drivers/macintosh/rack-meter.c

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

Hi Aaro,

On Fri, 16 Mar 2018 11:37:47 +0200 Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
>
> I can send a fix for this and test on Xserve.

Excellent.  (I should send emails about more old warnings :-))

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: build warning in drivers/macintosh/rack-meter.c

[Michael Ellerman]

Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Hi all,
>
> These warnings have beeen around for a while now;
>
> drivers/macintosh/rack-meter.c:157:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
>   memset(rdma->buf1, 0, ARRAY_SIZE(rdma->buf1));
>   ^~~~~~
> drivers/macintosh/rack-meter.c:158:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
>   memset(rdma->buf2, 0, ARRAY_SIZE(rdma->buf2));
>   ^~~~~~
>
> Introduced by commit
>
>   4f7bef7a9f69 ("drivers: macintosh: rack-meter: fix bogus memsets")

Yep looks like a bug.

Aaro, can you send a patch?

cheers