[U-Boot] [RFC 1/1] video: rk3288_mipi: check in rk_mipi_ofdata_to_platdata

[U-Boot] [RFC 1/1] video: rk3288_mipi: check in rk_mipi_ofdata_to_platdata

[Heinrich Schuchardt]

The error checking should also catch the case that no range has beeen
defined.
syscon_get_first_range() returns NULL if no range is defined.
cf. rk3399_mipi.c

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
I do not possess the hardware for testing. But the coding is not consistent
with the coding used in rk3399_mipi.c.

Why did we duplicate the coding instead of using a common c file?
---
 drivers/video/rockchip/rk3288_mipi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/rockchip/rk3288_mipi.c b/drivers/video/rockchip/rk3288_mipi.c
index 953b47fb8c..27d125f77e 100644
--- a/drivers/video/rockchip/rk3288_mipi.c
+++ b/drivers/video/rockchip/rk3288_mipi.c
@@ -136,7 +136,7 @@ static int rk_mipi_ofdata_to_platdata(struct udevice *dev)
 	struct rk_mipi_priv *priv = dev_get_priv(dev);
 
 	priv->grf = syscon_get_first_range(ROCKCHIP_SYSCON_GRF);
-	if (IS_ERR(priv->grf)) {
+	if (!priv->grf || IS_ERR(priv->grf)) {
 		debug("%s: Get syscon grf failed (ret=%p)\n",
 		      __func__, priv->grf);
 		return  -ENXIO;
-- 
2.16.2

[U-Boot] [U-Boot, RFC, 1/1] video: rk3288_mipi: check in rk_mipi_ofdata_to_platdata

[Philipp Tomsich]

> The error checking should also catch the case that no range has beeen
> defined.
> syscon_get_first_range() returns NULL if no range is defined.
> cf. rk3399_mipi.c
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> I do not possess the hardware for testing. But the coding is not consistent
> with the coding used in rk3399_mipi.c.
> 
> Why did we duplicate the coding instead of using a common c file?
> ---
>  drivers/video/rockchip/rk3288_mipi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

[U-Boot] [U-Boot, RFC, 1/1] video: rk3288_mipi: check in rk_mipi_ofdata_to_platdata

[Philipp Tomsich]

> The error checking should also catch the case that no range has beeen
> defined.
> syscon_get_first_range() returns NULL if no range is defined.
> cf. rk3399_mipi.c
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> I do not possess the hardware for testing. But the coding is not consistent
> with the coding used in rk3399_mipi.c.
> 
> Why did we duplicate the coding instead of using a common c file?
> ---
>  drivers/video/rockchip/rk3288_mipi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

[U-Boot] [U-Boot, RFC, 1/1] video: rk3288_mipi: check in rk_mipi_ofdata_to_platdata

[Philipp Tomsich]

> The error checking should also catch the case that no range has beeen
> defined.
> syscon_get_first_range() returns NULL if no range is defined.
> cf. rk3399_mipi.c
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> I do not possess the hardware for testing. But the coding is not consistent
> with the coding used in rk3399_mipi.c.
> 
> Why did we duplicate the coding instead of using a common c file?
> ---
>  drivers/video/rockchip/rk3288_mipi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied to u-boot-rockchip, thanks!