[PATCH] staging: vc04_services: bcm2835-camera: Add blank line after declaration

[PATCH] staging: vc04_services: bcm2835-camera: Add blank line after declaration

[Nishka Dasgupta]

Add blank line after declaration. Issue found with checkpatch.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
---
 drivers/staging/vc04_services/bcm2835-camera/controls.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c
index 0736214..cff7b1e 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
@@ -1270,6 +1270,7 @@ int bm2835_mmal_init_controls(struct bm2835_mmal_dev *dev,
 				 * mismatches.
 				 */
 				int i;
+
 				mask = 1 << V4L2_SCENE_MODE_NONE;
 				for (i = 0;
 				     i < ARRAY_SIZE(scene_configs);
-- 
2.7.4

Re: [PATCH] staging: vc04_services: bcm2835-camera: Add blank line after declaration

[Greg KH]

On Wed, Mar 14, 2018 at 06:36:14PM +0000, Nishka Dasgupta wrote:
> Add blank line after declaration. Issue found with checkpatch.
> 
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
> ---
>  drivers/staging/vc04_services/bcm2835-camera/controls.c | 1 +
>  1 file changed, 1 insertion(+)

You have sent 7 or more patches for this same driver, yet I have no idea
what order to apply the patches in :(

Please resend them properly, as a patch series, so I have a chance to
get it right :)

thanks,

greg k-h

Re: [PATCH] staging: vc04_services: bcm2835-camera: Add blank line after declaration

[Nishka Dasgupta]

On Mon, Mar 19, 2018 at 9:07 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Mar 14, 2018 at 06:36:14PM +0000, Nishka Dasgupta wrote:
>> Add blank line after declaration. Issue found with checkpatch.
>>
>> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
>> ---
>>  drivers/staging/vc04_services/bcm2835-camera/controls.c | 1 +
>>  1 file changed, 1 insertion(+)
>
> You have sent 7 or more patches for this same driver, yet I have no idea
> what order to apply the patches in :(
>
> Please resend them properly, as a patch series, so I have a chance to
> get it right :)
>
> thanks,
>
> greg k-h

I have resent this one; the others in this driver appear to be
variations on the multiple line dereference problem. Since we
discussed the dereference issue earlier this week (you pointed out
that my fix was more complicated than what I was trying to fix), I
thought it best not to waste anyone's time by resending the
dereference patches as well. Was I wrong and should I send the
dereference patches as a series again?

Thanking you,
Nishka Dasgupta