[PATCH RESEND] perf unwind: Report error from dwfl_attach_state

[PATCH RESEND] perf unwind: Report error from dwfl_attach_state

[Martin Vuille]

In verbose level 2, errors returned by libdw are reported in most cases,
but not when calling dwfl_attach_state.

Since elfutils v 0.160 (2014), dwfl_attach_state sets the error code to
report failure cause. On failure, log the reported error.

Signed-off-by: Martin Vuille <jpmv27@aim.com>
---
 tools/perf/util/unwind-libdw.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/unwind-libdw.c b/tools/perf/util/unwind-libdw.c
index 8e969f28cc59..7bdd239c795c 100644
--- a/tools/perf/util/unwind-libdw.c
+++ b/tools/perf/util/unwind-libdw.c
@@ -236,7 +236,8 @@ int unwind__get_entries(unwind_entry_cb_t cb, void *arg,
 	if (err)
 		goto out;
 
-	if (!dwfl_attach_state(ui->dwfl, EM_NONE, thread->tid, &callbacks, ui))
+	err = !dwfl_attach_state(ui->dwfl, EM_NONE, thread->tid, &callbacks, ui);
+	if (err)
 		goto out;
 
 	err = dwfl_getthread_frames(ui->dwfl, thread->tid, frame_callback, ui);
-- 
2.13.6

Re: [PATCH RESEND] perf unwind: Report error from dwfl_attach_state

[Kim Phillips]

On Sun, 18 Mar 2018 13:50:53 -0400
Martin Vuille <jpmv27@aim.com> wrote:

> In verbose level 2, errors returned by libdw are reported in most cases,
> but not when calling dwfl_attach_state.
> 
> Since elfutils v 0.160 (2014), dwfl_attach_state sets the error code to
> report failure cause. On failure, log the reported error.
> 
> Signed-off-by: Martin Vuille <jpmv27@aim.com>
> ---

Reviewed-by: Kim Phillips <kim.phillips@arm.com>

Kim

Re: [PATCH RESEND] perf unwind: Report error from dwfl_attach_state

[Kim Phillips]

On Sun, 18 Mar 2018 13:50:53 -0400
Martin Vuille <jpmv27@aim.com> wrote:

> In verbose level 2, errors returned by libdw are reported in most cases,
> but not when calling dwfl_attach_state.
> 
> Since elfutils v 0.160 (2014), dwfl_attach_state sets the error code to
> report failure cause. On failure, log the reported error.
> 
> Signed-off-by: Martin Vuille <jpmv27@aim.com>
> ---

Reviewed-by: Kim Phillips <kim.phillips@arm.com>

Kim

Re: [PATCH RESEND] perf unwind: Report error from dwfl_attach_state

[Arnaldo Carvalho de Melo]

Em Tue, Mar 20, 2018 at 08:06:33AM +0800, Kim Phillips escreveu:
> On Sun, 18 Mar 2018 13:50:53 -0400
> Martin Vuille <jpmv27@aim.com> wrote:
> 
> > In verbose level 2, errors returned by libdw are reported in most cases,
> > but not when calling dwfl_attach_state.
> > 
> > Since elfutils v 0.160 (2014), dwfl_attach_state sets the error code to
> > report failure cause. On failure, log the reported error.
> > 
> > Signed-off-by: Martin Vuille <jpmv27@aim.com>
> > ---
> 
> Reviewed-by: Kim Phillips <kim.phillips@arm.com>

Thanks, applied.

- Arnaldo

[tip:perf/core] perf unwind: Report error from dwfl_attach_state

[tip-bot for Martin Vuille]

Commit-ID:  555fc3b1ef4c850c635be333024dcf67bc1e7cb8
Gitweb:     https://git.kernel.org/tip/555fc3b1ef4c850c635be333024dcf67bc1e7cb8
Author:     Martin Vuille <jpmv27@aim.com>
AuthorDate: Sun, 18 Mar 2018 13:50:53 -0400
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 20 Mar 2018 13:16:09 -0300

perf unwind: Report error from dwfl_attach_state

In verbose level 2, errors returned by libdw are reported in most cases,
but not when calling dwfl_attach_state.

Since elfutils v 0.160 (2014), dwfl_attach_state sets the error code to
report failure cause. On failure, log the reported error.

Signed-off-by: Martin Vuille <jpmv27@aim.com>
Reviewed-by: Kim Phillips <kim.phillips@arm.com>
Link: http://lkml.kernel.org/r/20180318175053.4222-1-jpmv27@aim.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/unwind-libdw.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/unwind-libdw.c b/tools/perf/util/unwind-libdw.c
index 8e969f28cc59..7bdd239c795c 100644
--- a/tools/perf/util/unwind-libdw.c
+++ b/tools/perf/util/unwind-libdw.c
@@ -236,7 +236,8 @@ int unwind__get_entries(unwind_entry_cb_t cb, void *arg,
 	if (err)
 		goto out;
 
-	if (!dwfl_attach_state(ui->dwfl, EM_NONE, thread->tid, &callbacks, ui))
+	err = !dwfl_attach_state(ui->dwfl, EM_NONE, thread->tid, &callbacks, ui);
+	if (err)
 		goto out;
 
 	err = dwfl_getthread_frames(ui->dwfl, thread->tid, frame_callback, ui);