[igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Fix Y alignment in the scaledprimary subtest.

[igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Fix Y alignment in the scaledprimary subtest.

[Maarten Lankhorst]

This is hidden behind the other kms_frontbuffer_tracking failures,
but is its own fail.

On gen9/gen10 we fail the scaledprimary tests because FBC refuses
to be enabled with "plane Y offset is misaligned".
Looking at the kernel, this is a workaround for FIFO underruns
which can be tested as well. Test that with the right alignment, FBC
is enabled and with misalignment FBC is disabled on <= gen10.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_frontbuffer_tracking.c | 24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index e4da706b0631..495a3a49566c 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -2751,10 +2751,21 @@ static void scaledprimary_subtest(const struct test_mode *t)
 	struct igt_fb new_fb, *old_fb;
 	struct modeset_params *params = pick_params(t);
 	struct fb_region *reg = &params->primary;
+	int gen = intel_gen(intel_get_drm_devid(drm.fd)) >= 9;
+	int src_y_upscale = reg->h / 4;
 
-	igt_require_f(intel_gen(intel_get_drm_devid(drm.fd)) >= 9,
+	igt_require_f(gen >= 9,
 		      "Can't test primary plane scaling before gen 9\n");
 
+	/*
+	 * On gen <= 10 HW, FBC is not enabled on a plane with a Y offset
+	 * that isn't divisible by 4, because it causes FIFO underruns.
+	 */
+	if (gen <= 10)
+		src_y_upscale = ALIGN(src_y_upscale, 4);
+	else /* Lets misalign, to see if we trigger the underrun. */
+		src_y_upscale = ALIGN(src_y_upscale, 4) + 3;
+
 	prepare_subtest(t, NULL);
 
 	old_fb = reg->fb;
@@ -2801,11 +2812,20 @@ static void scaledprimary_subtest(const struct test_mode *t)
 
 	/* Destination doesn't fill the entire CRTC, upscaling. */
 	igt_fb_set_position(&new_fb, reg->plane,
-			    reg->x + reg->w / 4, reg->y + reg->h / 4);
+			    reg->x + reg->w / 4, reg->y + src_y_upscale);
 	igt_fb_set_size(&new_fb, reg->plane, reg->w / 2, reg->h / 2);
 	igt_display_commit2(&drm.display, COMMIT_UNIVERSAL);
 	do_assertions(DONT_ASSERT_CRC);
 
+	/* Check that with a wrong alignment FBC is disabled. */
+	if (gen <= 10) {
+		igt_fb_set_position(&new_fb, reg->plane,
+				reg->x + reg->w / 4, reg->y + src_y_upscale + 3);
+		igt_fb_set_size(&new_fb, reg->plane, reg->w / 2, reg->h / 2);
+		igt_display_commit2(&drm.display, COMMIT_UNIVERSAL);
+		do_assertions(DONT_ASSERT_CRC | ASSERT_FBC_DISABLED);
+	}
+
 	/* Back to the good and old blue fb. */
 	igt_plane_set_fb(reg->plane, old_fb);
 	igt_plane_set_position(params->primary.plane, 0, 0);
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Fix Y alignment in the scaledprimary subtest, v2.

[Maarten Lankhorst]

This is hidden behind the other kms_frontbuffer_tracking failures,
but is its own fail.

On gen9/gen10 we fail the scaledprimary tests because FBC refuses
to be enabled with "plane Y offset is misaligned".
Looking at the kernel, this is a workaround for FIFO underruns
which can be tested as well. Test that with the right alignment, FBC
is enabled and with misalignment FBC is disabled on <= gen10.

Changes since v1:
- Always check both alignments.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_frontbuffer_tracking.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index e4da706b0631..7eabe845f75e 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -2751,8 +2751,10 @@ static void scaledprimary_subtest(const struct test_mode *t)
 	struct igt_fb new_fb, *old_fb;
 	struct modeset_params *params = pick_params(t);
 	struct fb_region *reg = &params->primary;
+	int gen = intel_gen(intel_get_drm_devid(drm.fd)) >= 9;
+	int src_y_upscale = ALIGN(reg->h / 4, 4);
 
-	igt_require_f(intel_gen(intel_get_drm_devid(drm.fd)) >= 9,
+	igt_require_f(gen >= 9,
 		      "Can't test primary plane scaling before gen 9\n");
 
 	prepare_subtest(t, NULL);
@@ -2801,11 +2803,23 @@ static void scaledprimary_subtest(const struct test_mode *t)
 
 	/* Destination doesn't fill the entire CRTC, upscaling. */
 	igt_fb_set_position(&new_fb, reg->plane,
-			    reg->x + reg->w / 4, reg->y + reg->h / 4);
+			    reg->x + reg->w / 4, reg->y + src_y_upscale);
 	igt_fb_set_size(&new_fb, reg->plane, reg->w / 2, reg->h / 2);
 	igt_display_commit2(&drm.display, COMMIT_UNIVERSAL);
 	do_assertions(DONT_ASSERT_CRC);
 
+	/*
+	 * On gen <= 10 HW, FBC is not enabled on a plane with a Y offset
+	 * that isn't divisible by 4, because it causes FIFO underruns.
+	 *
+	 * Check that FBC is disabled.
+	 */
+	igt_fb_set_position(&new_fb, reg->plane,
+			    reg->x + reg->w / 4, reg->y + src_y_upscale + 3);
+	igt_fb_set_size(&new_fb, reg->plane, reg->w / 2, reg->h / 2);
+	igt_display_commit2(&drm.display, COMMIT_UNIVERSAL);
+	do_assertions(DONT_ASSERT_CRC | (gen <= 10 ? ASSERT_FBC_DISABLED : 0));
+
 	/* Back to the good and old blue fb. */
 	igt_plane_set_fb(reg->plane, old_fb);
 	igt_plane_set_position(params->primary.plane, 0, 0);
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Fix Y alignment in the scaledprimary subtest. (rev2)

[Patchwork]

== Series Details ==

Series: tests/kms_frontbuffer_tracking: Fix Y alignment in the scaledprimary subtest. (rev2)
URL   : https://patchwork.freedesktop.org/series/40192/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
b09e979a67817a9b068f841bda81940b9d208850 tools/aubdump: For gen10+ support addresses up to 4GB

with latest DRM-Tip kernel build CI_DRM_3951
260af42eeff0 drm-tip: 2018y-03m-19d-17h-15m-08s UTC integration manifest

No testlist changes.

---- Known issues:

Test prime_vgem:
        Subgroup basic-fence-flip:
                pass       -> FAIL       (fi-ilk-650) fdo#104008

fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008

fi-bdw-5557u     total:285  pass:264  dwarn:0   dfail:0   fail:0   skip:21  time:432s
fi-bdw-gvtdvm    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:443s
fi-blb-e6850     total:285  pass:220  dwarn:1   dfail:0   fail:0   skip:64  time:382s
fi-bsw-n3050     total:285  pass:239  dwarn:0   dfail:0   fail:0   skip:46  time:540s
fi-bwr-2160      total:285  pass:180  dwarn:0   dfail:0   fail:0   skip:105 time:299s
fi-bxt-j4205     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:515s
fi-byt-j1900     total:285  pass:250  dwarn:0   dfail:0   fail:0   skip:35  time:515s
fi-byt-n2820     total:285  pass:246  dwarn:0   dfail:0   fail:0   skip:39  time:503s
fi-cfl-8700k     total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:417s
fi-cfl-s2        total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:579s
fi-cfl-u         total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:512s
fi-cnl-drrs      total:285  pass:254  dwarn:3   dfail:0   fail:0   skip:28  time:528s
fi-elk-e7500     total:285  pass:225  dwarn:1   dfail:0   fail:0   skip:59  time:424s
fi-gdg-551       total:285  pass:176  dwarn:0   dfail:0   fail:1   skip:108 time:317s
fi-glk-1         total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:543s
fi-hsw-4770      total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:406s
fi-ilk-650       total:285  pass:224  dwarn:0   dfail:0   fail:1   skip:60  time:427s
fi-ivb-3520m     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:471s
fi-ivb-3770      total:285  pass:252  dwarn:0   dfail:0   fail:0   skip:33  time:439s
fi-kbl-7500u     total:285  pass:260  dwarn:1   dfail:0   fail:0   skip:24  time:475s
fi-kbl-7567u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:467s
fi-kbl-r         total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:514s
fi-pnv-d510      total:285  pass:219  dwarn:1   dfail:0   fail:0   skip:65  time:651s
fi-skl-6260u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:437s
fi-skl-6600u     total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:540s
fi-skl-6700hq    total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:544s
fi-skl-6700k2    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:503s
fi-skl-6770hq    total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:491s
fi-skl-guc       total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:433s
fi-skl-gvtdvm    total:285  pass:262  dwarn:0   dfail:0   fail:0   skip:23  time:451s
fi-snb-2520m     total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:595s
fi-snb-2600      total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:406s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1159/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_frontbuffer_tracking: Fix Y alignment in the scaledprimary subtest. (rev2)

[Patchwork]

== Series Details ==

Series: tests/kms_frontbuffer_tracking: Fix Y alignment in the scaledprimary subtest. (rev2)
URL   : https://patchwork.freedesktop.org/series/40192/
State : failure

== Summary ==

---- Possible new issues:

Test drv_suspend:
        Subgroup forcewake:
                pass       -> SKIP       (shard-snb)
Test kms_chv_cursor_fail:
        Subgroup pipe-b-128x128-right-edge:
                pass       -> FAIL       (shard-apl)
Test kms_frontbuffer_tracking:
        Subgroup fbc-2p-primscrn-pri-indfb-draw-mmap-gtt:
                pass       -> DMESG-FAIL (shard-hsw)

---- Known issues:

Test kms_flip:
        Subgroup flip-vs-wf_vblank-interruptible:
                pass       -> FAIL       (shard-hsw) fdo#100368 +1
Test kms_frontbuffer_tracking:
        Subgroup fbc-indfb-scaledprimary:
                pass       -> SKIP       (shard-apl) fdo#101623 +2
Test kms_setmode:
        Subgroup basic:
                fail       -> PASS       (shard-apl) fdo#99912
Test pm_lpsp:
        Subgroup screens-disabled:
                pass       -> INCOMPLETE (shard-hsw) fdo#104941

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#104941 https://bugs.freedesktop.org/show_bug.cgi?id=104941

shard-apl        total:3478 pass:1812 dwarn:1   dfail:0   fail:7   skip:1657 time:13056s
shard-hsw        total:3416 pass:1734 dwarn:1   dfail:1   fail:1   skip:1677 time:11351s
shard-snb        total:3478 pass:1356 dwarn:1   dfail:0   fail:2   skip:2119 time:7227s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1159/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Fix Y alignment in the scaledprimary subtest, v3.

[Maarten Lankhorst]

This is hidden behind the other kms_frontbuffer_tracking failures,
but is its own fail.

On gen9/gen10 we fail the scaledprimary tests because FBC refuses
to be enabled with "plane Y offset is misaligned".
Looking at the kernel, this is a workaround for FIFO underruns
which can be tested as well. Test that with the right alignment, FBC
is enabled and with misalignment FBC is disabled on <= gen10.

Changes since v1:
- Always check both alignments.
Changes since v2:
- Fix gen assignment.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_frontbuffer_tracking.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 454103d367c7..5576b058b852 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -2751,8 +2751,10 @@ static void scaledprimary_subtest(const struct test_mode *t)
 	struct igt_fb new_fb, *old_fb;
 	struct modeset_params *params = pick_params(t);
 	struct fb_region *reg = &params->primary;
+	int gen = intel_gen(intel_get_drm_devid(drm.fd));
+	int src_y_upscale = ALIGN(reg->h / 4, 4);
 
-	igt_require_f(intel_gen(intel_get_drm_devid(drm.fd)) >= 9,
+	igt_require_f(gen >= 9,
 		      "Can't test primary plane scaling before gen 9\n");
 
 	prepare_subtest(t, NULL);
@@ -2801,11 +2803,23 @@ static void scaledprimary_subtest(const struct test_mode *t)
 
 	/* Destination doesn't fill the entire CRTC, upscaling. */
 	igt_fb_set_position(&new_fb, reg->plane,
-			    reg->x + reg->w / 4, reg->y + reg->h / 4);
+			    reg->x + reg->w / 4, reg->y + src_y_upscale);
 	igt_fb_set_size(&new_fb, reg->plane, reg->w / 2, reg->h / 2);
 	igt_display_commit2(&drm.display, COMMIT_UNIVERSAL);
 	do_assertions(DONT_ASSERT_CRC);
 
+	/*
+	 * On gen <= 10 HW, FBC is not enabled on a plane with a Y offset
+	 * that isn't divisible by 4, because it causes FIFO underruns.
+	 *
+	 * Check that FBC is disabled.
+	 */
+	igt_fb_set_position(&new_fb, reg->plane,
+			    reg->x + reg->w / 4, reg->y + src_y_upscale + 3);
+	igt_fb_set_size(&new_fb, reg->plane, reg->w / 2, reg->h / 2);
+	igt_display_commit2(&drm.display, COMMIT_UNIVERSAL);
+	do_assertions(DONT_ASSERT_CRC | (gen <= 10 ? ASSERT_FBC_DISABLED : 0));
+
 	/* Back to the good and old blue fb. */
 	igt_plane_set_fb(reg->plane, old_fb);
 	igt_plane_set_position(params->primary.plane, 0, 0);
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Fix Y alignment in the scaledprimary subtest. (rev3)

[Patchwork]

== Series Details ==

Series: tests/kms_frontbuffer_tracking: Fix Y alignment in the scaledprimary subtest. (rev3)
URL   : https://patchwork.freedesktop.org/series/40192/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
b09e979a67817a9b068f841bda81940b9d208850 tools/aubdump: For gen10+ support addresses up to 4GB

with latest DRM-Tip kernel build CI_DRM_3954
141def2a45f4 drm-tip: 2018y-03m-19d-23h-48m-43s UTC integration manifest

No testlist changes.

---- Known issues:

Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:285  pass:264  dwarn:0   dfail:0   fail:0   skip:21  time:431s
fi-bdw-gvtdvm    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:440s
fi-blb-e6850     total:285  pass:220  dwarn:1   dfail:0   fail:0   skip:64  time:382s
fi-bsw-n3050     total:285  pass:239  dwarn:0   dfail:0   fail:0   skip:46  time:539s
fi-bwr-2160      total:285  pass:180  dwarn:0   dfail:0   fail:0   skip:105 time:297s
fi-bxt-dsi       total:285  pass:255  dwarn:0   dfail:0   fail:0   skip:30  time:524s
fi-bxt-j4205     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:513s
fi-byt-j1900     total:285  pass:250  dwarn:0   dfail:0   fail:0   skip:35  time:518s
fi-byt-n2820     total:285  pass:246  dwarn:0   dfail:0   fail:0   skip:39  time:503s
fi-cfl-8700k     total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:408s
fi-cfl-s2        total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:574s
fi-cfl-u         total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:512s
fi-cnl-drrs      total:285  pass:254  dwarn:3   dfail:0   fail:0   skip:28  time:536s
fi-elk-e7500     total:285  pass:225  dwarn:1   dfail:0   fail:0   skip:59  time:427s
fi-gdg-551       total:285  pass:176  dwarn:0   dfail:0   fail:1   skip:108 time:324s
fi-glk-1         total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:542s
fi-hsw-4770      total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:403s
fi-ilk-650       total:285  pass:225  dwarn:0   dfail:0   fail:0   skip:60  time:424s
fi-ivb-3520m     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:468s
fi-ivb-3770      total:285  pass:252  dwarn:0   dfail:0   fail:0   skip:33  time:429s
fi-kbl-7500u     total:285  pass:260  dwarn:1   dfail:0   fail:0   skip:24  time:480s
fi-kbl-7567u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:467s
fi-kbl-r         total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:517s
fi-pnv-d510      total:285  pass:219  dwarn:1   dfail:0   fail:0   skip:65  time:661s
fi-skl-6260u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:439s
fi-skl-6600u     total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:534s
fi-skl-6700hq    total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:543s
fi-skl-6700k2    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:504s
fi-skl-6770hq    total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:496s
fi-skl-guc       total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:425s
fi-skl-gvtdvm    total:285  pass:262  dwarn:0   dfail:0   fail:0   skip:23  time:446s
fi-snb-2520m     total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:598s
fi-snb-2600      total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:412s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1165/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_frontbuffer_tracking: Fix Y alignment in the scaledprimary subtest. (rev3)

[Patchwork]

== Series Details ==

Series: tests/kms_frontbuffer_tracking: Fix Y alignment in the scaledprimary subtest. (rev3)
URL   : https://patchwork.freedesktop.org/series/40192/
State : success

== Summary ==

---- Possible new issues:

Test kms_cursor_crc:
        Subgroup cursor-128x128-suspend:
                skip       -> PASS       (shard-snb)

---- Known issues:

Test kms_cursor_legacy:
        Subgroup 2x-long-flip-vs-cursor-legacy:
                incomplete -> PASS       (shard-hsw) fdo#104873
Test kms_flip:
        Subgroup dpms-vs-vblank-race:
                fail       -> PASS       (shard-hsw) fdo#103060
        Subgroup flip-vs-absolute-wf_vblank:
                fail       -> PASS       (shard-hsw) fdo#100368
Test kms_flip_tiling:
        Subgroup flip-x-tiled:
                fail       -> PASS       (shard-apl) fdo#103822
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                skip       -> PASS       (shard-snb) fdo#103375 +1
Test kms_plane_multiple:
        Subgroup atomic-pipe-a-tiling-x:
                pass       -> FAIL       (shard-snb) fdo#103166 +1
Test perf:
        Subgroup blocking:
                pass       -> FAIL       (shard-hsw) fdo#102252

fdo#104873 https://bugs.freedesktop.org/show_bug.cgi?id=104873
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252

shard-apl        total:3478 pass:1814 dwarn:1   dfail:0   fail:7   skip:1655 time:12948s
shard-hsw        total:3478 pass:1767 dwarn:1   dfail:0   fail:2   skip:1707 time:11807s
shard-snb        total:3478 pass:1357 dwarn:1   dfail:0   fail:3   skip:2117 time:7221s
Blacklisted hosts:
shard-kbl        total:3478 pass:1942 dwarn:1   dfail:0   fail:7   skip:1528 time:9819s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1165/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Fix Y alignment in the scaledprimary subtest, v3.

[Maarten Lankhorst]

Op 20-03-18 om 08:39 schreef Maarten Lankhorst:
> This is hidden behind the other kms_frontbuffer_tracking failures,
> but is its own fail.
>
> On gen9/gen10 we fail the scaledprimary tests because FBC refuses
> to be enabled with "plane Y offset is misaligned".
> Looking at the kernel, this is a workaround for FIFO underruns
> which can be tested as well. Test that with the right alignment, FBC
> is enabled and with misalignment FBC is disabled on <= gen10.
>
> Changes since v1:
> - Always check both alignments.
> Changes since v2:
> - Fix gen assignment.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  tests/kms_frontbuffer_tracking.c | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> index 454103d367c7..5576b058b852 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -2751,8 +2751,10 @@ static void scaledprimary_subtest(const struct test_mode *t)
>  	struct igt_fb new_fb, *old_fb;
>  	struct modeset_params *params = pick_params(t);
>  	struct fb_region *reg = &params->primary;
> +	int gen = intel_gen(intel_get_drm_devid(drm.fd));
> +	int src_y_upscale = ALIGN(reg->h / 4, 4);
>  
> -	igt_require_f(intel_gen(intel_get_drm_devid(drm.fd)) >= 9,
> +	igt_require_f(gen >= 9,
>  		      "Can't test primary plane scaling before gen 9\n");
>  
>  	prepare_subtest(t, NULL);
> @@ -2801,11 +2803,23 @@ static void scaledprimary_subtest(const struct test_mode *t)
>  
>  	/* Destination doesn't fill the entire CRTC, upscaling. */
>  	igt_fb_set_position(&new_fb, reg->plane,
> -			    reg->x + reg->w / 4, reg->y + reg->h / 4);
> +			    reg->x + reg->w / 4, reg->y + src_y_upscale);
>  	igt_fb_set_size(&new_fb, reg->plane, reg->w / 2, reg->h / 2);
>  	igt_display_commit2(&drm.display, COMMIT_UNIVERSAL);
>  	do_assertions(DONT_ASSERT_CRC);
>  
> +	/*
> +	 * On gen <= 10 HW, FBC is not enabled on a plane with a Y offset
> +	 * that isn't divisible by 4, because it causes FIFO underruns.
> +	 *
> +	 * Check that FBC is disabled.
> +	 */
> +	igt_fb_set_position(&new_fb, reg->plane,
> +			    reg->x + reg->w / 4, reg->y + src_y_upscale + 3);
> +	igt_fb_set_size(&new_fb, reg->plane, reg->w / 2, reg->h / 2);
> +	igt_display_commit2(&drm.display, COMMIT_UNIVERSAL);
> +	do_assertions(DONT_ASSERT_CRC | (gen <= 10 ? ASSERT_FBC_DISABLED : 0));
> +
>  	/* Back to the good and old blue fb. */
>  	igt_plane_set_fb(reg->plane, old_fb);
>  	igt_plane_set_position(params->primary.plane, 0, 0);

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105678

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Fix Y alignment in the scaledprimary subtest, v3.

[Lofstedt, Marta]

Reviewed-by: Marta Lofstedt <marta.lofstedt@intel.com>

> -----Original Message-----
> From: igt-dev [mailto:igt-dev-bounces@lists.freedesktop.org] On Behalf Of
> Maarten Lankhorst
> Sent: Tuesday, March 20, 2018 9:39 AM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Fix Y
> alignment in the scaledprimary subtest, v3.
> 
> This is hidden behind the other kms_frontbuffer_tracking failures, but is its
> own fail.
> 
> On gen9/gen10 we fail the scaledprimary tests because FBC refuses to be
> enabled with "plane Y offset is misaligned".
> Looking at the kernel, this is a workaround for FIFO underruns which can be
> tested as well. Test that with the right alignment, FBC is enabled and with
> misalignment FBC is disabled on <= gen10.
> 
> Changes since v1:
> - Always check both alignments.
> Changes since v2:
> - Fix gen assignment.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  tests/kms_frontbuffer_tracking.c | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_frontbuffer_tracking.c
> b/tests/kms_frontbuffer_tracking.c
> index 454103d367c7..5576b058b852 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -2751,8 +2751,10 @@ static void scaledprimary_subtest(const struct
> test_mode *t)
>  	struct igt_fb new_fb, *old_fb;
>  	struct modeset_params *params = pick_params(t);
>  	struct fb_region *reg = &params->primary;
> +	int gen = intel_gen(intel_get_drm_devid(drm.fd));
> +	int src_y_upscale = ALIGN(reg->h / 4, 4);
> 
> -	igt_require_f(intel_gen(intel_get_drm_devid(drm.fd)) >= 9,
> +	igt_require_f(gen >= 9,
>  		      "Can't test primary plane scaling before gen
> 9\n");
> 
>  	prepare_subtest(t, NULL);
> @@ -2801,11 +2803,23 @@ static void scaledprimary_subtest(const struct
> test_mode *t)
> 
>  	/* Destination doesn't fill the entire CRTC, upscaling. */
>  	igt_fb_set_position(&new_fb, reg->plane,
> -			    reg->x + reg->w / 4, reg->y +
> reg->h / 4);
> +			    reg->x + reg->w / 4, reg->y +
> src_y_upscale);
>  	igt_fb_set_size(&new_fb, reg->plane, reg->w / 2, reg->h / 2);
>  	igt_display_commit2(&drm.display, COMMIT_UNIVERSAL);
>  	do_assertions(DONT_ASSERT_CRC);
> 
> +	/*
> +	 * On gen <= 10 HW, FBC is not enabled on a plane with a Y
> offset
> +	 * that isn't divisible by 4, because it causes FIFO underruns.
> +	 *
> +	 * Check that FBC is disabled.
> +	 */
> +	igt_fb_set_position(&new_fb, reg->plane,
> +			    reg->x + reg->w / 4, reg->y +
> src_y_upscale + 3);
> +	igt_fb_set_size(&new_fb, reg->plane, reg->w / 2, reg->h / 2);
> +	igt_display_commit2(&drm.display, COMMIT_UNIVERSAL);
> +	do_assertions(DONT_ASSERT_CRC | (gen <= 10 ?
> ASSERT_FBC_DISABLED :
> +0));
> +
>  	/* Back to the good and old blue fb. */
>  	igt_plane_set_fb(reg->plane, old_fb);
>  	igt_plane_set_position(params->primary.plane, 0, 0);
> --
> 2.16.2
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Fix Y alignment in the scaledprimary subtest, v3.

[Maarten Lankhorst]

Op 28-03-18 om 12:50 schreef Lofstedt, Marta:
> Reviewed-by: Marta Lofstedt <marta.lofstedt@intel.com>
>
>> -----Original Message-----
>> From: igt-dev [mailto:igt-dev-bounces@lists.freedesktop.org] On Behalf Of
>> Maarten Lankhorst
>> Sent: Tuesday, March 20, 2018 9:39 AM
>> To: igt-dev@lists.freedesktop.org
>> Subject: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Fix Y
>> alignment in the scaledprimary subtest, v3.
>>
>> This is hidden behind the other kms_frontbuffer_tracking failures, but is its
>> own fail.
>>
>> On gen9/gen10 we fail the scaledprimary tests because FBC refuses to be
>> enabled with "plane Y offset is misaligned".
>> Looking at the kernel, this is a workaround for FIFO underruns which can be
>> tested as well. Test that with the right alignment, FBC is enabled and with
>> misalignment FBC is disabled on <= gen10.
>>
>> Changes since v1:
>> - Always check both alignments.
>> Changes since v2:
>> - Fix gen assignment.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>>  tests/kms_frontbuffer_tracking.c | 18 ++++++++++++++++--
>>  1 file changed, 16 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/kms_frontbuffer_tracking.c
>> b/tests/kms_frontbuffer_tracking.c
>> index 454103d367c7..5576b058b852 100644
>> --- a/tests/kms_frontbuffer_tracking.c
>> +++ b/tests/kms_frontbuffer_tracking.c
>> @@ -2751,8 +2751,10 @@ static void scaledprimary_subtest(const struct
>> test_mode *t)
>>  	struct igt_fb new_fb, *old_fb;
>>  	struct modeset_params *params = pick_params(t);
>>  	struct fb_region *reg = &params->primary;
>> +	int gen = intel_gen(intel_get_drm_devid(drm.fd));
>> +	int src_y_upscale = ALIGN(reg->h / 4, 4);
>>
>> -	igt_require_f(intel_gen(intel_get_drm_devid(drm.fd)) >= 9,
>> +	igt_require_f(gen >= 9,
>>  		      "Can't test primary plane scaling before gen
>> 9\n");
>>
>>  	prepare_subtest(t, NULL);
>> @@ -2801,11 +2803,23 @@ static void scaledprimary_subtest(const struct
>> test_mode *t)
>>
>>  	/* Destination doesn't fill the entire CRTC, upscaling. */
>>  	igt_fb_set_position(&new_fb, reg->plane,
>> -			    reg->x + reg->w / 4, reg->y +
>> reg->h / 4);
>> +			    reg->x + reg->w / 4, reg->y +
>> src_y_upscale);
>>  	igt_fb_set_size(&new_fb, reg->plane, reg->w / 2, reg->h / 2);
>>  	igt_display_commit2(&drm.display, COMMIT_UNIVERSAL);
>>  	do_assertions(DONT_ASSERT_CRC);
>>
>> +	/*
>> +	 * On gen <= 10 HW, FBC is not enabled on a plane with a Y
>> offset
>> +	 * that isn't divisible by 4, because it causes FIFO underruns.
>> +	 *
>> +	 * Check that FBC is disabled.
>> +	 */
>> +	igt_fb_set_position(&new_fb, reg->plane,
>> +			    reg->x + reg->w / 4, reg->y +
>> src_y_upscale + 3);
>> +	igt_fb_set_size(&new_fb, reg->plane, reg->w / 2, reg->h / 2);
>> +	igt_display_commit2(&drm.display, COMMIT_UNIVERSAL);
>> +	do_assertions(DONT_ASSERT_CRC | (gen <= 10 ?
>> ASSERT_FBC_DISABLED :
>> +0));
>> +
>>  	/* Back to the good and old blue fb. */
>>  	igt_plane_set_fb(reg->plane, old_fb);
>>  	igt_plane_set_position(params->primary.plane, 0, 0);
>> --
>> 2.16.2
>>
>> _______________________________________________
>> igt-dev mailing list
>> igt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/igt-dev

Thanks, pushed.

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev