* [PATCH libdrm v2 02/23] meson: don't enable libdrm_radeon without atomic support
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
@ 2018-04-04 15:37 ` Eric Engestrom
2018-04-04 21:00 ` Dylan Baker
2018-04-04 15:37 ` [PATCH libdrm v2 03/23] meson: don't enable libdrm_amdgpu " Eric Engestrom
` (20 subsequent siblings)
21 siblings, 1 reply; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:37 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
In the 'auto' case, the `with_atomic` check was bypassed.
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/meson.build b/meson.build
index e762dcc44bff5deac4d1..72cdd14a3ba834abde4d 100644
--- a/meson.build
+++ b/meson.build
@@ -82,11 +82,13 @@ endif
with_radeon = false
_radeon = get_option('radeon')
-if _radeon != 'false'
- if _radeon == 'true' and not with_atomics
- error('libdrm_radeon requires atomics.')
- endif
- with_radeon = true
+if _radeon == 'auto'
+ with_radeon = with_atomics
+else
+ with_radeon = _radeon == 'true'
+endif
+if with_radeon and not with_atomics
+ error('libdrm_radeon requires atomics.')
endif
with_amdgpu = false
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* Re: [PATCH libdrm v2 02/23] meson: don't enable libdrm_radeon without atomic support
2018-04-04 15:37 ` [PATCH libdrm v2 02/23] meson: don't enable libdrm_radeon " Eric Engestrom
@ 2018-04-04 21:00 ` Dylan Baker
0 siblings, 0 replies; 57+ messages in thread
From: Dylan Baker @ 2018-04-04 21:00 UTC (permalink / raw)
To: Eric Engestrom, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1077 bytes --]
Quoting Eric Engestrom (2018-04-04 08:37:57)
> In the 'auto' case, the `with_atomic` check was bypassed.
>
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
> meson.build | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index e762dcc44bff5deac4d1..72cdd14a3ba834abde4d 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -82,11 +82,13 @@ endif
>
> with_radeon = false
> _radeon = get_option('radeon')
> -if _radeon != 'false'
> - if _radeon == 'true' and not with_atomics
> - error('libdrm_radeon requires atomics.')
> - endif
> - with_radeon = true
What about just change this to `with_radeon = with_atomics`? We've already
verified that if radeon == true that atomics are present.
> +if _radeon == 'auto'
> + with_radeon = with_atomics
> +else
> + with_radeon = _radeon == 'true'
> +endif
> +if with_radeon and not with_atomics
> + error('libdrm_radeon requires atomics.')
> endif
>
> with_amdgpu = false
> --
> Cheers,
> Eric
>
[-- Attachment #1.2: signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
-----BEGIN PGP SIGNATURE-----
iHUEABYKAB0WIQRxxLdWILx1cItL2yVMlfqrPrBz7AUCWsU82gAKCRBMlfqrPrBz
7DCNAQDYmlnx312Xfw2OzxCAZ4SMBikXckmBMuN9J665pbf2kgEAr/ZNYQ+EX6FD
FyUe9Oerpo8EiBprdrNUFFsxnjVL2Qk=
=onvc
-----END PGP SIGNATURE-----
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 57+ messages in thread
* [PATCH libdrm v2 03/23] meson: don't enable libdrm_amdgpu without atomic support
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
2018-04-04 15:37 ` [PATCH libdrm v2 02/23] meson: don't enable libdrm_radeon " Eric Engestrom
@ 2018-04-04 15:37 ` Eric Engestrom
2018-04-04 15:37 ` [PATCH libdrm v2 04/23] meson: don't enable libdrm_nouveau " Eric Engestrom
` (19 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:37 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
In the 'auto' case, the `with_atomic` check was bypassed.
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/meson.build b/meson.build
index 72cdd14a3ba834abde4d..4bc088bacdd8120c1508 100644
--- a/meson.build
+++ b/meson.build
@@ -93,11 +93,13 @@ endif
with_amdgpu = false
_amdgpu = get_option('amdgpu')
-if _amdgpu != 'false'
- if _amdgpu == 'true' and not with_atomics
- error('libdrm_amdgpu requires atomics.')
- endif
- with_amdgpu = true
+if _amdgpu == 'auto'
+ with_amdgpu = with_atomics
+else
+ with_amdgpu = _amdgpu == 'true'
+endif
+if with_amdgpu and not with_atomics
+ error('libdrm_amdgpu requires atomics.')
endif
with_nouveau = false
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 04/23] meson: don't enable libdrm_nouveau without atomic support
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
2018-04-04 15:37 ` [PATCH libdrm v2 02/23] meson: don't enable libdrm_radeon " Eric Engestrom
2018-04-04 15:37 ` [PATCH libdrm v2 03/23] meson: don't enable libdrm_amdgpu " Eric Engestrom
@ 2018-04-04 15:37 ` Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 05/23] meson: don't enable libdrm_freedreno " Eric Engestrom
` (18 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:37 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
In the 'auto' case, the `with_atomic` check was bypassed.
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/meson.build b/meson.build
index 4bc088bacdd8120c1508..edcc7e8ddc39b1760868 100644
--- a/meson.build
+++ b/meson.build
@@ -104,11 +104,13 @@ endif
with_nouveau = false
_nouveau = get_option('nouveau')
-if _nouveau != 'false'
- if _nouveau == 'true' and not with_atomics
- error('libdrm_nouveau requires atomics.')
- endif
- with_nouveau = true
+if _nouveau == 'auto'
+ with_nouveau = with_atomics
+else
+ with_nouveau = _nouveau == 'true'
+endif
+if with_nouveau and not with_atomics
+ error('libdrm_nouveau requires atomics.')
endif
with_vmwgfx = false
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 05/23] meson: don't enable libdrm_freedreno without atomic support
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (2 preceding siblings ...)
2018-04-04 15:37 ` [PATCH libdrm v2 04/23] meson: don't enable libdrm_nouveau " Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 06/23] meson: split vc4=auto logic to make it easier to read Eric Engestrom
` (17 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
In the 'auto' case, the `with_atomic` check was bypassed.
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/meson.build b/meson.build
index edcc7e8ddc39b1760868..55ad207b6de349863be3 100644
--- a/meson.build
+++ b/meson.build
@@ -130,12 +130,13 @@ endif
with_freedreno = false
_freedreno = get_option('freedreno')
-if _freedreno != 'false'
- if _freedreno == 'true' and not with_atomics
- error('libdrm_freedreno requires atomics.')
- else
- with_freedreno = _freedreno == 'true' or ['arm', 'aarch64'].contains(host_machine.cpu_family())
- endif
+if _freedreno == 'auto'
+ with_freedreno = with_atomics and ['arm', 'aarch64'].contains(host_machine.cpu_family())
+else
+ with_freedreno = _freedreno == 'true'
+endif
+if with_freedreno and not with_atomics
+ error('libdrm_freedreno requires atomics.')
endif
with_tegra = false
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 06/23] meson: split vc4=auto logic to make it easier to read
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (3 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 05/23] meson: don't enable libdrm_freedreno " Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 07/23] meson: split libkms=auto " Eric Engestrom
` (16 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index 55ad207b6de349863be3..ba8072a19515f8d7aaa4 100644
--- a/meson.build
+++ b/meson.build
@@ -161,8 +161,10 @@ with_exynos = get_option('exynos') == 'true'
with_vc4 = false
_vc4 = get_option('vc4')
-if _vc4 != 'false'
- with_vc4 = _vc4 == 'true' or ['arm', 'aarch64'].contains(host_machine.cpu_family())
+if _vc4 == 'auto'
+ with_vc4 = ['arm', 'aarch64'].contains(host_machine.cpu_family())
+else
+ with_vc4 = _vc4 == 'true'
endif
# XXX: Aparently only freebsd and dragonfly bsd actually need this (and
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 07/23] meson: split libkms=auto logic to make it easier to read
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (4 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 06/23] meson: split vc4=auto logic to make it easier to read Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 08/23] meson: introduce simpler way to handle driver options Eric Engestrom
` (15 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index ba8072a19515f8d7aaa4..5b6710ee8dc16b02dbed 100644
--- a/meson.build
+++ b/meson.build
@@ -171,8 +171,10 @@ endif
# gnu/kfreebsd), not openbsd and netbsd
with_libkms = false
_libkms = get_option('libkms')
-if _libkms != 'false'
- with_libkms = _libkms == 'true' or ['linux', 'freebsd', 'dragonfly'].contains(host_machine.system())
+if _libkms == 'auto'
+ with_libkms = ['linux', 'freebsd', 'dragonfly'].contains(host_machine.system())
+else
+ with_libkms = _libkms == 'true'
endif
# Among others FreeBSD does not have a separate dl library.
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 08/23] meson: introduce simpler way to handle driver options
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (5 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 07/23] meson: split libkms=auto " Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 09/23] meson: use simple option handling for intel Eric Engestrom
` (14 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/meson.build b/meson.build
index 5b6710ee8dc16b02dbed..8efa99b54e6a108b8255 100644
--- a/meson.build
+++ b/meson.build
@@ -69,6 +69,27 @@ endif
config.set10('HAVE_LIBDRM_ATOMIC_PRIMITIVES', intel_atomics)
config.set10('HAVE_LIB_ATOMIC_OPS', lib_atomics)
+foreach d : [
+]
+ driver = d[0]
+ require_atomics = d[1]
+ default = d[2]
+ _option = get_option(driver)
+
+ if _option == 'auto'
+ if with_atomics or not require_atomics
+ set_variable('with_' + driver, default)
+ else
+ set_variable('with_' + driver, false)
+ endif
+ else
+ if _option == 'true' and require_atomics and not with_atomics
+ error('libdrm_' + driver + ' requires atomics.')
+ endif
+ set_variable('with_' + driver, _option == 'true')
+ endif
+endforeach
+
with_intel = false
_intel = get_option('intel')
if _intel == 'auto'
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 09/23] meson: use simple option handling for intel
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (6 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 08/23] meson: introduce simpler way to handle driver options Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 10/23] meson: use simple option handling for radeon Eric Engestrom
` (13 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/meson.build b/meson.build
index 8efa99b54e6a108b8255..12cf96157b2789df3a55 100644
--- a/meson.build
+++ b/meson.build
@@ -70,6 +70,7 @@ config.set10('HAVE_LIBDRM_ATOMIC_PRIMITIVES', intel_atomics)
config.set10('HAVE_LIB_ATOMIC_OPS', lib_atomics)
foreach d : [
+ ['intel', true, host_machine.cpu_family().startswith('x86')],
]
driver = d[0]
require_atomics = d[1]
@@ -90,17 +91,6 @@ foreach d : [
endif
endforeach
-with_intel = false
-_intel = get_option('intel')
-if _intel == 'auto'
- with_intel = with_atomics and host_machine.cpu_family().startswith('x86')
-else
- with_intel = _intel == 'true'
-endif
-if with_intel and not with_atomics
- error('libdrm_intel requires atomics.')
-endif
-
with_radeon = false
_radeon = get_option('radeon')
if _radeon == 'auto'
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 10/23] meson: use simple option handling for radeon
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (7 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 09/23] meson: use simple option handling for intel Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 11/23] meson: use simple option handling for amdgpu Eric Engestrom
` (12 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/meson.build b/meson.build
index 12cf96157b2789df3a55..035ac8cf2f1130d0b799 100644
--- a/meson.build
+++ b/meson.build
@@ -71,6 +71,7 @@ config.set10('HAVE_LIB_ATOMIC_OPS', lib_atomics)
foreach d : [
['intel', true, host_machine.cpu_family().startswith('x86')],
+ ['radeon', true, true],
]
driver = d[0]
require_atomics = d[1]
@@ -91,17 +92,6 @@ foreach d : [
endif
endforeach
-with_radeon = false
-_radeon = get_option('radeon')
-if _radeon == 'auto'
- with_radeon = with_atomics
-else
- with_radeon = _radeon == 'true'
-endif
-if with_radeon and not with_atomics
- error('libdrm_radeon requires atomics.')
-endif
-
with_amdgpu = false
_amdgpu = get_option('amdgpu')
if _amdgpu == 'auto'
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 11/23] meson: use simple option handling for amdgpu
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (8 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 10/23] meson: use simple option handling for radeon Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 12/23] meson: use simple option handling for nouveau Eric Engestrom
` (11 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/meson.build b/meson.build
index 035ac8cf2f1130d0b799..da52f5c078c3d2f47397 100644
--- a/meson.build
+++ b/meson.build
@@ -72,6 +72,7 @@ config.set10('HAVE_LIB_ATOMIC_OPS', lib_atomics)
foreach d : [
['intel', true, host_machine.cpu_family().startswith('x86')],
['radeon', true, true],
+ ['amdgpu', true, true],
]
driver = d[0]
require_atomics = d[1]
@@ -92,17 +93,6 @@ foreach d : [
endif
endforeach
-with_amdgpu = false
-_amdgpu = get_option('amdgpu')
-if _amdgpu == 'auto'
- with_amdgpu = with_atomics
-else
- with_amdgpu = _amdgpu == 'true'
-endif
-if with_amdgpu and not with_atomics
- error('libdrm_amdgpu requires atomics.')
-endif
-
with_nouveau = false
_nouveau = get_option('nouveau')
if _nouveau == 'auto'
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 12/23] meson: use simple option handling for nouveau
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (9 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 11/23] meson: use simple option handling for amdgpu Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 13/23] meson: use simple option handling for vmwgfx Eric Engestrom
` (10 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/meson.build b/meson.build
index da52f5c078c3d2f47397..e871c77c9860a84eed8f 100644
--- a/meson.build
+++ b/meson.build
@@ -73,6 +73,7 @@ foreach d : [
['intel', true, host_machine.cpu_family().startswith('x86')],
['radeon', true, true],
['amdgpu', true, true],
+ ['nouveau', true, true],
]
driver = d[0]
require_atomics = d[1]
@@ -93,17 +94,6 @@ foreach d : [
endif
endforeach
-with_nouveau = false
-_nouveau = get_option('nouveau')
-if _nouveau == 'auto'
- with_nouveau = with_atomics
-else
- with_nouveau = _nouveau == 'true'
-endif
-if with_nouveau and not with_atomics
- error('libdrm_nouveau requires atomics.')
-endif
-
with_vmwgfx = false
_vmwgfx = get_option('vmwgfx')
if _vmwgfx != 'false'
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 13/23] meson: use simple option handling for vmwgfx
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (10 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 12/23] meson: use simple option handling for nouveau Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 14/23] meson: use simple option handling for omap Eric Engestrom
` (9 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/meson.build b/meson.build
index e871c77c9860a84eed8f..6786a44e3df1a2e00540 100644
--- a/meson.build
+++ b/meson.build
@@ -74,6 +74,7 @@ foreach d : [
['radeon', true, true],
['amdgpu', true, true],
['nouveau', true, true],
+ ['vmwgfx', false, true],
]
driver = d[0]
require_atomics = d[1]
@@ -94,12 +95,6 @@ foreach d : [
endif
endforeach
-with_vmwgfx = false
-_vmwgfx = get_option('vmwgfx')
-if _vmwgfx != 'false'
- with_vmwgfx = true
-endif
-
with_omap = false
_omap = get_option('omap')
if _omap == 'true'
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 14/23] meson: use simple option handling for omap
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (11 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 13/23] meson: use simple option handling for vmwgfx Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 17:55 ` Sebastian Reichel
2018-04-04 15:38 ` [PATCH libdrm v2 15/23] meson: use simple option handling for exynos Eric Engestrom
` (8 subsequent siblings)
21 siblings, 1 reply; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/meson.build b/meson.build
index 6786a44e3df1a2e00540..29f91ee9f6eb96b05f0d 100644
--- a/meson.build
+++ b/meson.build
@@ -75,6 +75,7 @@ foreach d : [
['amdgpu', true, true],
['nouveau', true, true],
['vmwgfx', false, true],
+ ['omap', true, false],
]
driver = d[0]
require_atomics = d[1]
@@ -95,13 +96,12 @@ foreach d : [
endif
endforeach
-with_omap = false
-_omap = get_option('omap')
-if _omap == 'true'
- if not with_atomics
- error('libdrm_omap requires atomics.')
- endif
- with_omap = true
+with_exynos = false
+_exynos = get_option('exynos')
+if _exynos == 'auto'
+ with_exynos = true
+else
+ with_exynos = _exynos == 'true'
endif
with_freedreno = false
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* Re: [PATCH libdrm v2 14/23] meson: use simple option handling for omap
2018-04-04 15:38 ` [PATCH libdrm v2 14/23] meson: use simple option handling for omap Eric Engestrom
@ 2018-04-04 17:55 ` Sebastian Reichel
2018-04-05 10:12 ` Eric Engestrom
0 siblings, 1 reply; 57+ messages in thread
From: Sebastian Reichel @ 2018-04-04 17:55 UTC (permalink / raw)
To: Eric Engestrom; +Cc: dri-devel, Dylan Baker
[-- Attachment #1.1: Type: text/plain, Size: 541 bytes --]
Hi,
On Wed, Apr 04, 2018 at 04:38:09PM +0100, Eric Engestrom wrote:
> [...]
>
> -with_omap = false
> -_omap = get_option('omap')
> -if _omap == 'true'
> - if not with_atomics
> - error('libdrm_omap requires atomics.')
> - endif
> - with_omap = true
> +with_exynos = false
> +_exynos = get_option('exynos')
> +if _exynos == 'auto'
> + with_exynos = true
> +else
> + with_exynos = _exynos == 'true'
> endif
Looks like some patch rebasing went wrong with this one (it
simplifies omap, but also adds some exynos stuff)?
-- Sebastian
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH libdrm v2 14/23] meson: use simple option handling for omap
2018-04-04 17:55 ` Sebastian Reichel
@ 2018-04-05 10:12 ` Eric Engestrom
0 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-05 10:12 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: dri-devel, Dylan Baker
On Wednesday, 2018-04-04 19:55:18 +0200, Sebastian Reichel wrote:
> Hi,
>
> On Wed, Apr 04, 2018 at 04:38:09PM +0100, Eric Engestrom wrote:
> > [...]
> >
> > -with_omap = false
> > -_omap = get_option('omap')
> > -if _omap == 'true'
> > - if not with_atomics
> > - error('libdrm_omap requires atomics.')
> > - endif
> > - with_omap = true
> > +with_exynos = false
> > +_exynos = get_option('exynos')
> > +if _exynos == 'auto'
> > + with_exynos = true
> > +else
> > + with_exynos = _exynos == 'true'
> > endif
>
> Looks like some patch rebasing went wrong with this one (it
> simplifies omap, but also adds some exynos stuff)?
Indeed, that's a complete rebase fail...
Thanks for not letting me push this unaware :)
I'll send a v3 of 8-19 next week, after landing the first bits (1-7).
I think I'll defer 20-23 to after everything else has landed.
>
> -- Sebastian
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 57+ messages in thread
* [PATCH libdrm v2 15/23] meson: use simple option handling for exynos
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (12 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 14/23] meson: use simple option handling for omap Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 16/23] meson: use simple option handling for freedreno Eric Engestrom
` (7 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/meson.build b/meson.build
index 29f91ee9f6eb96b05f0d..f0804fc5a0a1d907313f 100644
--- a/meson.build
+++ b/meson.build
@@ -76,6 +76,7 @@ foreach d : [
['nouveau', true, true],
['vmwgfx', false, true],
['omap', true, false],
+ ['exynos', false, false],
]
driver = d[0]
require_atomics = d[1]
@@ -96,14 +97,6 @@ foreach d : [
endif
endforeach
-with_exynos = false
-_exynos = get_option('exynos')
-if _exynos == 'auto'
- with_exynos = true
-else
- with_exynos = _exynos == 'true'
-endif
-
with_freedreno = false
_freedreno = get_option('freedreno')
if _freedreno == 'auto'
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 16/23] meson: use simple option handling for freedreno
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (13 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 15/23] meson: use simple option handling for exynos Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 17/23] meson: use simple option handling for tegra Eric Engestrom
` (6 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/meson.build b/meson.build
index f0804fc5a0a1d907313f..72e5836e78bd239584b3 100644
--- a/meson.build
+++ b/meson.build
@@ -77,6 +77,7 @@ foreach d : [
['vmwgfx', false, true],
['omap', true, false],
['exynos', false, false],
+ ['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
]
driver = d[0]
require_atomics = d[1]
@@ -97,17 +98,6 @@ foreach d : [
endif
endforeach
-with_freedreno = false
-_freedreno = get_option('freedreno')
-if _freedreno == 'auto'
- with_freedreno = with_atomics and ['arm', 'aarch64'].contains(host_machine.cpu_family())
-else
- with_freedreno = _freedreno == 'true'
-endif
-if with_freedreno and not with_atomics
- error('libdrm_freedreno requires atomics.')
-endif
-
with_tegra = false
_tegra = get_option('tegra')
if _tegra == 'true'
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 17/23] meson: use simple option handling for tegra
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (14 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 16/23] meson: use simple option handling for freedreno Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 18/23] meson: use simple option handling for vc4 Eric Engestrom
` (5 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/meson.build b/meson.build
index 72e5836e78bd239584b3..a469bdbff1743f796bdf 100644
--- a/meson.build
+++ b/meson.build
@@ -78,6 +78,7 @@ foreach d : [
['omap', true, false],
['exynos', false, false],
['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
+ ['tegra', true, false],
]
driver = d[0]
require_atomics = d[1]
@@ -98,15 +99,6 @@ foreach d : [
endif
endforeach
-with_tegra = false
-_tegra = get_option('tegra')
-if _tegra == 'true'
- if not with_atomics
- error('libdrm_tegra requires atomics.')
- endif
- with_tegra = true
-endif
-
with_etnaviv = false
_etnaviv = get_option('etnaviv')
if _etnaviv == 'true'
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 18/23] meson: use simple option handling for vc4
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (15 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 17/23] meson: use simple option handling for tegra Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 19/23] meson: use simple option handling for etnaviv Eric Engestrom
` (4 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/meson.build b/meson.build
index a469bdbff1743f796bdf..f3747736f5bed7c01143 100644
--- a/meson.build
+++ b/meson.build
@@ -79,6 +79,7 @@ foreach d : [
['exynos', false, false],
['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
['tegra', true, false],
+ ['vc4', false, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
]
driver = d[0]
require_atomics = d[1]
@@ -110,14 +111,6 @@ endif
with_exynos = get_option('exynos') == 'true'
-with_vc4 = false
-_vc4 = get_option('vc4')
-if _vc4 == 'auto'
- with_vc4 = ['arm', 'aarch64'].contains(host_machine.cpu_family())
-else
- with_vc4 = _vc4 == 'true'
-endif
-
# XXX: Aparently only freebsd and dragonfly bsd actually need this (and
# gnu/kfreebsd), not openbsd and netbsd
with_libkms = false
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 19/23] meson: use simple option handling for etnaviv
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (16 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 18/23] meson: use simple option handling for vc4 Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 21:04 ` Dylan Baker
2018-04-04 15:38 ` [PATCH libdrm v2 20/23] meson: build omap by default Eric Engestrom
` (3 subsequent siblings)
21 siblings, 1 reply; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/meson.build b/meson.build
index f3747736f5bed7c01143..f659c02bc82660d038cc 100644
--- a/meson.build
+++ b/meson.build
@@ -80,6 +80,7 @@ foreach d : [
['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
['tegra', true, false],
['vc4', false, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
+ ['etnaviv', true, false],
]
driver = d[0]
require_atomics = d[1]
@@ -100,15 +101,6 @@ foreach d : [
endif
endforeach
-with_etnaviv = false
-_etnaviv = get_option('etnaviv')
-if _etnaviv == 'true'
- if not with_atomics
- error('libdrm_etnaviv requires atomics.')
- endif
- with_etnaviv = true
-endif
-
with_exynos = get_option('exynos') == 'true'
# XXX: Aparently only freebsd and dragonfly bsd actually need this (and
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* Re: [PATCH libdrm v2 19/23] meson: use simple option handling for etnaviv
2018-04-04 15:38 ` [PATCH libdrm v2 19/23] meson: use simple option handling for etnaviv Eric Engestrom
@ 2018-04-04 21:04 ` Dylan Baker
0 siblings, 0 replies; 57+ messages in thread
From: Dylan Baker @ 2018-04-04 21:04 UTC (permalink / raw)
To: Eric Engestrom, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1283 bytes --]
You can ignore my comments on the first couple of patches if you like, I think
the result is much nicer anyway.
1-19 are:
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
Quoting Eric Engestrom (2018-04-04 08:38:14)
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
> meson.build | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index f3747736f5bed7c01143..f659c02bc82660d038cc 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -80,6 +80,7 @@ foreach d : [
> ['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
> ['tegra', true, false],
> ['vc4', false, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
> + ['etnaviv', true, false],
> ]
> driver = d[0]
> require_atomics = d[1]
> @@ -100,15 +101,6 @@ foreach d : [
> endif
> endforeach
>
> -with_etnaviv = false
> -_etnaviv = get_option('etnaviv')
> -if _etnaviv == 'true'
> - if not with_atomics
> - error('libdrm_etnaviv requires atomics.')
> - endif
> - with_etnaviv = true
> -endif
> -
> with_exynos = get_option('exynos') == 'true'
>
> # XXX: Aparently only freebsd and dragonfly bsd actually need this (and
> --
> Cheers,
> Eric
>
[-- Attachment #1.2: signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
-----BEGIN PGP SIGNATURE-----
iHUEABYKAB0WIQRxxLdWILx1cItL2yVMlfqrPrBz7AUCWsU92wAKCRBMlfqrPrBz
7M7gAP4qvOFwOjinjQGpTtBsGI6s7nrmZ1qH/p/ASriadD9SEgEA4Ir8J9sqmAE2
8metj0Aw1ABUknwqPNBZxiH43w7KogU=
=p9ls
-----END PGP SIGNATURE-----
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 57+ messages in thread
* [PATCH libdrm v2 20/23] meson: build omap by default
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (17 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 19/23] meson: use simple option handling for etnaviv Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 21/23] meson: build exynos " Eric Engestrom
` (2 subsequent siblings)
21 siblings, 0 replies; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index f659c02bc82660d038cc..24688535a329ac530c10 100644
--- a/meson.build
+++ b/meson.build
@@ -75,7 +75,7 @@ foreach d : [
['amdgpu', true, true],
['nouveau', true, true],
['vmwgfx', false, true],
- ['omap', true, false],
+ ['omap', true, true],
['exynos', false, false],
['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
['tegra', true, false],
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH libdrm v2 21/23] meson: build exynos by default
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (18 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 20/23] meson: build omap by default Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 21:10 ` Dylan Baker
2018-04-04 15:38 ` [PATCH libdrm v2 22/23] meson: build tegra " Eric Engestrom
2018-04-04 15:38 ` [PATCH libdrm v2 23/23] meson: build etnaviv " Eric Engestrom
21 siblings, 1 reply; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 24688535a329ac530c10..7b26977a9e84290fdd37 100644
--- a/meson.build
+++ b/meson.build
@@ -76,7 +76,7 @@ foreach d : [
['nouveau', true, true],
['vmwgfx', false, true],
['omap', true, true],
- ['exynos', false, false],
+ ['exynos', false, true],
['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
['tegra', true, false],
['vc4', false, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* Re: [PATCH libdrm v2 21/23] meson: build exynos by default
2018-04-04 15:38 ` [PATCH libdrm v2 21/23] meson: build exynos " Eric Engestrom
@ 2018-04-04 21:10 ` Dylan Baker
2018-04-05 9:48 ` Eric Engestrom
0 siblings, 1 reply; 57+ messages in thread
From: Dylan Baker @ 2018-04-04 21:10 UTC (permalink / raw)
To: Eric Engestrom, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1030 bytes --]
For exynos and omap, are they in active use anymore? I'm pretty sure that
development of omap (the hardware) stopped, and others have told me exynos has
stopped too. I also don't think there's any open source consumer, since there is
no mesa driver for either of these.
Dylan
Quoting Eric Engestrom (2018-04-04 08:38:16)
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 24688535a329ac530c10..7b26977a9e84290fdd37 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -76,7 +76,7 @@ foreach d : [
> ['nouveau', true, true],
> ['vmwgfx', false, true],
> ['omap', true, true],
> - ['exynos', false, false],
> + ['exynos', false, true],
> ['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
> ['tegra', true, false],
> ['vc4', false, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
> --
> Cheers,
> Eric
>
[-- Attachment #1.2: signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
-----BEGIN PGP SIGNATURE-----
iHUEABYKAB0WIQRxxLdWILx1cItL2yVMlfqrPrBz7AUCWsU/SQAKCRBMlfqrPrBz
7FrpAQDN9V6wXgPhkNvSAUNy7YFab62aUMYUCaxV7i7TwLaR4QD9FHqcs12x7VZA
rKwKX5HrSRScefokh2Wtw5NwTJ53ww0=
=ivLq
-----END PGP SIGNATURE-----
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [PATCH libdrm v2 21/23] meson: build exynos by default
2018-04-04 21:10 ` Dylan Baker
@ 2018-04-05 9:48 ` Eric Engestrom
2018-04-05 20:39 ` Dylan Baker
0 siblings, 1 reply; 57+ messages in thread
From: Eric Engestrom @ 2018-04-05 9:48 UTC (permalink / raw)
To: Dylan Baker; +Cc: dri-devel
On Wednesday, 2018-04-04 14:10:33 -0700, Dylan Baker wrote:
> For exynos and omap, are they in active use anymore? I'm pretty sure that
> development of omap (the hardware) stopped, and others have told me exynos has
> stopped too. I also don't think there's any open source consumer, since there is
> no mesa driver for either of these.
Happy to drop these enablement patches; I just like to have everything
possible built by default, but if these are dead I'm fine with leaving
them disabled by default.
>
> Dylan
>
> Quoting Eric Engestrom (2018-04-04 08:38:16)
> > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> > ---
> > meson.build | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meson.build b/meson.build
> > index 24688535a329ac530c10..7b26977a9e84290fdd37 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -76,7 +76,7 @@ foreach d : [
> > ['nouveau', true, true],
> > ['vmwgfx', false, true],
> > ['omap', true, true],
> > - ['exynos', false, false],
> > + ['exynos', false, true],
> > ['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
> > ['tegra', true, false],
> > ['vc4', false, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
> > --
> > Cheers,
> > Eric
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [PATCH libdrm v2 21/23] meson: build exynos by default
2018-04-05 9:48 ` Eric Engestrom
@ 2018-04-05 20:39 ` Dylan Baker
0 siblings, 0 replies; 57+ messages in thread
From: Dylan Baker @ 2018-04-05 20:39 UTC (permalink / raw)
To: Eric Engestrom; +Cc: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 739 bytes --]
Quoting Eric Engestrom (2018-04-05 02:48:50)
> On Wednesday, 2018-04-04 14:10:33 -0700, Dylan Baker wrote:
> > For exynos and omap, are they in active use anymore? I'm pretty sure that
> > development of omap (the hardware) stopped, and others have told me exynos has
> > stopped too. I also don't think there's any open source consumer, since there is
> > no mesa driver for either of these.
>
> Happy to drop these enablement patches; I just like to have everything
> possible built by default, but if these are dead I'm fine with leaving
> them disabled by default.
>
Yeah, I just don't know what the right thing is, it just seems like a bad idea
to enable something by default that never really got anywhere.
Dylan
[-- Attachment #1.2: signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
-----BEGIN PGP SIGNATURE-----
iHUEABYKAB0WIQRxxLdWILx1cItL2yVMlfqrPrBz7AUCWsaJbwAKCRBMlfqrPrBz
7HQsAQCRC+ofHrojPlsDQwHt3exc3UWIUBgu3meZLuFAQ0RS8gEAgrr0ytkegd+Z
fgce23YDNM9pVHuNlWekbqNDdHiqfwE=
=3Mrg
-----END PGP SIGNATURE-----
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 57+ messages in thread
* [PATCH libdrm v2 22/23] meson: build tegra by default
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (19 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 21/23] meson: build exynos " Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 21:09 ` Dylan Baker
2018-04-04 15:38 ` [PATCH libdrm v2 23/23] meson: build etnaviv " Eric Engestrom
21 siblings, 1 reply; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 7b26977a9e84290fdd37..e816740cb240922bf98a 100644
--- a/meson.build
+++ b/meson.build
@@ -78,7 +78,7 @@ foreach d : [
['omap', true, true],
['exynos', false, true],
['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
- ['tegra', true, false],
+ ['tegra', true, true],
['vc4', false, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
['etnaviv', true, false],
]
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* Re: [PATCH libdrm v2 22/23] meson: build tegra by default
2018-04-04 15:38 ` [PATCH libdrm v2 22/23] meson: build tegra " Eric Engestrom
@ 2018-04-04 21:09 ` Dylan Baker
0 siblings, 0 replies; 57+ messages in thread
From: Dylan Baker @ 2018-04-04 21:09 UTC (permalink / raw)
To: Eric Engestrom, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 852 bytes --]
Please CC Thierry or someone else from nvidia about this,
Also I think this should be ['arm', 'aarch64'], like vc4 and freedreno.
Quoting Eric Engestrom (2018-04-04 08:38:17)
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 7b26977a9e84290fdd37..e816740cb240922bf98a 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -78,7 +78,7 @@ foreach d : [
> ['omap', true, true],
> ['exynos', false, true],
> ['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
> - ['tegra', true, false],
> + ['tegra', true, true],
> ['vc4', false, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
> ['etnaviv', true, false],
> ]
> --
> Cheers,
> Eric
>
[-- Attachment #1.2: signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
-----BEGIN PGP SIGNATURE-----
iHUEABYKAB0WIQRxxLdWILx1cItL2yVMlfqrPrBz7AUCWsU++AAKCRBMlfqrPrBz
7E+zAQDxPXn0ImmBrC0eGA850GkBAEFLDlDX/1cCjF521Zk+BwD8CW3PG6T5tSxb
EtmwXYYNrsl+028lqfcF/cHmbtxnXwI=
=IEVm
-----END PGP SIGNATURE-----
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 57+ messages in thread
* [PATCH libdrm v2 23/23] meson: build etnaviv by default
2018-04-04 15:37 ` [PATCH libdrm v2 01/23] meson: don't enable libdrm_intel without atomic support Eric Engestrom
` (20 preceding siblings ...)
2018-04-04 15:38 ` [PATCH libdrm v2 22/23] meson: build tegra " Eric Engestrom
@ 2018-04-04 15:38 ` Eric Engestrom
2018-04-04 21:06 ` Dylan Baker
21 siblings, 1 reply; 57+ messages in thread
From: Eric Engestrom @ 2018-04-04 15:38 UTC (permalink / raw)
To: dri-devel; +Cc: Dylan Baker
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index e816740cb240922bf98a..a725f05d342bbec4df18 100644
--- a/meson.build
+++ b/meson.build
@@ -80,7 +80,7 @@ foreach d : [
['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
['tegra', true, true],
['vc4', false, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
- ['etnaviv', true, false],
+ ['etnaviv', true, true],
]
driver = d[0]
require_atomics = d[1]
--
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 57+ messages in thread* Re: [PATCH libdrm v2 23/23] meson: build etnaviv by default
2018-04-04 15:38 ` [PATCH libdrm v2 23/23] meson: build etnaviv " Eric Engestrom
@ 2018-04-04 21:06 ` Dylan Baker
0 siblings, 0 replies; 57+ messages in thread
From: Dylan Baker @ 2018-04-04 21:06 UTC (permalink / raw)
To: Eric Engestrom, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 833 bytes --]
Please CC the etnaviv maintainers on this as well.
I think this should be ['arm', 'aarch64']... like vc4 and fredreno
Quoting Eric Engestrom (2018-04-04 08:38:18)
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index e816740cb240922bf98a..a725f05d342bbec4df18 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -80,7 +80,7 @@ foreach d : [
> ['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
> ['tegra', true, true],
> ['vc4', false, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
> - ['etnaviv', true, false],
> + ['etnaviv', true, true],
> ]
> driver = d[0]
> require_atomics = d[1]
> --
> Cheers,
> Eric
>
[-- Attachment #1.2: signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
-----BEGIN PGP SIGNATURE-----
iHUEABYKAB0WIQRxxLdWILx1cItL2yVMlfqrPrBz7AUCWsU+OAAKCRBMlfqrPrBz
7IcZAP0UGnSt4eS+aI81aF7Dyy1FivZ0oW/DKQ6bdPL71SvunAEAkqeJict+5xhU
Wq6k4zppPo+bs/rRcDPpTeikho4WTg8=
=6hNO
-----END PGP SIGNATURE-----
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 57+ messages in thread