* [PATCH v3] drm/i915/gvt: throw error on unhandled vfio ioctls
@ 2018-03-21 14:08 Gerd Hoffmann
2018-03-21 15:44 ` Alex Williamson
0 siblings, 1 reply; 5+ messages in thread
From: Gerd Hoffmann @ 2018-03-21 14:08 UTC (permalink / raw)
Cc: David Airlie, dri-devel, stable, Alex Williamson, Rodrigo Vivi,
intel-gvt-dev, Zhi Wang, Gerd Hoffmann
On unknown/unhandled ioctls the driver should return an error, so
userspace knows it tried to use something unsupported.
Cc: stable@vger.kernel.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
index 021f722e24..f34d7f1e6c 100644
--- a/drivers/gpu/drm/i915/gvt/kvmgt.c
+++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
@@ -1284,7 +1284,7 @@ static long intel_vgpu_ioctl(struct mdev_device *mdev, unsigned int cmd,
}
- return 0;
+ return -ENOTTY;
}
static ssize_t
--
2.9.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] drm/i915/gvt: throw error on unhandled vfio ioctls
2018-03-21 14:08 [PATCH v3] drm/i915/gvt: throw error on unhandled vfio ioctls Gerd Hoffmann
@ 2018-03-21 15:44 ` Alex Williamson
0 siblings, 0 replies; 5+ messages in thread
From: Alex Williamson @ 2018-03-21 15:44 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: intel-gvt-dev, David Airlie, dri-devel, stable, Rodrigo Vivi, Zhi Wang
On Wed, 21 Mar 2018 15:08:47 +0100
Gerd Hoffmann <kraxel@redhat.com> wrote:
> On unknown/unhandled ioctls the driver should return an error, so
> userspace knows it tried to use something unsupported.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index 021f722e24..f34d7f1e6c 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -1284,7 +1284,7 @@ static long intel_vgpu_ioctl(struct mdev_device *mdev, unsigned int cmd,
>
> }
>
> - return 0;
> + return -ENOTTY;
> }
>
> static ssize_t
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] drm/i915/gvt: throw error on unhandled vfio ioctls
@ 2018-03-21 15:44 ` Alex Williamson
0 siblings, 0 replies; 5+ messages in thread
From: Alex Williamson @ 2018-03-21 15:44 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: David Airlie, stable, dri-devel, Rodrigo Vivi, intel-gvt-dev, Zhi Wang
On Wed, 21 Mar 2018 15:08:47 +0100
Gerd Hoffmann <kraxel@redhat.com> wrote:
> On unknown/unhandled ioctls the driver should return an error, so
> userspace knows it tried to use something unsupported.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index 021f722e24..f34d7f1e6c 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -1284,7 +1284,7 @@ static long intel_vgpu_ioctl(struct mdev_device *mdev, unsigned int cmd,
>
> }
>
> - return 0;
> + return -ENOTTY;
> }
>
> static ssize_t
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] drm/i915/gvt: throw error on unhandled vfio ioctls
2018-03-21 15:44 ` Alex Williamson
@ 2018-03-22 2:13 ` Zhenyu Wang
-1 siblings, 0 replies; 5+ messages in thread
From: Zhenyu Wang @ 2018-03-22 2:13 UTC (permalink / raw)
To: Alex Williamson
Cc: Gerd Hoffmann, David Airlie, stable, dri-devel, Rodrigo Vivi,
intel-gvt-dev, Zhi Wang
[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]
On 2018.03.21 09:44:32 -0600, Alex Williamson wrote:
> On Wed, 21 Mar 2018 15:08:47 +0100
> Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> > On unknown/unhandled ioctls the driver should return an error, so
> > userspace knows it tried to use something unsupported.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> > drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> > index 021f722e24..f34d7f1e6c 100644
> > --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> > +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> > @@ -1284,7 +1284,7 @@ static long intel_vgpu_ioctl(struct mdev_device *mdev, unsigned int cmd,
> >
> > }
> >
> > - return 0;
> > + return -ENOTTY;
> > }
> >
> > static ssize_t
>
> Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
Applied, thanks!
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] drm/i915/gvt: throw error on unhandled vfio ioctls
@ 2018-03-22 2:13 ` Zhenyu Wang
0 siblings, 0 replies; 5+ messages in thread
From: Zhenyu Wang @ 2018-03-22 2:13 UTC (permalink / raw)
To: Alex Williamson
Cc: David Airlie, dri-devel, Gerd Hoffmann, Rodrigo Vivi, stable,
intel-gvt-dev, Zhi Wang
[-- Attachment #1.1: Type: text/plain, Size: 1082 bytes --]
On 2018.03.21 09:44:32 -0600, Alex Williamson wrote:
> On Wed, 21 Mar 2018 15:08:47 +0100
> Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> > On unknown/unhandled ioctls the driver should return an error, so
> > userspace knows it tried to use something unsupported.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> > drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> > index 021f722e24..f34d7f1e6c 100644
> > --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> > +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> > @@ -1284,7 +1284,7 @@ static long intel_vgpu_ioctl(struct mdev_device *mdev, unsigned int cmd,
> >
> > }
> >
> > - return 0;
> > + return -ENOTTY;
> > }
> >
> > static ssize_t
>
> Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
Applied, thanks!
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-22 2:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-21 14:08 [PATCH v3] drm/i915/gvt: throw error on unhandled vfio ioctls Gerd Hoffmann
2018-03-21 15:44 ` Alex Williamson
2018-03-21 15:44 ` Alex Williamson
2018-03-22 2:13 ` Zhenyu Wang
2018-03-22 2:13 ` Zhenyu Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.