* [PATCH][v3] mtd: rawnand: fsl_ifc: Fix nand waitfunc return value
@ 2018-03-20 23:01 Jagdish Gediya
2018-03-23 7:51 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Jagdish Gediya @ 2018-03-20 23:01 UTC (permalink / raw)
To: linux-mtd
Cc: boris.brezillon, computersforpeace, oss, leoyang.li,
Jagdish Gediya, stable
As per the IFC hardware manual, Most significant 2 bytes in
nand_fsr register are the outcome of NAND READ STATUS command.
So status value need to be shifted and aligned as per the nand
framework requirement.
Fixes: 82771882d960 ("NAND Machine support for Integrated Flash Controller")
Cc: stable@vger.kernel.org # v3.18+
Signed-off-by: Jagdish Gediya <jagdish.gediya@nxp.com>
Reviewed-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
Changes for v2: Incorporated comments from Boris Brezillon
- Added fixes tag
Changes for v3: Incorporated comments from Boris Brezillon
drivers/mtd/nand/fsl_ifc_nand.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
index 9390cbd..16104ca 100644
--- a/drivers/mtd/nand/fsl_ifc_nand.c
+++ b/drivers/mtd/nand/fsl_ifc_nand.c
@@ -629,6 +629,7 @@ static int fsl_ifc_wait(struct mtd_info *mtd, struct nand_chip *chip)
struct fsl_ifc_ctrl *ctrl = priv->ctrl;
struct fsl_ifc_runtime __iomem *ifc = ctrl->rregs;
u32 nand_fsr;
+ int status;
/* Use READ_STATUS command, but wait for the device to be ready */
ifc_out32((IFC_FIR_OP_CW0 << IFC_NAND_FIR0_OP0_SHIFT) |
@@ -643,12 +644,12 @@ static int fsl_ifc_wait(struct mtd_info *mtd, struct nand_chip *chip)
fsl_ifc_run_command(mtd);
nand_fsr = ifc_in32(&ifc->ifc_nand.nand_fsr);
-
+ status = nand_fsr >> 24;
/*
* The chip always seems to report that it is
* write-protected, even when it is not.
*/
- return nand_fsr | NAND_STATUS_WP;
+ return status | NAND_STATUS_WP;
}
/*
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][v3] mtd: rawnand: fsl_ifc: Fix nand waitfunc return value
2018-03-20 23:01 [PATCH][v3] mtd: rawnand: fsl_ifc: Fix nand waitfunc return value Jagdish Gediya
@ 2018-03-23 7:51 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2018-03-23 7:51 UTC (permalink / raw)
To: Jagdish Gediya
Cc: linux-mtd, boris.brezillon, stable, leoyang.li, oss, computersforpeace
On Wed, 21 Mar 2018 04:31:36 +0530
Jagdish Gediya <jagdish.gediya@nxp.com> wrote:
> As per the IFC hardware manual, Most significant 2 bytes in
> nand_fsr register are the outcome of NAND READ STATUS command.
>
> So status value need to be shifted and aligned as per the nand
> framework requirement.
>
> Fixes: 82771882d960 ("NAND Machine support for Integrated Flash Controller")
> Cc: stable@vger.kernel.org # v3.18+
> Signed-off-by: Jagdish Gediya <jagdish.gediya@nxp.com>
> Reviewed-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Applied.
Thanks,
Boris
> ---
> Changes for v2: Incorporated comments from Boris Brezillon
> - Added fixes tag
>
> Changes for v3: Incorporated comments from Boris Brezillon
>
> drivers/mtd/nand/fsl_ifc_nand.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
> index 9390cbd..16104ca 100644
> --- a/drivers/mtd/nand/fsl_ifc_nand.c
> +++ b/drivers/mtd/nand/fsl_ifc_nand.c
> @@ -629,6 +629,7 @@ static int fsl_ifc_wait(struct mtd_info *mtd, struct nand_chip *chip)
> struct fsl_ifc_ctrl *ctrl = priv->ctrl;
> struct fsl_ifc_runtime __iomem *ifc = ctrl->rregs;
> u32 nand_fsr;
> + int status;
>
> /* Use READ_STATUS command, but wait for the device to be ready */
> ifc_out32((IFC_FIR_OP_CW0 << IFC_NAND_FIR0_OP0_SHIFT) |
> @@ -643,12 +644,12 @@ static int fsl_ifc_wait(struct mtd_info *mtd, struct nand_chip *chip)
> fsl_ifc_run_command(mtd);
>
> nand_fsr = ifc_in32(&ifc->ifc_nand.nand_fsr);
> -
> + status = nand_fsr >> 24;
> /*
> * The chip always seems to report that it is
> * write-protected, even when it is not.
> */
> - return nand_fsr | NAND_STATUS_WP;
> + return status | NAND_STATUS_WP;
> }
>
> /*
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-23 7:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-20 23:01 [PATCH][v3] mtd: rawnand: fsl_ifc: Fix nand waitfunc return value Jagdish Gediya
2018-03-23 7:51 ` Boris Brezillon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.