* [PATCH for-4.11] x86/libxc: fix usage of XEN_X86_EMU_ALL after VPCI addition
@ 2018-03-23 10:57 Roger Pau Monne
2018-03-23 14:27 ` Wei Liu
0 siblings, 1 reply; 2+ messages in thread
From: Roger Pau Monne @ 2018-03-23 10:57 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Ian Jackson, Roger Pau Monne
HVM guest should be created with (XEN_X86_EMU_ALL &
~XEN_X86_EMU_VPCI). This is not an issue for xl/libxl because it
already sets the correct emulation flags and doesn't pass a NULL
xc_domain_configuration_t to xc_domain_create.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
tools/libxc/xc_domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
index ea3df1ef31..26b4b908b9 100644
--- a/tools/libxc/xc_domain.c
+++ b/tools/libxc/xc_domain.c
@@ -40,7 +40,7 @@ int xc_domain_create(xc_interface *xch, uint32_t ssidref,
#if defined (__i386) || defined(__x86_64__)
if ( flags & XEN_DOMCTL_CDF_hvm_guest )
- lconfig.emulation_flags = XEN_X86_EMU_ALL;
+ lconfig.emulation_flags = (XEN_X86_EMU_ALL & ~XEN_X86_EMU_VPCI);
#elif defined (__arm__) || defined(__aarch64__)
lconfig.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE;
lconfig.nr_spis = 0;
--
2.16.2
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH for-4.11] x86/libxc: fix usage of XEN_X86_EMU_ALL after VPCI addition
2018-03-23 10:57 [PATCH for-4.11] x86/libxc: fix usage of XEN_X86_EMU_ALL after VPCI addition Roger Pau Monne
@ 2018-03-23 14:27 ` Wei Liu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Liu @ 2018-03-23 14:27 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: xen-devel, Ian Jackson, Wei Liu
On Fri, Mar 23, 2018 at 10:57:56AM +0000, Roger Pau Monne wrote:
> HVM guest should be created with (XEN_X86_EMU_ALL &
> ~XEN_X86_EMU_VPCI). This is not an issue for xl/libxl because it
> already sets the correct emulation flags and doesn't pass a NULL
> xc_domain_configuration_t to xc_domain_create.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-23 14:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-23 10:57 [PATCH for-4.11] x86/libxc: fix usage of XEN_X86_EMU_ALL after VPCI addition Roger Pau Monne
2018-03-23 14:27 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.