From: Christoph Hellwig <hch@lst.de> To: Al Viro <viro@ZenIV.linux.org.uk> Cc: Christoph Hellwig <hch@lst.de>, Avi Kivity <avi@scylladb.com>, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/28] aio: implement IOCB_CMD_POLL Date: Fri, 23 Mar 2018 19:05:20 +0100 [thread overview] Message-ID: <20180323180520.GA7837@lst.de> (raw) In-Reply-To: <20180322181653.GJ30522@ZenIV.linux.org.uk> On Thu, Mar 22, 2018 at 06:16:53PM +0000, Al Viro wrote: > On Thu, Mar 22, 2018 at 06:24:10PM +0100, Christoph Hellwig wrote: > > > -static void aio_complete(struct aio_kiocb *iocb, long res, long res2) > > +static bool aio_complete(struct aio_kiocb *iocb, long res, long res2, > > + unsigned complete_flags) > > Looks like all callers are following that with "if returned true, > fput(something)". Does it really make any sense to keep that struct > file * in different fields? struct kiocb is used not just for aio, but for our normal read/write_iter APIs, and it is not suitable for poll or fsync. So I can't really find a good way to keep it common except for duplicating it in struct kiocb and strut aio_iocb. But maybe we could pass a struct file argument to aio_complete(). > Wait a sec... What ordering do we want for > * call(s) of ->ki_complete > * call (if any) of ->ki_cancel > * dropping reference to struct file > and what are the expected call chains for all of those? fput must be done exactly once from inside ->ki_complete OR ->ki_cancel in case it did manage to do the actual completion. Reference to struct file isn't needed in aio_complete, but if aio_complete decided who won the race we'll have to put after it (or inside it if we want to make it common)
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Al Viro <viro@ZenIV.linux.org.uk> Cc: Christoph Hellwig <hch@lst.de>, Avi Kivity <avi@scylladb.com>, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/28] aio: implement IOCB_CMD_POLL Date: Fri, 23 Mar 2018 19:05:20 +0100 [thread overview] Message-ID: <20180323180520.GA7837@lst.de> (raw) In-Reply-To: <20180322181653.GJ30522@ZenIV.linux.org.uk> On Thu, Mar 22, 2018 at 06:16:53PM +0000, Al Viro wrote: > On Thu, Mar 22, 2018 at 06:24:10PM +0100, Christoph Hellwig wrote: > > > -static void aio_complete(struct aio_kiocb *iocb, long res, long res2) > > +static bool aio_complete(struct aio_kiocb *iocb, long res, long res2, > > + unsigned complete_flags) > > Looks like all callers are following that with "if returned true, > fput(something)". Does it really make any sense to keep that struct > file * in different fields? struct kiocb is used not just for aio, but for our normal read/write_iter APIs, and it is not suitable for poll or fsync. So I can't really find a good way to keep it common except for duplicating it in struct kiocb and strut aio_iocb. But maybe we could pass a struct file argument to aio_complete(). > Wait a sec... What ordering do we want for > * call(s) of ->ki_complete > * call (if any) of ->ki_cancel > * dropping reference to struct file > and what are the expected call chains for all of those? fput must be done exactly once from inside ->ki_complete OR ->ki_cancel in case it did manage to do the actual completion. Reference to struct file isn't needed in aio_complete, but if aio_complete decided who won the race we'll have to put after it (or inside it if we want to make it common) -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2018-03-23 18:05 UTC|newest] Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-21 7:40 aio poll and a new in-kernel poll API V6 Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 01/28] fs: unexport poll_schedule_timeout Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 9:05 ` Greg KH 2018-03-21 9:05 ` Greg KH 2018-03-21 7:40 ` [PATCH 02/28] fs: cleanup do_pollfd Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 9:06 ` Greg KH 2018-03-21 9:06 ` Greg KH 2018-03-21 7:40 ` [PATCH 03/28] fs: update documentation to mention __poll_t Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 9:06 ` Greg KH 2018-03-21 9:06 ` Greg KH 2018-03-21 16:28 ` Darrick J. Wong 2018-03-21 16:28 ` Darrick J. Wong 2018-03-21 7:40 ` [PATCH 04/28] fs: add new vfs_poll and file_can_poll helpers Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 9:07 ` Greg KH 2018-03-21 9:07 ` Greg KH 2018-03-21 7:40 ` [PATCH 05/28] fs: introduce new ->get_poll_head and ->poll_mask methods Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 9:08 ` Greg KH 2018-03-21 9:08 ` Greg KH 2018-03-21 16:29 ` Darrick J. Wong 2018-03-21 16:29 ` Darrick J. Wong 2018-03-21 7:40 ` [PATCH 06/28] aio: implement IOCB_CMD_POLL Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 9:09 ` Greg KH 2018-03-21 9:09 ` Greg KH 2018-03-21 16:31 ` Darrick J. Wong 2018-03-21 16:31 ` Darrick J. Wong 2018-03-22 16:52 ` Al Viro 2018-03-22 16:52 ` Al Viro 2018-03-22 17:24 ` Christoph Hellwig 2018-03-22 17:24 ` Christoph Hellwig 2018-03-22 18:16 ` Al Viro 2018-03-22 18:16 ` Al Viro 2018-03-23 18:05 ` Christoph Hellwig [this message] 2018-03-23 18:05 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 07/28] net: refactor socket_poll Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 08/28] net: add support for ->poll_mask in proto_ops Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 09/28] net: remove sock_no_poll Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 10/28] net/tcp: convert to ->poll_mask Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 11/28] net/unix: " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 12/28] net: convert datagram_poll users tp ->poll_mask Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 9:11 ` Greg KH 2018-03-21 9:11 ` Greg KH 2018-03-21 7:40 ` [PATCH 13/28] net/dccp: convert to ->poll_mask Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 14/28] net/atm: " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 15/28] net/vmw_vsock: " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 16/28] net/tipc: " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 17/28] net/sctp: " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 18/28] net/bluetooth: " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 19/28] net/caif: " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 20/28] net/nfc: " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 21/28] net/phonet: " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 22/28] net/iucv: " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 23/28] net/rxrpc: " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 24/28] crypto: af_alg: " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 25/28] pipe: " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 26/28] eventfd: switch " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 27/28] timerfd: convert " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 7:40 ` [PATCH 28/28] random: " Christoph Hellwig 2018-03-21 7:40 ` Christoph Hellwig 2018-03-21 9:10 ` Greg KH 2018-03-21 9:10 ` Greg KH 2018-03-22 13:49 ` Theodore Y. Ts'o 2018-03-22 13:49 ` Theodore Y. Ts'o
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180323180520.GA7837@lst.de \ --to=hch@lst.de \ --cc=avi@scylladb.com \ --cc=linux-aio@kvack.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=viro@ZenIV.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.