All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Kumar A S <kumaras@chelsio.com>,
	Nirranjan Kirubaharan <nirranjan@chelsio.com>,
	Indranil Choudhury <indranil@chelsio.com>
Subject: Re: [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates
Date: Tue, 27 Mar 2018 12:31:56 +0530	[thread overview]
Message-ID: <20180327070155.GA17402@chelsio.com> (raw)
In-Reply-To: <af9d1a4f-41fe-7fbf-9348-7a6d71d581cf@intel.com>

On Tuesday, March 03/27/18, 2018 at 02:21:56 +0530, Ferruh Yigit wrote:
> On 3/10/2018 10:48 PM, Rahul Lakkireddy wrote:
> > Patches 1 - 9 add support for cxgbe VF driver.  Patches 10 - 12 fix
> > bugs and convert license in cxgbe files to SPDX License Tag.  Patch
> > 13 adds compile time option to keep outer vlan tag in Q-in-Q packet.
> > 
> > Patch 1 adds minimal cxgbe VF driver.
> 
> Can you please update driver documentation with new supported device?
> 

There is no addition of new devices. The existing supported devices will
be supported for VF PMD as well.

> > 
> > Patch 2 adds firmware mailbox support for VF.
> > 
> > Patch 3 adds base functions to enable VF ports in subsequent patches.
> > 
> > Patch 4 adds cxgbe VF probe to initialize VF devices.
> > 
> > Patch 5 initializes SGE and queues for VF.
> > 
> > Patch 6 enables RSS for VF.
> > 
> > Patch 7 updates TX and RX path for VF.
> > 
> > Patch 8 adds support for VF port statistics.
> > 
> > Patch 9 adds support to set mac address.
> > 
> > Patch 10 fixes bug where the other ports under same PF are not closed
> > properly.
> > 
> > Patch 11 exports RSS hash functions in device info and adds check
> > to prevent configuring unsupported hash functions.
> > 
> > Patch 12 converts all cxgbe files to use SPDX license tag.
> > 
> > Patch 13 adds compile time option to keep outer vlan tag in Q-in-Q
> > packet.
> 
> We are trying to reduce the config options, is it possible to provide this
> functionality with a runtime option (devargs) ?
> 

Thank you for pointing to this. It seems like a good option.

> Or there is already an offload option DEV_RX_OFFLOAD_QINQ_STRIP, I guess this is
> different (is it?), if so does it make sense to have another offload option to
> cover your case?
> 
> 

Yes, this is different. Here, its about stripping or preserving
Outer-VLAN tag from double-vlan in Rx. We have few customers who need
this for their use-case. So, adding another offload option would also
help. Let us know which is preferred - either one, devargs OR another
offload, seems fine.

Thanks,
Rahul

  reply	other threads:[~2018-03-27  7:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-10 22:48 [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 01/13] cxgbe: add skeleton VF driver Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 02/13] cxgbe: add VF firmware mailbox support Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 03/13] cxgbe: add base for enabling VF ports Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 04/13] cxgbe: add probe to initialize VF devices Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 05/13] cxgbe: initialize SGE and queues for VF Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 06/13] cxgbe: enable RSS " Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 07/13] cxgbe: update TX and RX path " Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 08/13] cxgbe: add VF port statistics Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 09/13] cxgbe: add support to set mac address Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 10/13] cxgbe: fix check to close other ports properly Rahul Lakkireddy
2018-03-28 17:24   ` Ferruh Yigit
2018-03-10 22:48 ` [PATCH 11/13] cxgbe: export supported RSS hash functions Rahul Lakkireddy
2018-03-28 17:25   ` Ferruh Yigit
2018-03-10 22:48 ` [PATCH 12/13] cxgbe: convert to SPDX license tags Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 13/13] cxgbe: add option to keep outer VLAN tag in Q-in-Q Rahul Lakkireddy
2018-03-26 20:51 ` [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates Ferruh Yigit
2018-03-27  7:01   ` Rahul Lakkireddy [this message]
2018-03-27 17:26     ` Ferruh Yigit
2018-03-28  7:44       ` Rahul Lakkireddy
2018-03-28  4:49     ` Shahaf Shuler
2018-03-28  7:39       ` Rahul Lakkireddy
2018-03-28  8:30         ` Shahaf Shuler
2018-03-28  9:29           ` Rahul Lakkireddy
2018-03-28 14:06             ` Ferruh Yigit
2018-03-28 17:25 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180327070155.GA17402@chelsio.com \
    --to=rahul.lakkireddy@chelsio.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=indranil@chelsio.com \
    --cc=kumaras@chelsio.com \
    --cc=nirranjan@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.