All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
	Shahaf Shuler <shahafs@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Kumar A S <kumaras@chelsio.com>,
	Nirranjan Kirubaharan <nirranjan@chelsio.com>,
	Indranil Choudhury <indranil@chelsio.com>
Subject: Re: [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates
Date: Wed, 28 Mar 2018 15:06:51 +0100	[thread overview]
Message-ID: <9e5a6116-0c68-956d-2596-3182354cbae1@intel.com> (raw)
In-Reply-To: <20180328092911.GA19730@chelsio.com>

On 3/28/2018 10:29 AM, Rahul Lakkireddy wrote:
> On Wednesday, March 03/28/18, 2018 at 14:00:58 +0530, Shahaf Shuler wrote:
>> Wednesday, March 28, 2018 10:40 AM, Rahul Lakkireddy:
>>> On Wednesday, March 03/28/18, 2018 at 10:19:17 +0530, Shahaf Shuler
>>>>
>>>> What exactly is the offload you try to expose? To strip the inner VLAN while
>>> keeping the outer one?
>>>>
>>>
>>> Sorry about that, I should have provided more details on this earlier.
>>> Chelsio hardware supports below for double-vlans:
>>> 1) Dropping Outer VLAN in hw; inner vlan is stripped and available as packet
>>> metadata.
>>
>> So this is basically the DEV_RX_OFFLOAD_QINQ_STRIP with limitation from your device you cannot return the outer vlan in the packet metadata
>>
> 
> Since this is specific to Chelsio devices, is it better handled by
> devargs approach instead? We will respin this particular patch
> separately.
>  
> Hi Ferruh,
> Should we re-post the entire series minus this particular patch?

No new version required.
I will not merge patch 13/13.
Also expecting an incremental documentation patch to update device information.

> 
>>> 2) Preserving Outer VLAN so, Outer VLAN is stripped and available as packet
>>> metadata. Inner VLAN is available as part of packet itself.
>>
>> And this one is the regular DEV_RX_OFFLOAD_VLAN_STRIP
>>
>>>
>>> So, the configurability here is with respect to Outer VLAN and subsequently
>>> what is available as part of packet metadata (outer or inner vlan).  Inner
>>> VLAN gets retained in both cases.  However, based on how Outer VLAN is
>>> configured, Inner VLAN will be available either as packet metadata or as part
>>> of packet itself.
>>>
>>> We are not very sure if DEV_RX_OFFLOAD_QINQ_STRIP could be used here.
>>> If it holds the same meaning then we will use the same.
>>
>> Yeah , we are missing good documentation of what each offload means. 
>>>
>>> Thanks,
>>> Rahul

  reply	other threads:[~2018-03-28 14:06 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-10 22:48 [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 01/13] cxgbe: add skeleton VF driver Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 02/13] cxgbe: add VF firmware mailbox support Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 03/13] cxgbe: add base for enabling VF ports Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 04/13] cxgbe: add probe to initialize VF devices Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 05/13] cxgbe: initialize SGE and queues for VF Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 06/13] cxgbe: enable RSS " Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 07/13] cxgbe: update TX and RX path " Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 08/13] cxgbe: add VF port statistics Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 09/13] cxgbe: add support to set mac address Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 10/13] cxgbe: fix check to close other ports properly Rahul Lakkireddy
2018-03-28 17:24   ` Ferruh Yigit
2018-03-10 22:48 ` [PATCH 11/13] cxgbe: export supported RSS hash functions Rahul Lakkireddy
2018-03-28 17:25   ` Ferruh Yigit
2018-03-10 22:48 ` [PATCH 12/13] cxgbe: convert to SPDX license tags Rahul Lakkireddy
2018-03-10 22:48 ` [PATCH 13/13] cxgbe: add option to keep outer VLAN tag in Q-in-Q Rahul Lakkireddy
2018-03-26 20:51 ` [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates Ferruh Yigit
2018-03-27  7:01   ` Rahul Lakkireddy
2018-03-27 17:26     ` Ferruh Yigit
2018-03-28  7:44       ` Rahul Lakkireddy
2018-03-28  4:49     ` Shahaf Shuler
2018-03-28  7:39       ` Rahul Lakkireddy
2018-03-28  8:30         ` Shahaf Shuler
2018-03-28  9:29           ` Rahul Lakkireddy
2018-03-28 14:06             ` Ferruh Yigit [this message]
2018-03-28 17:25 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e5a6116-0c68-956d-2596-3182354cbae1@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=indranil@chelsio.com \
    --cc=kumaras@chelsio.com \
    --cc=nirranjan@chelsio.com \
    --cc=rahul.lakkireddy@chelsio.com \
    --cc=shahafs@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.