* [PULL] more gvt-next-fixes for 4.17
@ 2018-03-27 8:39 Zhenyu Wang
2018-03-27 13:42 ` Joonas Lahtinen
0 siblings, 1 reply; 6+ messages in thread
From: Zhenyu Wang @ 2018-03-27 8:39 UTC (permalink / raw)
To: Joonas Lahtinen, Vivi, Rodrigo, Jani Nikula
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
[-- Attachment #1.1: Type: text/plain, Size: 1936 bytes --]
Hi, Joonas
Here's this week's gvt-next-fixes queued for 4.17. One notable change
is to revert previous workaround for gvt context preemption, now it
has full support for preemption now. Others are normal fixes and
optimizations.
Thanks
--
The following changes since commit d8303075699292008ae5b2c8fc728d455b994c26:
drm/i915/gvt: force to set all context control bits from guest (2018-03-19 17:33:30 +0800)
are available in the Git repository at:
https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2018-03-27
for you to fetch changes up to 21e6e1af36a3c9b1c34bc441e5fa27cb36fbb830:
drm/i915/gvt: Dereference msi eventfd_ctx when it isn't used anymore (2018-03-27 11:20:58 +0800)
----------------------------------------------------------------
gvt-next-fixes-2018-03-27
- fix unhandled vfio ioctl return value (Gerd)
- revert gvt ctx preemption workaround, enable preemption
on gvt context! (Weinan)
- no-op user interrupt for vGPU (Zhipeng)
- fix eventfd ctx deference (Xiong)
- misc cleanup
----------------------------------------------------------------
Gerd Hoffmann (1):
drm/i915/gvt: throw error on unhandled vfio ioctls
Gustavo A. R. Silva (1):
drm/i915/gvt: Mark expected switch fall-through in handle_g2v_notification
Weinan Li (1):
Revert "drm/i915/gvt: set max priority for gvt context"
Xiong Zhang (1):
drm/i915/gvt: Dereference msi eventfd_ctx when it isn't used anymore
Zhipeng Gong (1):
drm/i915/gvt: Make MI_USER_INTERRUPT nop in cmd parser
drivers/gpu/drm/i915/gvt/cmd_parser.c | 1 +
drivers/gpu/drm/i915/gvt/handlers.c | 1 +
drivers/gpu/drm/i915/gvt/kvmgt.c | 18 ++++++++++++++++--
drivers/gpu/drm/i915/gvt/scheduler.c | 3 ---
4 files changed, 18 insertions(+), 5 deletions(-)
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PULL] more gvt-next-fixes for 4.17
2018-03-27 8:39 [PULL] more gvt-next-fixes for 4.17 Zhenyu Wang
@ 2018-03-27 13:42 ` Joonas Lahtinen
2018-03-27 14:39 ` Joonas Lahtinen
2018-03-28 2:45 ` Zhenyu Wang
0 siblings, 2 replies; 6+ messages in thread
From: Joonas Lahtinen @ 2018-03-27 13:42 UTC (permalink / raw)
To: Vivi, Rodrigo, Jani Nikula, Zhenyu Wang
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
Quoting Zhenyu Wang (2018-03-27 11:39:42)
>
> Hi, Joonas
>
> Here's this week's gvt-next-fixes queued for 4.17. One notable change
> is to revert previous workaround for gvt context preemption, now it
> has full support for preemption now.
I've pulled the patches, but this revert sounds fishy. Is it something
that should have been done together with a commit in a batch introduced
to 4.17? To me, this sounds much like a feature patch, "enable
pre-emption on GVT context" is even written in the tag.
So I'm inclined to drop this patch from -fixes pull.
Is there some specific reason why you don't use Fixes: tagging to
make it easier to track which patches the fixes apply to, if there are
some?
Regards, Joonas
> Others are normal fixes and
> optimizations.
>
> Thanks
> --
> The following changes since commit d8303075699292008ae5b2c8fc728d455b994c26:
>
> drm/i915/gvt: force to set all context control bits from guest (2018-03-19 17:33:30 +0800)
>
> are available in the Git repository at:
>
> https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2018-03-27
>
> for you to fetch changes up to 21e6e1af36a3c9b1c34bc441e5fa27cb36fbb830:
>
> drm/i915/gvt: Dereference msi eventfd_ctx when it isn't used anymore (2018-03-27 11:20:58 +0800)
>
> ----------------------------------------------------------------
> gvt-next-fixes-2018-03-27
>
> - fix unhandled vfio ioctl return value (Gerd)
> - revert gvt ctx preemption workaround, enable preemption
> on gvt context! (Weinan)
> - no-op user interrupt for vGPU (Zhipeng)
> - fix eventfd ctx deference (Xiong)
> - misc cleanup
>
> ----------------------------------------------------------------
> Gerd Hoffmann (1):
> drm/i915/gvt: throw error on unhandled vfio ioctls
>
> Gustavo A. R. Silva (1):
> drm/i915/gvt: Mark expected switch fall-through in handle_g2v_notification
>
> Weinan Li (1):
> Revert "drm/i915/gvt: set max priority for gvt context"
>
> Xiong Zhang (1):
> drm/i915/gvt: Dereference msi eventfd_ctx when it isn't used anymore
>
> Zhipeng Gong (1):
> drm/i915/gvt: Make MI_USER_INTERRUPT nop in cmd parser
>
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 1 +
> drivers/gpu/drm/i915/gvt/handlers.c | 1 +
> drivers/gpu/drm/i915/gvt/kvmgt.c | 18 ++++++++++++++++--
> drivers/gpu/drm/i915/gvt/scheduler.c | 3 ---
> 4 files changed, 18 insertions(+), 5 deletions(-)
>
>
> --
> Open Source Technology Center, Intel ltd.
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PULL] more gvt-next-fixes for 4.17
2018-03-27 13:42 ` Joonas Lahtinen
@ 2018-03-27 14:39 ` Joonas Lahtinen
2018-03-28 8:26 ` Zhenyu Wang
2018-03-28 2:45 ` Zhenyu Wang
1 sibling, 1 reply; 6+ messages in thread
From: Joonas Lahtinen @ 2018-03-27 14:39 UTC (permalink / raw)
To: Vivi, Rodrigo, Jani Nikula, Zhenyu Wang
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
Quoting Joonas Lahtinen (2018-03-27 16:42:28)
> Quoting Zhenyu Wang (2018-03-27 11:39:42)
> >
> > Hi, Joonas
> >
> > Here's this week's gvt-next-fixes queued for 4.17. One notable change
> > is to revert previous workaround for gvt context preemption, now it
> > has full support for preemption now.
>
> I've pulled the patches, but this revert sounds fishy. Is it something
> that should have been done together with a commit in a batch introduced
> to 4.17? To me, this sounds much like a feature patch, "enable
> pre-emption on GVT context" is even written in the tag.
>
> So I'm inclined to drop this patch from -fixes pull.
On a second thought, I'll drop the whole pull to make it less of a
hassle with rebases. Please send and updated pull with just the fix
patches.
Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PULL] more gvt-next-fixes for 4.17
2018-03-27 14:39 ` Joonas Lahtinen
@ 2018-03-28 8:26 ` Zhenyu Wang
2018-03-30 6:36 ` Zhenyu Wang
0 siblings, 1 reply; 6+ messages in thread
From: Zhenyu Wang @ 2018-03-28 8:26 UTC (permalink / raw)
To: Joonas Lahtinen
Cc: Jani Nikula, intel-gfx, Yuan, Hang, Lv, Zhiyuan, Vivi, Rodrigo,
intel-gvt-dev
[-- Attachment #1.1: Type: text/plain, Size: 3149 bytes --]
On 2018.03.27 17:39:53 +0300, Joonas Lahtinen wrote:
> Quoting Joonas Lahtinen (2018-03-27 16:42:28)
> > Quoting Zhenyu Wang (2018-03-27 11:39:42)
> > >
> > > Hi, Joonas
> > >
> > > Here's this week's gvt-next-fixes queued for 4.17. One notable change
> > > is to revert previous workaround for gvt context preemption, now it
> > > has full support for preemption now.
> >
> > I've pulled the patches, but this revert sounds fishy. Is it something
> > that should have been done together with a commit in a batch introduced
> > to 4.17? To me, this sounds much like a feature patch, "enable
> > pre-emption on GVT context" is even written in the tag.
> >
> > So I'm inclined to drop this patch from -fixes pull.
>
> On a second thought, I'll drop the whole pull to make it less of a
> hassle with rebases. Please send and updated pull with just the fix
> patches.
>
Hi, Joonas
Here's refreshed pull for 4.17 without that revert patch which
also include new fixes for ggtt dma unmap and virtual display.
thanks
--
The following changes since commit d8303075699292008ae5b2c8fc728d455b994c26:
drm/i915/gvt: force to set all context control bits from guest (2018-03-19 17:33:30 +0800)
are available in the Git repository at:
https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2018-03-28
for you to fetch changes up to d35de041470fe08321bd9a7b42483ff653764918:
drm/i915/gvt: Disable primary/sprite/cursor plane at virtual display initialization (2018-03-28 16:15:01 +0800)
----------------------------------------------------------------
gvt-next-fixes-2018-03-28
- fix unhandled vfio ioctl return value (Gerd)
- no-op user interrupt for vGPU (Zhipeng)
- fix eventfd ctx deference (Xiong)
- fix ggtt dma unmap (Changbin)
- fix warning in fb decoder (Xiong)
- misc cleanup
----------------------------------------------------------------
Changbin Du (2):
drm/i915/gvt: Missed to cancel dma map for ggtt entries
drm/i915/gvt: Cancel dma map when resetting ggtt entries
Gerd Hoffmann (1):
drm/i915/gvt: throw error on unhandled vfio ioctls
Gustavo A. R. Silva (1):
drm/i915/gvt: Mark expected switch fall-through in handle_g2v_notification
Xiong Zhang (3):
drm/i915/gvt: Dereference msi eventfd_ctx when it isn't used anymore
drm/i915/gvt: Delete redundant error message in fb_decode.c
drm/i915/gvt: Disable primary/sprite/cursor plane at virtual display initialization
Zhipeng Gong (1):
drm/i915/gvt: Make MI_USER_INTERRUPT nop in cmd parser
drivers/gpu/drm/i915/gvt/cmd_parser.c | 1 +
drivers/gpu/drm/i915/gvt/display.c | 10 +++++++
drivers/gpu/drm/i915/gvt/fb_decoder.c | 27 ++++++------------
drivers/gpu/drm/i915/gvt/gtt.c | 52 ++++++++++++++++++++++++++++++-----
drivers/gpu/drm/i915/gvt/gtt.h | 2 +-
drivers/gpu/drm/i915/gvt/handlers.c | 1 +
drivers/gpu/drm/i915/gvt/kvmgt.c | 18 ++++++++++--
7 files changed, 83 insertions(+), 28 deletions(-)
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PULL] more gvt-next-fixes for 4.17
2018-03-28 8:26 ` Zhenyu Wang
@ 2018-03-30 6:36 ` Zhenyu Wang
0 siblings, 0 replies; 6+ messages in thread
From: Zhenyu Wang @ 2018-03-30 6:36 UTC (permalink / raw)
To: Joonas Lahtinen
Cc: Jani Nikula, intel-gfx, Yuan, Hang, Lv, Zhiyuan, Vivi, Rodrigo,
intel-gvt-dev
[-- Attachment #1.1: Type: text/plain, Size: 2852 bytes --]
On 2018.03.28 16:26:17 +0800, Zhenyu Wang wrote:
>
> Hi, Joonas
>
> Here's refreshed pull for 4.17 without that revert patch which
> also include new fixes for ggtt dma unmap and virtual display.
>
Joonas, pls ignore this one, smoke test pass but seems new issue found
in full test. I'll send you updated one later. Sorry!
> --
> The following changes since commit d8303075699292008ae5b2c8fc728d455b994c26:
>
> drm/i915/gvt: force to set all context control bits from guest (2018-03-19 17:33:30 +0800)
>
> are available in the Git repository at:
>
> https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2018-03-28
>
> for you to fetch changes up to d35de041470fe08321bd9a7b42483ff653764918:
>
> drm/i915/gvt: Disable primary/sprite/cursor plane at virtual display initialization (2018-03-28 16:15:01 +0800)
>
> ----------------------------------------------------------------
> gvt-next-fixes-2018-03-28
>
> - fix unhandled vfio ioctl return value (Gerd)
> - no-op user interrupt for vGPU (Zhipeng)
> - fix eventfd ctx deference (Xiong)
> - fix ggtt dma unmap (Changbin)
> - fix warning in fb decoder (Xiong)
> - misc cleanup
>
> ----------------------------------------------------------------
> Changbin Du (2):
> drm/i915/gvt: Missed to cancel dma map for ggtt entries
> drm/i915/gvt: Cancel dma map when resetting ggtt entries
>
> Gerd Hoffmann (1):
> drm/i915/gvt: throw error on unhandled vfio ioctls
>
> Gustavo A. R. Silva (1):
> drm/i915/gvt: Mark expected switch fall-through in handle_g2v_notification
>
> Xiong Zhang (3):
> drm/i915/gvt: Dereference msi eventfd_ctx when it isn't used anymore
> drm/i915/gvt: Delete redundant error message in fb_decode.c
> drm/i915/gvt: Disable primary/sprite/cursor plane at virtual display initialization
>
> Zhipeng Gong (1):
> drm/i915/gvt: Make MI_USER_INTERRUPT nop in cmd parser
>
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 1 +
> drivers/gpu/drm/i915/gvt/display.c | 10 +++++++
> drivers/gpu/drm/i915/gvt/fb_decoder.c | 27 ++++++------------
> drivers/gpu/drm/i915/gvt/gtt.c | 52 ++++++++++++++++++++++++++++++-----
> drivers/gpu/drm/i915/gvt/gtt.h | 2 +-
> drivers/gpu/drm/i915/gvt/handlers.c | 1 +
> drivers/gpu/drm/i915/gvt/kvmgt.c | 18 ++++++++++--
> 7 files changed, 83 insertions(+), 28 deletions(-)
>
>
> --
> Open Source Technology Center, Intel ltd.
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PULL] more gvt-next-fixes for 4.17
2018-03-27 13:42 ` Joonas Lahtinen
2018-03-27 14:39 ` Joonas Lahtinen
@ 2018-03-28 2:45 ` Zhenyu Wang
1 sibling, 0 replies; 6+ messages in thread
From: Zhenyu Wang @ 2018-03-28 2:45 UTC (permalink / raw)
To: Joonas Lahtinen
Cc: Jani Nikula, intel-gfx, Yuan, Hang, Lv, Zhiyuan, Vivi, Rodrigo,
intel-gvt-dev
[-- Attachment #1.1: Type: text/plain, Size: 1507 bytes --]
On 2018.03.27 16:42:28 +0300, Joonas Lahtinen wrote:
> Quoting Zhenyu Wang (2018-03-27 11:39:42)
> >
> > Hi, Joonas
> >
> > Here's this week's gvt-next-fixes queued for 4.17. One notable change
> > is to revert previous workaround for gvt context preemption, now it
> > has full support for preemption now.
>
> I've pulled the patches, but this revert sounds fishy. Is it something
> that should have been done together with a commit in a batch introduced
> to 4.17? To me, this sounds much like a feature patch, "enable
> pre-emption on GVT context" is even written in the tag.
>
> So I'm inclined to drop this patch from -fixes pull.
>
The dependent fix has already been queued for 4.17 as commit 702791f7f204
("drm/i915: add schedule out notification of preempted but completed request"),
and before we could revert previous workaround, we had a regression issue which
was later resolved, so this revert was delayed for regression verification and
validation. And now it has passed our full testing, so I consider to push it for
4.17 instead of still keeping previous workaround...
> Is there some specific reason why you don't use Fixes: tagging to
> make it easier to track which patches the fixes apply to, if there are
> some?
yeah, sorry, that's missed. Will fix that against workaround commit and re-send
this pull. Will that be fine for you?
thanks
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-30 6:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-27 8:39 [PULL] more gvt-next-fixes for 4.17 Zhenyu Wang
2018-03-27 13:42 ` Joonas Lahtinen
2018-03-27 14:39 ` Joonas Lahtinen
2018-03-28 8:26 ` Zhenyu Wang
2018-03-30 6:36 ` Zhenyu Wang
2018-03-28 2:45 ` Zhenyu Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.