From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org, jeffm@suse.com
Subject: Re: [PATCH 00/14] Qgroup metadata reservation rework
Date: Tue, 27 Mar 2018 17:23:20 +0200 [thread overview]
Message-ID: <20180327152320.GA30422@twin.jikos.cz> (raw)
In-Reply-To: <521fafd5-a927-b68d-8b6d-6c29ca5c34e5@gmx.com>
On Tue, Mar 27, 2018 at 07:49:02AM +0800, Qu Wenruo wrote:
> > Merging plan for this patchset from last week was to postpone until
> > 4.18 due to lack of final testing here. I've tried to run this with
> > quotas enabled an fstests that led to warnings in the power failure
> > simulation tests.
>
> Which test case?
eg shared/298, the log is then flooded by this message
[153085.406444] ------------[ cut here ]------------
[153085.411426] qgroup 5 data reserved space underflow, have 32661504 to free 268435456
[153085.411584] WARNING: CPU: 7 PID: 22475 at fs/btrfs/qgroup.c:102 qgroup_rsv_release+0x1fa/0x210 [btrfs]
[153085.499574] CPU: 7 PID: 22475 Comm: fio Tainted: G W 4.16.0-rc6-1.ge195904-vanilla+ #192
[153085.509186] Hardware name: empty empty/S3993, BIOS PAQEX0-3 02/24/2008
[153085.516008] RIP: 0010:qgroup_rsv_release+0x1fa/0x210 [btrfs]
[153085.521899] RSP: 0018:ffffb1de01bf7c18 EFLAGS: 00010296
[153085.527367] RAX: 0000000000000047 RBX: ffff928ce4950c00 RCX: 0000000000000002
[153085.534799] RDX: 0000000000000007 RSI: 0000000000000001 RDI: 0000000000000202
[153085.542236] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
[153085.549670] R10: 0000000000000000 R11: ffffb1de01bf7aa0 R12: ffff928ce4950c00
[153085.557106] R13: 0000000000000000 R14: 0000000010000000 R15: ffff928c3bb54000
[153085.564545] FS: 00007f90afdc5740(0000) GS:ffff928ce7400000(0000) knlGS:0000000000000000
[153085.572945] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[153085.578925] CR2: 000000000076daa8 CR3: 00000001f86e0000 CR4: 00000000000006e0
[153085.586367] Call Trace:
[153085.589112] btrfs_qgroup_free_refroot+0x174/0x2c0 [btrfs]
[153085.594873] __btrfs_run_delayed_refs+0xb9e/0x17e0 [btrfs]
[153085.600671] btrfs_run_delayed_refs+0x10d/0x1c0 [btrfs]
[153085.606179] btrfs_commit_transaction+0x30/0xad0 [btrfs]
[153085.611782] btrfs_sync_file+0x393/0x4f0 [btrfs]
[153085.616652] do_fsync+0x38/0x60
[153085.620021] SyS_fsync+0xc/0x10
[153085.623402] do_syscall_64+0x71/0x1a0
[153085.627296] entry_SYSCALL_64_after_hwframe+0x42/0xb7
[153085.632590] RIP: 0033:0x7f90af0942cd
[153085.636379] RSP: 002b:00007ffcb59a4c20 EFLAGS: 00000293 ORIG_RAX: 000000000000004a
[153085.644249] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f90af0942cd
[153085.651675] RDX: 0000000000001000 RSI: 00000000013e5960 RDI: 0000000000000004
[153085.659111] RBP: 0000000000000000 R08: 0000000000000008 R09: 9e37fffffffc0001
[153085.666549] R10: 000000000f75e468 R11: 0000000000000293 R12: 0000000000000000
[153085.673985] R13: 0000000006400000 R14: 00007f90968acfb8 R15: 00007f90adad4db0
[153085.700848] ---[ end trace 48a650f3d217fbac ]---
or generic/475
[69595.290236] WARNING: CPU: 1 PID: 3659 at fs/btrfs/extent-tree.c:124 btrfs_put_block_group+0x52/0x60 [btrfs]
[69595.300499] CPU: 1 PID: 3659 Comm: umount Tainted: G W 4.16.0-rc6-1.ge195904-vanilla+ #192
[69595.300502] Hardware name: empty empty/S3993, BIOS PAQEX0-3 02/24/2008
[69595.300555] RIP: 0010:btrfs_put_block_group+0x52/0x60 [btrfs]
[69595.300569] RSP: 0018:ffffb1de02d67dd0 EFLAGS: 00010286
[69595.393015] RAX: 0000000000000001 RBX: ffff928ca4b7dc00 RCX: 0000000000000002
[69595.393018] RDX: ffff928ca4b7ddd8 RSI: 0000000000000001 RDI: ffff928ca4b7dc00
[69595.393024] RBP: ffff928ca4b7dc00 R08: ffff928cd6c70e10 R09: 0000000000000000
[69595.420315] R10: 0000000000000000 R11: ffff928cd6c70e10 R12: ffff928c9c7640d0
[69595.420318] R13: ffff928c9c764000 R14: ffff928c9c764120 R15: 0000000000000000
[69595.420322] FS: 00007ff5e66a2840(0000) GS:ffff928ce6800000(0000) knlGS:0000000000000000
[69595.420328] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[69595.449136] CR2: 00007efdd6e6b594 CR3: 0000000211943000 CR4: 00000000000006e0
[69595.449140] Call Trace:
[69595.449207] btrfs_free_block_groups+0x164/0x420 [btrfs]
[69595.464610] close_ctree+0x127/0x2f0 [btrfs]
[69595.469046] generic_shutdown_super+0x69/0x110
[69595.469054] kill_anon_super+0xe/0x20
[69595.469102] btrfs_kill_super+0x13/0x100 [btrfs]
[69595.469114] deactivate_locked_super+0x39/0x70
[69595.469122] cleanup_mnt+0x3b/0x70
[69595.469128] task_work_run+0x80/0xb0
[69595.469139] exit_to_usermode_loop+0x71/0xa0
[69595.469148] do_syscall_64+0x157/0x1a0
[69595.469158] entry_SYSCALL_64_after_hwframe+0x42/0xb7
[69595.469164] RIP: 0033:0x7ff5e5f99d37
[69595.469167] RSP: 002b:00007ffeb054adf8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6
[69595.469172] RAX: 0000000000000000 RBX: 0000563360af5060 RCX: 00007ff5e5f99d37
[69595.469175] RDX: 0000000000000001 RSI: 0000000000000000 RDI: 0000563360af52c0
[69595.469178] RBP: 0000563360af52c0 R08: 00007ff5e628b97d R09: 0000000000000005
[69595.469181] R10: 0000563360af5280 R11: 0000000000000246 R12: 00007ff5e649a1a4
[69595.469183] R13: 0000000000000000 R14: 0000000000000000 R15: 00000000ffffffff
[69595.469339] ---[ end trace 48a650f3d217fba6 ]---
[69595.530603] WARNING: CPU: 1 PID: 3659 at fs/btrfs/extent-tree.c:9945 btrfs_free_block_groups+0x2cb/0x420 [btrfs]
[69595.590550] CPU: 1 PID: 3659 Comm: umount Tainted: G W 4.16.0-rc6-1.ge195904-vanilla+ #192
[69595.590552] Hardware name: empty empty/S3993, BIOS PAQEX0-3 02/24/2008
[69595.590594] RIP: 0010:btrfs_free_block_groups+0x2cb/0x420 [btrfs]
[69595.590614] RSP: 0018:ffffb1de02d67de0 EFLAGS: 00010286
[69595.683331] RAX: ffff928cb96e2908 RBX: 0000000000000000 RCX: 0000000000000002
[69595.683334] RDX: 0000000000000001 RSI: 0000000000000001 RDI: ffff928cb96e0800
[69595.683339] RBP: ffff928cb96e7c00 R08: 0000000000000000 R09: 0000000000000000
[69595.710642] R10: 0000000000000000 R11: 0000000000000002 R12: ffff928cb96e2800
[69595.710645] R13: ffff928c9c764000 R14: ffff928cb96e2908 R15: ffff928c9c766b50
[69595.710649] FS: 00007ff5e66a2840(0000) GS:ffff928ce6800000(0000) knlGS:0000000000000000
[69595.710654] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[69595.739454] CR2: 00007efdd6e6b594 CR3: 0000000211943000 CR4: 00000000000006e0
[69595.739457] Call Trace:
[69595.739524] close_ctree+0x127/0x2f0 [btrfs]
[69595.753856] generic_shutdown_super+0x69/0x110
[69595.753864] kill_anon_super+0xe/0x20
[69595.753902] btrfs_kill_super+0x13/0x100 [btrfs]
[69595.753912] deactivate_locked_super+0x39/0x70
[69595.771747] cleanup_mnt+0x3b/0x70
[69595.771755] task_work_run+0x80/0xb0
[69595.779135] exit_to_usermode_loop+0x71/0xa0
[69595.779144] do_syscall_64+0x157/0x1a0
[69595.787566] entry_SYSCALL_64_after_hwframe+0x42/0xb7
[69595.787572] RIP: 0033:0x7ff5e5f99d37
[69595.796590] RSP: 002b:00007ffeb054adf8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6
[69595.796596] RAX: 0000000000000000 RBX: 0000563360af5060 RCX: 00007ff5e5f99d37
[69595.796599] RDX: 0000000000000001 RSI: 0000000000000000 RDI: 0000563360af52c0
[69595.796602] RBP: 0000563360af52c0 R08: 00007ff5e628b97d R09: 0000000000000005
[69595.796605] R10: 0000563360af5280 R11: 0000000000000246 R12: 00007ff5e649a1a4
[69595.796608] R13: 0000000000000000 R14: 0000000000000000 R15: 00000000ffffffff
[69595.840989] ---[ end trace 48a650f3d217fba7 ]---
[69595.841079] BTRFS info (device dm-0): space_info 1 has 725651456 free, is not full
[69595.874673] BTRFS info (device dm-0): space_info total=2155872256, used=1430224896, pinned=0, reserved=18446744073709547520, may_use=0, readonly=0
next prev parent reply other threads:[~2018-03-27 15:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 7:34 [PATCH 00/14] Qgroup metadata reservation rework Qu Wenruo
2017-12-12 7:34 ` [PATCH 01/14] btrfs: qgroup: Skeleton to support separate qgroup reservation type Qu Wenruo
2017-12-12 7:34 ` [PATCH 02/14] btrfs: qgroup: Introduce helpers to update and access new qgroup rsv Qu Wenruo
2017-12-21 15:23 ` Nikolay Borisov
2017-12-12 7:34 ` [PATCH 03/14] btrfs: qgroup: Make qgroup_reserve and its callers to use separate reservation type Qu Wenruo
2017-12-12 7:34 ` [PATCH 04/14] btrfs: qgroup: Fix wrong qgroup reservation update for relationship modification Qu Wenruo
2017-12-12 7:34 ` [PATCH 05/14] btrfs: qgroup: Update trace events to use new separate rsv types Qu Wenruo
2017-12-12 7:34 ` [PATCH 06/14] btrfs: qgroup: Cleanup the remaining old reservation counters Qu Wenruo
2017-12-12 7:34 ` [PATCH 07/14] btrfs: qgroup: Split meta rsv type into meta_prealloc and meta_pertrans Qu Wenruo
2017-12-12 7:34 ` [PATCH 08/14] btrfs: qgroup: Don't use root->qgroup_meta_rsv for qgroup Qu Wenruo
2017-12-12 7:34 ` [PATCH 09/14] btrfs: qgroup: Introduce function to convert META_PREALLOC into META_PERTRANS Qu Wenruo
2017-12-12 7:34 ` [PATCH 10/14] btrfs: qgroup: Use separate meta reservation type for delalloc Qu Wenruo
2017-12-12 7:34 ` [PATCH 11/14] btrfs: delayed-inode: Use new qgroup meta rsv for delayed inode and item Qu Wenruo
2017-12-12 7:34 ` [PATCH 12/14] btrfs: qgroup: Use root->qgroup_meta_rsv_* to record qgroup meta reserved space Qu Wenruo
2017-12-12 7:34 ` [PATCH 13/14] btrfs: qgroup: Update trace events for metadata reservation Qu Wenruo
2017-12-12 7:34 ` [PATCH 14/14] Revert "btrfs: qgroups: Retry after commit on getting EDQUOT" Qu Wenruo
2017-12-12 14:16 ` [PATCH 00/14] Qgroup metadata reservation rework Nikolay Borisov
2017-12-12 18:01 ` David Sterba
2017-12-13 0:54 ` Qu Wenruo
2017-12-12 21:12 ` David Sterba
2017-12-13 0:55 ` Qu Wenruo
2018-03-26 14:10 ` David Sterba
2018-03-26 23:49 ` Qu Wenruo
2018-03-27 15:23 ` David Sterba [this message]
2018-03-27 18:00 ` Filipe Manana
2018-03-27 16:30 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327152320.GA30422@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.