From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org, jeffm@suse.com
Subject: Re: [PATCH 00/14] Qgroup metadata reservation rework
Date: Tue, 27 Mar 2018 07:49:02 +0800 [thread overview]
Message-ID: <521fafd5-a927-b68d-8b6d-6c29ca5c34e5@gmx.com> (raw)
In-Reply-To: <20180326141008.GO6955@twin.jikos.cz>
[-- Attachment #1.1: Type: text/plain, Size: 2141 bytes --]
On 2018年03月26日 22:10, David Sterba wrote:
> On Wed, Dec 13, 2017 at 08:55:21AM +0800, Qu Wenruo wrote:
>> On 2017年12月13日 05:12, David Sterba wrote:
>>> On Tue, Dec 12, 2017 at 03:34:22PM +0800, Qu Wenruo wrote:
>>>> The patch is consist of 2 main parts:
>>>> 1) Type based qgroup reservation
>>>> The original patchset is sent several months ago.
>>>> Nothing is modified at all, just rebased. And not conflict at all.
>>>>
>>>> It's from patch 1 to patch 6.
>>>>
>>>> 2) Split meta qgroup reservation into per-trans and prealloc sub types
>>>> The real work to address metadata underflow.
>>>> Due to the over-reserve problem, this part is still in RFC state.
>>>> But the framework should mostly be fine, only needs extra fine-tuning
>>>> to get more accurate qgroup rsv to avoid too early limit.
>>>>
>>>> It's from patch 7 to 14.
>>>
>>> I'm going to add the whole patchset to next, the first part has been
>>> there for some time and no test failures were reported. I optimistically
>>> expect that the second part will also be fine.
>>
>> The type based reservation is completely fine, since it doesn't
>> introduce anything new, just a preparation for the incoming meta rework.
>>
>> However I prefer not to push the whole patchset to upstream until
>> over-reserve behavior is solved.
>> Since it breaks quite some test cases with small limit.
>
> Merging plan for this patchset from last week was to postpone until
> 4.18 due to lack of final testing here. I've tried to run this with
> quotas enabled an fstests that led to warnings in the power failure
> simulation tests.
Which test case?
>
> As there's going to be one more rc, this gives us one more week to
> decide if its' ok-ish to merge this patch and fix the fallouts during
> the normal cycle.
>
> Given that this patchset has been in for-next for a long time, I'd do
> the merge now and focus on testing for that patchset as the rest of
> devel patches looks good.
>
> Please let me know if you have objections.
I'm completely fine with the decision.
Thanks,
Qu
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-03-26 23:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 7:34 [PATCH 00/14] Qgroup metadata reservation rework Qu Wenruo
2017-12-12 7:34 ` [PATCH 01/14] btrfs: qgroup: Skeleton to support separate qgroup reservation type Qu Wenruo
2017-12-12 7:34 ` [PATCH 02/14] btrfs: qgroup: Introduce helpers to update and access new qgroup rsv Qu Wenruo
2017-12-21 15:23 ` Nikolay Borisov
2017-12-12 7:34 ` [PATCH 03/14] btrfs: qgroup: Make qgroup_reserve and its callers to use separate reservation type Qu Wenruo
2017-12-12 7:34 ` [PATCH 04/14] btrfs: qgroup: Fix wrong qgroup reservation update for relationship modification Qu Wenruo
2017-12-12 7:34 ` [PATCH 05/14] btrfs: qgroup: Update trace events to use new separate rsv types Qu Wenruo
2017-12-12 7:34 ` [PATCH 06/14] btrfs: qgroup: Cleanup the remaining old reservation counters Qu Wenruo
2017-12-12 7:34 ` [PATCH 07/14] btrfs: qgroup: Split meta rsv type into meta_prealloc and meta_pertrans Qu Wenruo
2017-12-12 7:34 ` [PATCH 08/14] btrfs: qgroup: Don't use root->qgroup_meta_rsv for qgroup Qu Wenruo
2017-12-12 7:34 ` [PATCH 09/14] btrfs: qgroup: Introduce function to convert META_PREALLOC into META_PERTRANS Qu Wenruo
2017-12-12 7:34 ` [PATCH 10/14] btrfs: qgroup: Use separate meta reservation type for delalloc Qu Wenruo
2017-12-12 7:34 ` [PATCH 11/14] btrfs: delayed-inode: Use new qgroup meta rsv for delayed inode and item Qu Wenruo
2017-12-12 7:34 ` [PATCH 12/14] btrfs: qgroup: Use root->qgroup_meta_rsv_* to record qgroup meta reserved space Qu Wenruo
2017-12-12 7:34 ` [PATCH 13/14] btrfs: qgroup: Update trace events for metadata reservation Qu Wenruo
2017-12-12 7:34 ` [PATCH 14/14] Revert "btrfs: qgroups: Retry after commit on getting EDQUOT" Qu Wenruo
2017-12-12 14:16 ` [PATCH 00/14] Qgroup metadata reservation rework Nikolay Borisov
2017-12-12 18:01 ` David Sterba
2017-12-13 0:54 ` Qu Wenruo
2017-12-12 21:12 ` David Sterba
2017-12-13 0:55 ` Qu Wenruo
2018-03-26 14:10 ` David Sterba
2018-03-26 23:49 ` Qu Wenruo [this message]
2018-03-27 15:23 ` David Sterba
2018-03-27 18:00 ` Filipe Manana
2018-03-27 16:30 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521fafd5-a927-b68d-8b6d-6c29ca5c34e5@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.cz \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.