* [PATCH igt] igt/perf_pmu: Most-busy requires at least one busy engine
@ 2018-03-27 8:37 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2018-03-27 8:37 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
The test is whether with all but one engine busy we record the correct
load on each engine. If we only have one engine, this test degenerates
into all-idle/all-busy, so we can skip to avoid crashing on the
assumption that we have a busy spinner.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tests/perf_pmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index f27b7ec7..b59af818 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -513,6 +513,7 @@ most_busy_check_all(int gem_fd, const struct intel_execution_engine2 *e,
val[i++] = I915_PMU_ENGINE_BUSY(e_->class, e_->instance);
}
igt_assert(i == num_engines);
+ igt_require(spin); /* at least one busy engine */
fd[0] = -1;
for (i = 0; i < num_engines; i++)
--
2.16.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH igt] igt/perf_pmu: Most-busy requires at least one busy engine
@ 2018-03-27 8:37 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2018-03-27 8:37 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
The test is whether with all but one engine busy we record the correct
load on each engine. If we only have one engine, this test degenerates
into all-idle/all-busy, so we can skip to avoid crashing on the
assumption that we have a busy spinner.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tests/perf_pmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index f27b7ec7..b59af818 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -513,6 +513,7 @@ most_busy_check_all(int gem_fd, const struct intel_execution_engine2 *e,
val[i++] = I915_PMU_ENGINE_BUSY(e_->class, e_->instance);
}
igt_assert(i == num_engines);
+ igt_require(spin); /* at least one busy engine */
fd[0] = -1;
for (i = 0; i < num_engines; i++)
--
2.16.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH igt] igt/perf_pmu: Most-busy requires at least one busy engine
2018-03-27 8:37 ` [Intel-gfx] " Chris Wilson
@ 2018-03-27 8:54 ` Tvrtko Ursulin
-1 siblings, 0 replies; 8+ messages in thread
From: Tvrtko Ursulin @ 2018-03-27 8:54 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
On 27/03/2018 09:37, Chris Wilson wrote:
> The test is whether with all but one engine busy we record the correct
> load on each engine. If we only have one engine, this test degenerates
> into all-idle/all-busy, so we can skip to avoid crashing on the
> assumption that we have a busy spinner.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> tests/perf_pmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> index f27b7ec7..b59af818 100644
> --- a/tests/perf_pmu.c
> +++ b/tests/perf_pmu.c
> @@ -513,6 +513,7 @@ most_busy_check_all(int gem_fd, const struct intel_execution_engine2 *e,
> val[i++] = I915_PMU_ENGINE_BUSY(e_->class, e_->instance);
> }
> igt_assert(i == num_engines);
> + igt_require(spin); /* at least one busy engine */
Or igt_require(num_engines > 1) higher up. But same effect:
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
>
> fd[0] = -1;
> for (i = 0; i < num_engines; i++)
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH igt] igt/perf_pmu: Most-busy requires at least one busy engine
@ 2018-03-27 8:54 ` Tvrtko Ursulin
0 siblings, 0 replies; 8+ messages in thread
From: Tvrtko Ursulin @ 2018-03-27 8:54 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
On 27/03/2018 09:37, Chris Wilson wrote:
> The test is whether with all but one engine busy we record the correct
> load on each engine. If we only have one engine, this test degenerates
> into all-idle/all-busy, so we can skip to avoid crashing on the
> assumption that we have a busy spinner.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> tests/perf_pmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> index f27b7ec7..b59af818 100644
> --- a/tests/perf_pmu.c
> +++ b/tests/perf_pmu.c
> @@ -513,6 +513,7 @@ most_busy_check_all(int gem_fd, const struct intel_execution_engine2 *e,
> val[i++] = I915_PMU_ENGINE_BUSY(e_->class, e_->instance);
> }
> igt_assert(i == num_engines);
> + igt_require(spin); /* at least one busy engine */
Or igt_require(num_engines > 1) higher up. But same effect:
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
>
> fd[0] = -1;
> for (i = 0; i < num_engines; i++)
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH igt] igt/perf_pmu: Most-busy requires at least one busy engine
2018-03-27 8:54 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin
@ 2018-03-27 8:55 ` Chris Wilson
-1 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2018-03-27 8:55 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx; +Cc: igt-dev
Quoting Tvrtko Ursulin (2018-03-27 09:54:35)
>
> On 27/03/2018 09:37, Chris Wilson wrote:
> > The test is whether with all but one engine busy we record the correct
> > load on each engine. If we only have one engine, this test degenerates
> > into all-idle/all-busy, so we can skip to avoid crashing on the
> > assumption that we have a busy spinner.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> > tests/perf_pmu.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> > index f27b7ec7..b59af818 100644
> > --- a/tests/perf_pmu.c
> > +++ b/tests/perf_pmu.c
> > @@ -513,6 +513,7 @@ most_busy_check_all(int gem_fd, const struct intel_execution_engine2 *e,
> > val[i++] = I915_PMU_ENGINE_BUSY(e_->class, e_->instance);
> > }
> > igt_assert(i == num_engines);
> > + igt_require(spin); /* at least one busy engine */
>
> Or igt_require(num_engines > 1) higher up. But same effect:
I'm happy for both, if you want a preemptive r-b :)
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH igt] igt/perf_pmu: Most-busy requires at least one busy engine
@ 2018-03-27 8:55 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2018-03-27 8:55 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx; +Cc: igt-dev
Quoting Tvrtko Ursulin (2018-03-27 09:54:35)
>
> On 27/03/2018 09:37, Chris Wilson wrote:
> > The test is whether with all but one engine busy we record the correct
> > load on each engine. If we only have one engine, this test degenerates
> > into all-idle/all-busy, so we can skip to avoid crashing on the
> > assumption that we have a busy spinner.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> > tests/perf_pmu.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> > index f27b7ec7..b59af818 100644
> > --- a/tests/perf_pmu.c
> > +++ b/tests/perf_pmu.c
> > @@ -513,6 +513,7 @@ most_busy_check_all(int gem_fd, const struct intel_execution_engine2 *e,
> > val[i++] = I915_PMU_ENGINE_BUSY(e_->class, e_->instance);
> > }
> > igt_assert(i == num_engines);
> > + igt_require(spin); /* at least one busy engine */
>
> Or igt_require(num_engines > 1) higher up. But same effect:
I'm happy for both, if you want a preemptive r-b :)
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for igt/perf_pmu: Most-busy requires at least one busy engine
2018-03-27 8:37 ` [Intel-gfx] " Chris Wilson
(?)
(?)
@ 2018-03-27 15:36 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-03-27 15:36 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/perf_pmu: Most-busy requires at least one busy engine
URL : https://patchwork.freedesktop.org/series/40720/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
a9741da52ad1963f7632ef1e852cbe1c3bcc601e tests/perf_pmu: Improve accuracy by waiting on spinner to start
with latest DRM-Tip kernel build CI_DRM_3989
ff7820832182 drm-tip: 2018y-03m-27d-14h-31m-00s UTC integration manifest
No testlist changes.
---- Known issues:
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-cnl-y3) fdo#104951
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:437s
fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:443s
fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:387s
fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:541s
fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:300s
fi-bxt-dsi total:285 pass:255 dwarn:0 dfail:0 fail:0 skip:30 time:520s
fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:516s
fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:528s
fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:515s
fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:414s
fi-cfl-s3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:568s
fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:514s
fi-cnl-y3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:588s
fi-elk-e7500 total:285 pass:225 dwarn:1 dfail:0 fail:0 skip:59 time:431s
fi-gdg-551 total:285 pass:176 dwarn:0 dfail:0 fail:1 skip:108 time:324s
fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:542s
fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:418s
fi-ilk-650 total:285 pass:225 dwarn:0 dfail:0 fail:0 skip:60 time:423s
fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:465s
fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:431s
fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:480s
fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:468s
fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:514s
fi-pnv-d510 total:285 pass:219 dwarn:1 dfail:0 fail:0 skip:65 time:662s
fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:444s
fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:533s
fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:506s
fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:499s
fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:430s
fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:449s
fi-snb-2520m total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:584s
fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:415s
Blacklisted hosts:
fi-cnl-psr total:285 pass:256 dwarn:3 dfail:0 fail:0 skip:26 time:531s
fi-glk-j4005 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:488s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1194/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for igt/perf_pmu: Most-busy requires at least one busy engine
2018-03-27 8:37 ` [Intel-gfx] " Chris Wilson
` (2 preceding siblings ...)
(?)
@ 2018-03-27 20:48 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-03-27 20:48 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/perf_pmu: Most-busy requires at least one busy engine
URL : https://patchwork.freedesktop.org/series/40720/
State : success
== Summary ==
---- Known issues:
Test kms_cursor_legacy:
Subgroup flip-vs-cursor-atomic:
fail -> PASS (shard-hsw) fdo#102670
Test kms_flip:
Subgroup 2x-flip-vs-expired-vblank-interruptible:
pass -> FAIL (shard-hsw) fdo#102887
Subgroup 2x-flip-vs-wf_vblank:
fail -> PASS (shard-hsw) fdo#100368
Test kms_rotation_crc:
Subgroup primary-rotation-180:
fail -> PASS (shard-snb) fdo#103925
Test kms_sysfs_edid_timing:
pass -> WARN (shard-apl) fdo#100047
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
shard-apl total:3495 pass:1831 dwarn:1 dfail:0 fail:7 skip:1655 time:12964s
shard-hsw total:3495 pass:1782 dwarn:1 dfail:0 fail:2 skip:1709 time:11605s
shard-snb total:3495 pass:1375 dwarn:1 dfail:0 fail:2 skip:2117 time:6952s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1194/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-03-27 20:48 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-27 8:37 [PATCH igt] igt/perf_pmu: Most-busy requires at least one busy engine Chris Wilson
2018-03-27 8:37 ` [Intel-gfx] " Chris Wilson
2018-03-27 8:54 ` Tvrtko Ursulin
2018-03-27 8:54 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin
2018-03-27 8:55 ` Chris Wilson
2018-03-27 8:55 ` [igt-dev] [Intel-gfx] " Chris Wilson
2018-03-27 15:36 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-03-27 20:48 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.