* [PATCH dtc] checks: Print duplicate node name instead of parent name
@ 2018-03-27 12:13 Geert Uytterhoeven
2018-03-27 23:13 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2018-03-27 12:13 UTC (permalink / raw)
To: David Gibson, Jon Loeliger
Cc: devicetree-compiler, Rob Herring, Frank Rowand, devicetree,
Geert Uytterhoeven
When refactoring node path printing, the code checking for duplicate
node names was accidentally changed to print the name of the parent
node, instead of the name of the duplicated child node.
Fixes: 88960e3989073207 ("checks: centralize printing of node path in check_msg")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Also applies to Linux' scripts/dtc/checks.c.
---
checks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/checks.c b/checks.c
index 1e6a88c81a998415..e6a38a87cc7d9aac 100644
--- a/checks.c
+++ b/checks.c
@@ -255,7 +255,7 @@ static void check_duplicate_node_names(struct check *c, struct dt_info *dti,
child2;
child2 = child2->next_sibling)
if (streq(child->name, child2->name))
- FAIL(c, dti, node, "Duplicate node name");
+ FAIL(c, dti, child2, "Duplicate node name");
}
ERROR(duplicate_node_names, check_duplicate_node_names, NULL);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH dtc] checks: Print duplicate node name instead of parent name
2018-03-27 12:13 [PATCH dtc] checks: Print duplicate node name instead of parent name Geert Uytterhoeven
@ 2018-03-27 23:13 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2018-03-27 23:13 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Jon Loeliger, devicetree-compiler, Rob Herring, Frank Rowand, devicetree
[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]
On Tue, Mar 27, 2018 at 02:13:31PM +0200, Geert Uytterhoeven wrote:
> When refactoring node path printing, the code checking for duplicate
> node names was accidentally changed to print the name of the parent
> node, instead of the name of the duplicated child node.
>
> Fixes: 88960e3989073207 ("checks: centralize printing of node path in check_msg")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied, thanks.
> ---
> Also applies to Linux' scripts/dtc/checks.c.
> ---
> checks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/checks.c b/checks.c
> index 1e6a88c81a998415..e6a38a87cc7d9aac 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -255,7 +255,7 @@ static void check_duplicate_node_names(struct check *c, struct dt_info *dti,
> child2;
> child2 = child2->next_sibling)
> if (streq(child->name, child2->name))
> - FAIL(c, dti, node, "Duplicate node name");
> + FAIL(c, dti, child2, "Duplicate node name");
> }
> ERROR(duplicate_node_names, check_duplicate_node_names, NULL);
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-27 23:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-27 12:13 [PATCH dtc] checks: Print duplicate node name instead of parent name Geert Uytterhoeven
2018-03-27 23:13 ` David Gibson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.