* [PATCH] nvme: unexport nvme_start_keep_alive
@ 2018-03-26 8:40 ` Johannes Thumshirn
0 siblings, 0 replies; 6+ messages in thread
From: Johannes Thumshirn @ 2018-03-26 8:40 UTC (permalink / raw)
To: Keith Busch, Christoph Hellwig, Sagi Grimberg
Cc: Linux Kernel Mailinglist, Linux NVMe Mailinglist, Johannes Thumshirn
nvme_start_keep_alive() isn't used outside core.c so unexport it and
make it static.
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
---
drivers/nvme/host/core.c | 3 +--
drivers/nvme/host/nvme.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 7aeca5db7916..884061c7ebee 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -828,7 +828,7 @@ static void nvme_keep_alive_work(struct work_struct *work)
}
}
-void nvme_start_keep_alive(struct nvme_ctrl *ctrl)
+static void nvme_start_keep_alive(struct nvme_ctrl *ctrl)
{
if (unlikely(ctrl->kato == 0))
return;
@@ -838,7 +838,6 @@ void nvme_start_keep_alive(struct nvme_ctrl *ctrl)
ctrl->ka_cmd.common.opcode = nvme_admin_keep_alive;
schedule_delayed_work(&ctrl->ka_work, ctrl->kato * HZ);
}
-EXPORT_SYMBOL_GPL(nvme_start_keep_alive);
void nvme_stop_keep_alive(struct nvme_ctrl *ctrl)
{
diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index d733b14ede9d..7915d6d3fc3f 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -394,7 +394,6 @@ int __nvme_submit_sync_cmd(struct request_queue *q, struct nvme_command *cmd,
unsigned timeout, int qid, int at_head,
blk_mq_req_flags_t flags);
int nvme_set_queue_count(struct nvme_ctrl *ctrl, int *count);
-void nvme_start_keep_alive(struct nvme_ctrl *ctrl);
void nvme_stop_keep_alive(struct nvme_ctrl *ctrl);
int nvme_reset_ctrl(struct nvme_ctrl *ctrl);
int nvme_reset_ctrl_sync(struct nvme_ctrl *ctrl);
--
2.16.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] nvme: unexport nvme_start_keep_alive
@ 2018-03-26 8:40 ` Johannes Thumshirn
0 siblings, 0 replies; 6+ messages in thread
From: Johannes Thumshirn @ 2018-03-26 8:40 UTC (permalink / raw)
nvme_start_keep_alive() isn't used outside core.c so unexport it and
make it static.
Signed-off-by: Johannes Thumshirn <jthumshirn at suse.de>
---
drivers/nvme/host/core.c | 3 +--
drivers/nvme/host/nvme.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 7aeca5db7916..884061c7ebee 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -828,7 +828,7 @@ static void nvme_keep_alive_work(struct work_struct *work)
}
}
-void nvme_start_keep_alive(struct nvme_ctrl *ctrl)
+static void nvme_start_keep_alive(struct nvme_ctrl *ctrl)
{
if (unlikely(ctrl->kato == 0))
return;
@@ -838,7 +838,6 @@ void nvme_start_keep_alive(struct nvme_ctrl *ctrl)
ctrl->ka_cmd.common.opcode = nvme_admin_keep_alive;
schedule_delayed_work(&ctrl->ka_work, ctrl->kato * HZ);
}
-EXPORT_SYMBOL_GPL(nvme_start_keep_alive);
void nvme_stop_keep_alive(struct nvme_ctrl *ctrl)
{
diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index d733b14ede9d..7915d6d3fc3f 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -394,7 +394,6 @@ int __nvme_submit_sync_cmd(struct request_queue *q, struct nvme_command *cmd,
unsigned timeout, int qid, int at_head,
blk_mq_req_flags_t flags);
int nvme_set_queue_count(struct nvme_ctrl *ctrl, int *count);
-void nvme_start_keep_alive(struct nvme_ctrl *ctrl);
void nvme_stop_keep_alive(struct nvme_ctrl *ctrl);
int nvme_reset_ctrl(struct nvme_ctrl *ctrl);
int nvme_reset_ctrl_sync(struct nvme_ctrl *ctrl);
--
2.16.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme: unexport nvme_start_keep_alive
2018-03-26 8:40 ` Johannes Thumshirn
@ 2018-03-28 8:07 ` Christoph Hellwig
-1 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2018-03-28 8:07 UTC (permalink / raw)
To: Johannes Thumshirn
Cc: Keith Busch, Christoph Hellwig, Sagi Grimberg,
Linux Kernel Mailinglist, Linux NVMe Mailinglist
On Mon, Mar 26, 2018 at 10:40:15AM +0200, Johannes Thumshirn wrote:
> nvme_start_keep_alive() isn't used outside core.c so unexport it and
> make it static.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] nvme: unexport nvme_start_keep_alive
@ 2018-03-28 8:07 ` Christoph Hellwig
0 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2018-03-28 8:07 UTC (permalink / raw)
On Mon, Mar 26, 2018@10:40:15AM +0200, Johannes Thumshirn wrote:
> nvme_start_keep_alive() isn't used outside core.c so unexport it and
> make it static.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn at suse.de>
Looks good:
Reviewed-by: Christoph Hellwig <hch at lst.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme: unexport nvme_start_keep_alive
2018-03-28 8:07 ` Christoph Hellwig
@ 2018-03-28 15:07 ` Keith Busch
-1 siblings, 0 replies; 6+ messages in thread
From: Keith Busch @ 2018-03-28 15:07 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Johannes Thumshirn, Sagi Grimberg, Linux Kernel Mailinglist,
Linux NVMe Mailinglist
Thanks, applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] nvme: unexport nvme_start_keep_alive
@ 2018-03-28 15:07 ` Keith Busch
0 siblings, 0 replies; 6+ messages in thread
From: Keith Busch @ 2018-03-28 15:07 UTC (permalink / raw)
Thanks, applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-28 15:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-26 8:40 [PATCH] nvme: unexport nvme_start_keep_alive Johannes Thumshirn
2018-03-26 8:40 ` Johannes Thumshirn
2018-03-28 8:07 ` Christoph Hellwig
2018-03-28 8:07 ` Christoph Hellwig
2018-03-28 15:07 ` Keith Busch
2018-03-28 15:07 ` Keith Busch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.