* [igt-dev] [PATCH i-g-t] lib/igt_kms: Improve connector probing in igt_display_init()
@ 2018-03-26 10:40 Maarten Lankhorst
2018-03-26 11:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 1 reply; 11+ messages in thread
From: Maarten Lankhorst @ 2018-03-26 10:40 UTC (permalink / raw)
To: igt-dev
Only do a full probe when the initial connector status is unknown, and
otherwise skip it. This should speed up kms tests ever so slightly.
Also set pipe to PIPE_NONE for igt_output_refresh(), to make the
connector info slightly more accurate.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
lib/igt_kms.c | 17 +++++++++++++----
lib/igt_kms.h | 2 +-
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index d8f69d3db9ca..44f6ae977092 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -974,7 +974,7 @@ _kmstest_connector_config_find_encoder(int drm_fd, drmModeConnector *connector,
static bool _kmstest_connector_config(int drm_fd, uint32_t connector_id,
unsigned long crtc_idx_mask,
struct kmstest_connector_config *config,
- bool probe)
+ int probe)
{
drmModeRes *resources;
drmModeConnector *connector;
@@ -988,11 +988,19 @@ static bool _kmstest_connector_config(int drm_fd, uint32_t connector_id,
}
/* First, find the connector & mode */
- if (probe)
+ if (probe > 0)
connector = drmModeGetConnector(drm_fd, connector_id);
- else
+ else {
connector = drmModeGetConnectorCurrent(drm_fd, connector_id);
+ if (probe < 0 && connector &&
+ connector->connection == DRM_MODE_UNKNOWNCONNECTION) {
+ drmModeFreeConnector(connector);
+
+ connector = drmModeGetConnector(drm_fd, connector_id);
+ }
+ }
+
if (!connector)
goto err2;
@@ -2028,7 +2036,8 @@ void igt_display_init(igt_display_t *display, int drm_fd)
* We don't assign each output a pipe unless
* a pipe is set with igt_output_set_pipe().
*/
- output->force_reprobe = true;
+ output->force_reprobe = -1;
+ output->pipe = PIPE_NONE;
output->id = resources->connectors[i];
output->display = display;
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 6f16dc8cf85e..9e734ab1a5b8 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -340,7 +340,7 @@ typedef struct {
uint32_t id; /* KMS id */
struct kmstest_connector_config config;
char *name;
- bool force_reprobe;
+ int force_reprobe;
enum pipe pending_pipe;
bool use_override_mode;
drmModeModeInfo override_mode;
--
2.16.3
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_kms: Improve connector probing in igt_display_init()
2018-03-26 10:40 [igt-dev] [PATCH i-g-t] lib/igt_kms: Improve connector probing in igt_display_init() Maarten Lankhorst
@ 2018-03-26 11:06 ` Patchwork
2018-03-26 11:22 ` [igt-dev] [PATCH i-g-t] " Maarten Lankhorst
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Patchwork @ 2018-03-26 11:06 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
== Series Details ==
Series: lib/igt_kms: Improve connector probing in igt_display_init()
URL : https://patchwork.freedesktop.org/series/40660/
State : failure
== Summary ==
IGT patchset build failed on latest successful build
a9741da52ad1963f7632ef1e852cbe1c3bcc601e tests/perf_pmu: Improve accuracy by waiting on spinner to start
ninja: Entering directory `build'
[1/517] 'Generating version.h with a custom command.'
[2/514] Static linking library lib/libigt-igt_aux_c.a
[3/514] Compiling c object 'lib/igt-igt_kms_c@sta/igt_kms.c.o'
FAILED: lib/igt-igt_kms_c@sta/igt_kms.c.o
ccache cc '-Ilib/igt-igt_kms_c@sta' '-Ilib' '-I../lib' '-I.' '-I../' '-I../include/drm-uapi' '-I/usr/include/cairo' '-I/usr/include/glib-2.0' '-I/usr/lib/x86_64-linux-gnu/glib-2.0/include' '-I/usr/include/pixman-1' '-I/usr/include/freetype2' '-I/usr/include/libpng12' '-I/opt/igt/include' '-I/opt/igt/include/libdrm' '-I/usr/include' '-I/home/cidrm/kernel_headers/include' '-fdiagnostics-color=always' '-pipe' '-D_FILE_OFFSET_BITS=64' '-Wall' '-Winvalid-pch' '-Wextra' '-std=gnu99' '-O0' '-g' '-D_GNU_SOURCE' '-include' 'config.h' '-Wno-unused-parameter' '-Wno-sign-compare' '-Wno-missing-field-initializers' '-Wno-clobbered' '-Wno-type-limits' '-fPIC' '-pthread' '-DIGT_DATADIR="/opt/igt/share/intel-gpu-tools"' '-DIGT_SRCDIR="/home/cidrm/intel-gpu-tools/tests"' '-DIGT_LOG_DOMAIN="igt_kms"' '-MMD' '-MQ' 'lib/igt-igt_kms_c@sta/igt_kms.c.o' '-MF' 'lib/igt-igt_kms_c@sta/igt_kms.c.o.d' -o 'lib/igt-igt_kms_c@sta/igt_kms.c.o' -c ../lib/igt_kms.c
../lib/igt_kms.c: In function ‘igt_display_init’:
../lib/igt_kms.c:1967:9: error: ‘igt_output_t {aka struct <anonymous>}’ has no member named ‘pipe’
output->pipe = PIPE_NONE;
^~
ninja: build stopped: subcommand failed.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH i-g-t] lib/igt_kms: Improve connector probing in igt_display_init()
2018-03-26 11:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-03-26 11:22 ` Maarten Lankhorst
2018-03-27 13:28 ` Arkadiusz Hiler
2018-03-26 11:41 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Improve connector probing in igt_display_init() (rev2) Patchwork
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Maarten Lankhorst @ 2018-03-26 11:22 UTC (permalink / raw)
To: igt-dev
Only do a full probe when the initial connector status is unknown, and
otherwise skip it. This should speed up kms tests ever so slightly.
Also set pipe to PIPE_NONE for igt_output_refresh(), to make the
connector info slightly more accurate.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
lib/igt_kms.c | 17 +++++++++++++----
lib/igt_kms.h | 2 +-
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index d8f69d3db9ca..f47c32a79222 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -974,7 +974,7 @@ _kmstest_connector_config_find_encoder(int drm_fd, drmModeConnector *connector,
static bool _kmstest_connector_config(int drm_fd, uint32_t connector_id,
unsigned long crtc_idx_mask,
struct kmstest_connector_config *config,
- bool probe)
+ int probe)
{
drmModeRes *resources;
drmModeConnector *connector;
@@ -988,11 +988,19 @@ static bool _kmstest_connector_config(int drm_fd, uint32_t connector_id,
}
/* First, find the connector & mode */
- if (probe)
+ if (probe > 0)
connector = drmModeGetConnector(drm_fd, connector_id);
- else
+ else {
connector = drmModeGetConnectorCurrent(drm_fd, connector_id);
+ if (probe < 0 && connector &&
+ connector->connection == DRM_MODE_UNKNOWNCONNECTION) {
+ drmModeFreeConnector(connector);
+
+ connector = drmModeGetConnector(drm_fd, connector_id);
+ }
+ }
+
if (!connector)
goto err2;
@@ -2028,7 +2036,8 @@ void igt_display_init(igt_display_t *display, int drm_fd)
* We don't assign each output a pipe unless
* a pipe is set with igt_output_set_pipe().
*/
- output->force_reprobe = true;
+ output->force_reprobe = -1;
+ output->pending_pipe = PIPE_NONE;
output->id = resources->connectors[i];
output->display = display;
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 6f16dc8cf85e..9e734ab1a5b8 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -340,7 +340,7 @@ typedef struct {
uint32_t id; /* KMS id */
struct kmstest_connector_config config;
char *name;
- bool force_reprobe;
+ int force_reprobe;
enum pipe pending_pipe;
bool use_override_mode;
drmModeModeInfo override_mode;
--
2.16.3
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Improve connector probing in igt_display_init() (rev2)
2018-03-26 11:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-03-26 11:22 ` [igt-dev] [PATCH i-g-t] " Maarten Lankhorst
@ 2018-03-26 11:41 ` Patchwork
2018-03-26 13:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2018-03-26 11:41 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
== Series Details ==
Series: lib/igt_kms: Improve connector probing in igt_display_init() (rev2)
URL : https://patchwork.freedesktop.org/series/40660/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
a9741da52ad1963f7632ef1e852cbe1c3bcc601e tests/perf_pmu: Improve accuracy by waiting on spinner to start
with latest DRM-Tip kernel build CI_DRM_3978
94f5d9189e61 drm-tip: 2018y-03m-23d-23h-41m-40s UTC integration manifest
No testlist changes.
---- Known issues:
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-c:
incomplete -> PASS (fi-bxt-dsi) fdo#103927
incomplete -> PASS (fi-hsw-4770) fdo#104944
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104944 https://bugs.freedesktop.org/show_bug.cgi?id=104944
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:430s
fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:442s
fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:383s
fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:530s
fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:296s
fi-bxt-dsi total:285 pass:255 dwarn:0 dfail:0 fail:0 skip:30 time:516s
fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:513s
fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:519s
fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:507s
fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:407s
fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:509s
fi-elk-e7500 total:285 pass:225 dwarn:1 dfail:0 fail:0 skip:59 time:424s
fi-gdg-551 total:285 pass:176 dwarn:0 dfail:0 fail:1 skip:108 time:309s
fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:540s
fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:403s
fi-ilk-650 total:285 pass:225 dwarn:0 dfail:0 fail:0 skip:60 time:422s
fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:468s
fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:429s
fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:474s
fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:459s
fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:511s
fi-pnv-d510 total:285 pass:219 dwarn:1 dfail:0 fail:0 skip:65 time:649s
fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:439s
fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:531s
fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:508s
fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:503s
fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:428s
fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:444s
fi-snb-2520m total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:585s
fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:398s
Blacklisted hosts:
fi-cfl-s3 total:285 pass:258 dwarn:0 dfail:0 fail:1 skip:26 time:558s
fi-cnl-psr total:224 pass:198 dwarn:0 dfail:0 fail:1 skip:24
fi-glk-j4005 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:497s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1192/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib/igt_kms: Improve connector probing in igt_display_init() (rev2)
2018-03-26 11:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-03-26 11:22 ` [igt-dev] [PATCH i-g-t] " Maarten Lankhorst
2018-03-26 11:41 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Improve connector probing in igt_display_init() (rev2) Patchwork
@ 2018-03-26 13:41 ` Patchwork
2018-03-28 9:04 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Improve connector probing in igt_display_init() (rev3) Patchwork
2018-03-28 13:58 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2018-03-26 13:41 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
== Series Details ==
Series: lib/igt_kms: Improve connector probing in igt_display_init() (rev2)
URL : https://patchwork.freedesktop.org/series/40660/
State : success
== Summary ==
---- Known issues:
Test kms_cursor_legacy:
Subgroup 2x-long-flip-vs-cursor-atomic:
pass -> FAIL (shard-hsw) fdo#104873
Test kms_flip:
Subgroup 2x-dpms-vs-vblank-race:
fail -> PASS (shard-hsw) fdo#103060 +2
Subgroup 2x-flip-vs-expired-vblank-interruptible:
fail -> PASS (shard-hsw) fdo#102887
Subgroup basic-flip-vs-wf_vblank:
pass -> FAIL (shard-hsw) fdo#100368 +1
Test kms_rotation_crc:
Subgroup sprite-rotation-180:
fail -> PASS (shard-snb) fdo#103925 +1
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-apl) fdo#99912
fdo#104873 https://bugs.freedesktop.org/show_bug.cgi?id=104873
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
shard-apl total:3495 pass:1831 dwarn:1 dfail:0 fail:7 skip:1655 time:12783s
shard-hsw total:3495 pass:1781 dwarn:1 dfail:0 fail:3 skip:1709 time:11560s
shard-snb total:3495 pass:1373 dwarn:1 dfail:0 fail:4 skip:2117 time:6906s
Blacklisted hosts:
shard-kbl total:3423 pass:1908 dwarn:1 dfail:0 fail:9 skip:1504 time:9048s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1192/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/igt_kms: Improve connector probing in igt_display_init()
2018-03-26 11:22 ` [igt-dev] [PATCH i-g-t] " Maarten Lankhorst
@ 2018-03-27 13:28 ` Arkadiusz Hiler
2018-03-28 8:37 ` [igt-dev] [PATCH i-g-t] lib/igt_kms: Improve connector probing in igt_display_init(), v2 Maarten Lankhorst
0 siblings, 1 reply; 11+ messages in thread
From: Arkadiusz Hiler @ 2018-03-27 13:28 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
On Mon, Mar 26, 2018 at 01:22:06PM +0200, Maarten Lankhorst wrote:
> Only do a full probe when the initial connector status is unknown, and
> otherwise skip it. This should speed up kms tests ever so slightly.
>
> Also set pipe to PIPE_NONE for igt_output_refresh(), to make the
> connector info slightly more accurate.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> lib/igt_kms.c | 17 +++++++++++++----
> lib/igt_kms.h | 2 +-
> 2 files changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index d8f69d3db9ca..f47c32a79222 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -974,7 +974,7 @@ _kmstest_connector_config_find_encoder(int drm_fd, drmModeConnector *connector,
> static bool _kmstest_connector_config(int drm_fd, uint32_t connector_id,
> unsigned long crtc_idx_mask,
> struct kmstest_connector_config *config,
> - bool probe)
> + int probe)
> {
> drmModeRes *resources;
> drmModeConnector *connector;
> @@ -988,11 +988,19 @@ static bool _kmstest_connector_config(int drm_fd, uint32_t connector_id,
> }
>
> /* First, find the connector & mode */
> - if (probe)
> + if (probe > 0)
> connector = drmModeGetConnector(drm_fd, connector_id);
> - else
> + else {
> connector = drmModeGetConnectorCurrent(drm_fd, connector_id);
>
> + if (probe < 0 && connector &&
> + connector->connection == DRM_MODE_UNKNOWNCONNECTION) {
> + drmModeFreeConnector(connector);
> +
> + connector = drmModeGetConnector(drm_fd, connector_id);
> + }
> + }
> +
> if (!connector)
> goto err2;
>
> @@ -2028,7 +2036,8 @@ void igt_display_init(igt_display_t *display, int drm_fd)
> * We don't assign each output a pipe unless
> * a pipe is set with igt_output_set_pipe().
> */
> - output->force_reprobe = true;
> + output->force_reprobe = -1;
> + output->pending_pipe = PIPE_NONE;
> output->id = resources->connectors[i];
> output->display = display;
>
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 6f16dc8cf85e..9e734ab1a5b8 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -340,7 +340,7 @@ typedef struct {
> uint32_t id; /* KMS id */
> struct kmstest_connector_config config;
> char *name;
> - bool force_reprobe;
> + int force_reprobe;
I am all for doing full probe only when requested or necessary, but I
find keeping the name 'force_reprobe' and mixing -1, false and true
rather confusing.
What about changing the name to just "reprobe" and use enum values
NO_REPROBE, FORCE_REPROBE and IF_NECESSARY_REPROBE (or some better
names)?
-Arek
> enum pipe pending_pipe;
> bool use_override_mode;
> drmModeModeInfo override_mode;
> --
> 2.16.3
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH i-g-t] lib/igt_kms: Improve connector probing in igt_display_init(), v2.
2018-03-27 13:28 ` Arkadiusz Hiler
@ 2018-03-28 8:37 ` Maarten Lankhorst
2018-03-28 9:20 ` Arkadiusz Hiler
0 siblings, 1 reply; 11+ messages in thread
From: Maarten Lankhorst @ 2018-03-28 8:37 UTC (permalink / raw)
To: igt-dev
Only do a full probe when the initial connector status is unknown, and
otherwise skip it. This should speed up kms tests ever so slightly.
Also set pipe to PIPE_NONE for igt_output_refresh(), to make the
connector info slightly more accurate.
Changes since v1:
- Instead of a force_reprobe tristate, only force reprobe from
igt_display_init() when an unknown connection is found.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
lib/igt_kms.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 2b81cabb05d8..19d650a8dcf8 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1955,11 +1955,17 @@ void igt_display_init(igt_display_t *display, int drm_fd)
* We don't assign each output a pipe unless
* a pipe is set with igt_output_set_pipe().
*/
- output->force_reprobe = true;
+ output->pending_pipe = PIPE_NONE;
output->id = resources->connectors[i];
output->display = display;
igt_output_refresh(output);
+
+ if (output->config.connector &&
+ output->config.connector->connection == DRM_MODE_UNKNOWNCONNECTION) {
+ output->force_reprobe = true;
+ igt_output_refresh(output);
+ }
}
drmModeFreePlaneResources(plane_resources);
--
2.16.3
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Improve connector probing in igt_display_init() (rev3)
2018-03-26 11:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
` (2 preceding siblings ...)
2018-03-26 13:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-03-28 9:04 ` Patchwork
2018-03-28 13:58 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2018-03-28 9:04 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
== Series Details ==
Series: lib/igt_kms: Improve connector probing in igt_display_init() (rev3)
URL : https://patchwork.freedesktop.org/series/40660/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
0a393229479d61829a2f8671c1a46f533c76b385 igt/gem_ctx_isolation: Reset a scratch context
with latest DRM-Tip kernel build CI_DRM_3994
23c67dc0cf31 drm-tip: 2018y-03m-28d-06h-36m-40s UTC integration manifest
No testlist changes.
---- Known issues:
Test drv_module_reload:
Subgroup basic-reload-inject:
pass -> INCOMPLETE (fi-cnl-y3) fdo#105777
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-c:
pass -> INCOMPLETE (fi-bxt-dsi) fdo#103927
pass -> DMESG-FAIL (fi-cnl-y3) fdo#104951
Test prime_vgem:
Subgroup basic-fence-flip:
pass -> FAIL (fi-ilk-650) fdo#104008
fdo#105777 https://bugs.freedesktop.org/show_bug.cgi?id=105777
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:430s
fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:444s
fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:387s
fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:542s
fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:295s
fi-bxt-dsi total:243 pass:216 dwarn:0 dfail:0 fail:0 skip:26
fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:514s
fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:521s
fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:507s
fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:411s
fi-cfl-s3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:560s
fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:515s
fi-cnl-y3 total:284 pass:257 dwarn:0 dfail:1 fail:0 skip:25
fi-elk-e7500 total:285 pass:225 dwarn:1 dfail:0 fail:0 skip:59 time:418s
fi-gdg-551 total:285 pass:176 dwarn:0 dfail:0 fail:1 skip:108 time:315s
fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:540s
fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:404s
fi-ilk-650 total:285 pass:224 dwarn:0 dfail:0 fail:1 skip:60 time:422s
fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:476s
fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:431s
fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:471s
fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:463s
fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:509s
fi-pnv-d510 total:285 pass:219 dwarn:1 dfail:0 fail:0 skip:65 time:657s
fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:443s
fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:534s
fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:497s
fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:503s
fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:429s
fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:452s
fi-snb-2520m total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:562s
Blacklisted hosts:
fi-cnl-psr total:285 pass:256 dwarn:3 dfail:0 fail:0 skip:26 time:514s
fi-glk-j4005 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:486s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1201/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/igt_kms: Improve connector probing in igt_display_init(), v2.
2018-03-28 8:37 ` [igt-dev] [PATCH i-g-t] lib/igt_kms: Improve connector probing in igt_display_init(), v2 Maarten Lankhorst
@ 2018-03-28 9:20 ` Arkadiusz Hiler
2018-03-28 11:50 ` Maarten Lankhorst
0 siblings, 1 reply; 11+ messages in thread
From: Arkadiusz Hiler @ 2018-03-28 9:20 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
On Wed, Mar 28, 2018 at 10:37:36AM +0200, Maarten Lankhorst wrote:
> Only do a full probe when the initial connector status is unknown, and
> otherwise skip it. This should speed up kms tests ever so slightly.
>
> Also set pipe to PIPE_NONE for igt_output_refresh(), to make the
> connector info slightly more accurate.
>
> Changes since v1:
> - Instead of a force_reprobe tristate, only force reprobe from
> igt_display_init() when an unknown connection is found.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/igt_kms: Improve connector probing in igt_display_init(), v2.
2018-03-28 9:20 ` Arkadiusz Hiler
@ 2018-03-28 11:50 ` Maarten Lankhorst
0 siblings, 0 replies; 11+ messages in thread
From: Maarten Lankhorst @ 2018-03-28 11:50 UTC (permalink / raw)
To: Arkadiusz Hiler; +Cc: igt-dev
Op 28-03-18 om 11:20 schreef Arkadiusz Hiler:
> On Wed, Mar 28, 2018 at 10:37:36AM +0200, Maarten Lankhorst wrote:
>> Only do a full probe when the initial connector status is unknown, and
>> otherwise skip it. This should speed up kms tests ever so slightly.
>>
>> Also set pipe to PIPE_NONE for igt_output_refresh(), to make the
>> connector info slightly more accurate.
>>
>> Changes since v1:
>> - Instead of a force_reprobe tristate, only force reprobe from
>> igt_display_init() when an unknown connection is found.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Thanks, pushed. :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib/igt_kms: Improve connector probing in igt_display_init() (rev3)
2018-03-26 11:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
` (3 preceding siblings ...)
2018-03-28 9:04 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Improve connector probing in igt_display_init() (rev3) Patchwork
@ 2018-03-28 13:58 ` Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2018-03-28 13:58 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
== Series Details ==
Series: lib/igt_kms: Improve connector probing in igt_display_init() (rev3)
URL : https://patchwork.freedesktop.org/series/40660/
State : success
== Summary ==
---- Known issues:
Test drv_hangman:
Subgroup error-state-capture-blt:
pass -> DMESG-WARN (shard-snb) fdo#104058
Test kms_flip:
Subgroup 2x-plain-flip-ts-check-interruptible:
fail -> PASS (shard-hsw) fdo#100368 +2
Test kms_plane_multiple:
Subgroup atomic-pipe-a-tiling-x:
fail -> PASS (shard-snb) fdo#103166
Test kms_rotation_crc:
Subgroup sprite-rotation-180:
pass -> FAIL (shard-snb) fdo#103925 +1
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-hsw) fdo#99912 +1
Test kms_sysfs_edid_timing:
warn -> PASS (shard-apl) fdo#100047
fdo#104058 https://bugs.freedesktop.org/show_bug.cgi?id=104058
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
shard-apl total:3495 pass:1833 dwarn:1 dfail:0 fail:6 skip:1655 time:12997s
shard-hsw total:3495 pass:1782 dwarn:1 dfail:0 fail:2 skip:1709 time:11425s
shard-snb total:3495 pass:1373 dwarn:2 dfail:0 fail:3 skip:2117 time:6983s
Blacklisted hosts:
shard-kbl total:3495 pass:1948 dwarn:8 dfail:0 fail:9 skip:1530 time:9337s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1201/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-03-28 13:58 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-26 10:40 [igt-dev] [PATCH i-g-t] lib/igt_kms: Improve connector probing in igt_display_init() Maarten Lankhorst
2018-03-26 11:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-03-26 11:22 ` [igt-dev] [PATCH i-g-t] " Maarten Lankhorst
2018-03-27 13:28 ` Arkadiusz Hiler
2018-03-28 8:37 ` [igt-dev] [PATCH i-g-t] lib/igt_kms: Improve connector probing in igt_display_init(), v2 Maarten Lankhorst
2018-03-28 9:20 ` Arkadiusz Hiler
2018-03-28 11:50 ` Maarten Lankhorst
2018-03-26 11:41 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Improve connector probing in igt_display_init() (rev2) Patchwork
2018-03-26 13:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-03-28 9:04 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Improve connector probing in igt_display_init() (rev3) Patchwork
2018-03-28 13:58 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.