All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 for-4.11] tools: set DEBUG_DIR from configure
@ 2018-03-28  7:34 Roger Pau Monne
  2018-03-28 16:07 ` Wei Liu
  2018-03-29 10:54 ` Wei Liu
  0 siblings, 2 replies; 5+ messages in thread
From: Roger Pau Monne @ 2018-03-28  7:34 UTC (permalink / raw)
  To: xen-devel; +Cc: Wei Liu, Olaf Hering, Ian Jackson, Jan Beulich, Roger Pau Monne

Allow the path to be set from a configure command line option.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Olaf Hering <olaf@aepfle.de>
Cc: Jan Beulich <jbeulich@suse.com>
---
Changes since v1:
 - Fix the path so it's PREFRIX/lib/... instead of PREFIX/usr/lib/...
---
 config/Paths.mk.in | 1 +
 m4/paths.m4        | 9 +++++++++
 2 files changed, 10 insertions(+)

diff --git a/config/Paths.mk.in b/config/Paths.mk.in
index a603295146..8a518d5a5d 100644
--- a/config/Paths.mk.in
+++ b/config/Paths.mk.in
@@ -51,6 +51,7 @@ BASH_COMPLETION_DIR      := $(CONFIG_DIR)/bash_completion.d
 XEN_LOCK_DIR             := @XEN_LOCK_DIR@
 XEN_PAGING_DIR           := @XEN_PAGING_DIR@
 XEN_DUMP_DIR             := @XEN_DUMP_DIR@
+DEBUG_DIR                := @DEBUG_DIR@
 
 XENFIRMWAREDIR           := @XENFIRMWAREDIR@
 
diff --git a/m4/paths.m4 b/m4/paths.m4
index f208b7e39f..89d3bb8312 100644
--- a/m4/paths.m4
+++ b/m4/paths.m4
@@ -82,6 +82,12 @@ AC_ARG_WITH([rundir],
     [rundir_path=$withval],
     [rundir_path=$localstatedir/run])
 
+AC_ARG_WITH([debugdir],
+    AS_HELP_STRING([--with-debugdir=DIR],
+    [Path to directory for debug symbols. [PREFIX/lib/debug]]),
+    [debugdir_path=$withval],
+    [debugdir_path=$prefix/lib/debug])
+
 if test "$libexecdir" = '${exec_prefix}/libexec' ; then
     case "$host_os" in
          *netbsd*) ;;
@@ -146,6 +152,9 @@ AC_SUBST(XEN_PAGING_DIR)
 
 XEN_DUMP_DIR=$xen_dumpdir_path
 AC_SUBST(XEN_DUMP_DIR)
+
+DEBUG_DIR=$debugdir_path
+AC_SUBST(DEBUG_DIR)
 ])
 
 case "$host_os" in
-- 
2.16.3


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 for-4.11] tools: set DEBUG_DIR from configure
  2018-03-28  7:34 [PATCH v2 for-4.11] tools: set DEBUG_DIR from configure Roger Pau Monne
@ 2018-03-28 16:07 ` Wei Liu
  2018-03-28 16:09   ` Wei Liu
  2018-03-29 10:54 ` Wei Liu
  1 sibling, 1 reply; 5+ messages in thread
From: Wei Liu @ 2018-03-28 16:07 UTC (permalink / raw)
  To: Roger Pau Monne; +Cc: xen-devel, Olaf Hering, Ian Jackson, Wei Liu, Jan Beulich

On Wed, Mar 28, 2018 at 08:34:14AM +0100, Roger Pau Monne wrote:
> Allow the path to be set from a configure command line option.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

I think the DEBUG_DIR?= lines in StdGNU.mk and SunOS.mk can be removed
now.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 for-4.11] tools: set DEBUG_DIR from configure
  2018-03-28 16:07 ` Wei Liu
@ 2018-03-28 16:09   ` Wei Liu
  2018-03-29  8:11     ` Roger Pau Monné
  0 siblings, 1 reply; 5+ messages in thread
From: Wei Liu @ 2018-03-28 16:09 UTC (permalink / raw)
  To: Roger Pau Monne; +Cc: xen-devel, Olaf Hering, Ian Jackson, Wei Liu, Jan Beulich

On Wed, Mar 28, 2018 at 05:07:33PM +0100, Wei Liu wrote:
> On Wed, Mar 28, 2018 at 08:34:14AM +0100, Roger Pau Monne wrote:
> > Allow the path to be set from a configure command line option.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> I think the DEBUG_DIR?= lines in StdGNU.mk and SunOS.mk can be removed
> now.

Actually, no. We don't want hypervisor to depend on ./configure.

But then there will be two ways to set DEBUG_DIR which isn't nice...

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 for-4.11] tools: set DEBUG_DIR from configure
  2018-03-28 16:09   ` Wei Liu
@ 2018-03-29  8:11     ` Roger Pau Monné
  0 siblings, 0 replies; 5+ messages in thread
From: Roger Pau Monné @ 2018-03-29  8:11 UTC (permalink / raw)
  To: Wei Liu; +Cc: xen-devel, Olaf Hering, Ian Jackson, Jan Beulich

On Wed, Mar 28, 2018 at 05:09:39PM +0100, Wei Liu wrote:
> On Wed, Mar 28, 2018 at 05:07:33PM +0100, Wei Liu wrote:
> > On Wed, Mar 28, 2018 at 08:34:14AM +0100, Roger Pau Monne wrote:
> > > Allow the path to be set from a configure command line option.
> > > 
> > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > 
> > I think the DEBUG_DIR?= lines in StdGNU.mk and SunOS.mk can be removed
> > now.
> 
> Actually, no. We don't want hypervisor to depend on ./configure.
> 
> But then there will be two ways to set DEBUG_DIR which isn't nice...

I know... Sadly I don't see anyway to solve this that doesn't involve
using configure for the hypervisor also.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 for-4.11] tools: set DEBUG_DIR from configure
  2018-03-28  7:34 [PATCH v2 for-4.11] tools: set DEBUG_DIR from configure Roger Pau Monne
  2018-03-28 16:07 ` Wei Liu
@ 2018-03-29 10:54 ` Wei Liu
  1 sibling, 0 replies; 5+ messages in thread
From: Wei Liu @ 2018-03-29 10:54 UTC (permalink / raw)
  To: Roger Pau Monne; +Cc: xen-devel, Olaf Hering, Ian Jackson, Wei Liu, Jan Beulich

On Wed, Mar 28, 2018 at 08:34:14AM +0100, Roger Pau Monne wrote:
> Allow the path to be set from a configure command line option.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-03-29 10:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-28  7:34 [PATCH v2 for-4.11] tools: set DEBUG_DIR from configure Roger Pau Monne
2018-03-28 16:07 ` Wei Liu
2018-03-28 16:09   ` Wei Liu
2018-03-29  8:11     ` Roger Pau Monné
2018-03-29 10:54 ` Wei Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.