* [PATCH 2/2] KVM: X86: Fix disable pv tlb flush when steal time is enabled
@ 2018-03-25 4:18 Wanpeng Li
2018-03-28 20:14 ` Radim Krčmář
0 siblings, 1 reply; 3+ messages in thread
From: Wanpeng Li @ 2018-03-25 4:18 UTC (permalink / raw)
To: linux-kernel, kvm; +Cc: Paolo Bonzini, Radim Krčmář
From: Wanpeng Li <wanpengli@tencent.com>
PV TLB FLUSH can be turned on when steal time is enabled. The condition
reverse when the patch is sent out for several rounds review by mistake.
This patch fixes it.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Radim Krčmář <rkrcmar@redhat.com>
Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
---
arch/x86/kernel/kvm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index 31ac585..4f859cc 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -555,7 +555,7 @@ static void __init kvm_guest_init(void)
if (kvm_para_has_feature(KVM_FEATURE_PV_TLB_FLUSH) &&
!kvm_para_has_hint(KVM_HINTS_DEDICATED) &&
- !kvm_para_has_feature(KVM_FEATURE_STEAL_TIME))
+ kvm_para_has_feature(KVM_FEATURE_STEAL_TIME))
pv_mmu_ops.flush_tlb_others = kvm_flush_tlb_others;
if (kvm_para_has_feature(KVM_FEATURE_PV_EOI))
@@ -651,7 +651,7 @@ static __init int kvm_setup_pv_tlb_flush(void)
if (kvm_para_has_feature(KVM_FEATURE_PV_TLB_FLUSH) &&
!kvm_para_has_hint(KVM_HINTS_DEDICATED) &&
- !kvm_para_has_feature(KVM_FEATURE_STEAL_TIME)) {
+ kvm_para_has_feature(KVM_FEATURE_STEAL_TIME)) {
for_each_possible_cpu(cpu) {
zalloc_cpumask_var_node(per_cpu_ptr(&__pv_tlb_mask, cpu),
GFP_KERNEL, cpu_to_node(cpu));
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] KVM: X86: Fix disable pv tlb flush when steal time is enabled
2018-03-25 4:18 [PATCH 2/2] KVM: X86: Fix disable pv tlb flush when steal time is enabled Wanpeng Li
@ 2018-03-28 20:14 ` Radim Krčmář
2018-03-29 0:46 ` Wanpeng Li
0 siblings, 1 reply; 3+ messages in thread
From: Radim Krčmář @ 2018-03-28 20:14 UTC (permalink / raw)
To: Wanpeng Li; +Cc: linux-kernel, kvm, Paolo Bonzini
2018-03-24 21:18-0700, Wanpeng Li:
> From: Wanpeng Li <wanpengli@tencent.com>
>
> PV TLB FLUSH can be turned on when steal time is enabled. The condition
> reverse when the patch is sent out for several rounds review by mistake.
It was just one round and the m/l patch actually looks correct,
> This patch fixes it.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> ---
I've modified the commit message and rebased it for kvm/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] KVM: X86: Fix disable pv tlb flush when steal time is enabled
2018-03-28 20:14 ` Radim Krčmář
@ 2018-03-29 0:46 ` Wanpeng Li
0 siblings, 0 replies; 3+ messages in thread
From: Wanpeng Li @ 2018-03-29 0:46 UTC (permalink / raw)
To: Radim Krčmář; +Cc: LKML, kvm, Paolo Bonzini
2018-03-29 4:14 GMT+08:00 Radim Krčmář <rkrcmar@redhat.com>:
> 2018-03-24 21:18-0700, Wanpeng Li:
>> From: Wanpeng Li <wanpengli@tencent.com>
>>
>> PV TLB FLUSH can be turned on when steal time is enabled. The condition
>> reverse when the patch is sent out for several rounds review by mistake.
>
> It was just one round and the m/l patch actually looks correct,
>
>> This patch fixes it.
>>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Radim Krčmář <rkrcmar@redhat.com>
>> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
>> ---
>
> I've modified the commit message and rebased it for kvm/master, thanks.
Thanks Radim. :)
Regards,
Wanpeng Li
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-29 0:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-25 4:18 [PATCH 2/2] KVM: X86: Fix disable pv tlb flush when steal time is enabled Wanpeng Li
2018-03-28 20:14 ` Radim Krčmář
2018-03-29 0:46 ` Wanpeng Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.