seabios regression in staging

seabios regression in staging

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 916 bytes --]

It seems the latest seabios that was pulled into staging recently fails
to compile, at least in SLE_11:

[   86s]   Compile checking out/src/hw/blockcmd.o
[   86s] src/hw/blockcmd.c: In function 'scsi_rep_luns_scan':
[   86s] src/hw/blockcmd.c:229: error: unknown field 'cdbcmd' specified in initializer
[   86s] src/hw/blockcmd.c:229: warning: missing braces around initializer
[   86s] src/hw/blockcmd.c:229: warning: (near initialization for 'op.<anonymous>')
[   86s] src/hw/blockcmd.c:229: warning: initialization makes integer from pointer without a cast
[   86s] make[7]: *** [out/src/hw/blockcmd.o] Error 1

I can eventually trick the build to use gcc48 not only for xen but also
for tools, but I wonder if there is a way to fix this.

Upstream may have not fixed that yet:
https://github.com/coreboot/seabios/blame/master/src/block.h
https://github.com/coreboot/seabios/blame/master/src/hw/blockcmd.c

Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: seabios regression in staging

[Wei Liu]

On Thu, Mar 29, 2018 at 01:42:43PM +0200, Olaf Hering wrote:
> It seems the latest seabios that was pulled into staging recently fails
> to compile, at least in SLE_11:
> 
> [   86s]   Compile checking out/src/hw/blockcmd.o
> [   86s] src/hw/blockcmd.c: In function 'scsi_rep_luns_scan':
> [   86s] src/hw/blockcmd.c:229: error: unknown field 'cdbcmd' specified in initializer
> [   86s] src/hw/blockcmd.c:229: warning: missing braces around initializer
> [   86s] src/hw/blockcmd.c:229: warning: (near initialization for 'op.<anonymous>')
> [   86s] src/hw/blockcmd.c:229: warning: initialization makes integer from pointer without a cast
> [   86s] make[7]: *** [out/src/hw/blockcmd.o] Error 1
> 
> I can eventually trick the build to use gcc48 not only for xen but also
> for tools, but I wonder if there is a way to fix this.
> 
> Upstream may have not fixed that yet:
> https://github.com/coreboot/seabios/blame/master/src/block.h
> https://github.com/coreboot/seabios/blame/master/src/hw/blockcmd.c
> 

I think this is a problem with seabios upstream. We should ask them to
fix it and do another release.

Do you use a non-default seabios configuration? Osstest seems to be
happy with the update.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: seabios regression in staging

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 372 bytes --]

On Thu, Mar 29, Wei Liu wrote:

> Do you use a non-default seabios configuration? Osstest seems to be
> happy with the update.

Not sure how I would create a non-default seabios or toolchain build.

osstest does not use SLE11, so it can not possibly spot such compile
errors. It would certainly be cool if there would be a test with very
old and very new toolchain.

Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: seabios regression in staging

[Wei Liu]

On Thu, Mar 29, 2018 at 04:53:41PM +0200, Olaf Hering wrote:
> On Thu, Mar 29, Wei Liu wrote:
> 
> > Do you use a non-default seabios configuration? Osstest seems to be
> > happy with the update.
> 
> Not sure how I would create a non-default seabios or toolchain build.
> 
> osstest does not use SLE11, so it can not possibly spot such compile
> errors. It would certainly be cool if there would be a test with very
> old and very new toolchain.
> 

My reading of the log was that the code was actually wrong. But looking
at the code itself it should be a problem with older toolchain.

There is work on-going to use docker to test build Xen. See
.gitlab-ci.yml in xen.git. I think it would be helpful to add SLES 11 to
the list, too.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: seabios regression in staging

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 242 bytes --]

On Thu, Mar 29, Wei Liu wrote:

> I think this is a problem with seabios upstream. We should ask them to
> fix it and do another release.

https://mail.coreboot.org/pipermail/seabios/2017-November/011932.html

gcc-4.6+ is now required.

Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: seabios regression in staging

[Wei Liu]

On Thu, Mar 29, 2018 at 05:36:32PM +0200, Olaf Hering wrote:
> On Thu, Mar 29, Wei Liu wrote:
> 
> > I think this is a problem with seabios upstream. We should ask them to
> > fix it and do another release.
> 
> https://mail.coreboot.org/pipermail/seabios/2017-November/011932.html
> 
> gcc-4.6+ is now required.
> 

Yeah. I saw that.

We should either bump our requirement or have a separate entry for
seabios. I prefer the former.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: seabios regression in staging

[Doug Goldstein]

[-- Attachment #1.1.1: Type: text/plain, Size: 594 bytes --]

On 3/29/18 9:53 AM, Olaf Hering wrote:
> On Thu, Mar 29, Wei Liu wrote:
> 
>> Do you use a non-default seabios configuration? Osstest seems to be
>> happy with the update.
> 
> Not sure how I would create a non-default seabios or toolchain build.
> 
> osstest does not use SLE11, so it can not possibly spot such compile
> errors. It would certainly be cool if there would be a test with very
> old and very new toolchain.
> 
> Olaf

If you'd be willing to create a SLE11 Docker container, we can add that
to the tree and start doing builds against it.

-- 
Doug Goldstein


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: seabios regression in staging

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 213 bytes --]

On Thu, Mar 29, Doug Goldstein wrote:

> If you'd be willing to create a SLE11 Docker container, we can add that
> to the tree and start doing builds against it.

I do not know how to do that. Any pointers?

Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: seabios regression in staging

[Doug Goldstein]

[-- Attachment #1.1.1: Type: text/plain, Size: 637 bytes --]

On 3/29/18 3:00 PM, Olaf Hering wrote:
> On Thu, Mar 29, Doug Goldstein wrote:
> 
>> If you'd be willing to create a SLE11 Docker container, we can add that
>> to the tree and start doing builds against it.
> 
> I do not know how to do that. Any pointers?
> 
> Olaf
> 

Find the base image for SLE11. I've for the openSUSE ones at
https://hub.docker.com/r/library/opensuse/ so using those you would get
the line:

FROM opensuse:42.3

Then take one of the existing ones in the tree under automation/build
and change the FROM line and then update the commands that are
installing dependencies.

-- 
Doug Goldstein


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel