From: Boris Brezillon <boris.brezillon@bootlin.com> To: Xiaolei Li <xiaolei.li@mediatek.com> Cc: <richard@nod.at>, linux-mediatek@lists.infradead.org, linux-mtd@lists.infradead.org, srv_heupstream@mediatek.com Subject: Re: [PATCH v2 2/2] mtd: nand: Fix some function description mismatches in core.c Date: Thu, 29 Mar 2018 19:54:52 +0200 [thread overview] Message-ID: <20180329195452.582f4910@bbrezillon> (raw) In-Reply-To: <1522287299-12620-3-git-send-email-xiaolei.li@mediatek.com> On Thu, 29 Mar 2018 09:34:59 +0800 Xiaolei Li <xiaolei.li@mediatek.com> wrote: > In core.c, some function descriptions do not match function > definitions. Just fix these mismatches. > > Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> Applied. Thanks, Boris > --- > drivers/mtd/nand/core.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/mtd/nand/core.c b/drivers/mtd/nand/core.c > index f237a68..d0cd6f8 100644 > --- a/drivers/mtd/nand/core.c > +++ b/drivers/mtd/nand/core.c > @@ -51,7 +51,7 @@ bool nanddev_isbad(struct nand_device *nand, const struct nand_pos *pos) > /** > * nanddev_markbad() - Mark a block as bad > * @nand: NAND device > - * @block: block to mark bad > + * @pos: position of the block to mark bad > * > * Mark a block bad. This function is updating the BBT if available and > * calls the low-level markbad hook (nand->ops->markbad()). > @@ -117,9 +117,9 @@ bool nanddev_isreserved(struct nand_device *nand, const struct nand_pos *pos) > /** > * nanddev_erase() - Erase a NAND portion > * @nand: NAND device > - * @block: eraseblock to erase > + * @pos: position of the block to erase > * > - * Erases @block if it's not bad. > + * Erases the block if it's not bad. > * > * Return: 0 in case of success, a negative error code otherwise. > */ > @@ -179,11 +179,11 @@ int nanddev_mtd_erase(struct mtd_info *mtd, struct erase_info *einfo) > /** > * nanddev_init() - Initialize a NAND device > * @nand: NAND device > - * @memorg: NAND memory organization descriptor > * @ops: NAND device operations > + * @owner: NAND device owner > * > - * Initializes a NAND device object. Consistency checks are done on @memorg and > - * @ops. Also takes care of initializing the BBT. > + * Initializes a NAND device object. Consistency checks are done on @ops and > + * @nand->memorg. Also takes care of initializing the BBT. > * > * Return: 0 in case of success, a negative error code otherwise. > */ -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> To: Xiaolei Li <xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Cc: richard-/L3Ra7n9ekc@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Subject: Re: [PATCH v2 2/2] mtd: nand: Fix some function description mismatches in core.c Date: Thu, 29 Mar 2018 19:54:52 +0200 [thread overview] Message-ID: <20180329195452.582f4910@bbrezillon> (raw) In-Reply-To: <1522287299-12620-3-git-send-email-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> On Thu, 29 Mar 2018 09:34:59 +0800 Xiaolei Li <xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote: > In core.c, some function descriptions do not match function > definitions. Just fix these mismatches. > > Signed-off-by: Xiaolei Li <xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Applied. Thanks, Boris > --- > drivers/mtd/nand/core.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/mtd/nand/core.c b/drivers/mtd/nand/core.c > index f237a68..d0cd6f8 100644 > --- a/drivers/mtd/nand/core.c > +++ b/drivers/mtd/nand/core.c > @@ -51,7 +51,7 @@ bool nanddev_isbad(struct nand_device *nand, const struct nand_pos *pos) > /** > * nanddev_markbad() - Mark a block as bad > * @nand: NAND device > - * @block: block to mark bad > + * @pos: position of the block to mark bad > * > * Mark a block bad. This function is updating the BBT if available and > * calls the low-level markbad hook (nand->ops->markbad()). > @@ -117,9 +117,9 @@ bool nanddev_isreserved(struct nand_device *nand, const struct nand_pos *pos) > /** > * nanddev_erase() - Erase a NAND portion > * @nand: NAND device > - * @block: eraseblock to erase > + * @pos: position of the block to erase > * > - * Erases @block if it's not bad. > + * Erases the block if it's not bad. > * > * Return: 0 in case of success, a negative error code otherwise. > */ > @@ -179,11 +179,11 @@ int nanddev_mtd_erase(struct mtd_info *mtd, struct erase_info *einfo) > /** > * nanddev_init() - Initialize a NAND device > * @nand: NAND device > - * @memorg: NAND memory organization descriptor > * @ops: NAND device operations > + * @owner: NAND device owner > * > - * Initializes a NAND device object. Consistency checks are done on @memorg and > - * @ops. Also takes care of initializing the BBT. > + * Initializes a NAND device object. Consistency checks are done on @ops and > + * @nand->memorg. Also takes care of initializing the BBT. > * > * Return: 0 in case of success, a negative error code otherwise. > */ -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
next prev parent reply other threads:[~2018-03-29 17:54 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-29 1:34 [PATCH v2 0/2] Fix some function description mismatches Xiaolei Li 2018-03-29 1:34 ` Xiaolei Li 2018-03-29 1:34 ` [PATCH v2 1/2] mtd: Fix some function description mismatches in mtdcore.c Xiaolei Li 2018-03-29 1:34 ` Xiaolei Li 2018-03-29 20:24 ` Boris Brezillon 2018-03-29 20:24 ` Boris Brezillon 2018-03-29 1:34 ` [PATCH v2 2/2] mtd: nand: Fix some function description mismatches in core.c Xiaolei Li 2018-03-29 1:34 ` Xiaolei Li 2018-03-29 17:54 ` Boris Brezillon [this message] 2018-03-29 17:54 ` Boris Brezillon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180329195452.582f4910@bbrezillon \ --to=boris.brezillon@bootlin.com \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-mtd@lists.infradead.org \ --cc=richard@nod.at \ --cc=srv_heupstream@mediatek.com \ --cc=xiaolei.li@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.