From: Christoph Hellwig <hch@lst.de> To: viro@zeniv.linux.org.uk Cc: Avi Kivity <avi@scylladb.com>, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: aio poll and a new in-kernel poll API V8 Date: Thu, 29 Mar 2018 22:32:58 +0200 [thread overview] Message-ID: <20180329203328.3248-1-hch@lst.de> (raw) Hi all, this series adds support for the IOCB_CMD_POLL operation to poll for the readyness of file descriptors using the aio subsystem. The API is based on patches that existed in RHAS2.1 and RHEL3, which means it already is supported by libaio. To implement the poll support efficiently new methods to poll are introduced in struct file_operations: get_poll_head and poll_mask. The first one returns a wait_queue_head to wait on (lifetime is bound by the file), and the second does a non-blocking check for the POLL* events. This allows aio poll to work without any additional context switches, unlike epoll. This series sits on top of the aio-fsync series that also includes support for io_pgetevents. The changes were sponsored by Scylladb, and improve performance of the seastar framework up to 10%, while also removing the need for a privileged SCHED_FIFO epoll listener thread. git://git.infradead.org/users/hch/vfs.git aio-poll.8 Gitweb: http://git.infradead.org/users/hch/vfs.git/shortlog/refs/heads/aio-poll.8 Libaio changes: https://pagure.io/libaio.git io-poll Seastar changes (not updated for the new io_pgetevens ABI yet): https://github.com/avikivity/seastar/commits/aio Changes since V8: - make delayed cancellation safe and unconditional Changes since V7: - reworked cancellation Changes since V6: - small changelog updates - rebased on top of the aio-fsync changes Changes since V4: - rebased ontop of Linux 4.16-rc4 Changes since V3: - remove the pre-sleep ->poll_mask call in vfs_poll, allow ->get_poll_head to return POLL* values. Changes since V2: - removed a double initialization - new vfs_get_poll_head helper - document that ->get_poll_head can return NULL - call ->poll_mask before sleeping - various ACKs - add conversion of random to ->poll_mask - add conversion of af_alg to ->poll_mask - lacking ->poll_mask support now returns -EINVAL for IOCB_CMD_POLL - reshuffled the series so that prep patches and everything not requiring the new in-kernel poll API is in the beginning Changes since V1: - handle the NULL ->poll case in vfs_poll - dropped the file argument to the ->poll_mask socket operation - replace the ->pre_poll socket operation with ->get_poll_head as in the file operations
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: viro@zeniv.linux.org.uk Cc: Avi Kivity <avi@scylladb.com>, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: aio poll and a new in-kernel poll API V8 Date: Thu, 29 Mar 2018 22:32:58 +0200 [thread overview] Message-ID: <20180329203328.3248-1-hch@lst.de> (raw) Hi all, this series adds support for the IOCB_CMD_POLL operation to poll for the readyness of file descriptors using the aio subsystem. The API is based on patches that existed in RHAS2.1 and RHEL3, which means it already is supported by libaio. To implement the poll support efficiently new methods to poll are introduced in struct file_operations: get_poll_head and poll_mask. The first one returns a wait_queue_head to wait on (lifetime is bound by the file), and the second does a non-blocking check for the POLL* events. This allows aio poll to work without any additional context switches, unlike epoll. This series sits on top of the aio-fsync series that also includes support for io_pgetevents. The changes were sponsored by Scylladb, and improve performance of the seastar framework up to 10%, while also removing the need for a privileged SCHED_FIFO epoll listener thread. git://git.infradead.org/users/hch/vfs.git aio-poll.8 Gitweb: http://git.infradead.org/users/hch/vfs.git/shortlog/refs/heads/aio-poll.8 Libaio changes: https://pagure.io/libaio.git io-poll Seastar changes (not updated for the new io_pgetevens ABI yet): https://github.com/avikivity/seastar/commits/aio Changes since V8: - make delayed cancellation safe and unconditional Changes since V7: - reworked cancellation Changes since V6: - small changelog updates - rebased on top of the aio-fsync changes Changes since V4: - rebased ontop of Linux 4.16-rc4 Changes since V3: - remove the pre-sleep ->poll_mask call in vfs_poll, allow ->get_poll_head to return POLL* values. Changes since V2: - removed a double initialization - new vfs_get_poll_head helper - document that ->get_poll_head can return NULL - call ->poll_mask before sleeping - various ACKs - add conversion of random to ->poll_mask - add conversion of af_alg to ->poll_mask - lacking ->poll_mask support now returns -EINVAL for IOCB_CMD_POLL - reshuffled the series so that prep patches and everything not requiring the new in-kernel poll API is in the beginning Changes since V1: - handle the NULL ->poll case in vfs_poll - dropped the file argument to the ->poll_mask socket operation - replace the ->pre_poll socket operation with ->get_poll_head as in the file operations -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next reply other threads:[~2018-03-29 20:33 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-29 20:32 Christoph Hellwig [this message] 2018-03-29 20:32 ` aio poll and a new in-kernel poll API V8 Christoph Hellwig 2018-03-29 20:32 ` [PATCH 01/30] fs: unexport poll_schedule_timeout Christoph Hellwig 2018-03-29 20:32 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 02/30] fs: cleanup do_pollfd Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 03/30] fs: update documentation to mention __poll_t and match the code Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 04/30] fs: add new vfs_poll and file_can_poll helpers Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 05/30] fs: introduce new ->get_poll_head and ->poll_mask methods Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 06/30] aio: simplify cancellation Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 07/30] aio: add delayed cancel support Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 22:35 ` Al Viro 2018-03-29 22:35 ` Al Viro 2018-03-30 7:14 ` Christoph Hellwig 2018-03-30 7:14 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 08/30] aio: implement IOCB_CMD_POLL Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 09/30] net: refactor socket_poll Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 10/30] net: add support for ->poll_mask in proto_ops Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 11/30] net: remove sock_no_poll Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 12/30] net/tcp: convert to ->poll_mask Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 13/30] net/unix: " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 14/30] net: convert datagram_poll users tp ->poll_mask Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 15/30] net/dccp: convert to ->poll_mask Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 16/30] net/atm: " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 17/30] net/vmw_vsock: " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 18/30] net/tipc: " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 19/30] net/sctp: " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 20/30] net/bluetooth: " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 21/30] net/caif: " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 22/30] net/nfc: " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 23/30] net/phonet: " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 24/30] net/iucv: " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 25/30] net/rxrpc: " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 26/30] crypto: af_alg: " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 27/30] pipe: " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 28/30] eventfd: switch " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 29/30] timerfd: convert " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig 2018-03-29 20:33 ` [PATCH 30/30] random: " Christoph Hellwig 2018-03-29 20:33 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180329203328.3248-1-hch@lst.de \ --to=hch@lst.de \ --cc=avi@scylladb.com \ --cc=linux-aio@kvack.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.